From patchwork Thu Apr 21 15:57:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 12821920 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B02A1C433F5 for ; Thu, 21 Apr 2022 15:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RJGuYfs1vFzWWEX3b12y9TaDNBg/mWtEDvRRYpymEVw=; b=iq4GA9kCSQndx+ 68auENBnhikolzqVDgBR5LP0Zft/gsqjNCP1a58hkboffADih9P/ymoID/JWGVCEZxU8BH4gg/LzA oE9DNs8B3GHKYw4RmgnHD2XHV3YkqpfED6Rip4tVJzCrjYJtjug5VmjCtQLO9OGddV4E+0n1IS+pJ eRWsgped9tv8cDMyQWLf+rjNaEtJB0VUNZFMpjRF0Bmy1S0WaHry5xWIp1kDaWl2zmh2KsmstXRnV yQabPLyl5PPfcTkc6mwufZDiJLUCozQ+iGWc6/0Xvi4nq8vh/Y2GEpBynbfIcLWxPGoiQKXQO8oiy c3/muHIfZ2oXjQmh59UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhZBY-00E8H7-SW; Thu, 21 Apr 2022 15:57:37 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhZBV-00E8EE-8f for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 15:57:34 +0000 Received: by mail-wr1-x42f.google.com with SMTP id w4so7289906wrg.12 for ; Thu, 21 Apr 2022 08:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E0Xr29KwZXsM1RSTvbGVQLKdFlm6gLr6JsvZ9omdm1g=; b=Hr7mGBNybXCXwQwcy2LhZMdh/KpBSQgzb45nO28fqdIb6vNwaGHZPto4AqwTiu36U7 1J2H0Cy3CB0P4pTBdwieJdyBcv8KveCl9drrDLRiGm4BlVARbKLHJW/hnop9cbcN9I90 EV5xQyDgi4Z8kbFDOjkHK67bStZIAzJ+QmzlgzdXGURjmqUy2J54hMne6Klj01BitVe1 bx92ejZJKC2cswFvPxZFkteZOeEVIbqyfasj3U3pvxTyRoZniputX4dbzF2PiqgIPwv4 Wkz+RJJq2OMylno4iVKeRVvwDTKo4U9zMIyUfsT1lfUkqCnm7E8bIGShTC/eAnKcDC2w GCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E0Xr29KwZXsM1RSTvbGVQLKdFlm6gLr6JsvZ9omdm1g=; b=zwX+NRsQf7l7sg/4bb7E646XHDpuigTfO0hKOpb5Bgebz0NNpIT09Xi7QTSO+8+/ae vvzwOR9x6QocpYW5NPNwznWf65oR5X7MSdWXv8YSj5rDwLX+C+x05/Sy+navcxNQ/6pO wXbHFvTIGkG8RCqK0RcF/3IBNqFYDFJBTVeqxc/ip+XBPRuw1RMK1r6jTM1BMhGsxn65 O+4XeJQ+jrIyNW3Bng/11etr8qkuug94sa4Oas8mxn+oItLw1hC9wDc+weWCqj1SM/d7 JsFgpQwGVdFuM8uGpwKEaYUT23rC4F2S1l8HZlSFMoYVbn2/NhGI62C3WDhzAtuGwIQ+ /bUA== X-Gm-Message-State: AOAM530vmKUuVkO1VHgv8CiTtE9ck6l3QQDLF4OiUGvMMt+1fifgasZp PSN3Vr4BH1snwGWi5+TlvUbsEw== X-Google-Smtp-Source: ABdhPJx7vw1kRWMEjCJYzAEdaiwrgrOvmaqPUNeDkFIzBjyf49b6SsrkX7g8rEkQbjTibXRCOHMuJg== X-Received: by 2002:adf:efc6:0:b0:207:b89b:232b with SMTP id i6-20020adfefc6000000b00207b89b232bmr280197wrp.403.1650556650106; Thu, 21 Apr 2022 08:57:30 -0700 (PDT) Received: from localhost.localdomain ([2001:861:44c0:66c0:35ba:2677:956:980d]) by smtp.gmail.com with ESMTPSA id 61-20020adf8143000000b002061d8d807esm2623140wrm.87.2022.04.21.08.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 08:57:29 -0700 (PDT) From: Neil Armstrong To: jbrunet@baylibre.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong , Dmitry Shmidt Subject: [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger" Date: Thu, 21 Apr 2022 17:57:24 +0200 Message-Id: <20220421155725.2589089-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_085733_320461_E496FA08 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit bf5e4887eeddb48480568466536aa08ec7f179a5 because the following and required commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the following system crash when using audio: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282 Reported-by: Dmitry Shmidt Signed-off-by: Neil Armstrong Acked-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 0c31934a9630..e076ced30025 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -351,29 +351,13 @@ static int axg_tdm_iface_hw_free(struct snd_pcm_substream *substream, return 0; } -static int axg_tdm_iface_trigger(struct snd_pcm_substream *substream, - int cmd, +static int axg_tdm_iface_prepare(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { - struct axg_tdm_stream *ts = - snd_soc_dai_get_dma_data(dai, substream); - - switch (cmd) { - case SNDRV_PCM_TRIGGER_START: - case SNDRV_PCM_TRIGGER_RESUME: - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: - axg_tdm_stream_start(ts); - break; - case SNDRV_PCM_TRIGGER_SUSPEND: - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - case SNDRV_PCM_TRIGGER_STOP: - axg_tdm_stream_stop(ts); - break; - default: - return -EINVAL; - } + struct axg_tdm_stream *ts = snd_soc_dai_get_dma_data(dai, substream); - return 0; + /* Force all attached formatters to update */ + return axg_tdm_stream_reset(ts); } static int axg_tdm_iface_remove_dai(struct snd_soc_dai *dai) @@ -413,8 +397,8 @@ static const struct snd_soc_dai_ops axg_tdm_iface_ops = { .set_fmt = axg_tdm_iface_set_fmt, .startup = axg_tdm_iface_startup, .hw_params = axg_tdm_iface_hw_params, + .prepare = axg_tdm_iface_prepare, .hw_free = axg_tdm_iface_hw_free, - .trigger = axg_tdm_iface_trigger, }; /* TDM Backend DAIs */ From patchwork Thu Apr 21 15:57:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 12821921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5C3EC433F5 for ; Thu, 21 Apr 2022 15:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zEE9v/aqo+0/62ZP70n/1gkktJAcGTuAsp70Palxijc=; b=TKU+lMCvkePDz9 HkFdcWMpK9zgfbEsqrjmMih0cfM34/8d7Fok1Gf+rbFx/m2IcNli66Z3I6k0B8VVOQeNwSVfflrB/ Xsomp1VP8fNwFueuvDzgUG+kX+fcKG11qvJwXN7Tg1xmVulevq1sXGv/xBBwTLPJrub8GPrUIi7UP qWf2fEDnRZg0HNUIAN3zziQeXPXLnQMpG2+vPSM45550tEQxetX9PZeZ19WuPke9oK4ij+yffx4Bm qmb2oYNuMqpU5I0f8mJxvtQpqrJ+CBgE6qIvPeUmWjZfjMQyh28xFkX25ORihxPaS4qjmTJt8IBWF CPEZ5F1kZyyaQqHmHDkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhZBp-00E8PY-Bd; Thu, 21 Apr 2022 15:57:53 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhZBW-00E8Em-SL for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 15:57:36 +0000 Received: by mail-wr1-x42b.google.com with SMTP id u3so7345816wrg.3 for ; Thu, 21 Apr 2022 08:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c5v2dcbpfIREeY44tdPJXPJiKXCQO1isQe1PN8hnmtA=; b=x7mIAao/XjRhFqxaq69esUVD9gaSAFe7pBZaCn5vqPJ7FGAfIcxMddEd/ZwhipP4xe adLF8gMXeI+5Lr2Vr6CL40gna2y9IIhkZ19d1Kk17qzehiOtRLwt0VEWd5VamUDeaQMs xzeNByKjw9cAqJpO9CPiyjTLidYUSP84vxCflxxes3yEc40nRsQS7DNzcbMT6FyGVp4A ajm565I5vOTyqmV9Vqb9UHeQZhhoHlk9JHUiTrC/fEuvyTkAZ3XGkhwi8Cc75rAs9/qJ Brkd+R0DlIuzJ878hwMF9F8pQg9hkmzm8h6EoiAyMKBBplvmBjqaw2Mrq/Fo7uODcUhH HGpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c5v2dcbpfIREeY44tdPJXPJiKXCQO1isQe1PN8hnmtA=; b=PUrArwfbecjEyR5vPF/eU1ezjJkdQ8J0h6H1caQCs4l/AmvAiLWi2ptyz15vnaBSmL KnZdGSO8yn0JKO6K+xr92rImRB2ENKd3mxPRtDSCVCqOID5OOT4M8oqCEvBYIzc5X/9V Ab+cPV8cBF7RWUckXs/7UfXMlA/JW+WN08Loi26DpD6A93RfqUh4mzC6DfET80HajiY2 aybFQ2SF6VcLHkbTL0PLstKdZpeuhsg4bK1/TDjL7bORXGd3+NaJrM1iYm5MeNIGygOU Bgs/6+owJwX06i53lv0ry/2GnPcTqK/ExBiJDQSudjIrwcuWxe5YsiLBWBWFuqaDQ41q QrDw== X-Gm-Message-State: AOAM530NH+w1JxXp7wxY5K86Ryn5yuqPvCtNNMTQuxO+OpU5wcQ3LBNL Us5ixg/YbGUrhyKqSSwECmpIka1iO5zF2GKH X-Google-Smtp-Source: ABdhPJz8PBGJzTWGkvR9SDIvidKwEabWHonllUxUaq2TEm4JZ76WETtMHbtWwFFwMYrsLL0Ek3CKbw== X-Received: by 2002:a05:6000:713:b0:20a:92f1:c057 with SMTP id bs19-20020a056000071300b0020a92f1c057mr289175wrb.241.1650556651171; Thu, 21 Apr 2022 08:57:31 -0700 (PDT) Received: from localhost.localdomain ([2001:861:44c0:66c0:35ba:2677:956:980d]) by smtp.gmail.com with ESMTPSA id 61-20020adf8143000000b002061d8d807esm2623140wrm.87.2022.04.21.08.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 08:57:30 -0700 (PDT) From: Neil Armstrong To: jbrunet@baylibre.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong , Dmitry Shmidt Subject: [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic" Date: Thu, 21 Apr 2022 17:57:25 +0200 Message-Id: <20220421155725.2589089-2-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com> References: <20220421155725.2589089-1-narmstrong@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_085734_963185_E66EEFC2 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the following system crash when using audio on G12A/G12B & SM1 systems: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0 preempt_count: 10001, expected: 0 RCU nest depth: 0, expected: 0 Preemption disabled at: schedule_preempt_disabled+0x20/0x2c CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.17.0-rc6-03747-gd403c3588f77-dirty #957 Hardware name: SEI Robotics SEI610 (DT) Call trace: dump_backtrace+0xd8/0xf4 show_stack+0x18/0x30 dump_stack_lvl+0x70/0x8c dump_stack+0x18/0x38 __might_resched+0x154/0x164 __might_sleep+0x48/0x78 mutex_lock+0x24/0x60 _snd_pcm_stream_lock_irqsave+0x20/0x3c snd_pcm_period_elapsed+0x24/0xa4 axg_fifo_pcm_irq_block+0x64/0xdc __handle_irq_event_percpu+0x104/0x264 handle_irq_event+0x48/0xb4 ... start_kernel+0x3f0/0x484 __primary_switched+0xc0/0xc8 Revert this commit until the crash is fixed. Reported-by: Dmitry Shmidt Signed-off-by: Neil Armstrong --- sound/soc/meson/axg-card.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c index cbbaa55d92a6..2b77010c2c5c 100644 --- a/sound/soc/meson/axg-card.c +++ b/sound/soc/meson/axg-card.c @@ -320,7 +320,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np, dai_link->cpus = cpu; dai_link->num_cpus = 1; - dai_link->nonatomic = true; ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node, &dai_link->cpus->dai_name);