From patchwork Fri Apr 22 18:51:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12823996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97C08C433F5 for ; Fri, 22 Apr 2022 18:51:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C132610E259; Fri, 22 Apr 2022 18:51:42 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0E3610E25D for ; Fri, 22 Apr 2022 18:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650653500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hxCPWA8afO+/nG6bVigx+oLOlYxnjtDB8EbEFgDn4q4=; b=XGxq8l3V+fIMdxiyq6a2LmH2y4NTT4DwGJMV9QSNLNA9Lb22FphxIHWf7zGdByPK5oVCmI qmvE2ifSLEuUlC/1xLBXMmtRth9tr2KbPXgegGsueUTl3SXZ9Fo0vmYOzBbxZV1FMVmbG0 +sWyZD1Dy4Va4tUFiq2+V/0xCsIKC7w= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-505-wTn0plwmMlGP1SbF_MjCbQ-1; Fri, 22 Apr 2022 14:51:39 -0400 X-MC-Unique: wTn0plwmMlGP1SbF_MjCbQ-1 Received: by mail-qt1-f197.google.com with SMTP id t20-20020a05622a01d400b002f1f4b6d6d0so5540548qtw.21 for ; Fri, 22 Apr 2022 11:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hxCPWA8afO+/nG6bVigx+oLOlYxnjtDB8EbEFgDn4q4=; b=6UIkV19hZICdF4YYjyxZfLmrbg3GN9q1COgO6GALITLfRtGTRKXKwCZwsS5B3kG9FH a6kj70P/h9It1RgznBROue67E2WqTaTGd2BVLq6mf4RrqsrSX59v76BoBzBa7Mk8HVTA dHbU+P/jqJNEAVRYPvRMPiMZaj+RKBdUV07kw1GJq0TlwrdFzWTggV2OzJYiS+0MYsNg RUcoTj5M4cZUnEfXKEuj2VgnGeV+ig7fWax+VVahbMPKDKFP1/7Jj9oaKZ9+bieWx3Wc 6UxOmuXz8OLh4OZU4qe7JxBRPfQc9cF71LVWdI/uUoxW+RLF4at0LngSDPq2Y06C0vGD qWLA== X-Gm-Message-State: AOAM533F7KwaIGuj2p8v+a1yN2mVaNHql7b/ZXxZcGUkgjV4hsTeD/x7 wftAymRGyc/qIoMayqyn91yVWzrWt1FNYw4o6mGj/UoKN4NvpWzn0VEJ94ZD93RWrOgtA60NPF0 r3Ir+qssawVA3+cExChfYMOq3CTRM X-Received: by 2002:ac8:594c:0:b0:2f3:3fd2:3ccf with SMTP id 12-20020ac8594c000000b002f33fd23ccfmr4348332qtz.610.1650653499107; Fri, 22 Apr 2022 11:51:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoT4/XMYJdxpa4GMbbGlHtzbN4fpVF+tFJqN9scdq+SUM9VTkRJ4SJtkWZHXMzlvMYxYQFqg== X-Received: by 2002:ac8:594c:0:b0:2f3:3fd2:3ccf with SMTP id 12-20020ac8594c000000b002f33fd23ccfmr4348312qtz.610.1650653498849; Fri, 22 Apr 2022 11:51:38 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id z8-20020ac87f88000000b002e1cecad0e4sm1693729qtj.33.2022.04.22.11.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:51:38 -0700 (PDT) From: Tom Rix To: bskeggs@redhat.com, kherbst@redhat.com, lyude@redhat.com, airlied@linux.ie, daniel@ffwll.ch Subject: [PATCH] drm/nouveau/kms/gv100: use static for gv100_disp_core_mthd_[base|sor] Date: Fri, 22 Apr 2022 14:51:32 -0400 Message-Id: <20220422185132.3163248-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Rix Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sparse reports these issues coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? coregv100.c:43:1: warning: symbol 'gv100_disp_core_mthd_sor' was not declared. Should it be static? These variables are only used in coregv100.c. Single file use variables should be static, so add static to their storage-class specifier. Signed-off-by: Tom Rix Reviewed-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c index 448a515057c7..1d333c484a49 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c @@ -23,7 +23,7 @@ #include -const struct nv50_disp_mthd_list +static const struct nv50_disp_mthd_list gv100_disp_core_mthd_base = { .mthd = 0x0000, .addr = 0x000000, @@ -39,7 +39,7 @@ gv100_disp_core_mthd_base = { } }; -const struct nv50_disp_mthd_list +static const struct nv50_disp_mthd_list gv100_disp_core_mthd_sor = { .mthd = 0x0020, .addr = 0x000020,