From patchwork Sat Apr 23 17:02:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12824642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B53C433FE for ; Sat, 23 Apr 2022 17:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbiDWRGJ (ORCPT ); Sat, 23 Apr 2022 13:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236520AbiDWRGG (ORCPT ); Sat, 23 Apr 2022 13:06:06 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2051.outbound.protection.outlook.com [40.107.236.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2381DAC92F; Sat, 23 Apr 2022 10:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhFTelKM2hS/cqYXCA+gvfOKPJ4EmpXj+dHLR2pjgxIav4dFA54kNYAObCAiVlmoE353X1AGUne/lNvFOtn9w63LXojq1u8FKe82f5oh8P7PBnSkxlTxj/oZ8LLZrd2OzqM1RG2n5BuadDl/mwL28CJLTjjrzXNQc2bqk+t9rAB3Oky9pqLw7saklUKFL/Dkge2fLtN9YZSyld2gc4J2PKCv+39dW1wA0oV18T13fbWPsY1rwGUSvXLD9PI5QXH+iODx/ylFXJZtKLYCz5qK6kkbBAXQlY8m/zP2zzbt7RDUrAIw6Kek8UYPcsY0IFGac5iwTxmSVGkeUworGwqLEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWxl3A7nKkKK9UuArPItKEN8cXGm/Fd9+3BOPvZ1pNc=; b=KrUNeyLitJ6r0CZmMc3OdP6Xy19zFGYQTnLExIoTjvY6qxNtLT35LcpxT64pzDRkFIcpTi3IJmofaMBa5GMZ7bD2GQPuMnrD4P+ZZuZaRvwOscVnXTqtvSNJj0gZ7YKYCEGZ3DQMQr/43GwMcMiyLUejZ40qUOFOuRV3LYjJc3DSJUq7ObzB/u7LUcYMSkbdbvEL/N8xQ8eYFteNXMwgnATsb7IHt9gdvdvkcPAepF/fDoR9mpkdr+7q7+u/gY7pr84fNvPPB3gZcnsG3ml952qZWM1RgydTFEM/OotHdTKPRQc1yXYD77uWvCUDKI2yjd/Dv26uo2zLMfmWYmt04g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWxl3A7nKkKK9UuArPItKEN8cXGm/Fd9+3BOPvZ1pNc=; b=LTIAj8bnfFOk3g8xeAqnwMyPDzexD41kE4nKo4IdZqgvwC5ARn24X2z59PoNvllrvkzWeM4eOVyY5OVDUDdhNyoogalHDxbf+2VtSIrlacuGFJDZDz7E2s9QQj3SRYqcToL53lAzL2uP7u54g8TelvQ9KRdT7uoJfIrUQeuN/rE= Received: from DS7PR05CA0052.namprd05.prod.outlook.com (2603:10b6:8:2f::30) by PH0PR02MB7509.namprd02.prod.outlook.com (2603:10b6:510:5e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sat, 23 Apr 2022 17:03:05 +0000 Received: from DM3NAM02FT056.eop-nam02.prod.protection.outlook.com (2603:10b6:8:2f:cafe::25) by DS7PR05CA0052.outlook.office365.com (2603:10b6:8:2f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.6 via Frontend Transport; Sat, 23 Apr 2022 17:03:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT056.mail.protection.outlook.com (10.13.4.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:03:04 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 23 Apr 2022 10:02:52 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 23 Apr 2022 10:02:52 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=37114 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1niJ9o-000FkB-5Q; Sat, 23 Apr 2022 10:02:52 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v6 1/5] fpga: zynq: Fix incorrect variable type Date: Sat, 23 Apr 2022 22:32:31 +0530 Message-ID: <20220423170235.2115479-2-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com> References: <20220423170235.2115479-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 553e801b-aac0-45e4-7188-08da254b21ea X-MS-TrafficTypeDiagnostic: PH0PR02MB7509:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HUFPaM6hN7tQfPZAc1mFpjhcFb1NLScZEUwFSYU1aM6F04aMr6+bFQ1mL3ZnJcwb83w+K/r7iEuGvKMqoF72uEjNbSmnR8RlVYfidQD/5pSn7N7HJ6L5TKWIofSGvN2Qrsu6ljoFlH6QsYEefVji0KN/BaWnsG4geXY8/m/ZGGzXu73dQCWlHCKGPKdeQD9bxImvtMHrMUrDmCvH50z9o9rajP6sKV5TBc0EykPc3ny1Bj5aUJIL5H4HTA0mNPk+/Ct13bKuiWyWJ2F/Onh+xhrkPNhFZKI+91X3YEUE0Adz/PwIfFry6QUMwja+L7dkCnEJGb3B44brWYK5Jeed7qS7x4Nr5JjnW0o33bWFt87p2KYGvU4w6V/SPBh5+t8F+qTme5Z7vW98Zlz1p5vlvgdEJciq4m0VNo/Q2yZDqXCXO7tC8SrdJhak70e9T3vsQDPLrY236UzgFUMjZJ6U/5P/ONvM8O7jdHj/8mg5corL2lktItGREJNFoXay2pq7AdtIckkBmewiUEZ+2mOCB09DuKFr1yqVYjztz/8j2U9YmAGR/o9wEckUUSWzJzIIEouJT9GJy8+95eBTqSD7CajJ4yqDc8rkwWa8R2yrVhIQoyOL34cWioSF6xK5yA2UumtiEMC8JFJ4+leEap0Z2HYqSztdb6Gwe7VGiaZwsqRlQa5mnBDJms41hNwB1JlMEaxj5KxRmm2gvae8s+mtFc8hsVssK9Q/9oD62zxRhWQ= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(336012)(426003)(508600001)(5660300002)(9786002)(8936002)(47076005)(2616005)(36860700001)(107886003)(26005)(186003)(82310400005)(1076003)(6666004)(2906002)(7696005)(40460700003)(4326008)(356005)(70586007)(70206006)(8676002)(316002)(83380400001)(6636002)(110136005)(36756003)(7636003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 17:03:04.7196 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 553e801b-aac0-45e4-7188-08da254b21ea X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT056.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7509 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fix this issue by changing the buf type to "const char *" Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. Changes for v5: - Dropped the irrelevant doc update changes. Changes for v6: - None. drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..6beaba9dfe97 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) * the correct byte order, and be dword aligned. The input is a Xilinx .bin * file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && From patchwork Sat Apr 23 17:02:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12824640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BDCC433EF for ; Sat, 23 Apr 2022 17:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233532AbiDWRGC (ORCPT ); Sat, 23 Apr 2022 13:06:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236515AbiDWRGA (ORCPT ); Sat, 23 Apr 2022 13:06:00 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2087.outbound.protection.outlook.com [40.107.101.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4027692D10; Sat, 23 Apr 2022 10:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=maJ4Wl9Uuy3Qmmw/EFj8XW09VNpUZgUKg7hnvw8Q/qoepwnewcC9II4Dnsb1XAYJqdma2RGESALje5r+D2bPwoiKkAu65FtR/+LEBzK3qHuseN8ByksxYILWSx0BQ2YrndHNhiCoDG66V/S53U2OzGSLZrITsw/asl+B+V39E7g9BxKYr4i5sx2FjmIq9WzYDA0bvjPNKMRSLRHQXKrWghRcmCkYhSFTHbaSGOX85t98FZHrZxylcvpcqsFb3cS/9hIR5nhXLsImg2au9r/tRPQiUKLXV+1Of033DX7b483E0qKU8E9b/5pSJ9aJ8JhoxpYSjxsjceTiGlNuORbNfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pnEo2ORND0+Zy/ZwO7QEpUF1PNGFJBh74/U2HLvrJxY=; b=Axrj/gB81M9n8LjehDlXRpL7h3ujVnYsFFgsecaEDSm5FIN8JUS7Nh1PhJFyAT2GG5vmjIR53FN4qmIXP0ocbS1I98fefwIKALVlX/VPJRie4E982sStLQqCMULMPySnEBBE4eFqtQSrdGFZiIVrUqOHhdzMhGnmWyp5KhduvzV66n77MboJTyQ2+RQlTfPsR+39iPUtV8JrBRY3p88qbZ7EqnKa/I5HUe24g8hRLAhTjDLD6ICXiGukAcngOLwsDhcXVlGmKJrU+emw5dX9GZ9Ffre7EihL2KVH4Qwv6KwWq+fXJ3fQd7arKKmiKro2B6SQQAPpSaDzFIRsoNVZsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pnEo2ORND0+Zy/ZwO7QEpUF1PNGFJBh74/U2HLvrJxY=; b=PSm4ObV71a8KrXRxYG2KIdSMHICyiosms4ItjSyH93F13RDXaJnYlB783niFcNDyaX3jkKrQvjXmZeAVYCQBEDb78ODH5IEm271mECUuFEV/g73Rr/arsaADM/72QK0HvEHMrWWxhRXdeoQC9nHOID1HkdNuHNRjZvyXzftpJxo= Received: from DS7PR03CA0253.namprd03.prod.outlook.com (2603:10b6:5:3b3::18) by SJ0PR02MB7375.namprd02.prod.outlook.com (2603:10b6:a03:2a1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sat, 23 Apr 2022 17:02:59 +0000 Received: from DM3NAM02FT031.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::30) by DS7PR03CA0253.outlook.office365.com (2603:10b6:5:3b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Sat, 23 Apr 2022 17:02:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT031.mail.protection.outlook.com (10.13.4.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:02:59 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 23 Apr 2022 10:02:57 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 23 Apr 2022 10:02:57 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=37114 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1niJ9s-000FkB-QB; Sat, 23 Apr 2022 10:02:57 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v6 2/5] fpga: fix for coding style issues Date: Sat, 23 Apr 2022 22:32:32 +0530 Message-ID: <20220423170235.2115479-3-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com> References: <20220423170235.2115479-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 931914bd-445e-4000-8756-08da254b1eab X-MS-TrafficTypeDiagnostic: SJ0PR02MB7375:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0I2bNAEJK0rDjCvKcM5/oZYCjkzOv9sbo8jZMv0XcAwhB6uk087pXTGuKKXJKmd0IFg4vpUu9HxugyWyd/03eMIUle4uFTl6TVQ3XqIoZulZlso7UzdOTHHlNB+O6KPjbFq60h0jjitc0jA6m8oWfyPCcL7tuoKSgpPwlF+TPADWQ3Eo94ODIUwUkeh+EnRJaYU56wlHfN1A7PqXThKAALrPF/pCuktfohainLrfEQ05eApcYENjPvX/mTmFSfITdTR7ehggadelny6+tfss9/M7n3U6fEXqQ4alLDt8L3fJirQ8KvE7vIHvM0v2OldDkEMpZl1XOuyHv90+MlioVHiXL2izgNONLj1+E8N8blvsqVDrqk0wSBOzm2vGK8eGD056l2A5vS1imOFQ07U5UlkJhbk9kmaH5+zd0xgxBGRYEsVcjSjPnuNeBcygQV1QC+09LfgEJdNcC1fC7L96AxNxOtLRHDbQyVWokLVp/5VX3Hbqp/QkiHS0xKKCz4Xfg9qUZU7FCWRktzSqwrOsDl7RhrZqGlQs6p+yFGs+h1qIu1tuJL5ykh/2ZpbAhMp8HS1KCtojF555rpNojL8zEeIrLiEuPdFK9cY4XvgIrDRJqB4++VqFjStfqwrgfdlwwy++dImx1O/Onyrh+l/6OmpnWxvDV+svzvqi4DWeXx7g6lBtyU671/WgcepbcwnSZ1uXpqXwTCnwHWPShZetdIFFIQXBibFKkpxWKAfUzo0= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(9786002)(8936002)(5660300002)(107886003)(7636003)(356005)(1076003)(2616005)(426003)(336012)(40460700003)(6636002)(186003)(110136005)(508600001)(7696005)(6666004)(26005)(47076005)(316002)(36860700001)(8676002)(4326008)(83380400001)(70206006)(70586007)(36756003)(2906002)(82310400005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 17:02:59.2741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 931914bd-445e-4000-8756-08da254b1eab X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT031.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7375 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org fixes the below checks reported by checkpatch.pl: - Lines should not end with a '(' - Alignment should match open parenthesis Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Fixed similar issue exists in "drivers/fpga/*". Changes for v4: -None. Changes for v5: - Reduced the length of the 'fpga_mgr_write_init(...)' API as suggested by Joe. - To align Include declaration and definition of APIs updated the FPGA-region.h file as suggested by joe. - Fixed similar issue exists with of_fpga_region_parse_ov() API. Changes for v6: - Align the declaration and definition of APIs as suggested by Yilun and Joe. - Move the 'count' handling logic into 'else' block as suggested by Yilun. drivers/fpga/fpga-mgr.c | 9 +++++---- drivers/fpga/fpga-region.c | 6 +++--- drivers/fpga/of-fpga-region.c | 6 +++--- include/linux/fpga/fpga-region.h | 6 +++--- 4 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..24dee27c7897 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -148,11 +148,12 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, int ret; mgr->state = FPGA_MGR_STATE_WRITE_INIT; - if (!mgr->mops->initial_header_size) + if (!mgr->mops->initial_header_size) { ret = fpga_mgr_write_init(mgr, info, NULL, 0); - else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + } else { + count = min(mgr->mops->initial_header_size, count); + ret = fpga_mgr_write_init(mgr, info, buf, count); + } if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b0ac18de4885..485948e3c0db 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -18,9 +18,9 @@ static DEFINE_IDA(fpga_region_ida); static struct class *fpga_region_class; -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)) +struct fpga_region * +fpga_region_class_find(struct device *start, const void *data, + int (*match)(struct device *, const void *)) { struct device *dev; diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 50b83057c048..a598d03626af 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -189,9 +189,9 @@ static int child_regions_with_firmware(struct device_node *overlay) * fpga_image_info struct if there is an image to program. * error code for invalid overlay. */ -static struct fpga_image_info *of_fpga_region_parse_ov( - struct fpga_region *region, - struct device_node *overlay) +static struct fpga_image_info * +of_fpga_region_parse_ov(struct fpga_region *region, + struct device_node *overlay) { struct device *dev = ®ion->dev; struct fpga_image_info *info; diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h index 3b87f232425c..9d4d32909340 100644 --- a/include/linux/fpga/fpga-region.h +++ b/include/linux/fpga/fpga-region.h @@ -52,9 +52,9 @@ struct fpga_region { #define to_fpga_region(d) container_of(d, struct fpga_region, dev) -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)); +struct fpga_region * +fpga_region_class_find(struct device *start, const void *data, + int (*match)(struct device *, const void *)); int fpga_region_program_fpga(struct fpga_region *region); From patchwork Sat Apr 23 17:02:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12824641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13589C433EF for ; Sat, 23 Apr 2022 17:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236513AbiDWRGK (ORCPT ); Sat, 23 Apr 2022 13:06:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236526AbiDWRGJ (ORCPT ); Sat, 23 Apr 2022 13:06:09 -0400 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2050.outbound.protection.outlook.com [40.107.100.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17818AFADC; Sat, 23 Apr 2022 10:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSyCwVIhgWsKDSKqtWeik13koIv/40luRrcWuGP1bZJx8G/NxLrXnBhscf0uqhnRKYuq4iJeOvmZQs86P4Jt/bTaP8c4QFZggfXIJlNsZPpo5Ft9mCKpIFX/s48HFNw9T0A5GLwNxCr4R6cBE0WZy9BSuxDGY2VP5aFUe6hWzhRHITMHvs74cldr5lw//J8xWaYWvR3d4cYRVKzLYA7BmHDeIul3qoMDo1N9Gns5wfNDsUhDEzb2REBf9tx27Iqxzs+cyyLIUQ1lUSNgD4IAxZDVOb9SHZ68dfCMpv3Zav/Xm4LUtZlp0Joc7qHQZRL0ppmyjUcZnUTZpjU/AQHiVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXhtSUcSvE+NykUjEighaqvGZMaGzM23ZZIWBFInkXc=; b=UZ2zrIg/rUBjuwj/C4TvqE+AeTfjjau1FIn5l+DzXNgjHqodnLgXaqKQBAQbjOpG8wBL8SvSAr3Nul9sfTQXFdQoyAlVaktjuPetf0L+DpCrYONH7vRo/EYdguQGR2cYtMZHrZt/8EBZ3yR63MetWN+sAl9JK4Fhh5kOMLVH5ZDKeBKzy/CqT5zgBPFqDKcoTz1uNgLXO4EuRDmwyFnWW7qwdOfIX0RnObP4q5pJDQMTjKLY3WaUwzR3A2KuxhHL18PwC7Kg4NlQJfL6JGfA2ZHmTgpi7Evt4aUpS0ZLXGVj2r3GUm4qyX8DsQfQXqauu/6LN8q4i7o8STha/OLMAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXhtSUcSvE+NykUjEighaqvGZMaGzM23ZZIWBFInkXc=; b=fuxiihp7BOPOE/FNaE92ba8SgX5N7TvDsvrE+qSlljAONbw1Y4riQbWsDTPGrDpgEUb4LGTj/c5hF+6IIERhFlxWXG6cU7dJCOtYJTsVMobtZW1e/FgzDfakoymIfT5MykF5t8hnB3+X/5ocJc89ReJJBLTF3E/ULNTm+Nn7e1w= Received: from DS7PR03CA0113.namprd03.prod.outlook.com (2603:10b6:5:3b7::28) by BL0PR02MB4802.namprd02.prod.outlook.com (2603:10b6:208:53::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Sat, 23 Apr 2022 17:03:07 +0000 Received: from DM3NAM02FT020.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::a1) by DS7PR03CA0113.outlook.office365.com (2603:10b6:5:3b7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Sat, 23 Apr 2022 17:03:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT020.mail.protection.outlook.com (10.13.4.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:03:06 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 23 Apr 2022 10:03:02 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 23 Apr 2022 10:03:02 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=37114 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1niJ9x-000FkB-Pr; Sat, 23 Apr 2022 10:03:02 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v6 3/5] fpga: fpga-mgr: fix kernel-doc warnings Date: Sat, 23 Apr 2022 22:32:33 +0530 Message-ID: <20220423170235.2115479-4-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com> References: <20220423170235.2115479-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc2b9bde-b2d0-43c9-2f61-08da254b2333 X-MS-TrafficTypeDiagnostic: BL0PR02MB4802:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6fLgtGIVJq4lp3W9AF+s7sgThGQqkQgSqqd7GDTZ49ZGVM3DTIsc3FscU6hJIH/nhSwj/nrIawlX5OJbOhzooo7EiEMUW1i+Fw/8NFUdlUa7S2U2/LjgSF0hwOIuAd2VQ8TtYq3RRlg83+pObX9oUVE+ENbOmKf/RD/n1xWoZN3Rlf0jgRt7F1POk+zkBOnihM4AJaRKbVhwPePT7npo7oq0i6DxypZH7rvOoA7t12PFjYZODMXqjLNHSyyuA+a0x0nVP/2MoXVoJMj0WgdLpuDWgSF92WAfb+9ezrfC6SHTRzuGDdnz8ivjYplzVuudGx2RBd/V/3HcBhCnAcS0Guze4VcexY3tVK4PN/wj8Ov37cb2rsLPXv1R3/6f3t8a4Qx5b5ORy9L4ZjRyyz9NLs3JQDEsWb3G7b2Od9eQNlmETfK+xEaG3F6vGp/ngPU9fHfK+fbUJCBDVfEld1ewImkpNhrnZEdaEZKk6bwIeMNSlZ0z8ATzVIu0gygECRGm4uwwNZbDj1uW3P3hMvx5R/nbqiIaxzpfbYnhE0PVEiREa1bPeis7HCQ0Hu6NdQJ+dOOQIRMmQWYm4UFrIojN0S9HtXIy74qnNaLk704vpn0nu76cIwKz29gHS+4Z85AcWl1oZstBDwWWbaGgTdg5JmzrDvkn31eq0Mbjm9wNV8VIi4qak356Ekay+nbsDM+cQMMyojmXahfVkOFkL+pyorPnPjmKa4ag+28KCHaXu6riRYLKyf/iz03qt7JCheIS X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(82310400005)(2616005)(107886003)(7696005)(1076003)(83380400001)(70586007)(70206006)(40460700003)(336012)(426003)(47076005)(8936002)(356005)(9786002)(316002)(110136005)(186003)(508600001)(6636002)(7636003)(26005)(5660300002)(6666004)(4326008)(8676002)(36756003)(2906002)(36860700001)(102446001)(21314003)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 17:03:06.8741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc2b9bde-b2d0-43c9-2f61-08da254b2333 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4802 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org warnings: No description found for return value of 'xxx' In-order to fix the above kernel-doc warnings added the 'Return' description for 'devm_fpga_mgr_register_full()' and 'devm_fpga_mgr_register()' APIs. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. Changes for v5: -Updated commit description. Changes for v6: -None. drivers/fpga/fpga-mgr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index 24dee27c7897..a3595ecc3f79 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -731,6 +731,8 @@ static void devm_fpga_mgr_unregister(struct device *dev, void *res) * @parent: fpga manager device from pdev * @info: parameters for fpga manager * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register_full() for which the unregister * function will be called automatically when the managing device is detached. */ @@ -764,6 +766,8 @@ EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full); * @mops: pointer to structure of fpga manager ops * @priv: fpga manager private data * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register() for which the * unregister function will be called automatically when the managing * device is detached. From patchwork Sat Apr 23 17:02:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12824643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8CAC433F5 for ; Sat, 23 Apr 2022 17:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236551AbiDWRGT (ORCPT ); Sat, 23 Apr 2022 13:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236552AbiDWRGQ (ORCPT ); Sat, 23 Apr 2022 13:06:16 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2086.outbound.protection.outlook.com [40.107.236.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D06EEB646A; Sat, 23 Apr 2022 10:03:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrS8Kn8e32TmuygotDpKd5fVunNhB5QfdiUFJit8mqqPsEwph2aJcxQEhnAzDK2NZFNHjkwVDXHHyTETEASfCKBZ7XwqIjuVKMTZZZ29oI0R26RMDfV+rL1xXHeOQJmZ0hTHa6r0uBrZeC0349QO4LLPuUjKrSZjfZjPZg+5HXZ3ExF2W04Z8JhxGV63iDioJ9MEI1YNh6T4mfSEqS5G0xSNQ9hGWuEv9IUr5fQJESJbJ1FjZUENX7JzcnfOHArZJs76Ar1pWxfd6XxyIOkCrH+kgDapVKfvI0kCSzJhFzl7bsyOAbQShK2syyuxWM8BrmnTvHXzFt1YhFMkoTDDjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H2Pj2ZdklKpG2VYb4ZKoOj6v8mi2vKxUS8ZkiD73LjY=; b=ZuDZH+IKpt5E9oQjWzXbhtiqMUDWoBeByLFIKcQjHM8+sdltAMzVqyvirheTKtUw/5MAH2rlF+tQhtHmaTDNZcttZZCqiuhvCokuiciq6Z9PyHaOPJKTjiMDUhMC7RRUhsj0vsEsj1n6M7VOAWfwh9ohtS24L8WLpc8khPHeVb99ElYVvqp4P21Auz7gS2UtBvbQXOwKH1aONtZ7QIFOqaR9seYzBw+vr6GT112speON7wEdv77ZyaVA7nr9GXe3ZLDRO6FqR/e6xacEli44FHaOINdH8DzP6TE4kVmT7VUhkBiKZFDJPEqFzjaq4MMBqHFh3J83WytjRKz4wt+L9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H2Pj2ZdklKpG2VYb4ZKoOj6v8mi2vKxUS8ZkiD73LjY=; b=MHPYKJmau7JCAHZr8C8EhiTE8DSdxzE47LXY1rUnMttsVQf00WDqvRb76tdkKxZFz6sZWmNjbIjMwznBxsesieQ3YeB1TfLX/DziJUBADyFowQlLWtc2To/FYu//zSjT9YmT4PZDrRUKmTuH9OXzsg9zLSW0GbTojaamMPaLQdA= Received: from DS7PR05CA0037.namprd05.prod.outlook.com (2603:10b6:8:2f::24) by CO6PR02MB7505.namprd02.prod.outlook.com (2603:10b6:303:b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Sat, 23 Apr 2022 17:03:11 +0000 Received: from DM3NAM02FT056.eop-nam02.prod.protection.outlook.com (2603:10b6:8:2f:cafe::7c) by DS7PR05CA0037.outlook.office365.com (2603:10b6:8:2f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.6 via Frontend Transport; Sat, 23 Apr 2022 17:03:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT056.mail.protection.outlook.com (10.13.4.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:03:11 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 23 Apr 2022 10:03:07 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 23 Apr 2022 10:03:07 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=37114 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1niJA2-000FkB-Tf; Sat, 23 Apr 2022 10:03:07 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v6 4/5] fpga: Use tab instead of space indentation Date: Sat, 23 Apr 2022 22:32:34 +0530 Message-ID: <20220423170235.2115479-5-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com> References: <20220423170235.2115479-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f392f01-06ba-4c15-f0f5-08da254b260c X-MS-TrafficTypeDiagnostic: CO6PR02MB7505:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z/0ghV3GWnns4UzOqbWsVefNhWT5c/u8fnoMkRlWG/9Y5Ze3whoxA9oeDIDHt8iO+OuWKm38vKF/1mYWx/R+APibFEAJQe2bgtO9qlHiW0J2mZYXnLuuYttuDt/iYkq5JyWykOP8wVQLWHU7NNd2h6kHCPlT5BguHmzYsVe3rLwN3jJpnOJ96h8lYpKrlLiW54B+x1xXl9qdcbqi2valdpg3pIM1uxikUPlIXDPtSkooP2UEctioi8runFiLhLKLEPyJFSlcRDQIeVVm+8EaoqAqTIhDmPSEXjv3B0ELFrkbBLixo++45exW+dYH731erIMI/iG+V+hm4C+QITesf1t5xBoSQWv77f4l3LS+UXDJELokPoAvgcZEm9+yfZcdt+2muIIaWjNSyPr4rK7WLkLhmsk0u+dt7KfrmBF7+FEsIeuQ+FcqQs/kn5rRcNaElb5++UsCsfSUuyxImP/fFBrjKMTcajW1Cvp4zUIQmoCBVTPZqTykLSuG5CGuqTNEeaur5pdxKGO/F3RwGubnxd/bG6QO6L8/H2Ki2aYoPrb8EXmLqKzwcYFZqOh0O06FWbVfShP40PU0V9f9sd0lz+a7eDOhP57IPug9ZlqqETHumeZccViPlXbzL7LzqZZMtPXJ7XHsIra3mJI86rBqWqL3M719u0xWDRq+15yGa0QsF22AMvDWOE76t5eY86W1ZW24HvJ2SM4nFSuvYYRWZYdk/R/OhssLb60zKJI+nq8= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(8936002)(9786002)(5660300002)(107886003)(7636003)(356005)(1076003)(2616005)(40460700003)(6636002)(426003)(336012)(186003)(110136005)(508600001)(7696005)(6666004)(26005)(47076005)(316002)(36860700001)(8676002)(4326008)(83380400001)(70206006)(70586007)(36756003)(2906002)(82310400005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 17:03:11.6722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f392f01-06ba-4c15-f0f5-08da254b260c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT056.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR02MB7505 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org In FPGA Makefile has both space and tab indentation, to make them align use tab instead of space indentation. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Updated commit description. Changes for v4: -None. Changes for v5: -Updated commit description. Changes for v6: -None. drivers/fpga/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index 0bff783d1b61..5935b3d0abd5 100644 --- a/drivers/fpga/Makefile +++ b/drivers/fpga/Makefile @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o # FPGA Bridge Drivers obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o From patchwork Sat Apr 23 17:02:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12824644 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C689C433F5 for ; Sat, 23 Apr 2022 17:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbiDWRHL (ORCPT ); Sat, 23 Apr 2022 13:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236557AbiDWRGT (ORCPT ); Sat, 23 Apr 2022 13:06:19 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3CC5B646A; Sat, 23 Apr 2022 10:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OlLB250JcMQoc/miyRA25fL7fV/6f/CvOaQ5Y8QYEsXxFmlbpy79sIHm4gs2EKP9ocQwDPXSorqv6ch7BCDotUUenOi03ibAIY/zM7+t19ktUEE6YYDCMx/OTPbUnGKRPkHq1mNDLviqjrKTptsmfEREsuoUGl7KWYN3Kt2Tf3llc5pakBafwT/RswUt11cI42j1wtKyv6FC/kjj/ximI1uzWsekJemf70PuMtoUuVrkcc1INO3qt6THz6LH8V20iU2dU+G+9dWyTEvS2fkZOq7e0st6qkalkn6ggxmyMw4xEihSTT4+IqVY7QIzzRJSKfUgQB95ydNKisLvexZ9GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F22sGPSvn6ZgCBKqPOsRG7jr8EpEybrU0FESyvyYM3g=; b=G1xzqS2fd0k3WpBV/ai7HGHBxRrZ0RaZh37pIrE/fwENw46OYSVabPdkk9LD5qFh402rh1+31Kc7IkdAFjXQYTq6geFCpCA07C3vGQmb7ae2eyNRFV6pi4fE9ctJp1MCKlTHSMRhVsxpdJCvqRqjZgjehZBvoDYZXkR/DKD6hDOn2PY7U20+JjkFuTPUgGP737G9wTqWpfvPfBjkFN4LS2xyfhlziC7iHK0igRbUk0hzz41S7WPvaQVHSO1ot9cZm7CiNgv9gX2yfKOaONWtbNwnh/1PVimB1ZsdlwaKnkz8Thw3DaBs+ywX9VRAiVf/h9T0MK8spxw/qsOGTX9ZcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F22sGPSvn6ZgCBKqPOsRG7jr8EpEybrU0FESyvyYM3g=; b=Qz5v9vhNMLgbhcc1wiWeLUqW8kSmhDp3e5r5M+q/X7tQZd50QYb95kjgn2NBK07Y9JP2aaQBnEoyTJIoU4GVtlLMLZuVyP4r04zukLQkrmN1+gCV/YyYmlnsQK9TQjmegIsojMY1sOicE8d4SYtO2jyhLxLseNc6ZQOHY3hI8fM= Received: from DM6PR01CA0021.prod.exchangelabs.com (2603:10b6:5:296::26) by MN2PR02MB5951.namprd02.prod.outlook.com (2603:10b6:208:10e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Sat, 23 Apr 2022 17:03:16 +0000 Received: from DM3NAM02FT058.eop-nam02.prod.protection.outlook.com (2603:10b6:5:296:cafe::54) by DM6PR01CA0021.outlook.office365.com (2603:10b6:5:296::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:03:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT058.mail.protection.outlook.com (10.13.5.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Sat, 23 Apr 2022 17:03:16 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 23 Apr 2022 10:03:15 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 23 Apr 2022 10:03:15 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=37114 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1niJA9-000FkB-JS; Sat, 23 Apr 2022 10:03:14 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v6 5/5] fpga: fpga-region: fix kernel-doc formatting issues Date: Sat, 23 Apr 2022 22:32:35 +0530 Message-ID: <20220423170235.2115479-6-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com> References: <20220423170235.2115479-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24b865f0-2bca-43d6-9f3c-08da254b28e3 X-MS-TrafficTypeDiagnostic: MN2PR02MB5951:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JZGyOCn4ncapaX5osVWY+IaxQO6fNnBMMmWHX+sx8/jSNj2QLAFCFMmnCPOY6ordSzNn42hzCAAmGQoIi2Cbjsw3/7Nd8MIuGfQ1veeR8uQBzw0R/E/onv7JjtNNoAQWImvqRAO/fA1L6x4taUcSegMCzlVluFF7kCB1h7yADhhV6JizRFqWpXkQFdd3wvSOCCegfbVcwbEZnGaYnxAaoQmoxBlrMFsQfARoE/r9QJ4QCgizxFVBHF2cdYqjUoPDin+wSlVgYQ53jwXPPXH7VMkZd/sRGYAdfcBuXjkX8NPZCI58OSQlMwRLOjNo2G2J1nSU1WzaFS91U6SDLsl82cTbrkXlcj2zQzpyIfFdh1pmObMxKuQF5gpQ0hguaHabnY8uaWC78I4odVig/wyLJ/MO/u+OTIb6p0drpuSSQAsZjT7RGXsPkchaUrvkk1wzEZdvUaS7S5M15uPAtz9lcb2TYt6U6J9n8o/itSSeaGeX7NjAge5wWJU7wFwYYu7ZsohdaLwHGIX6OH6VRWwy1hN/yCy+M391tuxlpm02rzsd7eXQcjYiDmaUN+u44fqLZMksggpassJFoQWB5T5bO/dww6HHLGXPgJGjfgjoyUtWwCsa+IAzWF9HYOtP3D/gYCL+A0qrWixxX1QAZxd/VKqYUYJBxw8wyT4wivbYlQFEXR/Ep9mRT+FwlLBxjyc8aeZerNNtZOpBpsQkAqvKnicLk8gtJGNR4F0fdQYS5HE= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(2906002)(8676002)(4326008)(6666004)(110136005)(9786002)(8936002)(82310400005)(508600001)(186003)(7636003)(356005)(7696005)(316002)(336012)(5660300002)(6636002)(83380400001)(1076003)(426003)(40460700003)(26005)(2616005)(47076005)(70206006)(70586007)(107886003)(36756003)(36860700001)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 17:03:16.4190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24b865f0-2bca-43d6-9f3c-08da254b28e3 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT058.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB5951 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org To fix below kernel-doc warnings this patch does the following ->Replaced Return\Returns with 'Return:' keyword. ->Added 'Return' description For __init of_fpga_region_init()' API. ->Added description for 'child_regions_with_firmware()' API. warning: No description found for return value of 'of_fpga_region_find'. warning: No description found for return value of 'of_fpga_region_get_bridges'. warning: missing initial short description on line: * child_regions_with_firmware warning: No description found for return value of 'child_regions_with_firmware'. warning: No description found for return value of 'of_fpga_region_notify_pre_apply'. warning: No description found for return value of 'of_fpga_region_notify'. warning: No description found for return value of 'of_fpga_region_init'. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. Changes for v5: -None. Changes for v6: -None. drivers/fpga/of-fpga-region.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index a598d03626af..ae82532fc127 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -28,7 +28,7 @@ MODULE_DEVICE_TABLE(of, fpga_region_of_match); * * Caller will need to put_device(®ion->dev) when done. * - * Returns FPGA Region struct or NULL + * Return: FPGA Region struct or NULL */ static struct fpga_region *of_fpga_region_find(struct device_node *np) { @@ -80,7 +80,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct device_node *np) * Caller should call fpga_bridges_put(®ion->bridge_list) when * done with the bridges. * - * Return 0 for success (even if there are no bridges specified) + * Return: 0 for success (even if there are no bridges specified) * or -EBUSY if any of the bridges are in use. */ static int of_fpga_region_get_bridges(struct fpga_region *region) @@ -139,13 +139,13 @@ static int of_fpga_region_get_bridges(struct fpga_region *region) } /** - * child_regions_with_firmware + * child_regions_with_firmware - Used to check the child region info. * @overlay: device node of the overlay * * If the overlay adds child FPGA regions, they are not allowed to have * firmware-name property. * - * Return 0 for OK or -EINVAL if child FPGA region adds firmware-name. + * Return: 0 for OK or -EINVAL if child FPGA region adds firmware-name. */ static int child_regions_with_firmware(struct device_node *overlay) { @@ -184,7 +184,7 @@ static int child_regions_with_firmware(struct device_node *overlay) * Given an overlay applied to an FPGA region, parse the FPGA image specific * info in the overlay and do some checking. * - * Returns: + * Return: * NULL if overlay doesn't direct us to program the FPGA. * fpga_image_info struct if there is an image to program. * error code for invalid overlay. @@ -279,7 +279,7 @@ of_fpga_region_parse_ov(struct fpga_region *region, * If the checks fail, overlay is rejected and does not get added to the * live tree. * - * Returns 0 for success or negative error code for failure. + * Return: 0 for success or negative error code for failure. */ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, struct of_overlay_notify_data *nd) @@ -339,7 +339,7 @@ static void of_fpga_region_notify_post_remove(struct fpga_region *region, * This notifier handles programming an FPGA when a "firmware-name" property is * added to an fpga-region. * - * Returns NOTIFY_OK or error if FPGA programming fails. + * Return: NOTIFY_OK or error if FPGA programming fails. */ static int of_fpga_region_notify(struct notifier_block *nb, unsigned long action, void *arg) @@ -446,6 +446,8 @@ static struct platform_driver of_fpga_region_driver = { /** * of_fpga_region_init - init function for fpga_region class * Creates the fpga_region class and registers a reconfig notifier. + * + * Return: 0 on success, negative error code otherwise. */ static int __init of_fpga_region_init(void) {