From patchwork Mon Apr 25 01:11:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12825178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3E35C433EF for ; Mon, 25 Apr 2022 01:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9VvGAEO4KbOWpN1x4T7iuuVgNLMlNeYsmlF1rpa0kuQ=; b=bTZw8hKrKPTlJN sS1xkT8J/w3mri+yF58AtrabQ7fY8hrD12KQyosBS3El2AWkZ95S/144PCo0gRud3F5Zt+n/PyvzH Iv4fD5vCuWMOdyDWoXWhg2pGtlKrgICoxTgvzw9T9unyVKB8wsV5opqv6fhlG6uxgT/dcFQICFO5N EooduO0tdiPlIg2/HrtmezCz0199gk2jmELWIUWI0mpae0ybQ8b9FOrJgj/gI8xOJSMvPhacZkfxw q8kgMRw/1RsNu5i7m0pN4Q8RgjE1nSjZykyU6BHVyNdCnQCO0HGzb1bwBOd04C/tqRExf6QtudsEP 1meDmn4anzhgKHhY7PoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ninGG-007otB-Vq; Mon, 25 Apr 2022 01:11:33 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ninGE-007osr-8u for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 01:11:31 +0000 Received: by mail-pf1-x42d.google.com with SMTP id b15so13418243pfm.5 for ; Sun, 24 Apr 2022 18:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=YSoCH0xVGmx+Sdnu3ggx76S2cnidmkkBhFjPR4Sas3Q=; b=eyAYYSh01WWPXIJLX/iUTF9URHfNEL/mtDXc3taArEVl5Iynmgn+WbCXqlZc2ldIC/ h0bfG6wXJFRFCxaaKz5CF0rWaGnJ28JrUdPVvpUzWArWjYgcrgVbKtsR2dIRVJuLqKTu BFLHffJwBOdLOPkUIitqqTdw9L4xq4M73vtX+7B6KJQzxjMDSAROQUWkBO4a3SUi8jQA g11pxgD9rIzDbOXf8ZKxMGoqRfOjJcJJ/1B1/hldzilMJvA13rmVNA+m/oGvcXcPHvrk Ca68izmnC0REjk4qmvFrk2EjYLSaOnsgKGLDv1hcUqSwsC9kxIYszIMDA25HOv3a4G3V qJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YSoCH0xVGmx+Sdnu3ggx76S2cnidmkkBhFjPR4Sas3Q=; b=sOMCEtaW0iuJ2etxgbU/l+4ou017oPggeQ04nyHe0Ki827BiAZrVUdXnxHfGEDLzTz i4ZnZtMVceyJpnenGDDeGLuS1bMid102wMXMGKPeK+Pouyp6wq+/eH7xeYHQh4urVpPn acSTMqlsEZDeo0vnn0mT6E0lEcRg6S+KWIpkcHqoHICA7mH6Uzgs4UkIySWrduF6LCJR 8CeDPhmMyYhnWt51wWmsOVzikbSr244xPgiJO1SUhgBQqiQ90kxYfJS2/pj2O6casobl hS201QpcxGUdJswa1gLy5oaqKFy5bN47MYHwmrCVwlJ+Ni4xHiLLWLaFQm0O+3APoNz4 orUw== X-Gm-Message-State: AOAM531EebEUrbaHFnWu4z6A+WB2B/lRXLNL2qI97HXZulZC3CuxXeCw B2tJALpzZENrdwxOdZcTgcE= X-Google-Smtp-Source: ABdhPJwjHPGVOQINTadNkXbVqfZRxpPxLBKfTY2pBzNO0y9ZECO7/SZbHVLb9GTtJhJsZ2tGBrnR7w== X-Received: by 2002:a63:1114:0:b0:3aa:30b3:dd5f with SMTP id g20-20020a631114000000b003aa30b3dd5fmr12725982pgl.222.1650849088179; Sun, 24 Apr 2022 18:11:28 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id f186-20020a62dbc3000000b0050d3aa8c904sm2458157pfg.206.2022.04.24.18.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Apr 2022 18:11:27 -0700 (PDT) From: Miaoqian Lin To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Dong Aisheng , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [RESEND PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage Date: Mon, 25 Apr 2022 09:11:17 +0800 Message-Id: <20220425011117.25093-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220424_181130_371615_3B3F2A51 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1. Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() fails, so use pm_runtime_resume_and_get() instead. this function will handle this. Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") Signed-off-by: Miaoqian Lin Reviewed-by: Abel Vesa --- changes in v2: - change pm_runtime_get_sync to pm_runtime_resume_and_get - current check works fine for pm_runtime_resume_and_get() so stay the same. Link: https://lore.kernel.org/all/20220412065719.17735-1-linmq006@gmail.com/ --- drivers/clk/imx/clk-scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 083da31dc3ea..2044e62980e3 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -528,7 +528,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_enable(dev); - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret) { pm_genpd_remove_device(dev); pm_runtime_disable(dev);