From patchwork Mon Apr 25 21:06:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12826266 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AC0DC4332F for ; Mon, 25 Apr 2022 21:07:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3852410E23E; Mon, 25 Apr 2022 21:07:18 +0000 (UTC) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id E00D310E22F for ; Mon, 25 Apr 2022 21:07:13 +0000 (UTC) Received: by mail-pl1-x635.google.com with SMTP id n18so28369322plg.5 for ; Mon, 25 Apr 2022 14:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7pa6zrNLxEFTJIYew9I+MslyE/BqjUU2Vfh9xpblR54=; b=Shoz3tJtEfbeJHLbZbbAtm+y0n+qLrUd1IsVnLxx+HlgH0lU5Bzat9UjXBvtUxxkcZ fWVUxh4HAjy8+bLXQnIQG4pqK/T/ki1Ts5oXpNSWDKVq5nlj2zefrPxGz04zSJctnqww MdFeL7gkO8jwSYpuKBh4ELKQF7TnQPSYm6R2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7pa6zrNLxEFTJIYew9I+MslyE/BqjUU2Vfh9xpblR54=; b=4scrrfS+Nl1PxfMCFdwO6n07Pn2doMhOiuBeggppL6Z18ErWGW95qs86ZV4/EMIFTn lXHfGB0WQPSku/DgmpZlps9A4j7v5qBFqMNDs7oRbcu/fYyuo6tqyB44+a89GkC24yd3 SedcaAsfOXLs1q2Z5IcQCr2zhuzi3Ew6SLi7LDiyzilQL5zrQBlgdh10n/+I4Mhq0h4E MKK7yGIZeRjAbtv2Cpx6f9oUv91qjc8hQCalpZcenngmmfeUmdvALk/Hj+6UdrGioEQ2 e4hheW0cxINdVl99wcOXFYXAF4/BkyzK7M+w+WnQSHmMq8QBvZpdsb1t2GuR2PZGF1IR Hckg== X-Gm-Message-State: AOAM533Pjx55Smv7uYHIbj9sY5yji0p/Ysxxl3RCC22exZZrt7gOqLyW SPAQXsCFXygtCVv3Dts/tHy1BA== X-Google-Smtp-Source: ABdhPJx+uxbkSaPe2+0BH9EheOMTgYzUOtVzJymppogmrFVLTMjQ1PWdb8ch86SegBtXfRZtKHInSQ== X-Received: by 2002:a17:902:cf0f:b0:15a:24e0:d9b0 with SMTP id i15-20020a170902cf0f00b0015a24e0d9b0mr19745380plg.42.1650920833478; Mon, 25 Apr 2022 14:07:13 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:b820:7f63:f3dd:3da]) by smtp.gmail.com with ESMTPSA id b20-20020a62a114000000b0050d231e08ffsm8523202pff.37.2022.04.25.14.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 14:07:13 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Vinod Koul , Rob Herring , Dmitry Baryshkov , Rob Clark Subject: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings Date: Mon, 25 Apr 2022 14:06:42 -0700 Message-Id: <20220425140619.1.Ibfde5a26a7182c4b478d570c23d2649823ac2cce@changeid> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220425210643.2420919-1-dianders@chromium.org> References: <20220425210643.2420919-1-dianders@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, Sankeerth Billakanti , Douglas Anderson , David Airlie , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , Sean Paul , Krzysztof Kozlowski , linux-phy@lists.infradead.org, Stephen Boyd , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description. Signed-off-by: Douglas Anderson Reviewed-by: Sankeerth Billakanti --- .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,6 +76,9 @@ properties: "#sound-dai-cells": const: 0 + vdda-0p9-supply: true + vdda-1p2-supply: true + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -137,6 +140,9 @@ examples: power-domains = <&rpmhpd SC7180_CX>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + ports { #address-cells = <1>; #size-cells = <0>; From patchwork Mon Apr 25 21:06:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12826265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45270C433EF for ; Mon, 25 Apr 2022 21:07:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4F4F10E22F; Mon, 25 Apr 2022 21:07:17 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E6C5B10E22F for ; Mon, 25 Apr 2022 21:07:15 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id c12so28323496plr.6 for ; Mon, 25 Apr 2022 14:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYD/F2OSbA7Q4eCV40OrtxHiQtAfyrFTFEIn6t3W6f8=; b=WvFR64qpnd4yCLm8ubU/W/DeKgWVe5sf1D05fbZmkSyTq8yGSG6v5hnDff1XSYazp6 83XXw1NiHbANd+TaAV+ZBDA2iYhNtL67l2+aocpmUGDCinB5/oxcsmHaIHzPCmL0lSdx g5TTDnxbPbEk7GACTTB9R3BKu9hJsSL5XH2GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYD/F2OSbA7Q4eCV40OrtxHiQtAfyrFTFEIn6t3W6f8=; b=dacypHosqDleAzPuy0KcoCPhmMnrWJI8B0jrjiC3as0P55UHwJuIbyCghaNgMhgsUU 7FlXIl3AL13MSi3g35IOtXtfhEU00c1mO9JHOiIFzotkaw4JSlD8H0xBn0DF2wNX5Xmk rXwuWcEAqiM6Oqc5zDwj0hndEP+9JEZ9UQ6qNNk/FeqyeasPvNw3yCjUHgDah0S+v/qK nDnFu/S7r5TYUl4+3o35yD82M0HbR2uySMd3bt5c0XskVn4iIybggMXOp40iqgDxG12P 0EDEmSMLgfBHJw9OmyeRHbDv5wdNpZ7Ec3Yp4lCNDpOZvlbvUoexdQ7I0XdJgZjCFznk hNJQ== X-Gm-Message-State: AOAM533LMnREqdFmqQcBapGW/wPQl9ilsGyhVAJj43Nd/5Za7mv+wTdl M8B8B9h4eAL0gEtIPhuIv4a87g== X-Google-Smtp-Source: ABdhPJyG9Xx7/t8cUKO2ub7bBhrSNggYmBrlKgygY827SF0gU8Mp7i0d+ErwAnNSiBQq7WdPpARN0w== X-Received: by 2002:a17:902:ed89:b0:15a:d3e:ada6 with SMTP id e9-20020a170902ed8900b0015a0d3eada6mr20094621plj.94.1650920835532; Mon, 25 Apr 2022 14:07:15 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:b820:7f63:f3dd:3da]) by smtp.gmail.com with ESMTPSA id b20-20020a62a114000000b0050d231e08ffsm8523202pff.37.2022.04.25.14.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 14:07:15 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Vinod Koul , Rob Herring , Dmitry Baryshkov , Rob Clark Subject: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Date: Mon, 25 Apr 2022 14:06:43 -0700 Message-Id: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220425210643.2420919-1-dianders@chromium.org> References: <20220425210643.2420919-1-dianders@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, Sankeerth Billakanti , Douglas Anderson , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , Andy Gross , Krzysztof Kozlowski , linux-phy@lists.infradead.org, Stephen Boyd , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here. Signed-off-by: Douglas Anderson Reviewed-by: Sankeerth Billakanti --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index a5850ff529f8..cf9e9b8011cb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -41,6 +41,9 @@ properties: "#phy-cells": const: 0 + vdda-phy-supply: true + vdda-pll-supply: true + required: - compatible - reg @@ -65,5 +68,8 @@ examples: #clock-cells = <1>; #phy-cells = <0>; + + vdda-phy-supply = <&vdd_a_edp_0_1p2>; + vdda-pll-supply = <&vdd_a_edp_0_0p9>; }; ...