From patchwork Wed Apr 27 09:49:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B244AC433EF for ; Wed, 27 Apr 2022 09:50:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314680.532861 (Exim 4.92) (envelope-from ) id 1njeJ2-00089D-UR; Wed, 27 Apr 2022 09:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314680.532861; Wed, 27 Apr 2022 09:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ2-00088U-Qr; Wed, 27 Apr 2022 09:49:56 +0000 Received: by outflank-mailman (input) for mailman id 314680; Wed, 27 Apr 2022 09:49:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ1-00085x-Vs for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 64240b9e-c60f-11ec-a405-831a346695d4; Wed, 27 Apr 2022 11:49:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F56414BF; Wed, 27 Apr 2022 02:49:54 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 084053F774; Wed, 27 Apr 2022 02:49:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64240b9e-c60f-11ec-a405-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/8] xen/arm: bootfdt.c: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:34 +0200 Message-Id: <20220427094941.291554-2-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function device_tree_node_compatible defines and sets a variable mlen but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Julien Grall --- xen/arch/arm/bootfdt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index e318ef9603..29671c8df0 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -36,11 +36,8 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, const char *match) { int len, l; - int mlen; const void *prop; - mlen = strlen(match); - prop = fdt_getprop(fdt, node, "compatible", &len); if ( prop == NULL ) return false; From patchwork Wed Apr 27 09:49:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828522 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F251EC4332F for ; Wed, 27 Apr 2022 09:50:12 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314681.532879 (Exim 4.92) (envelope-from ) id 1njeJ5-0000Av-61; Wed, 27 Apr 2022 09:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314681.532879; Wed, 27 Apr 2022 09:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ5-0000Ai-22; Wed, 27 Apr 2022 09:49:59 +0000 Received: by outflank-mailman (input) for mailman id 314681; Wed, 27 Apr 2022 09:49:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ3-0008Li-MM for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 64f5fa1a-c60f-11ec-8fc2-03012f2f19d4; Wed, 27 Apr 2022 11:49:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B5F7A1480; Wed, 27 Apr 2022 02:49:55 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEFA23F774; Wed, 27 Apr 2022 02:49:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64f5fa1a-c60f-11ec-8fc2-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH 2/8] efi/boot.c: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:35 +0200 Message-Id: <20220427094941.291554-3-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function efi_start defines and sets a variable size but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich --- xen/common/efi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index ac1b235372..a25e1d29f1 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1226,9 +1226,9 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) { EFI_FILE_HANDLE dir_handle; EFI_HANDLE gop_handle; - UINTN depth, cols, rows, size; + UINTN depth, cols, rows; - size = cols = rows = depth = 0; + cols = rows = depth = 0; if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode, &cols, &rows) == EFI_SUCCESS ) From patchwork Wed Apr 27 09:49:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41533C433F5 for ; Wed, 27 Apr 2022 09:50:12 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314682.532890 (Exim 4.92) (envelope-from ) id 1njeJ7-0000X5-Ek; Wed, 27 Apr 2022 09:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314682.532890; Wed, 27 Apr 2022 09:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ7-0000Wc-B6; Wed, 27 Apr 2022 09:50:01 +0000 Received: by outflank-mailman (input) for mailman id 314682; Wed, 27 Apr 2022 09:49:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ5-0008Li-Eh for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6648801b-c60f-11ec-8fc2-03012f2f19d4; Wed, 27 Apr 2022 11:49:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 187241480; Wed, 27 Apr 2022 02:49:58 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23F0F3F774; Wed, 27 Apr 2022 02:49:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6648801b-c60f-11ec-8fc2-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 3/8] gnttab: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:36 +0200 Message-Id: <20220427094941.291554-4-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function unmap_common_complete defines and sets a variable ld that is later on passed to a macro gnttab_host_mapping_get_page_type. On arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable is enabled). Fix this by removing ld and directly passing current->domain to gnttab_host_mapping_get_page_type. Signed-off-by: Michal Orzel --- xen/common/grant_table.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index febbe12eab..71b1107999 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1556,7 +1556,7 @@ unmap_common( static void unmap_common_complete(struct gnttab_unmap_common *op) { - struct domain *ld, *rd = op->rd; + struct domain *rd = op->rd; struct grant_table *rgt; struct active_grant_entry *act; grant_entry_header_t *sha; @@ -1569,8 +1569,6 @@ unmap_common_complete(struct gnttab_unmap_common *op) return; } - ld = current->domain; - rcu_lock_domain(rd); rgt = rd->grant_table; @@ -1608,7 +1606,7 @@ unmap_common_complete(struct gnttab_unmap_common *op) if ( pg ) { if ( gnttab_host_mapping_get_page_type(op->done & GNTMAP_readonly, - ld, rd) ) + current->domain, rd) ) put_page_type(pg); put_page(pg); } From patchwork Wed Apr 27 09:49:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DCB7C43217 for ; Wed, 27 Apr 2022 09:50:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314683.532895 (Exim 4.92) (envelope-from ) id 1njeJ7-0000b1-Sq; Wed, 27 Apr 2022 09:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314683.532895; Wed, 27 Apr 2022 09:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ7-0000aH-LZ; Wed, 27 Apr 2022 09:50:01 +0000 Received: by outflank-mailman (input) for mailman id 314683; Wed, 27 Apr 2022 09:50:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ7-0008Li-4C for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 67496221-c60f-11ec-8fc2-03012f2f19d4; Wed, 27 Apr 2022 11:50:00 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6BB01480; Wed, 27 Apr 2022 02:49:59 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73CDB3F774; Wed, 27 Apr 2022 02:49:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67496221-c60f-11ec-8fc2-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 4/8] xen/arm: smmu.c: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:37 +0200 Message-Id: <20220427094941.291554-5-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function arm_smmu_init_context_bank defines and sets a variable gr0_base but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Acked-by: Julien Grall --- xen/drivers/passthrough/arm/smmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 5cacb2dd99..c21c4f3ac0 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -1086,10 +1086,9 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) bool stage1; struct arm_smmu_cfg *cfg = &smmu_domain->cfg; struct arm_smmu_device *smmu = smmu_domain->smmu; - void __iomem *cb_base, *gr0_base, *gr1_base; + void __iomem *cb_base, *gr1_base; paddr_t p2maddr; - gr0_base = ARM_SMMU_GR0(smmu); gr1_base = ARM_SMMU_GR1(smmu); stage1 = cfg->cbar != CBAR_TYPE_S2_TRANS; cb_base = ARM_SMMU_CB_BASE(smmu) + ARM_SMMU_CB(smmu, cfg->cbndx); From patchwork Wed Apr 27 09:49:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C5ABC433EF for ; Wed, 27 Apr 2022 09:50:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314684.532911 (Exim 4.92) (envelope-from ) id 1njeJA-0001Ib-52; Wed, 27 Apr 2022 09:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314684.532911; Wed, 27 Apr 2022 09:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ9-0001IA-W4; Wed, 27 Apr 2022 09:50:03 +0000 Received: by outflank-mailman (input) for mailman id 314684; Wed, 27 Apr 2022 09:50:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ8-00085x-Ps for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 683cf94c-c60f-11ec-a405-831a346695d4; Wed, 27 Apr 2022 11:50:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E6EA14BF; Wed, 27 Apr 2022 02:50:01 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 525183F774; Wed, 27 Apr 2022 02:50:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 683cf94c-c60f-11ec-a405-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli Subject: [PATCH 5/8] xen/sched: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:38 +0200 Message-Id: <20220427094941.291554-6-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function schedule_cpu_add defines and sets a variable old_unit but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Dario Faggioli --- xen/common/sched/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..8a8c25bbda 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3104,7 +3104,7 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c) { const cpumask_t *mask; unsigned int cpu_iter, idx = 0; - struct sched_unit *old_unit, *master_unit; + struct sched_unit *master_unit; struct sched_resource *sr_old; /* @@ -3128,7 +3128,6 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c) if ( cpu == cpu_iter ) continue; - old_unit = idle_vcpu[cpu_iter]->sched_unit; sr_old = get_sched_res(cpu_iter); kill_timer(&sr_old->s_timer); idle_vcpu[cpu_iter]->sched_unit = master_unit; From patchwork Wed Apr 27 09:49:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828526 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 025A6C433F5 for ; Wed, 27 Apr 2022 09:50:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314686.532923 (Exim 4.92) (envelope-from ) id 1njeJC-0001qA-Fa; Wed, 27 Apr 2022 09:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314686.532923; Wed, 27 Apr 2022 09:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJC-0001pU-AS; Wed, 27 Apr 2022 09:50:06 +0000 Received: by outflank-mailman (input) for mailman id 314686; Wed, 27 Apr 2022 09:50:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJA-0008Li-MV for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 695eb213-c60f-11ec-8fc2-03012f2f19d4; Wed, 27 Apr 2022 11:50:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54D7014BF; Wed, 27 Apr 2022 02:50:03 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C278B3F774; Wed, 27 Apr 2022 02:50:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 695eb213-c60f-11ec-8fc2-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 6/8] platforms/xgene: Make use of dt_device_get_address return value Date: Wed, 27 Apr 2022 11:49:39 +0200 Message-Id: <20220427094941.291554-7-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Currently function xgene_check_pirq_eoi assignes a return value of dt_device_get_address to a variable res but does not make use of it. Fix it by making use of res in a condition checking the result of a call to dt_device_get_address instead of checking the address stored in dbase. Signed-off-by: Michal Orzel Reviewed-by: Julien Grall --- xen/arch/arm/platforms/xgene-storm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index fced4d7c2c..befd0c3c2d 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void) panic("%s: Can not find interrupt controller node\n", __func__); res = dt_device_get_address(node, 0, &dbase, NULL); - if ( !dbase ) + if ( res ) panic("%s: Cannot find a valid address for the distributor\n", __func__); /* From patchwork Wed Apr 27 09:49:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828527 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 963ADC433FE for ; Wed, 27 Apr 2022 09:50:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314687.532934 (Exim 4.92) (envelope-from ) id 1njeJE-0002OO-VA; Wed, 27 Apr 2022 09:50:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314687.532934; Wed, 27 Apr 2022 09:50:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJE-0002Nw-OE; Wed, 27 Apr 2022 09:50:08 +0000 Received: by outflank-mailman (input) for mailman id 314687; Wed, 27 Apr 2022 09:50:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJC-00085x-Og for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:06 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6aa984d6-c60f-11ec-a405-831a346695d4; Wed, 27 Apr 2022 11:50:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 754AF1480; Wed, 27 Apr 2022 02:50:05 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC4BC3F7D8; Wed, 27 Apr 2022 02:50:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aa984d6-c60f-11ec-a405-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 7/8] platforms/omap: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:40 +0200 Message-Id: <20220427094941.291554-8-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function omap5_init_time defines and sets a variable den but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Julien Grall --- xen/arch/arm/platforms/omap5.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/platforms/omap5.c b/xen/arch/arm/platforms/omap5.c index aee24e4d28..5cf424a23e 100644 --- a/xen/arch/arm/platforms/omap5.c +++ b/xen/arch/arm/platforms/omap5.c @@ -48,7 +48,7 @@ static int omap5_init_time(void) void __iomem *ckgen_prm_base; void __iomem *rt_ct_base; unsigned int sys_clksel; - unsigned int num, den, frac1, frac2; + unsigned int num, frac1, frac2; ckgen_prm_base = ioremap_nocache(OMAP5_CKGEN_PRM_BASE, 0x20); if ( !ckgen_prm_base ) @@ -78,7 +78,6 @@ static int omap5_init_time(void) } frac2 = readl(rt_ct_base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET); - den = frac2 & ~NUMERATOR_DENUMERATOR_MASK; if ( num_den[sys_clksel][1] != num ) { frac2 &= NUMERATOR_DENUMERATOR_MASK; From patchwork Wed Apr 27 09:49:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828528 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62DF6C433F5 for ; Wed, 27 Apr 2022 09:50:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314690.532944 (Exim 4.92) (envelope-from ) id 1njeJG-0002kH-Hg; Wed, 27 Apr 2022 09:50:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314690.532944; Wed, 27 Apr 2022 09:50:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJG-0002jB-9W; Wed, 27 Apr 2022 09:50:10 +0000 Received: by outflank-mailman (input) for mailman id 314690; Wed, 27 Apr 2022 09:50:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJE-00085x-P7 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6bd0b73f-c60f-11ec-a405-831a346695d4; Wed, 27 Apr 2022 11:50:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6924C14BF; Wed, 27 Apr 2022 02:50:07 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D14C63F774; Wed, 27 Apr 2022 02:50:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bd0b73f-c60f-11ec-a405-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:41 +0200 Message-Id: <20220427094941.291554-9-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function exynos4210_uart_init_preirq defines and sets a variable divisor but does not make use of it. Remove the definition and comment out the assignment as this function already has some TODOs. Signed-off-by: Michal Orzel Acked-by: Julien Grall --- Commenting out a code is a bad practise as well as using TODOs. However the only alternative would be to get rid of divisor variable and TODO comments. I'm open for solutions. --- xen/drivers/char/exynos4210-uart.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c index fa7dbc0391..43aaf02e18 100644 --- a/xen/drivers/char/exynos4210-uart.c +++ b/xen/drivers/char/exynos4210-uart.c @@ -101,7 +101,6 @@ static void exynos4210_uart_interrupt(int irq, void *data, struct cpu_user_regs static void __init exynos4210_uart_init_preirq(struct serial_port *port) { struct exynos4210_uart *uart = port->uart; - unsigned int divisor; uint32_t ulcon; /* reset, TX/RX disables */ @@ -113,9 +112,12 @@ static void __init exynos4210_uart_init_preirq(struct serial_port *port) /* Line control and baud-rate generator. */ if ( uart->baud != BAUD_AUTO ) { - /* Baud rate specified: program it into the divisor latch. */ - divisor = ((uart->clock_hz) / (uart->baud)) - 1; - /* FIXME: will use a hacked divisor, assuming the src clock and bauds */ + /* + * TODO: should be updated + * Baud rate specified: program it into the divisor latch. + * divisor = ((uart->clock_hz) / (uart->baud)) - 1; + * FIXME: will use a hacked divisor, assuming the src clock and bauds. + */ exynos4210_write(uart, UFRACVAL, 53); exynos4210_write(uart, UBRDIV, 4); }