From patchwork Mon May 2 08:24:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 12833944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B5EC433EF for ; Mon, 2 May 2022 08:24:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D32910FBFD; Mon, 2 May 2022 08:24:24 +0000 (UTC) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16E6010FBFD for ; Mon, 2 May 2022 08:24:23 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id s27so17550657ljd.2 for ; Mon, 02 May 2022 01:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7s59/Q17Za6lJHQStBvDJic0/FOMAAkP8fNiF1n5RU=; b=rKwwxI4qcnZjlYF1CIXizaLM0mRyTT3aNe6ZMZpubtf31o5Lel5CdUNlQiobr/uitA QmhE9hlCPMEjiK3yvipxDRQsv/E8qT20nIg24rLZaSLWyKoJGuaNSFwPkNN5l0+Dcm9h lo+joRO6K/bFoqVxa7+RyQaWzb3LY6f4jX/n9elPRxJpLu6uI5xbb746n1ASEEi/l4Kz DUdq8Wl3MWpsGn5yenuNdBRhUARySy/2NqaS9g7viu3cxujCFPI7BuND0s4Ax1Vgzy9Q sZpxNOqesqOt21ER+EdFaQL9grOoptsjXrU7ZI96SRcD6P6zUFK+HewGJVYk31B8p4nh e53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7s59/Q17Za6lJHQStBvDJic0/FOMAAkP8fNiF1n5RU=; b=jlAFNQPvoTvGM/tj2d8ixKJSlQEFW/VoHku+yvkm8tIup+MQqN6hv7z/JP7WyawGqG jZaR1C7cBsvzEzfie1vF6UU/Xgxg5F4YMjAhrO7qGPMFEIQS8Y36dmSyH7brXtONd1SD nTXRqJP1MksiFt1kRTViR7c500+QwDpd82SIhAYgiKaUXRlipumE+kEmfWQiv/ulmauZ 4u15otEbjayqK8TzIRoRydoK89Cn1AOD6wo/m2V7g1Un3Sm5PhCRzC5GfB065wvVN+nV ZXYmGX1iOesl+bPSSnILYkqoJwLkI33QnTXOJlkBhAwS52ItjNC73I7QRApNDa5UJQ4i qioA== X-Gm-Message-State: AOAM530kGcRgU5hSvuBTJGlmSioI2D7+4934GQYD2DgYu84V0+JVGRdi ixf/21XNpiP0/iZBGWq+2PuxzA== X-Google-Smtp-Source: ABdhPJzCKDUJ9dajLmL2juVoQAnLpONDDplg6cI7LPzhbPdaUY7FmF9Lu77YXD0cgh7lE49BERTIBg== X-Received: by 2002:a2e:8657:0:b0:24f:14b6:4556 with SMTP id i23-20020a2e8657000000b0024f14b64556mr6931890ljj.369.1651479861379; Mon, 02 May 2022 01:24:21 -0700 (PDT) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id z22-20020ac25df6000000b0047255d21166sm643562lfq.149.2022.05.02.01.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 01:24:21 -0700 (PDT) From: Dmitry Baryshkov To: Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH] drm/msm/dpu: don't access mode pointer before it is set Date: Mon, 2 May 2022 11:24:20 +0300 Message-Id: <20220502082420.48409-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Move the initializer for the mode variable to the declaration point to remove unitialized variable access from the DEBUG_DPU macro. This fixes the following warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:250:37: note: initialize the variable 'mode' to silence this warning Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c index f4a79715a02e..4829d1ce0cf8 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c @@ -247,7 +247,7 @@ static int dpu_encoder_phys_wb_atomic_check( struct drm_connector_state *conn_state) { struct drm_framebuffer *fb; - const struct drm_display_mode *mode; + const struct drm_display_mode *mode = &crtc_state->mode; DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n", phys_enc->wb_idx, mode->name, mode->hdisplay, mode->vdisplay); @@ -256,7 +256,6 @@ static int dpu_encoder_phys_wb_atomic_check( return 0; fb = conn_state->writeback_job->fb; - mode = &crtc_state->mode; if (!conn_state || !conn_state->connector) { DPU_ERROR("invalid connector state\n");