From patchwork Tue May 3 06:15:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas De Marchi X-Patchwork-Id: 12835042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E384C433FE for ; Tue, 3 May 2022 06:15:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2782B10FE01; Tue, 3 May 2022 06:15:55 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C7F210FE00; Tue, 3 May 2022 06:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651558554; x=1683094554; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CpgxHoasoCjAahnwUEYAJ3jYQqTT6BFB3I4HnxPt7kM=; b=lcsjcZ3KH/jND8Q1zO5ewBKVqiK+h7MXI2iTWLS06BB1jFq/SYEx8bnX EVzQ9aJFjBtUO3FzRytVXF/yz4eJa3sC1L6uHNo5ZmRA/CIIcqpeR/ovF tPU7HA9xBxfrswqADlpPpI14+eIJtWw89m/qFhDGmAlwMsHBJTtun+ElL 2K+ICz2D6Tz26yImnpnyDnp+2qjSdADk9dyTcrDg6WrmQEAfmBiuwMK6S 73YlbfBZAtDgOpHVKvFXYSGe7GQWvRtCfcwv45S/e76VlLOkm1T3fjzpb WKj6Ax1X0oKX4/9bT75hu5NP6xKu3ygdEOaj5rmXBgslTiNIl75lyzapv g==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="267283119" X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="267283119" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 23:15:53 -0700 X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="653143918" Received: from lucas-s2600cw.jf.intel.com ([10.165.21.202]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 23:15:53 -0700 From: Lucas De Marchi To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/i915/gem: Make drop_pages() return bool Date: Mon, 2 May 2022 23:15:56 -0700 Message-Id: <20220503061556.513175-1-lucas.demarchi@intel.com> X-Mailer: git-send-email 2.36.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi , Niranjana Vishwanathapura Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Commit e4e806253003 ("drm/i915: Change shrink ordering to use locking around unbinding.") changed the return type to int without changing the return values or their meaning to "0 is success". Move it back to boolean. Signed-off-by: Lucas De Marchi Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c index 6a6ff98a8746..1030053571a2 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c @@ -36,7 +36,7 @@ static bool can_release_pages(struct drm_i915_gem_object *obj) return swap_available() || obj->mm.madv == I915_MADV_DONTNEED; } -static int drop_pages(struct drm_i915_gem_object *obj, +static bool drop_pages(struct drm_i915_gem_object *obj, unsigned long shrink, bool trylock_vm) { unsigned long flags;