From patchwork Thu May 5 10:36:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12839371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 310CAC433EF for ; Thu, 5 May 2022 10:36:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.321939.543107 (Exim 4.92) (envelope-from ) id 1nmYqH-0002mw-JH; Thu, 05 May 2022 10:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321939.543107; Thu, 05 May 2022 10:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqH-0002mp-GI; Thu, 05 May 2022 10:36:17 +0000 Received: by outflank-mailman (input) for mailman id 321939; Thu, 05 May 2022 10:36:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqF-0002XJ-VW for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:36:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 305beeb0-cc5f-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 12:36:15 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582B014BF; Thu, 5 May 2022 03:36:14 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE25A3FA27; Thu, 5 May 2022 03:36:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 305beeb0-cc5f-11ec-8fc4-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Date: Thu, 5 May 2022 12:36:00 +0200 Message-Id: <20220505103601.322110-2-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505103601.322110-1-michal.orzel@arm.com> References: <20220505103601.322110-1-michal.orzel@arm.com> MIME-Version: 1.0 Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable is enabled). Fix it by converting this macro to a static inline helper and using the boolean return type. While there, also convert macro gnttab_release_host_mappings. Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich --- xen/arch/arm/include/asm/grant_table.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index d31a4d6805..779f6fbdbb 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) #endif } +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, + struct domain *rd) +{ + return false; +} + +static inline bool gnttab_release_host_mappings(struct domain *d) +{ + return true; +} + int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned int flags, unsigned int cache_flags); -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned long new_gpaddr, unsigned int flags); -#define gnttab_release_host_mappings(domain) 1 /* * The region used by Xen on the memory will never be mapped in DOM0 From patchwork Thu May 5 10:36:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12839370 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07C93C433FE for ; Thu, 5 May 2022 10:36:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.321940.543118 (Exim 4.92) (envelope-from ) id 1nmYqI-00032Z-TW; Thu, 05 May 2022 10:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321940.543118; Thu, 05 May 2022 10:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqI-00032S-Pi; Thu, 05 May 2022 10:36:18 +0000 Received: by outflank-mailman (input) for mailman id 321940; Thu, 05 May 2022 10:36:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqH-0002XD-TD for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:36:18 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 317a602c-cc5f-11ec-a406-831a346695d4; Thu, 05 May 2022 12:36:16 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3214D1516; Thu, 5 May 2022 03:36:16 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF5A93FA27; Thu, 5 May 2022 03:36:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 317a602c-cc5f-11ec-a406-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Date: Thu, 5 May 2022 12:36:01 +0200 Message-Id: <20220505103601.322110-3-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505103601.322110-1-michal.orzel@arm.com> References: <20220505103601.322110-1-michal.orzel@arm.com> MIME-Version: 1.0 Modify macros to evaluate all the arguments and make sure the arguments are evaluated only once. While doing so, use typeof for basic types and use const qualifier when applicable. Signed-off-by: Michal Orzel --- xen/arch/arm/include/asm/grant_table.h | 67 ++++++++++++++++++-------- 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index 779f6fbdbb..b161d4baf1 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -57,38 +57,44 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, #define gnttab_init_arch(gt) \ ({ \ - unsigned int ngf_ = (gt)->max_grant_frames; \ + struct grant_table *gt_ = (gt); \ + unsigned int ngf_ = gt_->max_grant_frames; \ unsigned int nsf_ = grant_to_status_frames(ngf_); \ \ - (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ - (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ - if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ + gt_->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ + gt_->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ + if ( gt_->arch.shared_gfn && gt_->arch.status_gfn ) \ { \ while ( ngf_-- ) \ - (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ + gt_->arch.shared_gfn[ngf_] = INVALID_GFN; \ while ( nsf_-- ) \ - (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ + gt_->arch.status_gfn[nsf_] = INVALID_GFN; \ } \ else \ - gnttab_destroy_arch(gt); \ - (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ + gnttab_destroy_arch(gt_); \ + gt_->arch.shared_gfn ? 0 : -ENOMEM; \ }) #define gnttab_destroy_arch(gt) \ do { \ - XFREE((gt)->arch.shared_gfn); \ - XFREE((gt)->arch.status_gfn); \ + struct grant_table *gt_ = (gt); \ + XFREE(gt_->arch.shared_gfn); \ + XFREE(gt_->arch.status_gfn); \ } while ( 0 ) #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ ({ \ int rc_ = 0; \ - gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx); \ - if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) || \ - (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn, \ + const struct grant_table *gt_ = (gt); \ + const typeof(st) st_ = (st); \ + const typeof(idx) idx_ = (idx); \ + const gfn_t gfn_ = (gfn); \ + const gfn_t ogfn_ = gnttab_get_frame_gfn(gt_, st_, idx_); \ + if ( gfn_eq(ogfn_, INVALID_GFN) || gfn_eq(ogfn_, gfn_) || \ + (rc_ = guest_physmap_remove_page(gt_->domain, ogfn_, mfn, \ 0)) == 0 ) \ - ((st) ? (gt)->arch.status_gfn \ - : (gt)->arch.shared_gfn)[idx] = (gfn); \ + (st_ ? gt_->arch.status_gfn \ + : gt_->arch.shared_gfn)[idx_] = gfn_; \ rc_; \ }) @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, }) #define gnttab_shared_gfn(d, t, i) \ - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + ({ \ + const struct domain *d_ = (d); \ + const struct grant_table *t_ = (t); \ + const typeof(i) i_ = (i); \ + \ + if ( d_ != NULL ) \ + ASSERT(d_->grant_table == t_); \ + \ + (i_ >= nr_grant_frames(t_)) ? INVALID_GFN \ + : t_->arch.shared_gfn[i_]; \ + }) #define gnttab_status_gfn(d, t, i) \ - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + ({ \ + const struct domain *d_ = (d); \ + const struct grant_table *t_ = (t); \ + const typeof(i) i_ = (i); \ + \ + if ( d_ != NULL ) \ + ASSERT(d_->grant_table == t_); \ + \ + (i_ >= nr_status_frames(t_)) ? INVALID_GFN \ + : t_->arch.status_gfn[i_]; \ + }) -#define gnttab_need_iommu_mapping(d) \ - (is_domain_direct_mapped(d) && is_iommu_enabled(d)) +#define gnttab_need_iommu_mapping(d) \ + ({ \ + const struct domain *d_ = (d); \ + is_domain_direct_mapped(d_) && is_iommu_enabled(d_); \ + }) #endif /* __ASM_GRANT_TABLE_H__ */ /*