From patchwork Wed Jan 9 09:06:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Wang X-Patchwork-Id: 10753671 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A00413BF for ; Wed, 9 Jan 2019 09:07:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 209E528B8A for ; Wed, 9 Jan 2019 09:07:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 125F528F8E; Wed, 9 Jan 2019 09:07:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SUBJ_OBFU_PUNCT_FEW autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D257628B8A for ; Wed, 9 Jan 2019 09:07:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53A08E009D; Wed, 9 Jan 2019 04:07:29 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B01BB8E0038; Wed, 9 Jan 2019 04:07:29 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F30C8E009D; Wed, 9 Jan 2019 04:07:29 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 59D2A8E0038 for ; Wed, 9 Jan 2019 04:07:29 -0500 (EST) Received: by mail-pf1-f199.google.com with SMTP id p9so4818365pfj.3 for ; Wed, 09 Jan 2019 01:07:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; bh=GpjQ2KuVGeLWDMlEkWDph2LxNSO1M1yCZqMlnLB5rUw=; b=QrkCg0hs80TdE2R/dRf8XWPptNkSIzr/GnAWp8HWVkz+IpqD8UAlQdrsi8QKfvdUz0 Pl2qVoHrbdK0r1QLARLCh/LO5jx0QQX7xQXo3uUTeg0gbnMUfKsv5vvwyseRUGfEuCAG 87b+OcGaLueXmmoKUImYtvOvlPn8sbt2ftBjioepjlaIZKX+EqiGD6XjD7MU3d+PkKkF DCMzOA96HJrhVYXMKsRSMJCaT+mQH5bkbLV0TeBD+SRd3oS7SLV/MaOG3F5O/C8Xp6ht rORMb55x1YCn2RB1y4cCi0jL0i+6J8fscrdchaNX45SraC4R67k7CSSS3WLO1Ieniz9L iyow== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of rocking@whu.edu.cn designates 159.89.151.119 as permitted sender) smtp.mailfrom=rocking@whu.edu.cn X-Gm-Message-State: AJcUukf+7KHbyF5kEykRPLvm6xJsJk6WJiNNESkH+8UFNeXjsjbz3mPI feDyTkq6mwMuED15XPbGSMWuPQJ4+1rDQUQBrnM3QdM04CemLEsAaLXj4tZ0QGEwjw+2N8nc0II AIfKeevgxBmyt460jweD0/xeHoMzqIXhBkQec9reOYHlFU0rhYgtTjP727K4sMMkKUA== X-Received: by 2002:a62:8add:: with SMTP id o90mr5107620pfk.210.1547024849018; Wed, 09 Jan 2019 01:07:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN6TBer48A09VmN5iJ5WCHKA9KPYoXbuKAHdM5VstAuI3hLmBf4hMDCEtc/U+CDJCKqweEkh X-Received: by 2002:a62:8add:: with SMTP id o90mr5107541pfk.210.1547024847780; Wed, 09 Jan 2019 01:07:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547024847; cv=none; d=google.com; s=arc-20160816; b=d5pU1bJoDem1mJuNSSbbfH1BNeDg3uKfVak4fgEahb9AMuzvO35aWeXBWDL5MA017X 6Xj7Sug3tedd8Ap4BbyjrswerAbUJlCZ5DWMZ8N/pvKu7o4pZpnJLWPedD5bsbccsu6B z+nscfItk82wfFdwu/cZDkwex5DeN0IRuvtHtSIAoOCBmQor7wqM6QclTf/C5AFnyNB3 v0f9LRx0kyPEHtMGtCcIns4DW8OaNRM/GixW2ZdcuMP5bIqbYxh0kqjTOANgmsc3A+I4 cv9jmT5QtDLO9Yf9VhL9VMiUC4nRTz3Fm8rawgtIJQmCaoR5jqPSrpXT6FXH7bXUq0Lz E2pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=GpjQ2KuVGeLWDMlEkWDph2LxNSO1M1yCZqMlnLB5rUw=; b=jSwYEbSKUd4+smceq9Bzqn/9zn8Q5SZO9bZERc3cKdIDZE1Y+kVzoyO3IjuvKvUy8s DBLw9IazPz0Ucnmn+tM1XL59NNl0p4oxewOHIQUok1r07UljW+T+MC5v6SeI3MbKRZ7c T8oFhOd6EHU8qClC852jQxmpzWUACG9rWh+gDcpsLu8KtEITdBiNSXFuRTgCliYrmSW4 F+ksZkRCdnL6vjdCdcJmCJ1UqnSp9h1rcuQm/TBelr7kVph0JpL6qx+5GUNzTNpv356Q sQYwAyTwghjfR5A+gLIOf3iV4hTPSMShu5yfT1xI8WY+MayA1Y8UVZu5QrzowsmC7O7f olTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of rocking@whu.edu.cn designates 159.89.151.119 as permitted sender) smtp.mailfrom=rocking@whu.edu.cn Received: from zg8tmtu5ljg5lje1ms4xmtka.icoremail.net (zg8tmtu5ljg5lje1ms4xmtka.icoremail.net. [159.89.151.119]) by mx.google.com with SMTP id 133si13017824pfw.64.2019.01.09.01.07.27 for ; Wed, 09 Jan 2019 01:07:27 -0800 (PST) Received-SPF: pass (google.com: domain of rocking@whu.edu.cn designates 159.89.151.119 as permitted sender) client-ip=159.89.151.119; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rocking@whu.edu.cn designates 159.89.151.119 as permitted sender) smtp.mailfrom=rocking@whu.edu.cn Received: from localhost (unknown [114.255.3.133]) by email1 (Coremail) with SMTP id AQBjCgDX3fnFuTVcpkUhCg--.7191S2; Wed, 09 Jan 2019 17:07:23 +0800 (CST) From: Peng Wang To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peng Wang Subject: [PATCH] mm/slub.c: re-randomize random_seq if necessary Date: Wed, 9 Jan 2019 17:06:27 +0800 Message-Id: <20190109090628.1695-1-rocking@whu.edu.cn> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CM-TRANSID: AQBjCgDX3fnFuTVcpkUhCg--.7191S2 X-Coremail-Antispam: 1UD129KBjvdXoW7XFW3JF4rtrykXrWxXrWrXwb_yoW3tFX_ua y0yFy5Ar48GF4qkFyUZr4rJFWfC397uFnruasFvay7Ja4DtrnIyryUW3ykuFWxuFyv9FW5 GFW7G397Aa4vgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GFWl 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUjMmh5UUUUU== X-CM-SenderInfo: qsqrijaqrviiqqxyq4lkxovvfxof0/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP calculate_sizes() could be called in several places like (red_zone/poison/order/store_user)_store() while random_seq remains unchanged. If random_seq is not NULL in calculate_sizes(), re-randomize it. Signed-off-by: Peng Wang --- mm/slub.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index 1e3d0ec4e200..2a9d18019545 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3583,6 +3583,15 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order) if (oo_objects(s->oo) > oo_objects(s->max)) s->max = s->oo; +#ifdef CONFIG_SLAB_FREELIST_RANDOM + if (unlikely(s->random_seq)) { + kfree(s->random_seq); + s->random_seq = NULL; + if (init_cache_random_seq(s)) + return 0; + } +#endif + return !!oo_objects(s->oo); }