From patchwork Wed May 11 05:27:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12845800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1D67C433F5 for ; Wed, 11 May 2022 05:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9AzHHf5iCMbdXelac8qRJp8gCrAUs297g+VGD1OvhgQ=; b=ydjnRna6CZOUCF Iv1JQ7LW9a050qRJKDHAQkmKHd+gJ9oH7f4D4/nyd1fcUeFnB+ZxwHLvWo2qtqzhFs3RuFwn7Yxdr Hd5/HFJo4GhU9KRa1XfROfRFhscccXAMJZPUFriKI+S7SaSy8UADlO+nIaw0IuzWXgUdDTJSgedXX VXngRG5kCI4D7G1KcVx0OJWMaDAUvqV4Ei7h7JPfYcit1VzzDj83EAcnwI7ZBfqPcmBHr+zpOhkik WTaGmD+PbWisKkVNyM7DKoPp4RAa1U53SAFp5ny33lxFdp+LdG4s3D6VTzk0jNk8qhrqf84o971aB 7ZTTai22LYIc8pZVhRQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noetA-005Gz5-VH; Wed, 11 May 2022 05:27:57 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noet8-005GyI-3C for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 05:27:55 +0000 Received: by mail-pl1-x629.google.com with SMTP id q18so803676pln.12 for ; Tue, 10 May 2022 22:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xhdm254L1jYhgvQgbJzDhHX/1k7BNUYa5TibU3+NCCw=; b=pZ7INeRKE7ikbL0Wp1J2nkeg5H+ixeNlVyt8PYCddh2qShvjPh+hek64IhQ72pjYiI 7emBeRFo+ZBiSd6HXcaXOmhC+lL3WiJqfw6jXaPXvYjcjTJk8+EAcrW7nBNknBW8MamG y3IM79TAD97U/nTxtEo9yvf5XYzIF4gzw+u7IgzhoT3ceHSuOUOwpuYMb/KzCmOlru5l 9aNHlqiUqt3TaR84XMjujDYI71Svp937IGTCm9Oiuv+bXoeSRUiGHWiNMlWtcPUtFmKD BYh9nNVtPT2zfyA8wsUHIo3lHKyxQV33wgLC9Voh85/bQ8qPt9QSI43AUrUeQuBnwwSu gbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xhdm254L1jYhgvQgbJzDhHX/1k7BNUYa5TibU3+NCCw=; b=S3cP3jy/y5H7ih2TJlu/Nop55m+LGoK1dyYXORTL3zEYr9OYX/L0lmNmc0IqELhIQA +M/m9zsCqxIM+nCq9VK654kW+LqfMc6xbahdReNC8+acXdxC7ysaTgTP3HtQ/HUNBzs8 ADvOSqCxBnDCNIeyPr6/4g/NOHdyzxe05XnU7SdWvbSP7UrtM/u578jBDY7hbLUec+78 sqpvWu6fSsQgcK5KFRiCoY+EmJ1lovNsWwLzmBiqY2BgwdYXRn0WilJ2Z9IGWaBzx2ml eN4qT0wXXG8m5Wpeo5ed06bEFkgbiMA0teoRrUQ0n5LCxbIJfuNI3zWr3TTQ5Jrf8YwZ H6tw== X-Gm-Message-State: AOAM531N6eUjNTMj1Dp8XJcY97CckXSQvmyBpG3mmy3vqqdhaD/YKsfr aSLQAXj5xhKvXSQfKPo3NCo= X-Google-Smtp-Source: ABdhPJxp27enUzauf894HfT9NP3kw4axhqglDt0NeLn5w5FytMmzOkolsl2i+qdZja+aIx6uEVmDBQ== X-Received: by 2002:a17:902:7fc2:b0:153:3c90:17b9 with SMTP id t2-20020a1709027fc200b001533c9017b9mr24081383plb.61.1652246872324; Tue, 10 May 2022 22:27:52 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id s12-20020a170902c64c00b0015e8d4eb2e6sm588632pls.304.2022.05.10.22.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 22:27:51 -0700 (PDT) From: Miaoqian Lin To: Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Ye Guojin , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ASoC: imx-hdmi: Fix refcount leak in imx_hdmi_probe Date: Wed, 11 May 2022 09:27:40 +0400 Message-Id: <20220511052740.46903-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_222754_192360_F21C1534 X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_device_by_node() takes reference, we should use put_device() to release it. when devm_kzalloc() fails, it doesn't have a put_device(), it will cause refcount leak. Add missing put_device() to fix this. Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver") Fixes: f670b274f7f6 ("ASoC: imx-hdmi: add put_device() after of_find_device_by_node()") Signed-off-by: Miaoqian Lin --- sound/soc/fsl/imx-hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c index 929f69b758af..ec149dc73938 100644 --- a/sound/soc/fsl/imx-hdmi.c +++ b/sound/soc/fsl/imx-hdmi.c @@ -126,6 +126,7 @@ static int imx_hdmi_probe(struct platform_device *pdev) data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) { ret = -ENOMEM; + put_device(&cpu_pdev->dev); goto fail; }