From patchwork Wed May 11 13:37:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12846204 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1286EC433F5 for ; Wed, 11 May 2022 13:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5lKRg5NKeXCdJQCp7fxYI0ksh3IRA0NmUGQo4dsw7c8=; b=IBgkgxONBBP881 ABeJPaEh6me25aEhq+UB5sjLq5S2qGSfaaumCJrzqI19hFLT0FSLc9/8mPNXfRRDBphYe7PRDISoX YMAVVtsG+VPf156exLytvVFSF5dBxRLgN7HZWqhba+pu165I2Z2StupoH5pyDlyxLUY+3VB5Y4Vq4 mE25tVHs6L5hrAFWn1m1h7bQRrZXKCNOaMsOhoS8oSJjqZIoBzZV4AK4pVB4AObCo54KAX9/MDoKF yzQpNXiHIMyqu+LXXkRY99l7seL0iqsvvx18AQWFaIbYUQx4p9VfkKKsySLsjg97POHjIUpIvuMox BEpSnmUDExosgNTs8XrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nomXG-0071Re-42; Wed, 11 May 2022 13:37:50 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nomX9-0071PT-RL for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 13:37:48 +0000 Received: by mail-pf1-x42f.google.com with SMTP id j6so1987419pfe.13 for ; Wed, 11 May 2022 06:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZddwKY35pUrh6R5AAj9OCEj0zF8sOKGHECLF2uLCy64=; b=jvnIeRP3G/HbVmLPD7w6dkgxT0piYIz88WFV06yyQu91PXBZ2cPblZHFShL3Kk7iJg SylzzqYDiMsmjkqyRYPPIMdPBTxPdba7UNRLnZb+aJD3siim0k+8zAK9bOcohRQ4fBnx C8/xCp0aqJpv2AiKulUVIAkeKPBFdYNmbOF4iI2ZN4GcGZHpbI6HqCqy9VQUWP5HGSuH S9Np3y3ao934wf7u5wpJIulciBzXm9tQDBDP8MX9lNrBy0cxldKW5lIXvmmMBsAPJe3T dUbZMZBqzCGCEAaGIdVcUu/l+xmzKkmYoOSJXh5Pk1V+frCY+JqgiDIQJCVJxC99LKl8 u85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZddwKY35pUrh6R5AAj9OCEj0zF8sOKGHECLF2uLCy64=; b=q19oDnddVQm1E7SZataQG6WpGITaDm3fTAdVUpKFNXGWMVoiSLFICYuoN/ORPed7To 3V8vqRqukz37BjKgntNFKj+Yo4k5txgz42jAlyjA49Zp3p7NKJxVMC39Pxzrtln7rrK1 mlMlYX4/+IOrGoNiLOV4I2pvGsJR6D9UvsGFr9/KbnkD366wTdnR2gWzY/LxXLyHQu5R FraiyYbWZ2UaZ+wW4i9TSgjSZZj80geoIEvXbyOA3jugoUx9JAv+x2PffCF12gLqS/g6 TZvsqVivfMFE+8mfX6zeWvyvalpODNdGkqlq7+eUUSm05JK9seo+bL8nkhlAqg6IKN0o DTNg== X-Gm-Message-State: AOAM531ylpM5ixAaEHhVyvDFFn/4ddQu5q9dF0+waGbPHWUQmNLKRrYn 7wTMddyfX9aNpAvWi/1CeZc= X-Google-Smtp-Source: ABdhPJxL4qPnoibT3RMP2XXaUwIm8HlwdKX4ysIXOXXWBN6ZnU+aVvmJ/CK4tHzv9bgNCDSgwTbrvg== X-Received: by 2002:aa7:83d0:0:b0:50c:eb2b:8e8a with SMTP id j16-20020aa783d0000000b0050ceb2b8e8amr25314048pfn.31.1652276260106; Wed, 11 May 2022 06:37:40 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id o16-20020a170902d4d000b0015e8d4eb299sm1971367plg.227.2022.05.11.06.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 06:37:39 -0700 (PDT) From: Miaoqian Lin To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miaoqian Lin , Jiasheng Jiang , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: mxs-saif: Fix refcount leak in mxs_saif_probe Date: Wed, 11 May 2022 17:37:22 +0400 Message-Id: <20220511133725.39039-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_063743_940124_3FECEDF3 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Fixes: 08641c7c74dd ("ASoC: mxs: add device tree support for mxs-saif") Signed-off-by: Miaoqian Lin --- sound/soc/mxs/mxs-saif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c index 879c1221a809..7afe1a1acc56 100644 --- a/sound/soc/mxs/mxs-saif.c +++ b/sound/soc/mxs/mxs-saif.c @@ -754,6 +754,7 @@ static int mxs_saif_probe(struct platform_device *pdev) saif->master_id = saif->id; } else { ret = of_alias_get_id(master, "saif"); + of_node_put(master); if (ret < 0) return ret; else