From patchwork Wed May 11 15:45:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 12846390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6261C433EF for ; Wed, 11 May 2022 15:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343880AbiEKPpq (ORCPT ); Wed, 11 May 2022 11:45:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbiEKPpn (ORCPT ); Wed, 11 May 2022 11:45:43 -0400 Received: from sender2-op-o12.zoho.com.cn (sender2-op-o12.zoho.com.cn [163.53.93.243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A878DF9 for ; Wed, 11 May 2022 08:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652283920; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=From:From:To:To:Cc:Cc:Message-ID:Subject:Subject:Date:Date:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=LzdE0Xwv07gu2x2Cq0B39Z1oDicPX3n0TmcRbU8cBIE=; b=CCEVn+wytJisn78PbRwNoQtitYDovt3Qk1JShF6Qle3+8+rguCxFhyoyUT18Jovw YFSZj+fkvHXFzNyY1RLIU7D/830yA3Jubx+rA0j07zvdKT0crbxBFKV/GCBzhn1LHOn 7qt+Tg+9nzDEWj4o5fXg8mUnzdI1dze+xcn/2NvU= Received: from sanma.. (113.88.133.138 [113.88.133.138]) by mx.zoho.com.cn with SMTPS id 1652283918530281.90610360329765; Wed, 11 May 2022 23:45:18 +0800 (CST) From: Chengguang Xu To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, Chengguang Xu Message-ID: <20220511154503.28365-1-cgxu519@mykernel.net> Subject: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range() Date: Wed, 11 May 2022 11:45:03 -0400 X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-ZohoCNMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Move fdput() to right place in ksys_sync_file_range() to avoid fdput() after failed fdget(). Signed-off-by: Chengguang Xu Signed-off-by: Al Viro Reviewed-by: Jens Axboe --- fs/sync.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/sync.c b/fs/sync.c index c7690016453e..b217d908bee8 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -360,10 +360,10 @@ int ksys_sync_file_range(int fd, loff_t offset, loff_t nbytes, ret = -EBADF; f = fdget(fd); - if (f.file) + if (f.file) { ret = sync_file_range(f.file, offset, nbytes, flags); - - fdput(f); + fdput(f); + } return ret; }