From patchwork Thu May 12 03:03:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12846896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48989C433EF for ; Thu, 12 May 2022 03:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LEd43z3iU6asZRAEiVO/49zY2jYYTqGZ6EoEa/giGUw=; b=Xx/FRfQrSvhHtq lbMqekdW0CX2O6JLpNTGfbb0doQSxWgE5AAPt97cJtpfsHhXM5VP43D4LVUd1Rj7fejj/M1VtkC2i iF7qBHziF1p02LmigPC0L2KS4PkF3aT7MQD4UpbC8CZN7+yMJgPDNI4rqPrLkULCgsCwePSeykq6Z NtmHZ1UTfsauuuqUWoywt+KfQH/KRs3rZ0qiH4JSEpcuvfR9lt+vNLmuyBfLOGn2dNbcD4oxJSEUK otzCLyEx2vkeRk0kRNZTIVOCrFlNu4eKyrj7GQThQa3decgdfXBc7jCUXQ1BbSa7cq0rI/EyffIwN QHrG9nokLXgQJ1Ac7olQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noz7F-009cSf-FJ; Thu, 12 May 2022 03:03:49 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noz7B-009cRy-LQ for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 03:03:46 +0000 Received: by mail-pj1-x102d.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so3706234pjm.1 for ; Wed, 11 May 2022 20:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q41Jr8VR5dY09mKNn7RY5RfYlHLETTBtn1k7thCkKuQ=; b=J/zsEQMuV3jeFz2ZNyP7VN5TA+LgtwO4M2U3fzh8HvTEAuUbQNRfq7QJ9DC12ZVfn4 I8TTZ5KkOAOZxahJkyBOlCo1U2T2zkc03IKM6xt3J77YxyPEaOL0Vwl7tKMlMRSXogCp d3ZluyhDUTx4//RZrGv0wFfOp3u4s0S7Tp33qk561OC64mhOSZrVZuRTeohjmV+qI7q6 hbYyzx3z2iWEhcgWfnAN+06TIfsNB6ORPz8rwURmywoHEKF+TpiZgsCgXzVCjHAbyBR4 d5yxPSkTuXmq4T+SQBxa7W0HtrS3sKh3kO9N0X7tRqggNj4gahwMG3eyaBdDKgGJFCD8 sBGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q41Jr8VR5dY09mKNn7RY5RfYlHLETTBtn1k7thCkKuQ=; b=kQSd/Q2f5yQtkgi0pJ5iFS2gUyd9g9okpqps01W2OECWdRdO0fGKRXqyjmq6rmyPLc qsNCKa07i6cSS0k6YRf6xfkdVmbungdFj4f5E3ZbGShiux9RSzecL8Wr9k89ixWd5ZsL CfEq/EJi3Czhjq9FnIPDFqAfAsgu/UFS1WzC5GgajvVwsdc/4pWtdz0fxxqQuf/Vuxti ZZNLV2xXnXDtyX8ep00ZdSxW1Xfr0eFhtcBIXO8+D68FhdUvOgQ1VrRNc6TsLddK+o0G N1/Uc3pbp5ssofauAmSKkKC8IA/uA4xAqpF83FhFWdhq08jzNHuIr17VTKwZmmXCI15u 9xkQ== X-Gm-Message-State: AOAM5322d6+QsY32Y/xLbGHMOKbArcAvvrurin7HtJsqr4ZSKNBe1FOC pdjwPbFIa9L4nka4x1YgyZ5UnIq8ukt8i6moFlg= X-Google-Smtp-Source: ABdhPJzMEbwjlTwN4njMLoFUKyG6CTBFqiX1Z2hsX7AHrrVgcWAFRUs76ym8HM2zKTrZihSX41SbVg== X-Received: by 2002:a17:90b:3901:b0:1dc:5a24:691 with SMTP id ob1-20020a17090b390100b001dc5a240691mr8562489pjb.40.1652324624077; Wed, 11 May 2022 20:03:44 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id 5-20020a17090a190500b001d77f392280sm640890pjg.30.2022.05.11.20.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 20:03:43 -0700 (PDT) From: Miaoqian Lin To: Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Russell King , Brendan Higgins , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] arm: npcm: Fix some refcount leaks Date: Thu, 12 May 2022 07:03:34 +0400 Message-Id: <20220512030334.52918-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_200345_741555_29790C07 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 7bffa14c9aed ("arm: npcm: add basic support for Nuvoton BMCs") Signed-off-by: Miaoqian Lin --- arch/arm/mach-npcm/platsmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-npcm/platsmp.c b/arch/arm/mach-npcm/platsmp.c index 21633c70fe7f..fe63edc9886d 100644 --- a/arch/arm/mach-npcm/platsmp.c +++ b/arch/arm/mach-npcm/platsmp.c @@ -35,6 +35,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu, goto out; } gcr_base = of_iomap(gcr_np, 0); + of_node_put(gcr_np); if (!gcr_base) { pr_err("could not iomap gcr"); ret = -ENOMEM; @@ -63,6 +64,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int max_cpus) return; } scu_base = of_iomap(scu_np, 0); + of_node_put(scu_np); if (!scu_base) { pr_err("could not iomap scu"); return;