From patchwork Thu May 12 03:46:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12846991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C399C433EF for ; Thu, 12 May 2022 03:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cBlja3pDZ94nti0dZY+2edSFvkBBGGsAqqWIinURPG0=; b=3MGYinixKqrH++ 65L7PP0O6RbQgwIeZ71jQAdtWhxL4wAZZfZ+xUVDIIXMjKJ9reLTSVWxCoQb//Edjk4wmwtJjdhT2 xv4NcIjwbR3WdJ3lJB0pJ0zdw96CL19hhIdkDuJOv7g3bJOaZz25mouKLIm+B73OEqtyBSpApVW/y 2CipqFIeaxGOOdCxUmBhw6HuJnksIlvooQcV1KE86BFrWY6e60jqwFuGq6RdvHvM+UHhKCrHSjpbJ noooLCPUPld2H1iPlEtSJ09g7S9Bcmf/RyCQVh3k9r8C9giiWOazd+fAn9SJH9mr3E/kNSbzXR8kL PvupLjL6X0N3oI3ye0sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noznR-009lXf-Nm; Thu, 12 May 2022 03:47:26 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nozn4-009lLR-8u for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 03:47:03 +0000 Received: by mail-pj1-x1029.google.com with SMTP id cq17-20020a17090af99100b001dc0386cd8fso3734942pjb.5 for ; Wed, 11 May 2022 20:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D+CQFJULOsaKE0QcIymzWY3BtTqWCy7rPPABpYb/J1M=; b=V6m4b5QbEyPqUQT952TkN1fe+g3GgOV+kFIWzyY1oMQFKHkfgfWQ58fT8E71UzAcOj B9JH5Yr0uQcRlS0LXngocF3ZB9ajfdAme9gnHDfq+9muG0Uh08SKbteTOT+CEmTJT5QB ospSG9tr2GCwhOtZEcIeTdfxuNz96J+LTxGcV705LlSSTWc0xs5++KBKJfpaIPTAKbuJ iuUMgNZ9pDXRlgaKmEulgnyJqbTdIMGUFwn86XnnbguMoqKPwAiHAKzfxEC0mC8ErYw2 cJj7A/zyW+zeddcQbUE1lJv/yw1tY69DPKXdakQYe4f14GAze66j6k21R3jbBN7DzWWL bY3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D+CQFJULOsaKE0QcIymzWY3BtTqWCy7rPPABpYb/J1M=; b=rW8/prJuJx/Ug+YkcVSnV8P8KndJHik1UW4upHHumB2mw0HpTPKOqXI+1hxhlcue67 Ux/nNJunuHU+e4Sk5ztvLVDMMdNuShHa7YN6SRiq4YL5LarpcYZMXlugoZhGmk+txzy0 ihXlVKdGnSihD3jjhBLMhUi/Wm7q+f7wm2QQ4cz5Bo7Rwwn3+US6QlUfCXoJdIttPDEg 3LjCqCRumYHI/oD/KVfFMh8vd+AWkQ8Bie2JERf9r5tZzpBkAjY6ZcZdpVM3UpozT2J2 9CwEHfhS4i3B69DqciKnm7q+SvlXv0xczjPLFpjRrVDOccfPohuoYy+gHh0pMk1HDNKC DIyA== X-Gm-Message-State: AOAM532QNF++mSSvuVwqScrl7T+jy74yY5iVngM8Kwxmtg2oajJXbwA5 s/6z+EWk+ylTPsMDfi8w/j8= X-Google-Smtp-Source: ABdhPJxJ0fEoJq+s06+6zSP/2UThvmCVCffCFNC9l/cXRG01NkbOeVNWx/SjxNS3bito8G0wUcOMLw== X-Received: by 2002:a17:902:b698:b0:158:faee:442f with SMTP id c24-20020a170902b69800b00158faee442fmr29203392pls.75.1652327220523; Wed, 11 May 2022 20:47:00 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id 10-20020a17090a174a00b001d5f22845bdsm962677pjm.1.2022.05.11.20.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 20:47:00 -0700 (PDT) From: Miaoqian Lin To: Daniel Palmer , Romain Perier , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: mstar: Fix refcount leaks Date: Thu, 12 May 2022 07:46:51 +0400 Message-Id: <20220512034652.61134-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_204702_334004_DC4D7184 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 5919eec0f092 ("ARM: mstar: SMP support") Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs") Signed-off-by: Miaoqian Lin Reviewed-by: Romain Perier --- arch/arm/mach-mstar/mstarv7.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-mstar/mstarv7.c b/arch/arm/mach-mstar/mstarv7.c index 274c4f0df270..3176998817d2 100644 --- a/arch/arm/mach-mstar/mstarv7.c +++ b/arch/arm/mach-mstar/mstarv7.c @@ -86,6 +86,7 @@ static int mstarv7_boot_secondary(unsigned int cpu, struct task_struct *idle) np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); smpctrl = of_iomap(np, 0); + of_node_put(np); if (!smpctrl) return -ENODEV; @@ -120,6 +121,7 @@ static void __init mstarv7_init(void) soc_mb = mstarv7_mb; else pr_warn("Failed to install memory barrier, DMA will be broken!\n"); + of_node_put(np); } DT_MACHINE_START(MSTARV7_DT, "MStar/Sigmastar Armv7 (Device Tree)")