From patchwork Thu May 12 04:55:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12847033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9A70C433EF for ; Thu, 12 May 2022 04:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8EL3lXscHeh3toMufpdJzfubGG6D2GXbbv9dM6bfzEc=; b=U+SDFC/o305UN+ Oz0Gb8xjDHVsNhJ79Yk37Grx81vWk4SzEUGpbCogX+F9dfTMCMqThyeAUQ9Y+ei+JA1ZSosPUFOhC UrNP0/UNry0CpDoIhP34L2UrMx/Gn2dcXStZrwUeZsUIPgYN/fFAnRpZtv71gQ1gbgwgfhpvJhASE 1n0JJVszHm9IF3Bv5rtK5yikIz0ShDsHI6PCu+KGCXrn5/Fmi3oEU6Tizyu+WxlplkrvkMwNcCpY7 DYS1L/YV9cyIr38uUtRBUpGisnJiwL5xfUrhh2hiPZWpmTiGGmtPUMKxLVWOL0a9yUBBgdvm1c4vA q+WfSPHGU7rabJPwfycg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1np0s2-00A1ak-SY; Thu, 12 May 2022 04:56:14 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1np0rz-00A1aK-DJ for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 04:56:12 +0000 Received: by mail-pj1-x102b.google.com with SMTP id n10so4094423pjh.5 for ; Wed, 11 May 2022 21:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cZ7RH5y817mnOLvwZ/IWQwDogZf8paE6rFGK50oQ3hw=; b=kSgCCRJfGlri5OPnAl2kKgMp2k12cg/wAIHEe2ZMTVC9jrSvfAr0vtxm8gj9Aao9El cN+MwYEm0Fd+4rKh1l4IaFbOzSIH0I8koYvdxAx/BCwEM2bmiabFENahaG/NsxXIZUlt koyy20Dn/zohBPUFje7cHQBvqb3IepUcVONmfe5uD73Dd0dr9zGlxLS7bZgWO0FjPiBL C5QvjjpsMWZ4JO17gjZkjbqOXgcjgGc9PrYSYCbSt5GDavPG7MSl7v+Yfle383l+d1rT Njtbz4iiAH1dvptThir0yDJV2Vb+o0/y07yjNhoxwcPHm6qYY2tlHazz0XcsYf9JENGt 8a0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cZ7RH5y817mnOLvwZ/IWQwDogZf8paE6rFGK50oQ3hw=; b=fm4hgWcFdt8C4GgLLogr2i4IafmtUg7mEfXMXSyeHWRhIw3xbnk3mJdJt1mZRbmF3R aTjKN3ReHQJuux3S25hSNWVFs3jCuqIp1cQTwv7WyhPueKiE3g+TUHs6oegbJxPTOHC1 YYGR3QD7y2I/X9s8svUjHwZsZkiKwlrn66Km3oV+bXLi8M1xwHg3aw7MLACy+HQgN40B IuriqkCYa9+1K+wOHRvtNxLTnh+hdqrtJM0HU8PMWbn4IwbEpCWASKjkiWS9ZjFEQmXu hn4JLiGeYgtyOs1akF7XkFZ3tLPEnolB9KsyMEdnxkx/ln8BBEzNbljSqM1zl/OEBGp3 qsCQ== X-Gm-Message-State: AOAM531Bfn6Zuss/1GLJFg/mnUXTuABWfdXu8WYeEFMIJVnqy6a/4izQ 389HVhcuxSLGBt07qpwV1aA= X-Google-Smtp-Source: ABdhPJwS5r880J33xg84nWBQFByYbOqZGu+xxskLSLSXWmhYjYDOkdBsbL0MU/qQBlBpo8BX7HDIXA== X-Received: by 2002:a17:902:e94e:b0:154:3a4:c5e8 with SMTP id b14-20020a170902e94e00b0015403a4c5e8mr29117459pll.19.1652331368911; Wed, 11 May 2022 21:56:08 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id q16-20020a170902dad000b0015e8d4eb1bdsm3032954plx.7.2022.05.11.21.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 21:56:08 -0700 (PDT) From: Miaoqian Lin To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Oleksij Rempel , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] remoteproc: imx_rproc: Fix refcount leak in imx_rproc_addr_init Date: Thu, 12 May 2022 08:55:58 +0400 Message-Id: <20220512045558.7142-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_215611_504523_B12F1C9D X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore. This function has two paths missing of_node_put(). Fixes: 6e962bfe56b9 ("remoteproc: imx_rproc: add missing of_node_put") Fixes: a0ff4aa6f010 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rproc driver") Signed-off-by: Miaoqian Lin --- drivers/remoteproc/imx_rproc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..6363ed40854a 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -559,16 +559,17 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, node = of_parse_phandle(np, "memory-region", a); /* Not map vdevbuffer, vdevring region */ - if (!strncmp(node->name, "vdev", strlen("vdev"))) + if (!strncmp(node->name, "vdev", strlen("vdev"))) { + of_node_put(node); continue; + } err = of_address_to_resource(node, 0, &res); + of_node_put(node); if (err) { dev_err(dev, "unable to resolve memory region\n"); return err; } - of_node_put(node); - if (b >= IMX_RPROC_MEM_MAX) break;