From patchwork Fri May 13 19:38:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 12849306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C370C433FE for ; Fri, 13 May 2022 19:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383857AbiEMTik (ORCPT ); Fri, 13 May 2022 15:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383849AbiEMTii (ORCPT ); Fri, 13 May 2022 15:38:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FE6712EA; Fri, 13 May 2022 12:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=iGO39EDVjPnTYXbXk4m8oqTPwLMaY1sb1Vley0Ob2Bs=; b=xpbCJEZVFLojPYYKLedVllObpJ sIKinKb0p4nX/oHMltMoDAc0PB64XIfu2HYPQe9s403D2iryESyykHgKMjzr9inJ9W0jGRh6n0o8U yaP6pEuyLGdK2XhsBydQKxUg5VkoD41qsPkLM0zM4tONyTXoFz066JnV872EBNQQ0CkqPK16Zq0PX usWYLbFworSaNvmRhDJYjn2h1guPnX5ON2Wx/pk+MLUWFOE74lypAvvcuHZGNmyEA/xXfMkXvbQVS X8e/cARTNoRnDpEU1nuCZ9TOLinymaY/TjPbXgJewdSLmXghwq1DboR0x77p8hLTKCawb2v9AGsxq Pzvcnmsw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npb7T-00HM1x-Fl; Fri, 13 May 2022 19:38:35 +0000 From: Luis Chamberlain To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: patches@lists.linux.dev, amir73il@gmail.com, pankydev8@gmail.com, tytso@mit.edu, josef@toxicpanda.com, jmeneghi@redhat.com, jake@lwn.net, mcgrof@kernel.org Subject: [PATCH 1/4] workflows/Kconfig: be consistent when enabling fstests or blktests Date: Fri, 13 May 2022 12:38:28 -0700 Message-Id: <20220513193831.4136212-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220513193831.4136212-1-mcgrof@kernel.org> References: <20220513193831.4136212-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org We have two kconfig variables which we use to be able to express when we are going to enable fstests or blktests, either as a dedicated set of tests or when we want to enable testing both fstests and blktests in one system. But right now we only select this kconfig variable when we are using a dedicated system. This is not an issue as the kconfig is a kconfig symbols are bools which are set default to y if either the test is dedicated or not. But to be pedantic, and clear, let's make sure the tests select the respective kconfig for each case as we'd expect to see it. Otherwise this can confuse folks reading this. Signed-off-by: Luis Chamberlain --- kconfigs/workflows/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kconfigs/workflows/Kconfig b/kconfigs/workflows/Kconfig index 7e5c518..7f71470 100644 --- a/kconfigs/workflows/Kconfig +++ b/kconfigs/workflows/Kconfig @@ -133,6 +133,7 @@ if !WORKFLOWS_DEDICATED_WORKFLOW config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS bool "fstests" + select KDEVOPS_WORKFLOW_ENABLE_FSTESTS help Select this option if you are doing filesystem development and want to target development for a filesystem and enable fstests so that @@ -146,6 +147,7 @@ config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_BLKTESTS bool "blktests" + select KDEVOPS_WORKFLOW_ENABLE_BLKTESTS help Select this option if you are doing block layer development and want to run blktests. The git tree for blktests will be git clone and From patchwork Fri May 13 19:38:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 12849307 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF5DC433EF for ; Fri, 13 May 2022 19:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383870AbiEMTil (ORCPT ); Fri, 13 May 2022 15:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383685AbiEMTii (ORCPT ); Fri, 13 May 2022 15:38:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FD20712D5; Fri, 13 May 2022 12:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=/APt/fREJUivm2PL8Qip+DxLUsOoVfNgqWfQfNmKkEM=; b=2L3lR8RT+ik15tlc3Fk0Zwr327 vxDNvlTDagP9N62xnZg5ps/Lo3KS5NHaRwxIkc1EHB5WJGyy9nZtqAh/snrNzXOc4eIOirgqZWhjj Rg6CDQPJKppnwByCq2hXFIXhQfj+p8d5oaq+6IEJIxq7nlQhI8+3qaDXgF7LQ0qTQOSQ7Go8mcVL5 scX/ZXtnvESB9XTqpwLzX3zjT2O2RD99aSjGj3QR4rfKC/3GzrYomRPI6qbOtm+M5mWSrKgxs+GLH igbFNYm7tbCIL98z9YO40Cng6tFVpHquoatLkTQQK86hsE9pHEuzEuBQ7Sb5+L+xZVJ+yI81mep2K /7QMUxfQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npb7T-00HM1z-IL; Fri, 13 May 2022 19:38:35 +0000 From: Luis Chamberlain To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: patches@lists.linux.dev, amir73il@gmail.com, pankydev8@gmail.com, tytso@mit.edu, josef@toxicpanda.com, jmeneghi@redhat.com, jake@lwn.net, mcgrof@kernel.org Subject: [PATCH 2/4] kdevops: move generic kdevops variables to its own file Date: Fri, 13 May 2022 12:38:29 -0700 Message-Id: <20220513193831.4136212-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220513193831.4136212-1-mcgrof@kernel.org> References: <20220513193831.4136212-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org There are shared kdevops variables between different workflows, which *can* be used by any workflow. Move these into a generic kdevops helper Makefile, as we can later expand on this. This makes no functional changes. Signed-off-by: Luis Chamberlain --- workflows/Makefile | 33 +-------------------------------- workflows/common/Makefile | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 32 deletions(-) create mode 100644 workflows/common/Makefile diff --git a/workflows/Makefile b/workflows/Makefile index 928e42f..033ffc7 100644 --- a/workflows/Makefile +++ b/workflows/Makefile @@ -1,37 +1,6 @@ # SPDX-License-Identifier: copyleft-next-0.3.1 -# How we create the partition for the workflow data partition -WORKFLOW_DATA_DEVICE:=$(subst ",,$(CONFIG_WORKFLOW_DATA_DEVICE)) -WORKFLOW_DATA_PATH:=$(subst ",,$(CONFIG_WORKFLOW_DATA_PATH)) -WORKFLOW_DATA_FSTYPE:=$(subst ",,$(CONFIG_WORKFLOW_DATA_FSTYPE)) -WORKFLOW_DATA_LABEL:=$(subst ",,$(CONFIG_WORKFLOW_DATA_LABEL)) - -WORKFLOW_KDEVOPS_GIT:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_GIT)) -WORKFLOW_KDEVOPS_GIT_DATA:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_GIT_DATA)) -WORKFLOW_KDEVOPS_DIR:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_DIR)) - -WORKFLOW_ARGS += data_device=$(WORKFLOW_DATA_DEVICE) -WORKFLOW_ARGS += data_path=$(WORKFLOW_DATA_PATH) -WORKFLOW_ARGS += data_fstype=$(WORKFLOW_DATA_FSTYPE) -WORKFLOW_ARGS += data_label=$(WORKFLOW_DATA_LABEL) -WORKFLOW_ARGS += kdevops_git=$(WORKFLOW_KDEVOPS_GIT) -WORKFLOW_ARGS += kdevops_data=\"$(WORKFLOW_KDEVOPS_GIT_DATA)\" -WORKFLOW_ARGS += kdevops_dir=\"$(WORKFLOW_KDEVOPS_DIR)\" - -ifeq (y,$(CONFIG_WORKFLOW_MAKE_CMD_OVERRIDE)) -WORKFLOW_MAKE_CMD:=$(subst ",,$(CONFIG_WORKFLOW_MAKE_CMD)) -endif - -ifeq (y,$(CONFIG_WORKFLOW_INFER_USER_AND_GROUP)) -WORKFLOW_ARGS += infer_uid_and_group=True -else -WORKFLOW_DATA_USER:=$(subst ",,$(CONFIG_WORKFLOW_DATA_USER)) -WORKFLOW_DATA_GROUP:=$(subst ",,$(CONFIG_WORKFLOW_DATA_GROUP)) - -WORKFLOW_ARGS += data_user=$(WORKFLOW_DATA_USER) -WORKFLOW_ARGS += data_group=$(WORKFLOW_DATA_GROUP) - -endif # CONFIG_WORKFLOW_MAKE_CMD_OVERRIDE == y +include workflows/common/Makefile BOOTLINUX_ARGS := ifeq (y,$(CONFIG_BOOTLINUX)) diff --git a/workflows/common/Makefile b/workflows/common/Makefile new file mode 100644 index 0000000..da21d78 --- /dev/null +++ b/workflows/common/Makefile @@ -0,0 +1,34 @@ +# SPDX-License-Identifier: copyleft-next-0.3.1 + +# How we create the partition for the workflow data partition +WORKFLOW_DATA_DEVICE:=$(subst ",,$(CONFIG_WORKFLOW_DATA_DEVICE)) +WORKFLOW_DATA_PATH:=$(subst ",,$(CONFIG_WORKFLOW_DATA_PATH)) +WORKFLOW_DATA_FSTYPE:=$(subst ",,$(CONFIG_WORKFLOW_DATA_FSTYPE)) +WORKFLOW_DATA_LABEL:=$(subst ",,$(CONFIG_WORKFLOW_DATA_LABEL)) + +WORKFLOW_KDEVOPS_GIT:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_GIT)) +WORKFLOW_KDEVOPS_GIT_DATA:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_GIT_DATA)) +WORKFLOW_KDEVOPS_DIR:=$(subst ",,$(CONFIG_WORKFLOW_KDEVOPS_DIR)) + +WORKFLOW_ARGS += data_device=$(WORKFLOW_DATA_DEVICE) +WORKFLOW_ARGS += data_path=$(WORKFLOW_DATA_PATH) +WORKFLOW_ARGS += data_fstype=$(WORKFLOW_DATA_FSTYPE) +WORKFLOW_ARGS += data_label=$(WORKFLOW_DATA_LABEL) +WORKFLOW_ARGS += kdevops_git=$(WORKFLOW_KDEVOPS_GIT) +WORKFLOW_ARGS += kdevops_data=\"$(WORKFLOW_KDEVOPS_GIT_DATA)\" +WORKFLOW_ARGS += kdevops_dir=\"$(WORKFLOW_KDEVOPS_DIR)\" + +ifeq (y,$(CONFIG_WORKFLOW_MAKE_CMD_OVERRIDE)) +WORKFLOW_MAKE_CMD:=$(subst ",,$(CONFIG_WORKFLOW_MAKE_CMD)) +endif + +ifeq (y,$(CONFIG_WORKFLOW_INFER_USER_AND_GROUP)) +WORKFLOW_ARGS += infer_uid_and_group=True +else +WORKFLOW_DATA_USER:=$(subst ",,$(CONFIG_WORKFLOW_DATA_USER)) +WORKFLOW_DATA_GROUP:=$(subst ",,$(CONFIG_WORKFLOW_DATA_GROUP)) + +WORKFLOW_ARGS += data_user=$(WORKFLOW_DATA_USER) +WORKFLOW_ARGS += data_group=$(WORKFLOW_DATA_GROUP) + +endif # CONFIG_WORKFLOW_INFER_USER_AND_GROUP == y From patchwork Fri May 13 19:38:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 12849308 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41257C433FE for ; Fri, 13 May 2022 19:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383889AbiEMTis (ORCPT ); Fri, 13 May 2022 15:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383863AbiEMTil (ORCPT ); Fri, 13 May 2022 15:38:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E4676FA23; Fri, 13 May 2022 12:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=50oUJFS0CRaiUG2nXdYJz1eNDp24nYsSSOfImyNmLXQ=; b=rDJw8YY6/2qoi7Wd2z9/ax2QMp iWpd03mz287Ld+1+eDdTzp+dch0/xHjGAiIQ1I1o/8Fv+mMBYxEkI/WUkOGHJDL+ijzT1E2O9lfHo alrCDczA4yj3BF+NU0rgcvoFlNQMZxf+yy0YlWc+8Uw3uoSi7YeY/tYt0nxb5AN+RZ2nN8ATbmmsz YIrlezogmRxoX5w7OBkHTytnaZDZ8WAoK1NwqLnEZlmPHQt80ag/nTgHqnG4URw3l+Z/v1HqbK4o4 7qUnbhtRizTpKfrkd4amsggqB3UsZ6aEflt4UIcRTtJ9UwIyN7+6iNloeNgmgf5ATBWN7Dkmp7odM Djr2DPQA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npb7T-00HM21-Kz; Fri, 13 May 2022 19:38:35 +0000 From: Luis Chamberlain To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: patches@lists.linux.dev, amir73il@gmail.com, pankydev8@gmail.com, tytso@mit.edu, josef@toxicpanda.com, jmeneghi@redhat.com, jake@lwn.net, mcgrof@kernel.org Subject: [PATCH 3/4] playbooks: add a common playbook a git reset task for kdevops Date: Fri, 13 May 2022 12:38:30 -0700 Message-Id: <20220513193831.4136212-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220513193831.4136212-1-mcgrof@kernel.org> References: <20220513193831.4136212-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Two playbooks share the concept of git cloning kdevops into the target nodes (guests, cloud hosts, baremetal hosts) so that expunge files can be used for avoiding tests. If you decide you want to change the URL for that git tree it may not be so obvious what to do. Fortunately the solution is simple. You just tell ansible to use the new git tree URL. That's it. It won't remove the old directory and things work as expected. But since we use the kdevops git tree on both fstests and blktests it is not so obvious to developers that the thing to do here is to just run 'make fstests' or 'make blktests' and even that is not as efficient as that will also re-clone the fstests or blktests tree respectively. When we just want to reset the kdevops git tree we currently have no semantics to specify that. But since this is a common post-deployment goal, just add a common playbook that let's us do common tasks. All we need then is the kconfig logic to define when some commmon tasks might make sense. So to reset your kdevops git tree, all you have to do now is change the configuration for it, then run: make make kdevops-git-reset Signed-off-by: Luis Chamberlain --- kconfigs/workflows/Kconfig | 4 +++ playbooks/common.yml | 4 +++ playbooks/roles/common/README.md | 38 ++++++++++++++++++++++++ playbooks/roles/common/defaults/main.yml | 7 +++++ playbooks/roles/common/tasks/main.yml | 23 ++++++++++++++ workflows/common/Makefile | 12 ++++++++ 6 files changed, 88 insertions(+) create mode 100644 playbooks/common.yml create mode 100644 playbooks/roles/common/README.md create mode 100644 playbooks/roles/common/defaults/main.yml create mode 100644 playbooks/roles/common/tasks/main.yml diff --git a/kconfigs/workflows/Kconfig b/kconfigs/workflows/Kconfig index 7f71470..817335b 100644 --- a/kconfigs/workflows/Kconfig +++ b/kconfigs/workflows/Kconfig @@ -175,6 +175,10 @@ source "workflows/blktests/Kconfig" endmenu endif # KDEVOPS_WORKFLOW_ENABLE_BLKTESTS +config KDEVOPS_WORKFLOW_GIT_CLONES_KDEVOPS_GIT + bool + default y if KDEVOPS_WORKFLOW_ENABLE_FSTESTS || KDEVOPS_WORKFLOW_ENABLE_BLKTESTS + endif # WORKFLOWS_LINUX_TESTS endif # WORKFLOWS_TESTS diff --git a/playbooks/common.yml b/playbooks/common.yml new file mode 100644 index 0000000..48485e3 --- /dev/null +++ b/playbooks/common.yml @@ -0,0 +1,4 @@ +--- +- hosts: all + roles: + - role: common diff --git a/playbooks/roles/common/README.md b/playbooks/roles/common/README.md new file mode 100644 index 0000000..2b0084c --- /dev/null +++ b/playbooks/roles/common/README.md @@ -0,0 +1,38 @@ +common +====== + +The common role lets you add tasks which is commmon to all workflows. +Without this we would be duplicating code. + +Requirements +------------ + +None. + +Role Variables +-------------- + + * kdevops_git_reset: perform a git reset. This is useful in case you want + to change the URL you use for kdevops. + +Dependencies +------------ + +None. + +Example Playbook +---------------- + +Below is an example playbook task: + +``` +--- +- hosts: all + roles: + - role: common +``` + +License +------- + +copyleft-next-0.3.1 diff --git a/playbooks/roles/common/defaults/main.yml b/playbooks/roles/common/defaults/main.yml new file mode 100644 index 0000000..69cd0af --- /dev/null +++ b/playbooks/roles/common/defaults/main.yml @@ -0,0 +1,7 @@ +# SPDX-License-Identifier copyleft-next-0.3.1 +--- + +kdevops_data: "/data/kdevops" +kdevops_git: "https://github.com/linux-kdevops/kdevops.git" + +kdevops_git_reset: False diff --git a/playbooks/roles/common/tasks/main.yml b/playbooks/roles/common/tasks/main.yml new file mode 100644 index 0000000..4482349 --- /dev/null +++ b/playbooks/roles/common/tasks/main.yml @@ -0,0 +1,23 @@ +--- +- name: Import optional extra_args file + include_vars: "{{ item }}" + ignore_errors: yes + with_first_found: + - files: + - "../extra_vars.yml" + - "../extra_vars.yaml" + - "../extra_vars.json" + skip: true + tags: vars + +# Distro agnostic stuff goes below + +- name: git reset kdevops + environment: + GIT_SSL_NO_VERIFY: true + git: + repo: "{{ kdevops_git }}" + dest: "{{ kdevops_data }}" + tags: [ 'kdevops_reset'] + when: + - kdevops_git_reset|bool diff --git a/workflows/common/Makefile b/workflows/common/Makefile index da21d78..6596ed1 100644 --- a/workflows/common/Makefile +++ b/workflows/common/Makefile @@ -32,3 +32,15 @@ WORKFLOW_ARGS += data_user=$(WORKFLOW_DATA_USER) WORKFLOW_ARGS += data_group=$(WORKFLOW_DATA_GROUP) endif # CONFIG_WORKFLOW_INFER_USER_AND_GROUP == y + +ifeq (y,$(CONFIG_KDEVOPS_WORKFLOW_GIT_CLONES_KDEVOPS_GIT)) +kdevops-git-reset: + $(Q)ansible-playbook -f 30 -i hosts playbooks/common.yml --tags vars,kdevops_reset --extra-vars '{ kdevops_git_reset: True }' $(LIMIT_HOSTS) + +kdevops-help-menu: + @echo "Common workflow options:" + @echo "kdevops-git-reset: - Resets your kdevops git tree URL and contents on guests" + @echo + +HELP_TARGETS += kdevops-help-menu +endif # CONFIG_KDEVOPS_WORKFLOW_GIT_CLONES_KDEVOPS_GIT From patchwork Fri May 13 19:38:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 12849305 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F6DC4332F for ; Fri, 13 May 2022 19:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383853AbiEMTij (ORCPT ); Fri, 13 May 2022 15:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346242AbiEMTii (ORCPT ); Fri, 13 May 2022 15:38:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E4B76FD36; Fri, 13 May 2022 12:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=GAZcGk03ehrHc5Dtxk7odt4Ht5+ef2Nl5pEGHuLhXTc=; b=o1Xegp6GbvaEkEIroQaEaDuJbO 2zmGch5vozo3M0a8yTt7EHCU0DiarL2Ecc/pGhadzqhihoMrvMA/UnuhfGRNLraCmW9/o34DKzN49 ZmbWrhS09pw8kvvEkHw9EAOA2JFVUIP1ag3FXllW6g1dSEQPS3fFRrBj3n/niwLkP3co8XQBkG9Su /0u+ggTYZKC9F8Db/gZkKRKDsnIueDBlSksFHNLILEgfAU5yRm1yxjPS86xaCFE1XIgmEPnyF1aV3 jLugS7RYjt+DaoPY7z6DyT1iH4ZWWGjXZ/TT/hBuG96asJomP91qLFFwLNb+VJvBfMONMVt4UOTm4 RVNNI4kA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npb7T-00HM23-Nh; Fri, 13 May 2022 19:38:35 +0000 From: Luis Chamberlain To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: patches@lists.linux.dev, amir73il@gmail.com, pankydev8@gmail.com, tytso@mit.edu, josef@toxicpanda.com, jmeneghi@redhat.com, jake@lwn.net, mcgrof@kernel.org Subject: [PATCH 4/4] kdevops: make linux-kdevops the default tree Date: Fri, 13 May 2022 12:38:31 -0700 Message-Id: <20220513193831.4136212-5-mcgrof@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220513193831.4136212-1-mcgrof@kernel.org> References: <20220513193831.4136212-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org At LSFMM 2022 at Palm Springs it was discussed that we should *strive* towards a shared expunge list for fstests / blktests. Although that effort requires splitting out the expunge list from kdevops to a new git subtree, sharing a git tree for commit work for kdevops seems also innevitable and desirable since some of us are already collaborating on at least one shared test runner, kdevops. So we can start by using a shared organization for what we need to share, we call this organization linux-kdevops [0]. This encompasses a few usual suspects git trees which can be used by both fstests and blktests picking a "stable" sort of git sha1sum for each and always striving towards the latest: * fstests * blktests * dbench * ndd We'll be using the linux-kdevops organization for what trees we use and trust that those in the organization will communicate what is needed before making controversial changes. This is perhaps the first controversial change, but it only applies to kdevops, so if you are not using kdevops as a test runner you probably won't care. Those using kdevops should become aware that they should change their default upstream to use linux-kdevops URL now: So we switch from: https://github.com/mcgrof/kdevops To: https://github.com/linux-kdevops/kdevops Users which change this on a live environemtn would also then just have to change the CONFIG_WORKFLOW_KDEVOPS_GIT on their configuration so they'd just run: make menuconfig # set CONFIG_WORKFLOW_KDEVOPS_GIT to https://github.com/linux-kdevops/kdevops make make kdevops-git-reset Those who have commit access to the organization linux-kdevops can then just commit as needed to help move baselines forwards and if and when something comes up which really seems controversial we can use the mailing lists as with this change. [0] https://github.com/orgs/linux-kdevops/ Signed-off-by: Luis Chamberlain --- kconfigs/workflows/Kconfig.shared | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kconfigs/workflows/Kconfig.shared b/kconfigs/workflows/Kconfig.shared index 4cccfbe..4a2ecf6 100644 --- a/kconfigs/workflows/Kconfig.shared +++ b/kconfigs/workflows/Kconfig.shared @@ -47,7 +47,7 @@ endif config WORKFLOW_KDEVOPS_GIT string "Git tree of kdevops to clone on targets" - default "https://github.com/mcgrof/kdevops.git" if !GIT_ALTERNATIVES && !HAVE_CUSTOM_KDEVOPS_GIT + default "https://github.com/linux-kdevops/kdevops.git" if !GIT_ALTERNATIVES && !HAVE_CUSTOM_KDEVOPS_GIT default "https://github.com/linux-kdevops/kdevops.git" if GIT_LINUX_KDEVOPS_GITHUB default "https://gitlab.com/linux-kdevops/kdevops.git" if GIT_LINUX_KDEVOPS_GITLAB default CUSTOM_KDEVOPS_GIT if HAVE_CUSTOM_KDEVOPS_GIT