From patchwork Mon May 16 07:31:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12850346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57134C433F5 for ; Mon, 16 May 2022 07:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UEKn/wjsHYsvtb6coi51T69Buo7Dz+AAYfjqP6EvFmI=; b=3F5mUHWBZnslZa IZHq/nSv6htDZroEhjYkmm9sK3byCs3LtK0IKbzZ6oq3qpQ36Jul2+45Oc8n8CCYFywjSlfPmKvPB 31RWwdQ0liv4aPUtfJyNxQzRqac8lnhwmievP0JZ77/rc/dacIulEeU0qFjoa0VrE1A/160z/LgEd jjxs1wV90OAkbk3kA3b+7mbq7Kc3om7ETiaCUIj6GMqco6m46HRR6rJk6vH/HI454z9dJNdJlHWVy OSWcLRGPmPqvZ1di7FCWFz1cifHoiyiKuDhcWDmfDXNZyktFnW2qHJA83foCOfgmn0aM+ff6DXRtO osLSWNDqNVDUyTKS+vtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVD4-006Tqm-FL; Mon, 16 May 2022 07:32:06 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVD1-006Tns-1n for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:32:05 +0000 Received: by mail-pg1-x535.google.com with SMTP id 202so13294539pgc.9 for ; Mon, 16 May 2022 00:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cqDqf9Ouh9kt7IzDhnAUWG94jCCiPx6/C4Y9VUOo8Og=; b=i+Dp67aT9+OEtCYWkwWzHaG8m0BapotR432HsMZsaY4yaPW1ifUEszS3KpDMqtbQ4/ UVoW9Zcvh62VZ80yYOl4t9nXM7QRkOByEqBleCDOvlY2K6EdUTOUNfiKhJJFkLR54CPk r+QGEv4Vyog5w3Y1rgqVPHLSIeEIPP128hdXtZ06MBAXywtGcY56uxw8DBlGGZcfzfZY p2LjGT+iaNiVkhCeemrwCHmx6gj624vkK85gQY7OBEIr7a/yVFTdf26K9jdMZ/p5cTxk GlXrg0kF403Ad3tVZPXx9oboJqpKaIHcbMnpVPvHc6sKZ5l0mwrZx+jcfGPPGb+NdXbm rYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cqDqf9Ouh9kt7IzDhnAUWG94jCCiPx6/C4Y9VUOo8Og=; b=e+MucBS2t9UwqMvvrayZE8WAZBdEH4Oc9I0F/DPgl6+LGd6EWTaDQmLxkgHazTXR/2 4ZPA8wIXCCOuHXRgXE6aCmJtbPL/MYDOy1qBQX9UiW8Y5PlcbTE3Ek/22AopK0abZxme 5213kHWll+zE6ah5iPxsWRnK71xhmjzexoXDkFgpgMZK9D5aneAASR+++6twS998AjW8 8W57OH/lJCp5kQLBWIaCUaLmeUK2oukjSiNCTH7Lr2OztiICBgz2t/Mz6Qln37R97fmI r96apMHOHsmNC9Ra3HrN6k/LQlIU3BwmpZVirAKXFiwjhU80FC0ZbodZ4F9dHgmWzAyi CpFg== X-Gm-Message-State: AOAM533HTVRZFPikL5j+EL35oqxaIVzNGP6mzKc+mtIC5uwDnvmWaBrt XCytRy5ycBgGluXeyIj7c1c= X-Google-Smtp-Source: ABdhPJyqMgJSYlcjnJe4wGk/9qhyBD9+IH8uogJM4OSRWjtfartQPb74T6UmFqSmsN20Apd6pFv0dQ== X-Received: by 2002:a65:6946:0:b0:39d:a0c3:71f with SMTP id w6-20020a656946000000b0039da0c3071fmr14008974pgq.160.1652686321095; Mon, 16 May 2022 00:32:01 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y124-20020a62ce82000000b0050dc762812bsm6167647pfg.5.2022.05.16.00.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 00:32:00 -0700 (PDT) From: Miaoqian Lin To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe Date: Mon, 16 May 2022 11:31:50 +0400 Message-Id: <20220516073151.25918-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_003203_167631_BD51ECBB X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support") Signed-off-by: Miaoqian Lin --- drivers/thermal/imx_sc_thermal.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c index 8d76dbfde6a9..1ab854c228e5 100644 --- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c @@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) if (!sensor) { of_node_put(child); of_node_put(sensor_np); + of_node_put(np); return -ENOMEM; } @@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) } of_node_put(sensor_np); + of_node_put(np); return ret; }