From patchwork Mon May 16 07:44:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12850354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD1FC433F5 for ; Mon, 16 May 2022 07:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=JTLSvAAfKpH2AUKhXjJqTsetyJuV5RbgZQqF7SLnyFc=; b=2tzP2MUb2r/Ut3 4xfQKGKqsLoIZbTsseoR/MzHmXzT20KI53o+XSnHAhDwNdTye0ZKEcNo50uQA1ld8FQUl1fUo9Odx /2F77aJGcpiyI9YV9EBSXpmkcYetHFJZo4BeA500ugdBJyvKM8hjznw3CprSYfJEEtGoZTWCyZgOL Z1SqLVtte/uGbxytpnAsaXdWjVI0iyvyMBEKsP2bwK7HRnSRrnVO5tUt64rgGJSeMWMWHgh0wT2ky rMJ/tVjF4uCykFvDj1ikn8m5fEWt44SNrNedq9Kz8Dhu1M72W59h2DjNZn2HgpY1xQMX2O53qgkvq QJzG7nifmgaLipNGQvVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVPJ-006Wkr-Su; Mon, 16 May 2022 07:44:46 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVPG-006WkH-Ej for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:44:43 +0000 Received: by mail-pj1-x1035.google.com with SMTP id pq9-20020a17090b3d8900b001df622bf81dso1129377pjb.3 for ; Mon, 16 May 2022 00:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y7GuWHsJybHMQGpKO0nmV9x7SQtARUoRM/1CQH6XR9g=; b=jhAbH65rJRpjxi787HhYLR7MxfS7Km1gQDSHipikR+X/k0I3MorZBjDFcrS1ZsDOT1 qiJTnH8FhghWwFV7fkwUgBKTxZa77mjbxd96NZGjPp1Jo8O/cP7BSeFTdDYidGocDSdk HQc3sFHNv8qpY3HTccUjeI9XAUhBariveV0AJ6T/cTKOIK1YHDMbI1I6qNXR7YGbbWiw doA60CZKDuDjhp3xoO78GljWrGq7nmY2axy7udbqSDZ5jpPUSNarW/8otX06onWAvG6o Sa+Avg7WScsMXAnp9o44YNYV5ti9PZl96FbmBwP7RKyzusZJ7RAuENFNdlkAr+rGXrUC 7C1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y7GuWHsJybHMQGpKO0nmV9x7SQtARUoRM/1CQH6XR9g=; b=nsWjCfsRauwsfkcJQvQaGn1fZNiuVYY6JGfQ2iSuiESLKbuwg67UDRhNChxWDQQcGr Lc957zhts79bTG0m7LpSZc1kVJyGSEirqoVI29X6G11l9BWKhR3ZhPNSoBf9/rla2Av3 9pSjgp3SLVWm5N+9HRPR0vy3bOWss6scq2PfOUksvwmcpxzxpsSCqUI9QOZcJ0+QUahe 7cyKAdkwX6/7WfhwUqiVQlcMkkEjAmRmpv7ioySgTMdTshC/3gWkyG9PwWCezogPzOQZ S+v+eFN60j92evjV3e7c4R+VPke+tVNfdTnGu+6CzXbGxkNDVlMtCxDkfq+u74in4SUh K7/A== X-Gm-Message-State: AOAM532Q53Clwz8nU22PDdWch5lMnltRtXrkvh58fcxi3QUYCJjvTsZ1 ycqIExBkoPXMERqv6rSQ2vRaYjlDGVIcX+jt X-Google-Smtp-Source: ABdhPJyLvH98LklY2E6TRF91Nh6p+BlKJA9ZsYLI8kfsl2/dp5boXhBGYLNMEcQ4JbGJdHLa4EF2jw== X-Received: by 2002:a17:902:988e:b0:161:8750:480b with SMTP id s14-20020a170902988e00b001618750480bmr2133268plp.154.1652687081061; Mon, 16 May 2022 00:44:41 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y12-20020a17090a1f4c00b001ded49491basm13290517pjy.2.2022.05.16.00.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 00:44:40 -0700 (PDT) From: Miaoqian Lin To: Sudeep Holla , Cristian Marussi , Liam Girdwood , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] regulator: scmi: Fix refcount leak in scmi_regulator_probe Date: Mon, 16 May 2022 11:44:33 +0400 Message-Id: <20220516074433.32433-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_004442_533840_B8D40D94 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 0fbeae70ee7c ("regulator: add SCMI driver") Signed-off-by: Miaoqian Lin --- drivers/regulator/scmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index 1f02f60ad136..41ae7ac27ff6 100644 --- a/drivers/regulator/scmi-regulator.c +++ b/drivers/regulator/scmi-regulator.c @@ -352,7 +352,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev) return ret; } } - + of_node_put(np); /* * Register a regulator for each valid regulator-DT-entry that we * can successfully reach via SCMI and has a valid associated voltage