From patchwork Mon May 16 08:41:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiabing Wan X-Patchwork-Id: 12850408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFC3C433FE for ; Mon, 16 May 2022 08:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241878AbiEPImq (ORCPT ); Mon, 16 May 2022 04:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239517AbiEPImf (ORCPT ); Mon, 16 May 2022 04:42:35 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2096.outbound.protection.outlook.com [40.107.215.96]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160A3BE1C; Mon, 16 May 2022 01:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EV8jdjNAioHlRV3l/livgcylCAaItw7TeQxM02bsAOk5ODzPA8WOPuyohQvjYn9egdTdWiZTLVcvLNr8/QcmMj3rkdvM4q50hOXC/LnoxIb5pwRawW0wT2nnwOyWMIFGBmBTfrm+0lKjVCqG1hrihFVw9KDg9Q3Ui8clHvQmB2oiglTxYrCjfiD2U0+k6Qa2jyRi4nmRNNVpguka82afuP6QF2FTGtjInyyyyTmY2tzjkDNGcsrDYveIPGzSfTZ0fTvGJUy4nZ/GFWUqOw86csyoauUs79uChwmJWeWGEJtGLQarFhl+31E/ODoZTalkP5GR23REr1bVrhfM2GL6Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofvvTbHAPPrz+0DHCbFm40sIvX/xXpp83GgZSUmLHVY=; b=l8g+3ZLgwotNGUE96cXMdojoKHdVowGbRgVQ0UMsu3WeuOVsOZrDrWHNJiLXyrNpOcyaYYnh+WQJ8v4EBS1AV9d8WszoJkkY9IrGWfWz6R13Tri76U5gQrLa2K47w5le+FTQOZGFZUE0ii0ZvLyjGZE9XL5VdYcOHh+KnEfYxUKtM9KeBfKYxhQV9MmmQKblT0oH0t4BGn/qpmA5pMWLU6pF3agNWPrxTK2yV8e5x3LoRsJW7tcBtaVRNXlls0P3GrHnvm8JDw+2Y5zHHAX+FnhdVrdcTXc/uqFLMYso5vvYGtRpGjNa8Z/Z1VQu4usDwqM1jr83x0zuIPJ0ulzPrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofvvTbHAPPrz+0DHCbFm40sIvX/xXpp83GgZSUmLHVY=; b=c1dJV1aussKJcL0bM0tHmtI/I5AlZOFbEvQe4U4ffQTnzJgDnwxPerM+U4ymVBwabESTIYYYhryX1BZsCJhf8rlmOtZ+5SKm0gmcHftQjXI4nBvnym3gn/t9HLdZhH5YOsnc70Su5M4SoKZ26f5I/MMUQCNchE3kfgFMOp669Gc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by HK0PR06MB2977.apcprd06.prod.outlook.com (2603:1096:203:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 08:42:26 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 08:42:26 +0000 From: Wan Jiabing To: Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Wan Jiabing Subject: [PATCH 1/4] dmaengine: ep93xx_dma: Remove unneeded ERROR check before clk_put Date: Mon, 16 May 2022 16:41:36 +0800 Message-Id: <20220516084139.8864-2-wanjiabing@vivo.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516084139.8864-1-wanjiabing@vivo.com> References: <20220516084139.8864-1-wanjiabing@vivo.com> X-ClientProxiedBy: HK2PR02CA0143.apcprd02.prod.outlook.com (2603:1096:202:16::27) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11924982-b694-4328-826b-08da3718010c X-MS-TrafficTypeDiagnostic: HK0PR06MB2977:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUZL67Qaj6oAfTTWGXjJYcet0c05bRGbN8JEIY8rhkPdGv7GwbmwqYfBvV8eJMbz8Of9kzflTN9ua7MICeXvU6zh3NI6qpLBb9207MdHOUfdQ6DrGevUsy3sL8HJXtU+H1MP0AY6Jn0qCX6YYnQZLzQsl6X3whOeQGveDM+3VWuouwc8KYAjTfUUVyymIOR9tG576SHgaURVmGLYJdHeSfrMmJapbGoLJn701R4TG3Efh2G8SiGZmq3vU0I3ehJziCLb8W27FhU69SS1W+t247mgLFQ8tQMsGxFj+uIJPNxGhszX9T5w6yHHC+nV1IYPcKvN8WSsygeKjXHPZeku9qmTcQvky3PNRBfyE5Mc27xB/yi6LTQCpRhxvJMM81UbRnQr9Vg8lVGkK+jhXEGixoyKxVyJU+kAmPj7u0xyDmlEEjwkah/jpO9uAvKtXTKhICyC3rNCK9ebQU+6TAqirsYj1uuuzmk+uaCT8jL0dlJNwmMwLgVo3NSGKzvEwnmQhGXB3UvpTDGvp8thmfp45blPddHalAXy2tBKiD0y9OD0JdWMcjvcBBa6HEue+alaaF3Iv6o21+JeEbT0luZDBes3zXQNvh9339SEPVS+ADAiz7JjDEWcmhRIxSipOYf/AHvuH7yKneF0HiCQvL3KYBnZRatgI8ViMFRc4KsQ4z/ne1+DNTf2QTcLo4ddk9Z159CbA8r0XxeSSS3gOSvQCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3367.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(2906002)(38350700002)(38100700002)(83380400001)(316002)(110136005)(52116002)(6512007)(66946007)(1076003)(186003)(6486002)(66556008)(66476007)(4326008)(8676002)(4744005)(5660300002)(508600001)(8936002)(26005)(6506007)(86362001)(36756003)(2616005)(107886003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: p34xn27CEhJvzwOcFVPG4jXwuUuaLbXHnVzGL/L6voYqV8sR0h4JzsUbaH3j9rmHkKFu8XtHpNSxDOVSv+8OZ653cs/iZEQiDUEGcCozrMpd+fXTIAvkg22zE3mS4XCq1+hIz6aj/qnxL/BmFXwKbpZM3BiN9r2mvi9ZISEAiwRk0Bxn+pzhK4konullo/2bm3kYavcmbzmH4a/upAZOsY0NdCs3pgWIanveDO6ueOv0XuRUskFyiSABOmssiFZcqEJYfrjYILkxfqh4k2/LWMVK9Wb2QUqdXd326plnjug/E+Zj/8e7DoXzc/Wjcf8/YcLJd0YdO6XY6J43/ZfE/a88Fp3tiO2RdoLr3HzW4NWR2pdGQg0fMj3cWxaXDipi1rTo1wBZP1kxJGkAifqHmT6m/N0eS92pRwVsZVvwp0ugMIh89eOUKBf/h68n+1VxunkZHenF9z0PrwFE5lnUCTr6nQgxI3/nmJzWWEqO8LxKfd3SbTEunmOQqPA4nQOv+mGj/b0pNq14z+HiGknGjmA+qnwXEwHAstbgT8QXeRwlX+v7x/eDS5INH0ugMRRrovmVFjoZM7FARL0DM3Kn4cPs2mE9E9r1ftAa0nFItxCnVK8fl65+2ENb91zh5pKm0ptnl9/XlP3Ap8+a7XekXWzGtv8kEOyGLbezWnY5KXlANKzqQVxiSU1qvMXbbq+UZrgITiddJD20E7UCHj9q+zBhOIfEbzUMmtZu34lOBzWMA47McMvSnAMSrDM5xsBk/YspbDmm8N29D1JqUdISBTN0ha4V8FKbB88WoZVHjtwUlEpWylepdBwjAin/swPEJ8gJ0dJSl4tBNOSo/9ODmvDynPYfOv27b5UeYuD4ZM8oaZQ7nTOuA5Lrl8K0HGqxpBwSFaJcg7cmDrpzhYVRWMRgwGuX967DPg7QOds2Wz3SCPNMfGA2esylVQQDjCDkE6I13lQFJe0xeJ299xn8F0NgPI37qY43+nAEqUYu/C5fdpkO+4+KtoSPcwoxlG/5MfY9St6Stw2nFMGhe6IDcrhgAD8dFyrdpEDx18er6Mwu+nYxCGujvONq4ZdCV+w2FRQjZjREWiq71uS42Uqk2+jNttHY/A+viqiPOrcSPE9SOTvyAcKDewqMZkH6cZgsddlTPvl2+BlkXMhEJtXR1EAHbKYCIP4Vi+/l+SercbhnsNQfZnd7UjNgLsibV5zkj6WChx4cQqHYsWm5cu3g16zfhkAobcsnvQyrF9bTmnRjC5SkXC+4RkZ0zXAdTcZw4PIl2iGf6fHtS6VYb2Rlc6PLtsOUaTi2/payMsBVS+FTGQqKZMAdS1CALNR6n3rp9Le/uV2VFlK77fAeYS8v5y7H4OmUIlhkLij2D6M6ckQcUrchIYX+99EbkTtESc9XQWs+zcoThqk3Zb3/B7ftXEFCtaPsziPxppoJWKAErWh+p29IHlpfgdocnvYLTSQaGk+cpu8iJBKfyZVIDGScjMT7SkmMmk6e+/lT9UpR7BGS2GB93MHGJHRVwvarxnBRX4Ox1YxEob67sa/z4NUANebqqdTGyCVuchfDM17XhCOiLjinBMwvmrtgj9yHA4Lv4HNGgiONeL3Tcbuh3aNLlyQ1wPrd/0J1DMH88rTipY86hcbU7/CKSk4x80O3dpOUSX7PihCwgZ8AGC4Pvi7ycrPGgySZLawC9zEeq8RD4IufKLZno6wetJKTIwSaMlxHcm3IpzK4ecGTTBtxpSi9Gg== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11924982-b694-4328-826b-08da3718010c X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:42:26.5498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gi6gWbbpyTk+q7rUWA7XjMDvk5salpemoyi9F6aH6u1Ub2Fysbzn5hfLUwbiAcNTCfiuUdasY2K7k7BZbO2Kfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2977 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org clk_put() already uses !clk and IS_ERR(clk) to check ERROR or NULL. Remove unneeded ERROR or NULL check for edmac->clk. Signed-off-by: Wan Jiabing --- drivers/dma/ep93xx_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index 971ff5f9ae84..60dc7b3f3d0d 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -1398,8 +1398,7 @@ static int __init ep93xx_dma_probe(struct platform_device *pdev) if (unlikely(ret)) { for (i = 0; i < edma->num_channels; i++) { struct ep93xx_dma_chan *edmac = &edma->channels[i]; - if (!IS_ERR_OR_NULL(edmac->clk)) - clk_put(edmac->clk); + clk_put(edmac->clk); } kfree(edma); } else { From patchwork Mon May 16 08:41:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiabing Wan X-Patchwork-Id: 12850407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C529C433EF for ; Mon, 16 May 2022 08:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbiEPImp (ORCPT ); Mon, 16 May 2022 04:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241853AbiEPImm (ORCPT ); Mon, 16 May 2022 04:42:42 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2096.outbound.protection.outlook.com [40.107.215.96]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD1BBC05; Mon, 16 May 2022 01:42:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m1tdQjp7qJTIIpZAsOBxjJgUxaiXxpeH9bNcB8kYxYhdqSe1jmxR+VVJIgXgWXiILqoLHc15ioXgefYCcukgXkU6EasZgpwZi1OIOLJL7TJodwkmZ9PyJ9C+mm7YpWYU8WykKOekx9ceEBKYHlTlg33ciJr7CZN7v3KzWVNraMMomZM7Ax1/aggzzkyLFpcIzO5FMU0GzQR6ZhicemugH8459CUaqjoDjVgpn1sYpS4gN09uxyzqgBoXq5DpfpJhaiKm+qE17jbNwf2vTYWemR8Ab86D+NvMg2+FgSD5U9XRhDxnwLQ9syGcH/lKfeyMNBY8UE0/BOMV6RNphFxHPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EnyYYnnPn8Ne/FL30rnVe038b9vuP9C2o08MRu9Uvmc=; b=bSQeq/RTcC57TxW/iaR2rKvkQI71qPB+YUcGqI8A4TxwVzvJRZwjGrF3BqzVA6rNeup5hAHWNAh+8d8YrsdQh1UI3HwXE1KmpVCH4v/MTQ89Z96JN5ng6vqTwVmRWEkYvsPmRdLHsyK0Rikzo8vFp6zWaMKgMU9b3Fz0e6CXs/VBT1VkJ29hkDtCqCY9Ph9gypkMa9KimjtBAHipIdrKX4QzJZe0kbNzrP9OHbsaOhcTdkftQJIZeUkoWE5Ar7vC1O4kW8M3cdQuRZkqh6pead0oQvGlXc0lgqP2xAIyY+wpFQDkrdv+iDSt9rj1HlfcnSX9pcFAlmU63mE2DqN+Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnyYYnnPn8Ne/FL30rnVe038b9vuP9C2o08MRu9Uvmc=; b=I90CwfE+4rHq4gFZjX4HSRk5fA2KHoUlkhkD1OB3jbMVpSXRbsRiFYH2pYyNk4fKLvWvu0rT1xNLwEPN2D1S8CK8gkb1AvnDh4e+AwEFnwwqenOx5rdBaXPa+QrqI4UZh4QOJa7O6YVH7/2QHVqgvuv3eTwEs6DfxVD+FJh+b8g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by HK0PR06MB2977.apcprd06.prod.outlook.com (2603:1096:203:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 08:42:29 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 08:42:29 +0000 From: Wan Jiabing To: Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Wan Jiabing Subject: [PATCH 2/4] dmaengine: sprd-dma: Remove unneeded ERROR check before clk_disable_unprepare Date: Mon, 16 May 2022 16:41:37 +0800 Message-Id: <20220516084139.8864-3-wanjiabing@vivo.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516084139.8864-1-wanjiabing@vivo.com> References: <20220516084139.8864-1-wanjiabing@vivo.com> X-ClientProxiedBy: HK2PR02CA0143.apcprd02.prod.outlook.com (2603:1096:202:16::27) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c54c36c2-f165-4437-5028-08da371802e9 X-MS-TrafficTypeDiagnostic: HK0PR06MB2977:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e0hxjS04R7H8YTfbxUGohwyUUlWeT4khR8nqwZR1BoP86y++sjvW6X//vX7Vu0gkrz3vORIq396tzNTdeSY4MddYxOfsZ+TSXkd3Y1y8VrZVW6YlRZG0EJTmveyuSlJJ2yDE/UaVgBuWQcPg0aR0Do/1+3ELde+K478355CkHYpSIifwsqhnEaM5NS6Mwnbtd0VqHJqBtownO0eLXEGipCwAYjIgNVCwTQt2XfeU2GKwC/c9uqKzhINSL2p2EIq5jSV3jFc+b0R7Cky4LNv7/IG+hp9kOsat5JmjtTTVouo7lDnU35E7nISwKF4QO9k1zMEal9oRVCtTvOGnnLcw20h//d9avPLG2DI+sK1RSsiydJKlQp6GETlA52KqAAXDslyuXOP0hRXO6EYYWpdM6iEWKLunU/jJv3nZXy4XIqfmkNjl5MMshF4lmNth+GtxKKsTulbMnAEH0rqdqXRIdLskjCcS6hB3nND852CSBqEHmWq/MBrlCmy2Dh+jxsj19tqWltsm/n1ul3udnTEWImNMTON0lmdhm0qMdSY3Zj5SnFKK+jEIIrenwJ772t2uAo4QsRk1st0L+uGQyHt9w/AaN6+Irihk858UGhBPYreZSwROERLobjBxuww20ckM8nQTJPg/ssjJjRkxIZxkItpvRmwwuE009T7pXDotl1b9dSh7U9n2gnVcohm/R5hqABvknoyaxYdoNRdp5HCUBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3367.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(2906002)(38350700002)(38100700002)(83380400001)(316002)(110136005)(52116002)(6512007)(66946007)(1076003)(186003)(6486002)(66556008)(66476007)(4326008)(8676002)(4744005)(5660300002)(508600001)(8936002)(26005)(6506007)(86362001)(36756003)(2616005)(107886003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uj+WCdy1U/wIRlfQlN16POanJ48JXVuOTcuo5k5gEE4fbvzyNpsKe/RKGutTCBS8hUg1pmIrz2x38awSU02gmfvNmYQy0O6UkCC6lxR5jdtmSCjGyGeM39N6GDYXaLdN1ugR1/7iZgHUiqKCJL0hf/ukJnRyd7O96zxMlh/a/cZ/n7NaHUkGuQCpFm2LNIFFb2oKvL2SgIfDM8emAINe+7JJfiT4wnuJ1hNLz/4smVCbR1SuN2BMu75we2J36F/xu6N9IlliBVZYZ6MzShus3lI67D84/v5wDAi/akqpWsjPj7hYKTeHuAwgQtdGCW+WVHx0S5JMIVt61pwnj1nUNX3QBM9ckRrl3qBj95T3qBCwiQULOjNFenOCwrPT5+v91aSEGa25v14tR+h8+uODY3e6Kb7oLuIAos2ihrEYgKBW8xeOVcTSBFsD/w+WaYz0tzVh1fPXRMlII3ize7yf1Lxp0D/ddBtwrUHLW1pGoM4fIeer87om+CYbk+ffaJvOGDMJNE2DhMOBPilRtXsCIg7rtRDtsvHMHMVEKoGtliPWl5gR3GH9+zuOUeSnJGop/g4OSNrz3Tzll4PLmuzA8fAuH4WNUFNPGx7HHA4XDAK2s2LjuKaJOPYWqFg6WGkzAxDbqrB+yTO4todQP7sqr/5d6RabMvZPtCEvVCajcdBZZ7HZ2jheeMr1JtY0TES15D/aFV1eqxz+Dk0D5i3jyWEIbwNGWWh8+LxDAGr1tZXVnjLiO00u1jKcf5TrYY0rcjR93B/9Iixfa6+cAqJRjc2TScAIJ5XLpkBoabacPyAXiqkfes22N1S9rbIKcYfDu822ERoeIHSc6zag3D+p17q9sy9cJPWr3nXM3aA3YNRnGgY94mHKgV5Bm/VDRjrg7AWghkth2c1xzh1PLQ6opJD8y0IqGKcPSvWcMwGxbcIIvdzPCTwBfQM9oTPHmY0a3SKx0/pQRiRkTxB/slkjHk9LO338HTmbvsSngn9pLf91V2ylwYdzsKtx8RRo7Gz0e9wp7Hfs9qlPW7YvGrzoX6YwmfzDRmhYt1jySIRtJ7Cafb1Ia81/N0S9u851tYwmaM2WCgiv0hfWHXEP/23jHRWOi2jK8DCb9dK1LZi+Dtzsb/Bbds5j5saqYACyalJdxymlEa71H/Kz8pa5sN+SJ1p+0qyFwslsZ4kA9nbC6WZgUFZcy6T/SNYZMRBcNcjdq7kp90SzNxnLbCQAnnyGFdB4FFuZFG0Ixn7WVUCrGkl3l9cUk4Y2QPJ8LnEieNvM/pstWSRTWKwr8+tgaQ66YggTQ2kEWZrFdFIQVR6gMUzqAO3n3UiW63w22Va3m4Cia6CuCboKdIOBWfzNCMGWDdEcflvHHctm/yHgw06UvZmAV8EUsF0GVddEnErW8GJbtNSVjA4QoR4Z7KTdEdZ3QVG0yO1hOhcZXsu6aCUq2IkFR5ukabVSEHNfwhGtdmsTzGkhUol0+Ltrko0Agu0G/4ozpdq5wc8Gp3EQ7rV0fO+3JZxdUiPxgyYhg6HQoDsHHQeoce0uHvV1qAe1by7OPvMOrtedtBz8OZpgeyVd42bnfKjw2xeVPW1Q5C9HSb6qlOqbPCXwpF0sHlmF6Qvvj/N5cpEI+NlOT14O2NDsPvmKZ/anV7i+dA3rWKqjcev2mVvI016zrlBId2slSrcbWa5QeiJ7GrAEuzfalAmsJkc0V4rjSfphYmbCDw0VXzmSwvNjywzbuh8nv7t1/3sAjw== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c54c36c2-f165-4437-5028-08da371802e9 X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:42:29.7527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: msFshjehFkNTVXYViAgbDA/6+05DK7oP6Z6gd8g50lWuXqFP+GnJgKbZcACwV4INpPm6DJXxcZ9MLjMFVyIxZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2977 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. Remove unneeded ERROR check for sdev->ashb_clk. Signed-off-by: Wan Jiabing Reviewed-by: Krzysztof Kozlowski --- drivers/dma/sprd-dma.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 7f158ef5672d..bf5ad879b5e2 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -279,12 +279,7 @@ static int sprd_dma_enable(struct sprd_dma_dev *sdev) static void sprd_dma_disable(struct sprd_dma_dev *sdev) { clk_disable_unprepare(sdev->clk); - - /* - * Need to check if we need disable the optional ashb_clk for AGCP DMA. - */ - if (!IS_ERR(sdev->ashb_clk)) - clk_disable_unprepare(sdev->ashb_clk); + clk_disable_unprepare(sdev->ashb_clk); } static void sprd_dma_set_uid(struct sprd_dma_chn *schan) From patchwork Mon May 16 08:41:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiabing Wan X-Patchwork-Id: 12850410 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D82C433F5 for ; Mon, 16 May 2022 08:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241991AbiEPInH (ORCPT ); Mon, 16 May 2022 04:43:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241911AbiEPImn (ORCPT ); Mon, 16 May 2022 04:42:43 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2096.outbound.protection.outlook.com [40.107.215.96]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFC3FBE3E; Mon, 16 May 2022 01:42:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BmVcXp/3fNlOPIuAQO7BnmGxGurnorCq+du3GUgnZwvbzfRkycnIyLYB4SwJZrjGJRepWnB1oropTIBOy902YX4AyvhFSDCiaw/fsryepNT207n9gojoO23xP+s1xQdSjsyx4a3w8V07AudQvGss9lWUeCZSdSHWy9zUeJd6C8Xquy6EYgNbpGXqicvTOwpEPNMOHnubDs3Xm/CfBecew6R+k1GlSF3D+4rtw/k3+H+WrvmSisbAgcrcGNzKJa1eg5Jl0lj8TwZSOI5fjED9pzqp4M97Ghlk1dDgphkTzfy913msentLaZm3Rpo/J+s+6Y1NO6z/a2Q7bNbOR3NFXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eJdRUJyYLg08dI884eNAPRNvcq/zODGnc3rdagTwgDY=; b=J8kLpkSkz4IH0JlL7tL+s6XiKt/AWutcKHrp+OQDYpaAm2cmo7J/TJD0KXSxcQvjqMA/n1sn2B3LAJ6F3YoDyJJDaeMURUcojTjBRW7LDzYVsS997hWcitJQZ1fewbgzT22EwulwIEWyPi7L67DMGnXWj5rvHa/OKaxYcL63LPYK/QeXXiu1osDHXReN5dqdAIIkITBzDCllvyEXpNrQLpnqARRB4QpK2LT6U7eGED5/bPvUHTabV4Wr72gknIcRDerjedVt6gpJB78mnCrBydAKlY6wYpDvYadUODCRJauBzaZgxsAloYh5hzp/Is3zPgOGjGp8ttgBVVD80Jckuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJdRUJyYLg08dI884eNAPRNvcq/zODGnc3rdagTwgDY=; b=Xd4md8sAwmUT6c95P391xURIangMSOR9ZdEF19Tf5nPSHV5xwDGBQEY5uXQN5B56k3l4YHUflQQtwXPIGHw8pqp+6JSHbC0gGmbtx72nT8wkGlsTOBnk5oCU4oM6dG8FWwYjWJENFoQp5svHlo/hNBLajtoea7e8xVVr9RhvUaY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by HK0PR06MB2977.apcprd06.prod.outlook.com (2603:1096:203:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 08:42:32 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 08:42:32 +0000 From: Wan Jiabing To: Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Wan Jiabing Subject: [PATCH 3/4] dmaengine: ste_dma40: Remove unneeded ERROR and NULL check in ste_dma40 Date: Mon, 16 May 2022 16:41:38 +0800 Message-Id: <20220516084139.8864-4-wanjiabing@vivo.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516084139.8864-1-wanjiabing@vivo.com> References: <20220516084139.8864-1-wanjiabing@vivo.com> X-ClientProxiedBy: HK2PR02CA0143.apcprd02.prod.outlook.com (2603:1096:202:16::27) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 219dc012-4690-4794-0f67-08da37180475 X-MS-TrafficTypeDiagnostic: HK0PR06MB2977:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XA4+Jpye9Fa0ZLNmm5e/LcUvylhBQrOQrRuVYgw38FM3qUenMH8q0QSISFmmpTdVmNHhCgpxIOPjCScs61IOSMltcmzEka/1vTJxgwF6WP7j5HA3whQ0qkQTR+YCGyFFTHXlNJlRmW5IVFoKY+rlhOalOicemRYclYJzKdBr508MB850RasQ84ZJRuJPa+bJRuQNgtPfCcJpstbBiyns9ZYQSbRXl9YbK8mYFSLYL5dSHIlPmzXiRb0QatoragUw+GAzG0+8XpijhqD6SCvN5cRZnzNrYCwLcCrpNNde1TPVo32lhVX5FQgD9N8qkuvGP2IkKQ9gB5YVF8zLzHmwsSH7on/b0xEO8pVvC9bbZHLeOXAEskHt9OF+uOKoSfxtTB6iV+z20hojhN5CgDn5H2MYYftpXSM0baI0NzSRPdj34K9kH/3bvp9xBu40xXKvAiCgHtZAIfR6Q10W87HdKAJc+QxF3RUeJc6lEUyJiaDEHacf4ivzvLjHAvJFE1bY4kN0Y5Y5z8/lE4ZEkV852MlQCIAeVGu2Uv9nLrB4X5y2teq6yA0+R1sH+WrB6b61hg9GUYXAmCo5kdgf6Nwn+OSblChvT9UKSD3u99WccC4I6eoexRQ/md+kWsth6c1zJb7h8tRT1FYBXHmwIlmlRwFdwT545sy9cgc9yCIJq3wWzM6US0pyHNKz4wvLpOAxQ6snc07FBGfiloew02p74Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3367.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(38350700002)(38100700002)(83380400001)(316002)(110136005)(52116002)(6512007)(66946007)(1076003)(186003)(6486002)(66556008)(66476007)(4326008)(8676002)(5660300002)(508600001)(8936002)(26005)(6506007)(86362001)(36756003)(2616005)(107886003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DGcx2LJEOVjNSKvkIb6xoPAqS7UsbxiZFLssEhYnlsxkZR87G0fSJU1CBIqXhU8LcrpmAdQfgpBzKs6bO1swbE9b7j4XAQlfMPVcgZfd+T3Ast9ASGeIc+0zZ9kKlvzg00pNvdT+PIlTRKhpnh6kEcm7fWlIR1BqpLnfeLzKx2+aI6QFjLFnqN2nf1dOobMzv9MH0rYYOOTulTTdN6jTknTuqgU9O9jCOsAQuHAJiNPk6IkiuiNApqCcjhU3X8u+tNXPTN3lrwC7B/QuGKUeune0xJiQBdqSUvRhVCai2JssstiynkUdE2DIaWDDHbvvT5dfglIghOtKKqgEO5qJJL03LzGfOh7ASUNMfak/MdU057rJwO6DlduPusce9NxmYlDW9QxrVDJVIEs8gkzxaDi/4Ro6sQ5y1fl8kzMoQO24tQFJsi22Oes45ifuDM+b/PAgFZTesqh7NV3VmEDA2cR+/LyELcx+V5LwuiLjV5XlTNbXZUiA2i2Owrq0/rYD0RrTLNBApfD3izyUeSiMJxwiXbWoenY4xSUwmiNcxg9U5bo3E1hJuniTcin8ZBBcEPGL+d5IxfNTUKQ2gy6yHZs9Epff4h2F+6fTcF8hXzmYsIAJDJMAFyQLL/OLJpH+bKY3/9idFS4M0l0utdCMMBd2OHKNkJn8vlVy8Y+elsc5WO+njz1oV5eqAUwqIdhey/9X0ehLolVzFNHhhgwaAJomJguDIixqMfr+aP5XeA6Yz5bU7VZyP0pf8r5qeXVzRfHz/MYctsN2aiZo1rfWoSpXsudJJlsVtsFwAUtDIdOJ71qslqnsaZoZfkP/G3TkByib6W+01e4Y2zoVKqwGvmNXXiMBoANpDCImoec0xAjKBArzS/gXOmXztOxtpiJ7cNN25nURwKWTzEzlCPgw30s3fnaFvbb1YW0npyrlaYDAtpDG/tLbtzPNUJ2Rsmz0AF9T19c2fB1Qik3qv9hKkad+4ntFvdHi+kgd464+d4T2iNuHL5GWLpNqaSyQxhWb0STADgSpk5M0lYI7w8kGeeTiMv5QF8FJ7VJzJ+aB9Nvo17bkhw6GscMdgBe/SobbrFNPtXcMXcwBUyDViMm/2JgRq3wcW+mLFn6Mu23taJStyjQB/2HEdk3WPswZDu9CzufAz3MXKJ5DiIUNadAw9Td4fiff/23TkIgpquXt1SdO6Snts4KOau4lqQvoh5cQ8b5bK+f58cgS2pT4/rzFQxkRzN38nTwuWPAprdtxkcrieR3zHTy4vXi8fNXLq9YG/TGGBSVwvVXuL7ffnL+GeaOsHPzQYp0PH+ODoAZI6VdYlaMmNfp06I1eP7F119ubSmgJOE3SaoYfLwZoIjFzhJSPkTYnxm66e4PCIf249eyDEgEl1havo2dsGv/Z4m8RcVhKQ/BOA/DZO1rtj+J6jQhG3a4jK9XT7spNpPokTimlNuI3e2I10SUneH11Q8syiQblIuyHc0+Esa9ZUBKTxNjg66YYFDxJeE3SQ7cSbwIXne6LdEVqxWXLt/UULLqbWzhHk6lMz04nUnsspRGh4+W/N9s714OHhxugchgDTMh/EzHEtWakjrd7/FaFWqLVzsa9qWtRFimv/GG+A8QnEmBAeuZBfq8cMWdEpbhEPIupaJluYus4LDRNvDoHQ9IltCdr84hKM5OvLojeZ0ojoISvf5Sw4vw7DvSJDgJuz+Tz8jEfz0dm4ag7CgmqrWFbolT2GsLUvgygcmHenZE/mQ== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 219dc012-4690-4794-0f67-08da37180475 X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:42:32.1900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZivrUyBmm+lqWEf5fnjPRmPhlBWUJszsJW4fcJSxLSf7UT96hQkqByyW756a357EeIpJQvBD0NuqasmmODpUwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2977 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org clk_put() already checks ERROR by using IS_ERR. clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL. Remove unneeded NULL check for clk_ret and ERROR check for clk. Signed-off-by: Wan Jiabing --- drivers/dma/ste_dma40.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index e1827393143f..7d1bf4ae4495 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3119,7 +3119,7 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev) clk = clk_get(&pdev->dev, NULL); if (IS_ERR(clk)) { d40_err(&pdev->dev, "No matching clock found\n"); - goto check_prepare_enabled; + goto disable_unprepare; } clk_ret = clk_prepare_enable(clk); @@ -3305,12 +3305,10 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev) iounmap(virtbase); release_region: release_mem_region(res->start, resource_size(res)); - check_prepare_enabled: - if (!clk_ret) disable_unprepare: - clk_disable_unprepare(clk); - if (!IS_ERR(clk)) - clk_put(clk); + clk_disable_unprepare(clk); + clk_put(clk); + return NULL; } From patchwork Mon May 16 08:41:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiabing Wan X-Patchwork-Id: 12850409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537A7C433F5 for ; Mon, 16 May 2022 08:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241951AbiEPImw (ORCPT ); Mon, 16 May 2022 04:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241917AbiEPImn (ORCPT ); Mon, 16 May 2022 04:42:43 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2096.outbound.protection.outlook.com [40.107.215.96]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777E3E09E; Mon, 16 May 2022 01:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0vVbbkL4f14Aac+GNShj8zy2uKWHpxyzAAGxgEP6yBvPxk9uRdgIJZepR9+CwSWEql7zCcl6VbPgezE+gnLeSAlzOGaTpvsteoUCnVc58UJQoeLFsWf86DTWxpVMUgh7KstF18XSML9loCOFwmqALt9WCR+5b0ua+TxbE6wRA2DEu5hFVF3RL+/S1zQ61J6EOfvJUo8tIv40+sFDehhSaVQeUAORyomI/quTmYDi+cLyCvz0tU+CZuOULugTWjzHv94yXClj6I1k6GSggIRq44p1hkQlyTwPShLPnqZ3tOy9yG/Yqyp/iKANPr6up5PbYgO1GHxcuWzbee2YlKSLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gXNEXCszyK1k1ab9hq0q1ucGzPn4mrmbmlx1iDS71fk=; b=Bo+goWztaXz7IedzrwByJtUs5WZl+JEGa3WUcT8iIq/uXKsVYdaC7pkOUPCe22ehWdpxCPZVEnD0NuXLEi6a4usPPOrw1twS540halSNFV+/+XyFnuXJAJtxHQE6u81uRfyH0nOCGbGum4SKH2St8dxdtLjcqxc60ctqvBPmnEfq4TXVqaFIFEv+j5Bnv81+pzEoaFi5m4F2WSDvYi8cQLa5g7NSzOygPWdpznLobhB7Z3/k2Yto0vSI3hcBrqUHehfdnWgf/kyYUzMUQZIlwDALtH1LT/ZbU2pmNifsWe8Em1UtyxFWd4OWxG1a8SUaoOQaa/EEf9RHzEw2DAXNdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXNEXCszyK1k1ab9hq0q1ucGzPn4mrmbmlx1iDS71fk=; b=gzysEHfEk5EXm+Vh3V2DBbWqC5YOAJ18dVTX7HFiL6rkXEkhGtz0VCgk8my5kDujAkAkjr2k6r1Wc9EEbodk17kN1MGVNcafHkwLLG908YCz11FfcLriyhpU4WGVFnsBpH2oJJfhxFoBBN67706cflRkQBBiH3x4ewqDQ3k/ltE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by HK0PR06MB2977.apcprd06.prod.outlook.com (2603:1096:203:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 08:42:34 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 08:42:34 +0000 From: Wan Jiabing To: Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Wan Jiabing Subject: [PATCH 4/4] dmaengine: xgene-dma: Remove unneeded ERROR check before clk_disable_unprepare Date: Mon, 16 May 2022 16:41:39 +0800 Message-Id: <20220516084139.8864-5-wanjiabing@vivo.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516084139.8864-1-wanjiabing@vivo.com> References: <20220516084139.8864-1-wanjiabing@vivo.com> X-ClientProxiedBy: HK2PR02CA0143.apcprd02.prod.outlook.com (2603:1096:202:16::27) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20cd911d-4537-47f3-7050-08da371805c0 X-MS-TrafficTypeDiagnostic: HK0PR06MB2977:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /0ELUy40NiaQaE79smYmlhhQNh+vxfoZnCE79QVbG1mQrlJcz1NYatnw7a50jH4DKOnhxJxAZgaL+omipYJAYEzsaMKRcXvwrbOEBuqvI6P526Wh8XEDQ5O55p9rSOQcGn4IkxeE5CSN1Mh1lpuZHWc47GHqIh4P/mxID0BZ1NNwX4Wbs7J3d8RDGVoGNzJqx0tAGUiA+gkLPQuBnKMTR3ciUCpmSojqzvEBZzETv9Zx7DVgK/cQWxEGQhDFoCZ9QczKr/KzourmQmTwqg/JXIWsuKwM4XzndwqOlrLTs61oBiLE4V6+X34JfDgSh9Xr4lnHO3KtITHPdk+/ku+UJWPLlHGO+V6jtW50Z9cSds35iklcNyShCFX2CbJf74gv1qwuNrioUuuOEsR9Plf5zMSrZbGSx8vYQEyJNrnSLa0x61nrjz7rp0+2sRIkcHww4sDIwLdk9QBcXtpixWZyTbykjgAwzyo2PRA8dkNpRhINT1I1w9SF0uB17dskLlEuDENCKB42x8+o1KvvBlk65PHj3Qqlmy0OT4+2a4lEPAV6KA+dBvvVVgwsuobTkqM7qauE9z+bQfhN5O6e0f49qYZACcR5XkqdTv1xcz/FdQKSCpNNTJ2BYOlopV0UAsGN5IA1TRdwgHJ2fsvl4fMQiHs/lOXHwBrCdIctTRTmHUzUajgjDVvvcWOP6CnsFpl+W+z2rO2SHzMhupX4/5MKJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3367.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(38350700002)(38100700002)(83380400001)(316002)(110136005)(52116002)(6512007)(66946007)(1076003)(186003)(6486002)(66556008)(66476007)(4326008)(8676002)(4744005)(5660300002)(508600001)(8936002)(26005)(6506007)(86362001)(36756003)(2616005)(107886003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JUfll+W0zoQF9O64Y0HfuJsprIzgH6mPX7efi1H0oYzsQU955xosbqToKbRKmKT8WyQpKFMmBCBzFWUb0yPqDg+g1HIB9o787w6Eu7U0tw7DcZSFoBu8pnKYtaHfQCZH3y49stvIy8gZPMYlR/hSvfkzzi3S6m2BXNTaoDhj3iRLSzJCrXuYaVz3TG9TFrTnpAd/v9rsRKXVw5g2AR31WJkjM+ejvjNgtoopQZCrjcX7jNDOKYDHpu7TPgjeVc+jPgSTCYrVzNgqvy4gEsc5t4FbzWiBEeEMjYU4X27dyjmILntUCbiW0wAhix2jPa2iAHXJA3cR+q8wnsqq1B7prdl26JJq77y3ROgHoNkYBMCqVC47c5Z97Q6ekbpnlx0wdQwJHlBClU/aVTLnCgCjJGOuQFsVkL4S0mBoof/3ofiDTRKQdi2S4oWgSYZ5ou7spmqR/t8aAYq/ZAi7+n9kUbPSTY2BecADRFW4XG/TdhW3ZkxUfvHATzx4FsUl30h5pfD9lmrAw85yhn5hmFhgS9vLE+WsrRUVT/kWpxCg3F1gy+RqnO5sdJMfZoB/ZcW72PcLXxj9mc1J1fVthZ4o5ItRr6h/ypAqUcfLb68JjL961gIy2yeIOGkzL0FDLaSuJYcimzBCWPIM6Ss4c2Kp5FHThmq4PiBw4L2rnPN49PWvfjEqMpcgrzr3ijQ5+Axv4vHqa1BwLHV17c9AWn2S1gG8g+MdHzcKKZAqvHsG8WNQGHUWseHX5d0udtod1I22RNqVrZtC8ttaSksVME6lmyfzRauBLg1gUN28wqN16fRu3MUTsdmY6NutCeeLokb+qLxBtrssc1CkrP5kUqHvfWnUb3zD5jJZ/Yrj647kNrAbyZxg+e/2nS0WPnWr7ti1t8Sak2WaH/hajkM/vgwVGXffNyFWRco6GBZLuu/1UAQ1yYpacHr3vG/oUUoDM7VvNwu3w/27d7uGondowIlQzUVNbWPn2OxDMkMIHb7aXTgVtlho9ZfWx9CWAfv1wPlCoyrUiep6xtbg77IfuaTlS/SLtS/cgegAf5TAAF/hNnvZPbqbCkgBpeBxz56dqyMUuasVoMJFzyNkzAJqK71y/BK3hpnUUL8CnC4kfhKF67Ip+IWJeElUeH0Zxh6vyPOtWU5O37ZDGGzik+fsJ9muYuvaKZPkueKTZ2D1plkPlD7/WYnqcQ6bKDCcRP3OEnf1cgLmxBWFskpv2W2rU+BF9ltcLV6fqGZYAZAbTZtxjq2SnMl+ZCkHZMQc+2u/AnIqmBn9GPcIwk37ibhyvkW40z3GAMagPq9Hiz0orin3tKeRJI+wsITa+MZs6ILPS0Qg2rx25w20QYHK8ugWYaj/zsitnfJvcCooQA1UVaH/dY1JZ4XppME3k6U3wNoEVUQPnoRfF3GS+5Ter9YEsgS5UiVO3er0floILV+B26r2opp/Kfk6TqzJ35hyFJnKSfyMDb6AVChmUTw9S7LAdeKAVT3WIGHrQtGcXdceY6lb8kSyO/LC+N03dGE8dqau7QuyLb5wdHz2+Z5G4BpMflVem+jCqx6TRk/ams0MARlcB6LI30tvX8y7e9Fl+Y4OyOTb+AJZjTTyNHAHuihuZADo4YTnXLFMl/iTyUAZI+/QlpmqvRnOrpjaTx4KIEPDtRwGSdgHafhfubaP35DPhLv3VjIhITSzpIaa51pia/eZk85GDjMsY7zrmvYSOihsMPao6CG2v/nM7Vx1BZL3yvAXiQ== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20cd911d-4537-47f3-7050-08da371805c0 X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:42:34.3774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OaGqYM1UUaw9lbx5Uex7MEmkaGoLLuxFze3ahjaSu0T1QA70VTZUY4A4A63fbl6+k+iR5bT6J/omBqZDnyEOrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2977 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. Remove unneeded ERROR check for pdma->clk. Signed-off-by: Wan Jiabing --- drivers/dma/xgene-dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c index 3589b4ef50b8..7f0088b09714 100644 --- a/drivers/dma/xgene-dma.c +++ b/drivers/dma/xgene-dma.c @@ -1769,8 +1769,7 @@ static int xgene_dma_probe(struct platform_device *pdev) err_dma_mask: err_clk_enable: - if (!IS_ERR(pdma->clk)) - clk_disable_unprepare(pdma->clk); + clk_disable_unprepare(pdma->clk); return ret; } @@ -1794,8 +1793,7 @@ static int xgene_dma_remove(struct platform_device *pdev) xgene_dma_delete_chan_rings(chan); } - if (!IS_ERR(pdma->clk)) - clk_disable_unprepare(pdma->clk); + clk_disable_unprepare(pdma->clk); return 0; }