From patchwork Wed Jan 9 18:00:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 10754747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A9F56C2 for ; Wed, 9 Jan 2019 18:00:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D2CC29222 for ; Wed, 9 Jan 2019 18:00:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 700EC2922A; Wed, 9 Jan 2019 18:00:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 259CA29222 for ; Wed, 9 Jan 2019 18:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Kc7/IyKXYK/kYmIg3D/OPbGX4KAEKmq12Ut+GwwTnu0=; b=PyyAcocTHlvAr1 lmdc9hVa8WmP0QGG0snevjQeJ1D3mDjEAHLlsCvV0Fv7UXVqaP9CxAdhy4SvHLcUw69pE3KGXEerM vcngYRCRrswNIDHlYkiCmA8o9kt1jPBb4LPXoNMlguFTMluagn7Km6UHH1rhEYHy0dT2iz0inYRHU ac8ApRGMV2j3Ncm+83sFxMWT1CNm9IdvaQwFnZVf7nkXdVJZcg1ltkcOZw3SGMg2O1AbIqffz8wWA lgQiqhw0m+5dhczLyARSoZRA5Rltdoe5LB+GpYRpooeyu9gwTJF6yrWX92EoBOqfGXK6WIZzEnk8+ 4jCQ2UfDXhCx6wb1uaDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghI9v-0006kN-9E; Wed, 09 Jan 2019 18:00:55 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghI9s-0006jq-OA for linux-arm-kernel@lists.infradead.org; Wed, 09 Jan 2019 18:00:54 +0000 Received: by mail-lf1-x141.google.com with SMTP id y11so6328849lfj.4 for ; Wed, 09 Jan 2019 10:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f/Exw1NcVYYqGrDV4q3XAZMtf+t2lHH10SHKVIs+s0M=; b=nN3l1YHTwyNvgXU5aHouPLyz5RKleujjsUrUQZNpon475ZWiOOpJhVfzvr8J8jmsyo 4J80CT+b2kpk0JndsiBspEE2vT08vfhyAM8SZVxkeRTpqrE+fZI3qhAHWCyeCLZZXdw7 HJuNtqnIKTOJiT+q1ZvS0vh87pBnDs8B2HWKr462Hk/xGzwy7gVb+C6tqI2j0rBi1BwK 2WQu75lAirxUOH+Vwvou68ojYlRqFHKaRzPSJ4gRa5+5rj7DyoRX7yhttS/3hO/qz6dP LTPlb/LnyO6SwXkP2Xp3VgG7tsmX97plEXlJHE56QAbKQ+w2O0qvTtVSWndptRT4KCuF K4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f/Exw1NcVYYqGrDV4q3XAZMtf+t2lHH10SHKVIs+s0M=; b=Y0T3xX/5mUPQd9ilD1rVhovRK3PpbdKN89skJTMdSs+KnY42sAJc6x3G4nzbyWEvqk 9Ce4+gppq3KdjS3fs6ANK20o7m9lhiNlrYCXsXOppNUPHYg9uZi+HPpzKYIYDkYbk8u8 JcKwAfLTPa28Jnk+s9T5FAUvjtIl6tQldEvwE4Vo9ASkuPZ//YHTRQDkLjPIasoyPhEK AG2JlTfnv9ymzTwyf+r9vUBNkAgo+enTpI9meOjoofFcc+Ja9GpO+VrviomcweCctDzz JGzcdw/2JbeJwyvAVv52jgx0EhjFqqAwP+D6MXh7BTCoUJ83QElPJFPv34LTeE6LsZ9+ HwTg== X-Gm-Message-State: AJcUukeQ989ev1997exiHH7kvlgrk0RuOOgAr3sAWyLt5o/HMjzoJkJ6 nMcl6HBageR7QFNC+CWoZZY= X-Google-Smtp-Source: ALg8bN5fQjwNwyGqcTdgDv8HuAV34HEznubOvmzRp6xS1BVxGJxxbr7M5qR87k+TaO5am3Uy05NqNQ== X-Received: by 2002:a19:660a:: with SMTP id a10mr4350637lfc.146.1547056847286; Wed, 09 Jan 2019 10:00:47 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:c1c3:bc43:64cd:2432]) by smtp.googlemail.com with ESMTPSA id p67sm13817510lfe.14.2019.01.09.10.00.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 10:00:46 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: andrzej.p@samsung.com Subject: [PATCH] media: s5p-jpeg: Correct step and max values for V4L2_CID_JPEG_RESTART_INTERVAL Date: Wed, 9 Jan 2019 19:00:41 +0100 Message-Id: <20190109180041.31052-1-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_100052_813793_C7E40548 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-kernel@vger.kernel.org, jacek.anaszewski@gmail.com, s.nawrocki@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This commit corrects max and step values for v4l2 control for V4L2_CID_JPEG_RESTART_INTERVAL. Max should be 0xffff and step should be 1. It was found by using v4l2-compliance tool and checking result of VIDIOC_QUERY_EXT_CTRL/QUERYMENU test. Previously it was complaining that step was bigger than difference between max and min. Fixes: 15f4bc3b1f42 ("[media] s5p-jpeg: Add JPEG controls support") Signed-off-by: Paweł Chmiel Reviewed-by: Jacek Anaszewski Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 3f9000b70385..33e9927db9a0 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c @@ -2002,7 +2002,7 @@ static int s5p_jpeg_controls_create(struct s5p_jpeg_ctx *ctx) v4l2_ctrl_new_std(&ctx->ctrl_handler, &s5p_jpeg_ctrl_ops, V4L2_CID_JPEG_RESTART_INTERVAL, - 0, 3, 0xffff, 0); + 0, 0xffff, 1, 0); if (ctx->jpeg->variant->version == SJPEG_S5P) mask = ~0x06; /* 422, 420 */ }