From patchwork Fri May 20 18:45:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 12857335 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314ADC433F5 for ; Fri, 20 May 2022 18:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352950AbiETSrf (ORCPT ); Fri, 20 May 2022 14:47:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352935AbiETSrd (ORCPT ); Fri, 20 May 2022 14:47:33 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC329132751 for ; Fri, 20 May 2022 11:47:32 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id s7dFnjjoIFl1es7dQnBCYZ; Fri, 20 May 2022 18:46:01 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=6287e1e9 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=GTDKvHI3U8AOy6iqAGgA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Date: Fri, 20 May 2022 13:45:25 -0500 Message-Id: <20220520184528.4078-2-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520184528.4078-1-Larry.Finger@lwfinger.net> References: <20220520184528.4078-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfB2BPp870NwGJvhiDPgUVrf3PKe8iiv09QDltWJb6pg296in77esuLV70Nkldy2hSG13RonDyFn4viiAlDnYIaBs+uqJWytwGQXZfzfzU6ShtOwJ2tB7 neoes8Yth4Ij8zc7xLUUpw2c4FauQ4srUN4m9VRrPF68qL3SslGpBafdmBF0JkdSV6PAsWR70S6VVPwWyu4AGbUmJ5fY9UEI3YlK11uU4KIhaQTC8KvMqtM7 gbfhqcKeWkNUItKwyXokhuX+npdaLDyIOP4E2e4ucSXvGlBCMiadFTDC3+EOt+uR5CsZHrqtjazAtFENx5MshADaS1dgmrthO6++/FUQfF9JnYJv4l2HbIPP gHl5Vhi99hwbxCN7xCyC7uIvJIYx96IoU4YHWoiZQROQul2yUD0= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse lists the following for rtw88: CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c index dccd722b8e62..60c4e75df035 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = { [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0}, }; -struct rtw_chip_info rtw8822b_hw_spec = { +static struct rtw_chip_info rtw8822b_hw_spec = { .ops = &rtw8822b_ops, .id = RTW_CHIP_TYPE_8822B, .fw_name = "rtw88/rtw8822b_fw.bin", From patchwork Fri May 20 18:45:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 12857336 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A999C433F5 for ; Fri, 20 May 2022 18:47:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352935AbiETSro (ORCPT ); Fri, 20 May 2022 14:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343778AbiETSrn (ORCPT ); Fri, 20 May 2022 14:47:43 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8EE0132A20 for ; Fri, 20 May 2022 11:47:42 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id s7dFnjjoIFl1es7dbnBCac; Fri, 20 May 2022 18:46:11 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=6287e1f3 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=FdcD7zexmCKM3xszi1wA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c Date: Fri, 20 May 2022 13:45:26 -0500 Message-Id: <20220520184528.4078-3-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520184528.4078-1-Larry.Finger@lwfinger.net> References: <20220520184528.4078-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfBt3kk4i6IBq0JhS4AnSuWgSfvWPasLTV72KOzfbtA7Vo5hcT2bJBG2m8S3aw3jJc1t7JBQ0l2FAqgel1IZiTYBNGbdGfHro0TRzliyjoApKMaV850Qs 7dal3iaT3IwqFXnELoW3/8vnRmd2r3Rm0WYXAVV5WHRAKCf9yo6O0YcrKNtinaXGfDiC9q0N0LmZlgCc/ySe5dJSCHXyzhdVSOUkqBeoBeP3IFPi5y7m+upF BBNakCqDKW8L48pdyhPZcI6bX4bgSqi6XTs27cWSHI8y6TBVsreSyeuzJ4LRu0ritF4tuA/VCSoQM3e6qAEdxcQusasb+ZcUWsj6AglZe0A6I7dVpXDRjcEG 7UNwViLxdX7L1MuQOkW23z6DRSNQWVrs7i/X337PtWgw0twdNd0= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse reports the following: CHECK drivers/net/wireless/realtek/rtw88/rtw8822c.c drivers/net/wireless/realtek/rtw88/rtw8822c.c:5313:22: warning: symbol 'rtw8822c_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c index c043b5c520b9..5ae72d7f5c50 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c @@ -5310,7 +5310,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8822c[] = { {0xc50, MASKBYTE0, RTW_REG_DOMAIN_MAC8}, }; -struct rtw_chip_info rtw8822c_hw_spec = { +static struct rtw_chip_info rtw8822c_hw_spec = { .ops = &rtw8822c_ops, .id = RTW_CHIP_TYPE_8822C, .fw_name = "rtw88/rtw8822c_fw.bin", From patchwork Fri May 20 18:45:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 12857337 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD05C433FE for ; Fri, 20 May 2022 18:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350841AbiETSru (ORCPT ); Fri, 20 May 2022 14:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352945AbiETSrs (ORCPT ); Fri, 20 May 2022 14:47:48 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2147913276D for ; Fri, 20 May 2022 11:47:47 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id s7dFnjjoIFl1es7dfnBCba; Fri, 20 May 2022 18:46:16 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=6287e1f8 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=-nFclCnxJA8rJoUu8tsA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d Date: Fri, 20 May 2022 13:45:27 -0500 Message-Id: <20220520184528.4078-4-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520184528.4078-1-Larry.Finger@lwfinger.net> References: <20220520184528.4078-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfKXVMTPLxZi3UuKkdY28tTfDA+DUoqqumw1DP2/kUejPFmFMiAjtcdxEldg+RhXkjI5WPBfmcM5J41MBrPiVovs2US2TQilKJJHQ0o8qaWH2UOoz5nay dYvA0MtRDBPjcgfwKAY4lY9NpM+gioKvAgTNC5V8JN0uzXUCCZEqVlwOgK2MNP85fUaSfHdTItaQK8CPil8qvoCl3NB1eOpbBjt9d8p87zRHFPAvuex9nmpN 29Pt93cCOGL8E9gDgSy8g9FPNedDqH1tPp1I3M5iyO4bGh4fneW3ndXy5kEq+UCp1KlY7EiQYRitmwc9byuAi8KgA8QsWFZKaOOjOrHRYrt2BAaMCEn+djrS C873pa2TTbzK/YCbptAnYn7/zjNMiAtJib8juBXc8l47gJiKouE= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse list the following: CHECK drivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/rtw8723d.c:2704:22: warning: symbol 'rtw8723d_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c b/drivers/net/wireless/realtek/rtw88/rtw8723d.c index 93cce44df531..05e826e6ed0d 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c @@ -2701,7 +2701,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8723d[] = { {0x953, BIT(1), RTW_REG_DOMAIN_MAC8}, }; -struct rtw_chip_info rtw8723d_hw_spec = { +static struct rtw_chip_info rtw8723d_hw_spec = { .ops = &rtw8723d_ops, .id = RTW_CHIP_TYPE_8723D, .fw_name = "rtw88/rtw8723d_fw.bin",