From patchwork Mon May 23 14:55:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12859142 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6C46C433EF for ; Mon, 23 May 2022 14:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lZ0roIx+w+ZgICTqWw3+KSAeT0h+vIDVEfZ4zDOGGtg=; b=TqtXIUCP6l2u17 EVH62E4abxz63i8U2GYY66FCAkVf01aJKyxuh6IiwQVh3DOQTQ5YSA4IvD3ApubGYLI34vA8mobf8 O2qWqPdWIeyAtn9FbRnoG/+cWO2XOVwW4KKYxAQRyOmKgc+q6nT2AQZP2OtzCuVGcjwFgHZkYwRJf Vz7Jh1l9EOFdcipZSdnuT9bXNfOGyix0YxOKajpfO53F5mf3PVR2VjVp/ZQzj1z3cY/mTncc1x0vL IrXOHgD506n25sCshxU6u6al/Usd2DpahsPWhk71/fRhtHs/BaRHYnOe7EzLGbfYWmQyW7Np7kAa3 4GlcPBcwtQNayl+F801w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt9Sx-004o3J-Up; Mon, 23 May 2022 14:55:28 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt9Sv-004o1p-IQ for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 14:55:26 +0000 Received: by mail-pj1-x1034.google.com with SMTP id fw21-20020a17090b129500b001df9f62edd6so153900pjb.0 for ; Mon, 23 May 2022 07:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lAsfZ94mPmdCtSLuY+yTmU/kf8t1RWq4c+zfwIS3kZU=; b=qL3OCqHcHzyKI5hwEV6UajS56blAArm+NUR5fTeRmpHvBTF2luIyJ0ScsLgXZJOktO AF+2XMLz6+6H7LaZw3wtPUtT2Dr+4Kw6bV6pOwQV3I0sQgHyK9n3jm2RFDteLOjtxfmg md34NvnoGVWei0z081yCNsxplR+5EOZMtzGTDcjJb7Bk86yaGlqqyHz2YHa7w7/uP5yQ W1Vdv3MY9pBEomJvjedvwOBD7nZTr9KwQT/Y2VbgfX6x45Vm9FZy+R4QfW+6P5FSp8sj L9iUxeFcwd5G9AcJFDobomkNWm20xsxRiRWJaHYzrnUnhp+bA0nMBFZAz/XRdjsGXlrR kBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lAsfZ94mPmdCtSLuY+yTmU/kf8t1RWq4c+zfwIS3kZU=; b=C3JbCl5RUtUIKaPCUgauJZrOmaOMbGhkbxCxsy+SqEOf7hKDAxOXpfca4Rh8TwglAg i9gwkb/CNIEbJO+oGg9IRhM/a+qJXBBF08cQDzxj+JVMbFu5oHatrr/pLZT9RZpfDzUw LJuwQQDcGoLgo4gylI87uu0gMb/x/+mNZpmiIspxZsMBwl0cmqRuss+7X//hhQD85GGP 0LqJCsHnNePXR2aBq2Ny8XA4uJKJBs7wWLELWx8gHL6b7c52O3qf6tHagNyoCe/hKcDo ucXph75E2b5eRnGhU1M057SiB2z/ktFyIZQKibokJX++nhjZ61Wi8jen0iTvWH3x0eSR L+wg== X-Gm-Message-State: AOAM530nL0HkqMF9D8LdSWtyeoxhsSqDvfYbxjvIijOZqrjbWoATwxrN RDooOE5iZFeeLa6OqIm60y8= X-Google-Smtp-Source: ABdhPJwZhynyLL9YejikmlfxuBPI0eDBAgXevyP08lOSVThADiIwAEm0EMxekv2afPJkWC7NZT4lQg== X-Received: by 2002:a17:903:124b:b0:15e:84d0:ded6 with SMTP id u11-20020a170903124b00b0015e84d0ded6mr22841886plh.141.1653317722732; Mon, 23 May 2022 07:55:22 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id o13-20020a17090a4b4d00b001df264610c4sm138116pjl.0.2022.05.23.07.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:55:22 -0700 (PDT) From: Miaoqian Lin To: Russell King , Krzysztof Kozlowski , Alim Akhtar , Pankaj Dubey , Tomasz Figa , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: exynos: Fix refcount leak in exynos_map_pmu Date: Mon, 23 May 2022 18:55:13 +0400 Message-Id: <20220523145513.12341-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_075525_665401_ACA0E6C6 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT") Signed-off-by: Miaoqian Lin --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 8b48326be9fd..51a247ca4da8 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -149,6 +149,7 @@ static void exynos_map_pmu(void) np = of_find_matching_node(NULL, exynos_dt_pmu_match); if (np) pmu_base_addr = of_iomap(np, 0); + of_node_put(np); } static void __init exynos_init_irq(void)