From patchwork Mon May 23 15:34:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12859193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D4F2C433F5 for ; Mon, 23 May 2022 15:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HrAveY525c7OyGjTCvvzgO4zxtsVTBZgO4XJU8QpHdk=; b=UvNi5nDKhqmO9D RgBaCh71lkZjB2sQBiRoYu04m63Ywtd7arrFUjoG5SfLQsBxqnUcIo5IhpgqWz2llnnpjwXakP0y9 lUrWOzf2OxxcE2OXsF/OxzYwZD3tBKjHc4HTKn3iRwTSoL5IKoozPex6wGRFTkkA4TeAiUcdlBFY2 Ii9vlSnLGxsqpj/bvMozC9uJqTZBhlHmSniZgDop++Y1jclsz6sMHkFiMJvON3gUvjUZRewU6iUbg tJlmguM/Om9TJiQnPSrlnVGKohtd3yfM83qfzYPf3HC79/9XbiEbBLIU6RqG606+oYyXZcciYSA4n STF8hG6TJLQXjQXHc32g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntA4b-004yPO-Cj; Mon, 23 May 2022 15:34:21 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntA4Y-004yNp-Bf for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 15:34:19 +0000 Received: by mail-pj1-x102a.google.com with SMTP id n10so14398713pjh.5 for ; Mon, 23 May 2022 08:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W4RCFlHPKPzBpfZ4VSRaqmfuqEsVoa/sGTVsUgYmMkw=; b=YGoYoVqwdqHR20dUUiThyv7mSi+CuU7dvhVuKDwnSf55afYm8Xq8utr0ljcFgoU5GW zpCKB2yh8ZSQlJPZEKqm4ujVrHmMxNP8RnjYJfz/TF8/wYudZRnhVjY7UD5MdXuMTgfM mydwtqvtrXgQg7io3VCJ92Bq23W+uR1pqrqBHarN4OzCGuRGlRO8vR5qFT+7xg/UYt/M OTEvcbdSiIvoH8/KvTQr6J3cY8zPw/Dn57bZ4Qs/ryjn/Wm8mtPyFATqOhyaGsz9L50i GdTOX+RIbrnFiJWxCaI4Br6yirCtDZvUEDHiR0nSszHCcQjb1+BT8zs0cSe68Zf/AwMt nZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W4RCFlHPKPzBpfZ4VSRaqmfuqEsVoa/sGTVsUgYmMkw=; b=pL9cEU51b8LFHp8e1rcVl4UnfOk92yvZKytPSo7CkcO/fCteUPA0rMuP3WTKwSo7W5 hHox16icFFFxSXQi0b7YAW3NbQzW4Hxjzpv9HfWDNk2v5v3SHnp/JmMbg0cRm1YJTgaj V+hMVYZScF29WdZ32m0lTrJLgVSvGA4ctAHmpIjz2xJEPTTYgMTdRt+eX8tgYeDIE9sB vG+K1in4SypurwFo2ePM65lyu00LAb6qVc5iPhbMKA3V4+TPucee4yhCcE3SYot2w/gE 5FOS15bATaF7/GKcCmowtPknchPGCYIxbkLO1mAKJIZyeBOVrEJl44iYonjd6DCeeUJ9 R1dA== X-Gm-Message-State: AOAM530dqlguW+34n60nreC/Z4tu/MnDCfK0LhyZbLMN1dJPGnro+Fer FBSuOqX4Bb86OQZftR7tqgk= X-Google-Smtp-Source: ABdhPJzljZ11lQunxi5u5KVqo9IYckGYCLPpmtlOuo+7t/bCcHtXT+XiPLzpWe6/z4+bvzkEyU285w== X-Received: by 2002:a17:902:f549:b0:161:f216:4f46 with SMTP id h9-20020a170902f54900b00161f2164f46mr16620819plf.70.1653320056826; Mon, 23 May 2022 08:34:16 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id n8-20020a17090a160800b001d92e2e5694sm7316928pja.1.2022.05.23.08.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 08:34:16 -0700 (PDT) From: Miaoqian Lin To: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] bus: arm-integrator-lm: Fix refcount leak in integrator_ap_lm_probe Date: Mon, 23 May 2022 19:34:09 +0400 Message-Id: <20220523153409.22949-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_083418_451521_AF0DF2C8 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules") Signed-off-by: Miaoqian Lin --- drivers/bus/arm-integrator-lm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c index 2344d560b144..ab5fad8aaa99 100644 --- a/drivers/bus/arm-integrator-lm.c +++ b/drivers/bus/arm-integrator-lm.c @@ -85,6 +85,7 @@ static int integrator_ap_lm_probe(struct platform_device *pdev) return -ENODEV; } map = syscon_node_to_regmap(syscon); + of_node_put(syscon); if (IS_ERR(map)) { dev_err(dev, "could not find Integrator/AP system controller\n");