From patchwork Tue May 24 00:34:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zqiang X-Patchwork-Id: 12859599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC9CC433EF for ; Tue, 24 May 2022 00:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232229AbiEXAfC (ORCPT ); Mon, 23 May 2022 20:35:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232214AbiEXAfA (ORCPT ); Mon, 23 May 2022 20:35:00 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CB99BAFA; Mon, 23 May 2022 17:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653352499; x=1684888499; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cn//lySDkZnoisvjz9SADhbX/aP26ag0T/ZF0md/lDg=; b=ZY9dayXL3bvYEu6+3b9TgGE5N6zXl3Fv09D8ZAt/PNT4DIUQbOokhQTP Av7dqC1PbbvCsZd6sRQXFzJaUev1k5kmJLhOfYk9zOd4OXQiS3XneAM/q iC3oOsf6xBqWhyr0p/IYj0ZWIkvqnmA6MhPoRAIqybFF3YdkW8GJJnu1v Y1EA5ZXRhs/UkPue6Q3JJI/VEJWZIKsgVpDql268UL9yuVRZQJXAmJvQd ZtA97VM8uPxC75Yxb3NuO9cYREPTvhSY/yX5P72en47VpqaKe4EEWjOLk mEOWqYSHbjdsice7yQn9pV6wA9QLiYCq4oQi/QCFADfUnLfk/xu0uxF+f w==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="273509532" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="273509532" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 17:34:59 -0700 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="600952749" Received: from zq-optiplex-7090.bj.intel.com ([10.238.156.125]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 17:34:57 -0700 From: Zqiang To: paulmck@kernel.org, frederic@kernel.org Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH v3 1/2] rcu-tasks: Stop RCU Tasks scanning no-idle tasks which record on dyntick-idle entry Date: Tue, 24 May 2022 08:34:53 +0800 Message-Id: <20220524003454.1887414-2-qiang1.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220524003454.1887414-1-qiang1.zhang@intel.com> References: <20220524003454.1887414-1-qiang1.zhang@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org When the RCU Tasks scanning on-rq tasks, there is no need to scanning no-idle tasks(have invoked rcu_user_enter()) which record on dyntick-idle entry, at this time, these tasks are not remain within an RCU Tasks read-side critical section. This commit skip scanning tasks which record on dyntick-idle entry in rcu_tasks_pertask(). Reported-by: kernel test robot Signed-off-by: Zqiang --- kernel/rcu/tasks.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 195c97e85bcb..a28337f280e4 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -809,10 +809,16 @@ static void rcu_tasks_pregp_step(struct list_head *hop) synchronize_rcu(); } +static bool task_is_on_dyntick_idle(struct task_struct *t) +{ + return IS_ENABLED(CONFIG_NO_HZ_FULL) && t->rcu_tasks_idle_cpu >= 0; +} + /* Per-task initial processing. */ static void rcu_tasks_pertask(struct task_struct *t, struct list_head *hop) { - if (t != current && READ_ONCE(t->on_rq) && !is_idle_task(t)) { + if (t != current && READ_ONCE(t->on_rq) && !is_idle_task(t) && + !task_is_on_dyntick_idle(t)) { get_task_struct(t); t->rcu_tasks_nvcsw = READ_ONCE(t->nvcsw); WRITE_ONCE(t->rcu_tasks_holdout, true); @@ -842,8 +848,7 @@ static void check_holdout_task(struct task_struct *t, if (!READ_ONCE(t->rcu_tasks_holdout) || t->rcu_tasks_nvcsw != READ_ONCE(t->nvcsw) || !READ_ONCE(t->on_rq) || - (IS_ENABLED(CONFIG_NO_HZ_FULL) && - !is_idle_task(t) && t->rcu_tasks_idle_cpu >= 0)) { + task_is_on_dyntick_idle(t)) { WRITE_ONCE(t->rcu_tasks_holdout, false); list_del_init(&t->rcu_tasks_holdout_list); put_task_struct(t); From patchwork Tue May 24 00:34:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zqiang X-Patchwork-Id: 12859600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1397BC433F5 for ; Tue, 24 May 2022 00:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbiEXAfC (ORCPT ); Mon, 23 May 2022 20:35:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbiEXAfB (ORCPT ); Mon, 23 May 2022 20:35:01 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1D249C2D4; Mon, 23 May 2022 17:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653352500; x=1684888500; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Uuq/o6+TsTmTxh6cE4BlifTTgnKV8Ddm8hawFfo0q0A=; b=i16+2PcYQlPRALd/EPJ3H4pJLACcur6s/vAmKJgnDvedON+hChBhENJj 5e6RdDivlw0SmLEzCDnlj4BzdDRGT100LHJO3eAa/XaqrbygTL5ZLNJEv s15jpNd35sxvJA04MRJN6PU6DE55CoH2bv7mYKKxh1Og4ehK0nKaBSclY 7I5VCtK00bZaDoEt7DSKlP0lOloKtmIYcHz+clwxok9Na0Sasy0+owCoQ VluxF6y8G6YZCH3ccEDsBuISz7Tkz+baqLy9+ZmJgZeCkxMHyWidY57zv gnUCHt77Xwe4SikStmUi0Rlzema5fJ0d8+I2UgVEjsHQVjguU4he0bGaZ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="273509534" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="273509534" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 17:35:00 -0700 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="600952750" Received: from zq-optiplex-7090.bj.intel.com ([10.238.156.125]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 17:34:59 -0700 From: Zqiang To: paulmck@kernel.org, frederic@kernel.org Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] rcu-tasks: Remove is_idle_task() from warnings in check_holdout_task() Date: Tue, 24 May 2022 08:34:54 +0800 Message-Id: <20220524003454.1887414-3-qiang1.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220524003454.1887414-1-qiang1.zhang@intel.com> References: <20220524003454.1887414-1-qiang1.zhang@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org Due to the rcu_tasks_pertask() already exclude idle tasks, the idle tasks not appear in holdout list. so It is not necessary to judge whether the tasks in the holdout list are idle tasks. Signed-off-by: Zqiang --- kernel/rcu/tasks.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index a28337f280e4..6a2598efd0cc 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -862,9 +862,8 @@ static void check_holdout_task(struct task_struct *t, *firstreport = false; } cpu = task_cpu(t); - pr_alert("%p: %c%c nvcsw: %lu/%lu holdout: %d idle_cpu: %d/%d\n", - t, ".I"[is_idle_task(t)], - "N."[cpu < 0 || !tick_nohz_full_cpu(cpu)], + pr_alert("%p: %c nvcsw: %lu/%lu holdout: %d idle_cpu: %d/%d\n", + t, "N."[cpu < 0 || !tick_nohz_full_cpu(cpu)], t->rcu_tasks_nvcsw, t->nvcsw, t->rcu_tasks_holdout, t->rcu_tasks_idle_cpu, cpu); sched_show_task(t);