From patchwork Thu May 26 08:28:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12862091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CE38C433F5 for ; Thu, 26 May 2022 08:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fI5u895KLufx1wQKWIb14U5+NibJZ8QJ8BxWPnxMGLE=; b=bHXQvbQ3ACSbrY ei1rB0x20lnCWjUJFYsFy7U4ESuZoAg/s9mWa+MrTlaio8clmNPx+s/OptcGXcBerDyIpmGm5Hg/s Xj/1vaCFWKZ6kC018kVWAUD3j3KgS2eBkOTm/o9C3ci4Si5ep3FlYyTLc3jzkApsYo37udUpucBsB f6uvFfStxsHs9nmVsQyQ6DXJD8P2p2OHA5vaQrMeLMThukPerg1yhk/lnNFeLqVL0cDXaElD51ljZ +h+kAm3Mv3jpBpEpOpyXDm8kRWJT5YfCBdSqoJOsxodUXUZ6oZUawQ9CfVUeHTDUdLdoHiNpWLpEx gw4Gq22SaKfzuTAJc3GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8rm-00E4ju-8J; Thu, 26 May 2022 08:29:10 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8rj-00E4ig-Kq for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 08:29:08 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d22so868637plr.9 for ; Thu, 26 May 2022 01:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ta2fnNORGUsjuMjKE85VSi51HYB7+7nVCChsv1cbuY=; b=cKvLolcB0qKL6HE4x2ld1APfOOtnBG+zZ7xjFnuF9ASGev8did1cbzdkQMPu0wFlXt JsMwX1SR8ry7yEpZPkXsgp97azZxkwbA1N6vRFc5+BX732RPa25GQdT0VFH1GLgcFN47 ORQQncZBfR4wXvwI2LpS1orjIY83/HY15ge8dktV//YIt7mu5Bog3ATngb9wkGSaGRfq EPUn24bG8g0d/JMDiTmttgl2ywASsE0FsoKkVhKdrtlmhrSdkHQ+lOfamnujqvffXVxH WOjCF86KGG/JD0WxHhdQWTOBBC83lDGB9353kEDXz5IGlVsxeDLpBi2S4OMc7mdlAc00 GsxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ta2fnNORGUsjuMjKE85VSi51HYB7+7nVCChsv1cbuY=; b=Ck2ZBIgQy996NCU/5n/7HaPAiFGB5YlEGhLR8HRXEs7VX9TA/K3emfuU30ISIGF3Ks HZ+bXM60z84Yg4GjoP/mo3ZurIuDnyltGwHH9wvWbOvPbFkfgPDvSnAoEzFLoePxWzk1 WyAwm2Rgn84tJjh2os1Zf65j3WGU27mJ/RyosU76WJcenaYMD+wpjBzayrcuIh3M2d5N WHiJppj/AiE3GFaRezFRgHDZeWv0nq5n8jZ1/5L3GeIlDtBn+DlQsR3WmCVV1bU+LrO6 vD5vAfxR7qG6AmMpE8Zx+h40nosquE9L2oVAU1vyH13ScL6mP85uV1pYdvfOz5lG3Hgd fCzw== X-Gm-Message-State: AOAM531rl+wRYk3+EH/Y8vcxU2htJI1ZBCC91xVFm9Fd5CV9K8zGhho1 yB0NvdKNFmqKiuHXEkiVfxoB+Vrmb5cS1gUn X-Google-Smtp-Source: ABdhPJxcDtzIa1cpNLT0Egvkyg2gtm0014D7uRbUsAgnDGvLvuH2YfJNpFLGDUJ0jEUFxz/6zQdYeg== X-Received: by 2002:a17:902:c402:b0:163:5b99:8efb with SMTP id k2-20020a170902c40200b001635b998efbmr6962403plk.4.1653553745828; Thu, 26 May 2022 01:29:05 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id 71-20020a17090a09cd00b001e25e3ba05csm251685pjo.2.2022.05.26.01.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 01:29:05 -0700 (PDT) From: Miaoqian Lin To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events Date: Thu, 26 May 2022 12:28:56 +0400 Message-Id: <20220526082856.37594-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_012907_728061_F876C364 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. This function only calls of_node_put() in normal path, missing it in error paths. Add missing of_node_put() to avoid refcount leak. Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class") Signed-off-by: Miaoqian Lin --- drivers/devfreq/event/exynos-ppmu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 9b849d781116..a443e7c42daf 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -519,15 +519,19 @@ static int of_get_devfreq_events(struct device_node *np, count = of_get_child_count(events_np); desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL); - if (!desc) + if (!desc) { + of_node_put(events_np); return -ENOMEM; + } info->num_events = count; of_id = of_match_device(exynos_ppmu_id_match, dev); if (of_id) info->ppmu_type = (enum exynos_ppmu_type)of_id->data; - else + else { + of_node_put(events_np); return -EINVAL; + } j = 0; for_each_child_of_node(events_np, node) {