From patchwork Thu May 26 10:12:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiasheng Jiang X-Patchwork-Id: 12862170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E68C433F5 for ; Thu, 26 May 2022 10:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9xhefnJFwLN9BzO2BYrne4rSp5zU1sCtOQh7i9qw55M=; b=uHdPtEAEYGFzaN 1T2xQznHsdPvpb8nRj1PeDhPtHzkR3ZMmwyznW/X1Qpq1EWLfIV3najTR0CNDeO+nG6jfH2KJdlMu f9on+xsZqAg6J6X5VHKc/SBZuZ+VUnBR4qryOyQWDlNQhTcJeuyveFdFSx1X27TNPCLRIJkM1UIiU CVlmaYq2qrgKnrd4YpY/bVyGXNVwl9YyR2hnExbH+HecMOaoI+sLtZySfk7+joeUN0NmcY0gE0zmD xXofKvDPi6XAg5k8RYOeYSARydvsc3mmS5wBl//mS/KqI+g8JnN+yM6waNCw69CJpNdACv450dn4F NiSIqjedEqzZfeB87IDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuATu-00ELxd-6I; Thu, 26 May 2022 10:12:38 +0000 Received: from smtp84.cstnet.cn ([159.226.251.84] helo=cstnet.cn) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuATp-00ELte-Mp for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 10:12:36 +0000 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-05 (Coremail) with SMTP id zQCowAAnxxiBUo9iwleiCg--.21840S2; Thu, 26 May 2022 18:12:18 +0800 (CST) From: Jiasheng Jiang To: s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, alim.akhtar@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, krzysztof.kozlowski@linaro.org Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] clk: samsung: Add check for platform_driver_register Date: Thu, 26 May 2022 18:12:15 +0800 Message-Id: <20220526101215.1519155-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: zQCowAAnxxiBUo9iwleiCg--.21840S2 X-Coremail-Antispam: 1UD129KBjvJXoWrtw18uF43GF1rCr1xWw4xXrb_yoW8Jr4kpF 47GrWfZr1rtFW0ka12yFn8Za98u3W2gFy09ryxuw13Zwn8Cr9rC348Ga40y3ZrXw48XFyq yr1UCa15uF45ZaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvY14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFyl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0J UdHUDUUUUU= X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_031234_151916_6CC88D2B X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As platform_driver_register() could fail, it should be better to deal with the return value in order to maintain the code consisitency. Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver") Signed-off-by: Jiasheng Jiang Acked-by: Chanwoo Choi Reviewed-by: Stephen Boyd --- drivers/clk/samsung/clk-exynos5-subcmu.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5-subcmu.c b/drivers/clk/samsung/clk-exynos5-subcmu.c index 65c82d922b05..8b090481a9dc 100644 --- a/drivers/clk/samsung/clk-exynos5-subcmu.c +++ b/drivers/clk/samsung/clk-exynos5-subcmu.c @@ -188,8 +188,18 @@ static struct platform_driver exynos5_clk_driver __refdata = { static int __init exynos5_clk_drv_init(void) { - platform_driver_register(&exynos5_clk_driver); - platform_driver_register(&exynos5_subcmu_driver); + int ret; + + ret = platform_driver_register(&exynos5_clk_driver); + if (ret) + return ret; + + ret = platform_driver_register(&exynos5_subcmu_driver); + if (ret) { + platform_driver_unregister(&exynos5_clk_driver); + return ret; + } + return 0; } core_initcall(exynos5_clk_drv_init);