From patchwork Tue May 31 12:10:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12865446 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F5EC433F5 for ; Tue, 31 May 2022 12:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344084AbiEaMKi (ORCPT ); Tue, 31 May 2022 08:10:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235595AbiEaMKh (ORCPT ); Tue, 31 May 2022 08:10:37 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 883858AE74; Tue, 31 May 2022 05:10:36 -0700 (PDT) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VBE6BT021152; Tue, 31 May 2022 12:10:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=sEovGwsQnO6W5ORmc1c585pKpxqgCrV1SCPB8VMD61g=; b=CAXV5T7kiOkdyquFLyZcCRWMZ6hjcfjwjnpHZ65GdcB9+aEaO8AEm4CrxF+3dgkOYQ/t CUUm/bJIad/P9/5KjJkQkYVeoLuDOu3RMdK0WQAleq4wY3mcz0tPiJTGq9npMsVUB3BV pqpNQst7qu3XuUYaMbNZqjGDXeCIQ+mVgdvWFqFY4ZHmdUk9/sJeCH5uJ+AfHNtHAigj Fe9ENp6crIJLtI0HRIAFJWt5RMpAs+U6mtb7TcXw7mYl52EjUI3kDLmnjCmbGHB2Ealw UxZLX1h6A4ugx37JgZM3fJh1QlQcmIoaBjCVLa+eDCbsZGhhAqhuzxnlQX/NhXRwGayq Xw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gbc7kmssc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 May 2022 12:10:22 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24VC6Akb024955; Tue, 31 May 2022 12:10:21 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3gc8hv2qdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 May 2022 12:10:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2EXXTzLRoh92uBuoCgbETz4FR3M9A5odrXahKguhPMjd9qMNEis21nQWBz2QoznSGeHRRl6uXF26jx+sN1ptb0J/DaIy4bT2mQcSOiymjsIpFMrSGmQ4xlOfG9LWKe4qETDa6y661GcTwd/0ZAUFga8Lf8xTjR0tX29o9qRhBr5KLWg5uouomtL0ZzssseAerX1XRPaw2ZwPKYKPk37X2/QOoONH9RfuOZ1+t0od1XGrKi70WQL3AJBK999pQpn8auCJCJmFzu/00DXitPtBPkCkP9+d4H746IIYzVbA6ErLSZREJnyeuhLB4ZQ4ABlHYlrDaUrD6A742NEdFwRMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sEovGwsQnO6W5ORmc1c585pKpxqgCrV1SCPB8VMD61g=; b=TQJNsqlPu98+fVWpdTzKTrHvREE+H1scz3rxT4MsBeylpTKAklWgsK952a4m8/IHdO1do/jlaic+lK2CZMgtZdeTOcVtp5MPZTHwWlSWX06u64DWmj7EJ6LoAb01r03y87jTWmFeRbqUd3A55HEigf2n9Ywh4uRSizsEjE3xa9SfY4UVmkMnc/mWgAGfJFCVJ/mjLGTdlZiC5aaL6qG1ZxVQkmWtNYUHhzRaJBSNdqg4tG4BaLPN+aKkSPkeEEUpipf0N35LzToCSFR6ntWtyXTRgRInVyNcOiY5GHvuidZQLahY+ZT3QEY9IWgxnw8t3flbGNhrmBG76Yb+SYtY9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sEovGwsQnO6W5ORmc1c585pKpxqgCrV1SCPB8VMD61g=; b=JE7veAVrk2gsRZaSzgz785tacpUpmwVKx6NoEQFHvTPfhN2p44OxkSdJqkB3seMuTFKwO1ET96HcM2c3b+kObsH40/OIGeB6qzxp/WL5UMDduZzVsjS0nQ3arxjwZw8sO0fchZ4JOv2uCyyhbtyrwQXmgNYJ4qH1rgE5Pz3+Wm4= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by CH0PR10MB5386.namprd10.prod.outlook.com (2603:10b6:610:dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 12:10:18 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::86f:81ba:9951:5a7e]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::86f:81ba:9951:5a7e%2]) with mapi id 15.20.5293.019; Tue, 31 May 2022 12:10:18 +0000 Date: Tue, 31 May 2022 15:10:05 +0300 From: Dan Carpenter To: Jamal Hadi Salim , Toshiaki Makita Cc: Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Paul Blakey , Pablo Neira Ayuso , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() Message-ID: Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-ClientProxiedBy: ZR0P278CA0011.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::21) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16511fb7-e581-457c-d0ab-08da42fe86d8 X-MS-TrafficTypeDiagnostic: CH0PR10MB5386:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xZuwBDx/GViZ6lLplr8ct+Gkkf6ZtQVON/XwNWyz37Bibd5GCKQ4xCoQlmgfjV6aTURzXAqSqAasa0LtpfGSkfqoHfPa3D0bhyvc3WEnclSgj+03/e/yGGCJR6ddgmmcD/wYDa27YbTtz+2IL7aIUZLOalqO2qjXchzogrhAmorQNCAJi4CVEo0P88jiZyGwFblPBgtYu9Bnoocu0OwBmkU7FWxJ5OYbdZ9Q8BOm1xtO4vkqhWvQvkodJPuKDx1pqPZXuLB+ZW3EQ0vFTufV61PDGFeXPoZ/WsmMESFFBfNNgNNdntzBFL96oTZZ/1rexw2J6pRQ0KS/SXGUpwWtsAX2+jmJF7l8WGTrOOan1NTormAyHIvpwNTCxR3CNyJGV62qJZ/Vm1s839SZajh7DFK/A/AA2gRb9DK6pCv+jS+dC4/bwiipDoS9K7diGppr4qCc4o6el3cNWmhsl03fhiO4bbZ03ie1NSfAwIen8x72O/P4zhny/O39jZ7B3yxKzkHjR00EVY2INSZ8YKbVcKN97UeIiLlz17w/mFKmTX7G70Yjc8tWt6T+Nj4XwQJmGgoUkwISNNMS94N6uKFuk7u+fHcOSEPmoBR57frSw0/8fQ/DYEKvqmhX6MNt6zkhFdFen6wxAOO4X4yWogZzU2Kq6Q3wCdQLm0WuZWHQ+sP2+zc8qLUD4AWVeEYB2/N0sPYev9BZ/oNxxK3jA9+85A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(8676002)(44832011)(4744005)(7416002)(5660300002)(83380400001)(6506007)(38350700002)(38100700002)(66556008)(66476007)(66946007)(4326008)(8936002)(508600001)(186003)(316002)(2906002)(52116002)(6666004)(86362001)(54906003)(26005)(6486002)(9686003)(6512007)(110136005)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9j+OyMf7VQvplDeqlDU1/rNFOl03lqiFfEB5nyWRpJ1lV2kFDyKYkozrgru4zcmiIRObpQJBocwZnN2/NxujpKf8g3uIVc1hW2rXfKKxzwXXUBn4Ht6XheqGuNA69E0KJJuq7pH5gM0Wakl59EsGY2kHc7cVBfvpKtzMjGPXN3BUvWudtkXC13RRpYNQ9UxAqiKs3jb+42PS6Vr8RrLRp47bgux4qrgkGX/2N1UwElbH56x2WC6fS5Tufn+MaNusNKp117Y/0B6kZvxQTTS/Og51IB1qZvkA83BYildRKuNIaAEaijKK+YnTNxqyRY7UZW6syMmve/TUU/yie3qBoLxnJqQC/3WNgPxFOlX+fqTFm9bUx5h0YI4dkpTi4J4567BtodVzbjQBhLitMIlMkxipqtd7NBHWLjXNt7O9je0DFQ6+90nSC4ALZpZuq5OyicpBL/pvXxg24M1tBaQO8uL5uAMkIExt1Vlr3IO0EnuQhCuRwIEBhJD2QT25nZAAA9LZv7JHNttiVNLqv7ew2I9Q5PVGhnCLVVAryswusHD+8+U6horH4J2yB5pY0o7RI2l1PytzkDs6OJ1X7OpF9t+Da4k99paqbp/HKQ2poLnx6KCEhkIM1Sft9tfNRcrEX2gOYXmULTZDb9BWNN+y5cyPzSfKZTnBeXZ6syxJcBVfkRmXn20I+gv4WpmljyTHF6l1xbhUG59kd7pFC6k08wGZ4Ai7mLbGuNzU/b2JfTcnQZYvs7whCcHVVTNs8UaY/jCAQePg3xHcQEt4akPDnoH9MA0L2ssM/VYr51vu/GHe5nrsR57BpbMM+stwdU9kMCaTXFSSngrwWBAWIx/qIlNUZeswUi4fOP0vWDIDzr810ofQqYkaPjT6v3cMb8oakzzE6v2YMjhCAbqMxqoG6jk56McoiH35rQl3qqEg3a5CWa4qnpm1ntw8dnNkaIvFvCByVO4iC8SYSKnYvnrBSpI8YID/AUd55zwgvHAal0oHM/zcCFBwwUnGoU+nIGokUagam9QkMLB33AMbn7ammEgjFgZQDpzf5M1wdLWaEs+jFyEjSQ5NNytDTDAzOarMjox0lmKstcHdZPNU5hRSUbrJ0UODyHvrSp26ZaWzP9Ye8Lk4nKAqG4cPzSD3E9Y5zSwFbqCF/qIBJSkFrvVCRzHWSVkTiGRbfDbyRZ0wu5t2q/OInGPtT7joKTEXtTZbyZyglO7nLdaxUEhQwWlRcibiklqbBAUgawPTPxR+YSKmhJ7Q9amYRbXt+UFHoOOdrWAQVGlnA/qJbVEdeukpx1j+vGuOJc2yHlai+TGjHxZ7KCKVAQHrqB8wM7p/TjVttHH+nC4ZKk/0LgzuyWFLmssmMu3D+xMXPlDPFmt8+cGttwqmXJWE3Y8M9pixTExofnRM84SFPcsLT8MVI97J92YEi0ErmMoyiowSRNr17WPUVaXfrHxv8IGE3H2wkEshBngM0swQCpB2zThv7hjWNcbyXtcG5YViPY0oVNhwZbsTQdYwYvKeLLRQx/Kmhu+e2jBO2JfTzuKAuV8qyA1i52wszAhg1Mu0D5ytbEj6IR7SeyofUdLPafQalxGPTsCFOIh3Nb/m/6EEyetRQdYT1LRtZWmrUXZDJum/z+qbn62XmWR96YyHIVTD5ONH81m5L/nzoZ90lUArZHLo8cSixhHEtGlfLamBOgT+7PP/y/pn+xf5f99GslB8L2/w2cA6imA85ScWO+OxR7Rte8hf1bUSaAj/T8zUwD5f4DV/fzI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16511fb7-e581-457c-d0ab-08da42fe86d8 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 12:10:18.0953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w2cj2cnzAnwY/0CoCBd/1L3VLYBb/EOFLsvuNz4NpfRh8wUlg1LzkQgGvbko7vIsPGOWrP3eCmWHewARDdw3V01kbY3akF9ZT/Ui8/VM/Wo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5386 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874 definitions=2022-05-31_04:2022-05-30,2022-05-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205310063 X-Proofpoint-GUID: JuXqlgsCVWeCd6G5CNf2zdoPhtyy0lkp X-Proofpoint-ORIG-GUID: JuXqlgsCVWeCd6G5CNf2zdoPhtyy0lkp Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true. Fixes: fcb6aa86532c ("act_ct: Support GRE offload") Signed-off-by: Dan Carpenter Acked-by: Toshiaki Makita --- net/sched/act_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index 8af9d6e5ba61..e013253b10d1 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb, break; #endif default: - return -1; + return false; } if (ip6h->hop_limit <= 1)