From patchwork Wed Jun 1 02:19:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiasheng Jiang X-Patchwork-Id: 12866299 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68466C433EF for ; Wed, 1 Jun 2022 02:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=93LqdtlLIfETI5WVgRn+7T2Uwxp/vd7Ltk4lttrJ0aY=; b=iMkHqwrSmpVcTg NqbPFbgHKxQ8/rIyHczuxEHKdMRzD8t5utHxV7MIMNfISZzUpOQdNKqwIONNS/OIQF+pZONTO1HYD FPEV/i3kxSMsyImlQO7V/HcbLCCxiiv3oTLI5lWukOp6e6A7Q3g/PsR59kBic0ZggUb659cGPqHtN 2K5sslzpT6RW823oqSUycOAmOASRxHKIgUHVaiXNDntuYs7IcQANtd+qO10+P5J2mtJE1eW+zOWNV I8Je74HByb+BfWWL5lV1UEvYDaWKHA5KcfKrJ/07l9cW3THrpTc7Zc59xUUrITb4buzRL3f5CG3LO 1VD9ZGPf3jKCezp8gcXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwDxu-00DNkE-Fw; Wed, 01 Jun 2022 02:20:06 +0000 Received: from smtp21.cstnet.cn ([159.226.251.21] helo=cstnet.cn) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwDxp-00DNhx-Pt; Wed, 01 Jun 2022 02:20:04 +0000 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowABnbY2xzJZiT7r0Cw--.5697S2; Wed, 01 Jun 2022 10:19:39 +0800 (CST) From: Jiasheng Jiang To: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] drm/panel/raspberrypi-touchscreen: Add check for mipi_dsi_driver_register Date: Wed, 1 Jun 2022 10:19:25 +0800 Message-Id: <20220601021925.2752352-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: qwCowABnbY2xzJZiT7r0Cw--.5697S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZr43Kw4fAryxWryfKFWkCrg_yoWkAFc_Cr 4FqFnrWr4UG39xWF17Aan8ZryakFs5urs3Zw18ta4Skw17CrnrJa9ru34xXr1UGF1UAa4D Gw42qFyvyrsrCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbI8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8 ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AK xVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvj fUoOJ5UUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_192002_263094_4082B6FF X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As mipi_dsi_driver_register could return error if fails, it should be better to check the return value and return error if fails. Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c index 145047e19394..cc90afbf4b3e 100644 --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c @@ -498,7 +498,12 @@ static struct i2c_driver rpi_touchscreen_driver = { static int __init rpi_touchscreen_init(void) { - mipi_dsi_driver_register(&rpi_touchscreen_dsi_driver); + int ret; + + ret = mipi_dsi_driver_register(&rpi_touchscreen_dsi_driver); + if (ret) + return ret; + return i2c_add_driver(&rpi_touchscreen_driver); } module_init(rpi_touchscreen_init);