From patchwork Wed Jun 1 04:48:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75A7BC433F5 for ; Wed, 1 Jun 2022 04:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=rKnb0DlyKcC3VUATN1NIPd6arzPWFxy4NYf2ZVoSGYY=; b=VQyae7sdRq7ubD CHVHH3m+opXXO2au6p9iNYS5l/ZLStEOZiE2ef5DgjDoXiTQt1oJYxloHh4TFHRe0ZreebleQPjZI wSm9Ufu15jRy2h8miVtTfuSQKxmGeC5rT6nJVteTOfnl2uibvI72zjRQ5qlMxtkoZMSJCxEk6m+xM GeGvhqSxJcAwqj6/IVmSnF4CNxgBRQegBeCpCRjA28UtXsX5ng4WAWaxKe5R8lECg4svaerl/e87P b9W6zwlQpfnlb4bI/jB7EZsY6mu/eobcORxXxVzbyx9EXP/C1/xqSg9vUgEC299ygCJhgqanKJkjv /NLY3PWuRnDrvXHJ72Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwGID-00DqgG-6Q; Wed, 01 Jun 2022 04:49:13 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwGIA-00Dqf9-9w for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 04:49:11 +0000 Received: by mail-pl1-x631.google.com with SMTP id d22so678683plr.9 for ; Tue, 31 May 2022 21:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xQQdqLGDEyEaJ0q3XFvWz51XQwcwBB1gnP9grs45a0A=; b=l0N4Jd8kgXKz6N4pPkce+78dFAQxuAbgMSVylHnUGhpEqPXBAVOiY0OoZwRy5c+IkW xB5+7Z7sSTibAAqsd7xVrOEMfm+H5pjtwKLOra+t1UhalNkdExB1AJI7wg+LtrywJL2J 6BJ9617aJ/gmk/K+56QdPBx1Tod7f1z9qvoFmmrJkDLbTcc+IMnjp/gRKbF9dfuTKc4Y pU7p8gDqZGCsW+6GQxDEu6Hr5+aexGgCW9ZbewgZMBWSmtSeIKb+598CNaU+TPuviGfl vMsoxFcvkd8XFj6gWz/pNEhNAZEUUt0MaU0xa038JYJD4NRoRhhrN3r4O0nk1rxkhw05 cmQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xQQdqLGDEyEaJ0q3XFvWz51XQwcwBB1gnP9grs45a0A=; b=TSt025eoSGIkgnqZtr6tThv7CO1kcOc1fH83xo1EiB+aHdcJy8eIN/bNvDOd4M+E2V B9HRNPxBxEqpbj4gimjToXc0F3dtmH9l8BI4Lz9AaoGYFk9gtGwbMW/Rb3xEUXP45pc6 LEi5JabEAQbWhUvH4OzcB/9QQbI5/gl/Vaxfv/h6qIQNT9hLOdzXeeZyFrAvJATYqlQk QkXie6dPiJqud6++MLD2q/sfge2wY286alybv/u4xfCFrSpMJCnUL/nPw4aDplGCKDXz G44xsxkKSMQC1Zr8MUn9JJYJ7l6DpcJnr4gEk1EL582tpxYnZ+DoCwsejF4dz0aH2cbM tfvw== X-Gm-Message-State: AOAM533/nQTQ/JtLSPkxxh8d3xwZjmVioyPL5d5QJk7w3+3dnJItPwhv E70vJbyGJD8SRtCNByUX/ug= X-Google-Smtp-Source: ABdhPJxaDmfiU+rYQUhJxxGHahVE4aT3yrHtc2NV7ORrbgG83abmkaleOSY268WQG3kwgqwvVdi5zw== X-Received: by 2002:a17:90a:de0b:b0:1e3:33e9:6665 with SMTP id m11-20020a17090ade0b00b001e333e96665mr7862047pjv.27.1654058947423; Tue, 31 May 2022 21:49:07 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id p126-20020a622984000000b0050dc76281e4sm315672pfp.190.2022.05.31.21.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 21:49:07 -0700 (PDT) From: Miaoqian Lin To: Tony Lindgren , Russell King , Laurent Pinchart , Tomi Valkeinen , Sebastian Reichel , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: OMAP2+: Fix refcount leak in omapdss_init_of Date: Wed, 1 Jun 2022 08:48:58 +0400 Message-Id: <20220601044858.3352-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_214910_384638_7B32C450 X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org omapdss_find_dss_of_node() calls of_find_compatible_node() to get device node. of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() in later error path and normal path. Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver") Signed-off-by: Miaoqian Lin Reviewed-by: Laurent Pinchart --- arch/arm/mach-omap2/display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 21413a9b7b6c..ed2cb2649cf6 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -259,11 +259,13 @@ static int __init omapdss_init_of(void) if (!pdev) { pr_err("Unable to find DSS platform device\n"); + of_node_put(node); return -ENODEV; } r = of_platform_populate(node, NULL, NULL, &pdev->dev); put_device(&pdev->dev); + of_node_put(node); if (r) { pr_err("Unable to populate DSS submodule devices\n"); return r;