From patchwork Wed Jun 1 12:30:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5871DC433EF for ; Wed, 1 Jun 2022 12:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WvMGIRnNN5d2IDL+4y2HV54r0kzp0tHW/atJk4YgC04=; b=aPQPAdp8FZyMlr +mFSaXvQ9SYhEqFFD7jvZQ7wiQqqX8ST8/nrq9qg1UUkW4JZE5xdDeRlDYr2dOE8i1v/bs+6Ea4NE EdY0tIML2wFOVEdYRv65v/LBMs+tQWL123YLijweWmIF4QDx/cXOPWUr2Zg6225JYBVgM1DioyCyP vzXvoYRVicOX7cOZhkS097hEy8rThIOojwphlcc/8Ej5Y4qw9J62f19QqGxF3E1i6N8G+pEzcdtw8 q5b1C3ld+w6yBnoOXyp784lXbOGR4HnkPEd4sJKO4ZbtBN89SFYxQY9goXATyjD4l4vyuBOUPJzCS obgFHFO+ALGwnzUSReeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwNUo-00G2wQ-Bw; Wed, 01 Jun 2022 12:30:42 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwNUl-00G2v9-MW for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 12:30:40 +0000 Received: by mail-pg1-x534.google.com with SMTP id i185so1780999pge.4 for ; Wed, 01 Jun 2022 05:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dobCxK4OC92EBjp1RkCP1kDTote0DN9ExGNqTwwRdRU=; b=Yj2ztRMVWHrKvL/JjhY21O2YiqbJ7ALPDfBZz7UhFk5/nSCS/hoBMD2HHjfAd26Jb4 m/kLFwbSjHyd55sxC0qFS2xVdH5zu/OkzelDi6G4LNAWlFtuy7WI+Eo7PO8NS9oIuZLi xAGi+FcjpGcxg0PQHjfKIGogSKwzo5HKtPPecSWUMtnZaY+IS2m2PIOR5b4dep2Nx5XB CGFnq6XTV/qrlYGU4H3Ze4OiF2PVCoL0qPx2LXvB65CCfIMElK955GzratfNiTKdExlW audMBqkPtbKxCE8ddp5UEjdhyBVpix6Uu8sAEaWtO5yA9d61QoTOVruo00p4nL+/hhzy 1fnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dobCxK4OC92EBjp1RkCP1kDTote0DN9ExGNqTwwRdRU=; b=D97xKkisOFjoNV1NNMdNM1RIWjBRPTnQvuYdR+mQsL/f0aEMSZmwXlExVAbHDGiX+t Bg/d/kP21GAevJuB6r6mBru9EAQIvE/Bzgz7eBWY1Stz5OJhxAJnm1jQNj7IcTpF9J6c KXv8gxQDA8ej88gnBE0Yrf/vtWLJEY9u6G4GbskHjtNMPOFI4oUXz9+LLyygzPIKYP/o ArwnoRETtm8J3UMfXIi+w76+whoeSaQ1Nvg7gKvNpRIEATAs1z7az88tbr+LHVvoTnij +DTnXbhvR8OBgbYEIhjBR5U+I9RlUC32w/rniA6SWjnmzP/Z2pQ2G3v/2CgjT8ZfQrwA b/ug== X-Gm-Message-State: AOAM530k5eozCNLJ0wM4dcilalq9gdCIKFIOLaSa8baM4u2OHprSGu7O Y7uOrecM1A3JWkZdoJXmFTyE+8ReolX698p4XUM= X-Google-Smtp-Source: ABdhPJzy47iKor+i/UJAy5jAnbJ63ro9WfMBurWXy0/UksARPx2R31tHOrC/Zo8U5p9FKx23f3CXpQ== X-Received: by 2002:a05:6a00:164c:b0:50a:472a:6b0a with SMTP id m12-20020a056a00164c00b0050a472a6b0amr66474311pfc.77.1654086636639; Wed, 01 Jun 2022 05:30:36 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id x1-20020a170902820100b001618383483fsm1424740pln.224.2022.06.01.05.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 05:30:35 -0700 (PDT) From: Miaoqian Lin To: Codrin Ciubotariu , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Hans-Christian Egtvedt , Haavard Skinnemoen , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [RESEND PATCH] misc: atmel-ssc: Fix IRQ check in ssc_probe Date: Wed, 1 Jun 2022 16:30:26 +0400 Message-Id: <20220601123026.7119-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_053039_775170_67569730 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91") Signed-off-by: Miaoqian Lin Reviewed-by: Claudiu Beznea --- drivers/misc/atmel-ssc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index d6cd5537126c..69f9b0336410 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -232,9 +232,9 @@ static int ssc_probe(struct platform_device *pdev) clk_disable_unprepare(ssc->clk); ssc->irq = platform_get_irq(pdev, 0); - if (!ssc->irq) { + if (ssc->irq < 0) { dev_dbg(&pdev->dev, "could not get irq\n"); - return -ENXIO; + return ssc->irq; } mutex_lock(&user_lock);