From patchwork Fri Jun 3 13:08:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B105C433EF for ; Fri, 3 Jun 2022 13:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PWFB/ZUn+NXO2RCVQhucUuME/tmITFE8tvfBzj+uu7c=; b=cnDglHj1sR5pSe 2J5falXDS9DTq1tYSWpC6YTWgrCQvsb4co/suIrUDdU74I/2e32xunPN7Ck7RCyPeUEJRPj+6qqhI 5BYR+gFYGGDZnIADGse2HbJPYpAUd+H05XXOfwXWNpvNk85UTWdfTqM7oQtSjWQfnHr0OWEk6HTlY Rqtw0j0XW5scXH8I5MejiPpuNme9eNACItNFObyocORuMvXMQqHXpd71Fv3Oz7GUJmlBJ12N3wkbh rWBuWexjYcBs8m1IsoXJIpFoJaL+Vedtua+D6bY4tBfOgfAXUvudS//JkpKhsaTUTdqoaeUEj5VLi +OoPUCT8VgVsCIpI3Xmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx736-007W2t-Jd; Fri, 03 Jun 2022 13:09:08 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx731-007W14-WB; Fri, 03 Jun 2022 13:09:05 +0000 Received: by mail-pj1-x1030.google.com with SMTP id v11-20020a17090a4ecb00b001e2c5b837ccso12024177pjl.3; Fri, 03 Jun 2022 06:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mVZpEQ32MpZ2jjCKEG/4tHTxVZCWFD+esEDsknLSJKI=; b=WBAcoxSP2zhANkvtbfwCiU2kORsH55UzHh/mapzXWi/0kED+ukXlntdj8C/P8KM7oJ iILNZM0iQj0J0TPwakXUfYIeVZn+s5brhnRcfjXfMTqNRYU9XkmzPhHClWMiB2aKXQ50 gwPThywhc1UK4wdvZtdLNbXjXh4MOoksJQhDz3n+2O40MiUcoGno0UfleNFiFDI8Fg1L VP9+B1PP0TXkZ+vUSLs4rnyEp//KEwH0+mbZsFvLeBJ1suT7dyf+WLMrXKcQbCcAjrCZ CSR5X1MoCt2wxiW/D72BdUwHvkUhcZMhbS/SSFhPRrVGVj740SsGGjk8QvaBXqLP6gkL oXAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mVZpEQ32MpZ2jjCKEG/4tHTxVZCWFD+esEDsknLSJKI=; b=uBB28j96G/O0XPfWhVcPyiEtDrFLU7s/+wxU+gEbv/nRtzFIJaqdXncXHTJ3V5NmuA 2BTESvQ6XXomEhai5VGyeCG6owkyYawtEIw4UZMZ2yxNA0FxY3H7KuWGA277jPZwq3Ac N/fuZJHZmaUpaO3miaBlWyoWET3nRm1y7KzVTiWZqpLqwWMXn0MFugmc+biLAIv2hlAk 1DkEIUkIFV2epfKf3ZHKXUCMXijWhR3G+aosYsDM+LreTo4izSx6en1hZGZW5z6D5Pls zLhpJnUTCEotMXbEz/qx0Vuhd5k+WOqEtRc7NRX2i+cF86tbYytsXz+JS02+trPa9Ygf Oa1A== X-Gm-Message-State: AOAM533er+J16S89XYInj86SSbbgPGxmLq75soBF79WG44zSVwf1pd9t qa3HmtTFx7Pf5BIWwKArmew= X-Google-Smtp-Source: ABdhPJwFb/EjeiXip+FbPnvJM5M4Ceo7gNr0Wbt8APuryYL9ZXsDK3uuQDjpABp3K0y5wQ7HSUshnQ== X-Received: by 2002:a17:90b:3b4c:b0:1e0:3354:5e5d with SMTP id ot12-20020a17090b3b4c00b001e033545e5dmr46202726pjb.239.1654261740290; Fri, 03 Jun 2022 06:09:00 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id g69-20020a636b48000000b003fbfe88be17sm5166973pgc.24.2022.06.03.06.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 06:08:59 -0700 (PDT) From: Miaoqian Lin To: Nicolas Saenz Julienne , Broadcom internal kernel review list , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Marc Zyngier , Andrew Murray , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH v2] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe Date: Fri, 3 Jun 2022 17:08:49 +0400 Message-Id: <20220603130849.38252-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220603_060904_082954_0E119498 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") Signed-off-by: Miaoqian Lin Reviewed-by: Rob Herring --- changes in v2: - update Fixes tag. v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com --- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 375c0c40bbf8..e3b673441a11 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret = brcm_pcie_enable_msi(pcie); if (ret) { dev_err(pcie->dev, "probe of internal MSI failed"); + of_node_put(msi_np); goto fail; } + of_node_put(msi_np); } bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;