From patchwork Sun Jun 5 07:58:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FEA6C433EF for ; Sun, 5 Jun 2022 08:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jMS/fG/pOZVd/ESCnLrEOeSTFRbz7fnUzGLvZiL760c=; b=MyTkQz/QAIIWdP KjWbQbj2225ZOfHlIxyEWFWYk/9pS692rgfH22nDpSdXlHDtTg3Be3b5MNjVlSuFmcK0VfFIHlbOc bllZ3BnWUL+zT+bMXbU4+QyWL/xVonP3wkN+Y2f7vto4cF2uD0dVjHA/tinsOd1rSTft889kAZC7Q LNMp77m0IjCIk37upIJRdz1bxK1i9QWUfgA7koC/rt51gLbgTwf3A2XH1NIKNVdBQGwAJ230W9EZS sIw1GmXDOq+xX/Vr7Hi0O/4o0s1z+VIauzDxULQ5zAGjqquTcsbfrUZluzXUjyIHDQTTSi6fYX711 DkswRrFOzg5LdhAZjtwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxl9x-00Dw6v-9f; Sun, 05 Jun 2022 07:58:53 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxl9u-00Dw6J-Cr for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 07:58:51 +0000 Received: by mail-pf1-x432.google.com with SMTP id j6so10387375pfe.13 for ; Sun, 05 Jun 2022 00:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SIaW2W3kciWaqF9Rr2LnHumkokFFkDuqQM4YiszKM2Y=; b=nJgso2Q6AIEclla/wuH8+42F+fzYyKTBXqQde2ubdOoLHm4kscNoo4aMedMkX5mMAp bV8/zPpDAQNzvIXL0FmzesKSNBZedxG5c/BPxou8t1KKKxr/xhWy0sLbu9UHnKEL7FjZ MUKY099immUppc2dns9cYFASfhPXvyCWn7vLiL1OAmip00wjVb4rmW84cUfPU5OwrQJx AlgpmfFNK0sDMTzBQ7tACDLKypOEArTECBhFqD1LALG7f4CMz/f9G6kBLzM3dI1kpaB/ ltsgNCTez2+uSWf1c2DctfTCNO2u2fITwtR1SfS5aTZHM64kg2+XdZ68LB23/zFWaDgV tO5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SIaW2W3kciWaqF9Rr2LnHumkokFFkDuqQM4YiszKM2Y=; b=Fn/ajZJhBeQhImheAwbN8oJBDun7BzKwxFswv5laiTzTqsHIokrsm/JmuZlupJbJuj 26S7GYdADZQjeTDg3YyybL4l9u2hSZId73CCpgxpYQxXlejuL4M+bxClJx6I5y1+CpFr TCp1JSXCoe3t6xNKBwv9VDECOlPj+qwf/R3wyjKzfh9fPaGesQxOjIdU8h8rfu5xTO65 r733mSMbC7IleJ6nbSb0cIXy84VylxE4KoJYbCRsKr9Oy0hRzxIVGlCYS8xyDYsOahIW UfK363GNEfpl/fD+cRewbFqYirNYhvYj/psuiCt1O7I7HY0TxXy1aICuvf2n8HNjR3xK 1Hhw== X-Gm-Message-State: AOAM532Ihr0S77zlh7bVDzyR3Hg4fbT9gthmMpDJBesAV0y57HcVu+ar rUrDkR2h+IXMjt02tQP1xe0= X-Google-Smtp-Source: ABdhPJzY4AllDjrmX2fBbjfpvyFtvxSZFxKd9yd9eY6Pb7bv/UBqovBwq0AAXYIXMqZN/sK/DYNGfg== X-Received: by 2002:a63:7c4e:0:b0:380:8ae9:c975 with SMTP id l14-20020a637c4e000000b003808ae9c975mr16314985pgn.25.1654415929335; Sun, 05 Jun 2022 00:58:49 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id s16-20020aa78bd0000000b0051bbd79fc9csm7182568pfd.57.2022.06.05.00.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 00:58:48 -0700 (PDT) From: Miaoqian Lin To: Krzysztof Halasa , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init Date: Sun, 5 Jun 2022 11:58:41 +0400 Message-Id: <20220605075841.19929-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_005850_493594_251149FB X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support") Signed-off-by: Miaoqian Lin Acked-by: Krzysztof Halasa --- arch/arm/mach-cns3xxx/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c index e4f4b20b83a2..3fc4ec830e3a 100644 --- a/arch/arm/mach-cns3xxx/core.c +++ b/arch/arm/mach-cns3xxx/core.c @@ -372,6 +372,7 @@ static void __init cns3xxx_init(void) /* De-Asscer SATA Reset */ cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SATA)); } + of_node_put(dn); dn = of_find_compatible_node(NULL, NULL, "cavium,cns3420-sdhci"); if (of_device_is_available(dn)) { @@ -385,6 +386,7 @@ static void __init cns3xxx_init(void) cns3xxx_pwr_clk_en(CNS3XXX_PWR_CLK_EN(SDIO)); cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SDIO)); } + of_node_put(dn); pm_power_off = cns3xxx_power_off;