From patchwork Tue Jun 7 03:00:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12871304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A13D2C433EF for ; Tue, 7 Jun 2022 03:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wb3prgiXt60SqaT97qEt3zYtO6VmRDLvZKvF6b/CCHM=; b=cZBd+IxWndlgdG 1ZqkMKhXayk5Skqf2Wiy3vdtNN2LBJNwrf3lebG44hy8Ho97PmPGBVo8D2CW15FcUZVd0imEA9bRn cSXe9Mfk7eBFaXJgzzg3ClJGZPcx7Vw3HxkvdJhAjuv3DfQRF3PNYLuFw+i7E3n6K9C5Z5NTghnlE 7y0FwD/WxwC5JfQa0bu+n2AVf1qep9ePqvNjIXjuuCsIOBaUchRRCdcsJVPDL7NX+3UqteKk+37oZ dEBV5WRrfjSfNpPR9evoJHzwFwURXdKRZ17/4raKosi59JM8drFBlG7vczrAL+8VMtJyatTd6tG5O DOYTDorxCqcPNGb+4f+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyPT8-004F3h-5a; Tue, 07 Jun 2022 03:01:22 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyPT5-004F10-6b for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 03:01:20 +0000 Received: by mail-pl1-x62f.google.com with SMTP id u18so13697438plb.3 for ; Mon, 06 Jun 2022 20:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WQyqWY1DaF2KX7zCLh6Al5CBhTie1rko5iuwHl2wcu0=; b=g5tx3HSzjPwCPfnKaUUSX5bRcUPAxfnB3BrNTHzMAI3YPhZp1yZzEWNyrOmSv5AEId O2u25pKE4UoYC56ZYU3HX4o+OfIQpCkgG+rf6lbwiwJOXpVs8j/SyC378aRAVtF5v1EB amkqP4HcNnbo2wsVJ9Ra2zy2R501SjYgJSosQWRmC8ZinIq85SYLt7OA4/CE2dS33572 6CaxZtv1fP8BmqW/HfJ6LKTPYkuxKEN9PGBOcgcyeLu3dA+iiz/uPHfpASlWuM3HA7cn yioBOUYcUu2n0hzEKJbOZyEYcn+JGRMkN96WWfQbf7raAxl49q7ThuFP1c//gArFoJwP y2Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WQyqWY1DaF2KX7zCLh6Al5CBhTie1rko5iuwHl2wcu0=; b=QyvrevFvWGV5SeTQWZdA9OYe0hlnYyE7wpjh3qJTHVo90+87gabYdKj5chQ2JgiDEL y64NniWOeZG53EHq53Am9T4IIzHwDZ8n2pBjc2SnI7tVg1u6rpAVKu/0jdRiOPSUpZ1v yqNNQ+WQOcxDc2NfP6xTuAnqFawIhrX3WhxUkR7r0YXn7X88oHTWfwRQaPKmsZsAcIOr Cofm1uMii8SfeMXs3FnHqkonOMjzv3c+Q9X3KVm5r46gOy56kjhjLZfgSWwhXF6mrwoB MUG5JVjZhKktb74EmEsGgGVKDLRiPPKB+s6JGl4Ve2htut19g4p/CCVQdAQAN/3tCyAk +d0Q== X-Gm-Message-State: AOAM533SMkP/Njk1ASApu+p8+4WiiYgaYR8h+sb2+6v91/t39+PbuY4R sHhVzzeHIZBGHDa87joQhz0= X-Google-Smtp-Source: ABdhPJw8h6WtpEg/INJaH9p1F9/23RL/px1c4AekgPVVBjIRK7MKG0L0hBk1ulCS9RAUrEeZ7SGBdQ== X-Received: by 2002:a17:90b:3b4e:b0:1e8:743a:735c with SMTP id ot14-20020a17090b3b4e00b001e8743a735cmr11707056pjb.189.1654570877129; Mon, 06 Jun 2022 20:01:17 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id gt24-20020a17090af2d800b001e3351cb7fbsm13217382pjb.28.2022.06.06.20.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 20:01:16 -0700 (PDT) From: Miaoqian Lin To: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Miaoqian Lin , Mihai Sain , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init Date: Tue, 7 Jun 2022 07:00:55 +0400 Message-Id: <20220607030058.53695-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_200119_321607_79F12203 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 960ddf70cc11 ("drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs") Signed-off-by: Miaoqian Lin Reviewed-by: Claudiu Beznea --- changes in v2: - create new variable match to refactor the patch. v1 Link: https://lore.kernel.org/r/20220605084035.27127-1-linmq006@gmail.com --- drivers/soc/atmel/soc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c index b2d365ae0282..7152a38c657a 100644 --- a/drivers/soc/atmel/soc.c +++ b/drivers/soc/atmel/soc.c @@ -368,8 +368,11 @@ static const struct of_device_id at91_soc_allowed_list[] __initconst = { static int __init atmel_soc_device_init(void) { struct device_node *np = of_find_node_by_path("/"); + const struct of_device_id *match; - if (!of_match_node(at91_soc_allowed_list, np)) + match = of_match_node(at91_soc_allowed_list, np); + of_node_put(np); + if (!match) return 0; at91_soc_init(socs);