From patchwork Thu Jun 9 14:14:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 12875617 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1180EC43334 for ; Thu, 9 Jun 2022 14:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236709AbiFIOPC (ORCPT ); Thu, 9 Jun 2022 10:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235502AbiFIOPA (ORCPT ); Thu, 9 Jun 2022 10:15:00 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28696712FA for ; Thu, 9 Jun 2022 07:14:57 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7B312C000A; Thu, 9 Jun 2022 14:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654784096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yqqc+sX57VUv6x0xqxtveG3qFJraJsoM6L4mjEa0RTs=; b=HiDdskUvqDW9kQBwmII99+Sp3aCP8zKMSqFCcdKvYGRdE2zg9otZjaFDbi2woHP1ZcGw1D +oNFSeJ2dle73Z8GQJi042rCaLe4R2QMlI2Al+7G1ttZc1BQ5f0DO044Xgd7uyFvUNGW+e 3UA8YELJJYpQtLUhuhFyP0FNPqO8JcT1X+NK9GbjYMCyosG4PU/XsaYgoyI/WMXD3Bx+aF aIgRpPV1/C98z/S9e/uyWw5cG/1L673GTtLLODJzVQQoeTsVU8pUTc5OTYkud9UgN3fJB4 9MSWyErpEaA7PdTZngEzhPL/xi1qByV7m4sW3HvM3oSIJgmaA6mM7mVSXaAVHg== From: Miquel Raynal To: Vinod Koul , dmaengine@vger.kernel.org Cc: Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Andy Shevchenko , ilpo.jarvinen@linux.intel.com, Miquel Raynal Subject: [PATCH v3 1/2] dmaengine: dw: dmamux: Export the module device table Date: Thu, 9 Jun 2022 16:14:54 +0200 Message-Id: <20220609141455.300879-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org This is a tristate driver that can be built as a module, as a result, the OF match table should be exported with MODULE_DEVICE_TABLE(). Fixes: 134d9c52fca2 ("dmaengine: dw: dmamux: Introduce RZN1 DMA router support") Signed-off-by: Miquel Raynal Reviewed-by: Andy Shevchenko --- Changes in v3: * Added a Fixes tag. Changes in v2: * New patch. drivers/dma/dw/rzn1-dmamux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/dw/rzn1-dmamux.c b/drivers/dma/dw/rzn1-dmamux.c index 11d254e450b0..0ce4fb58185e 100644 --- a/drivers/dma/dw/rzn1-dmamux.c +++ b/drivers/dma/dw/rzn1-dmamux.c @@ -140,6 +140,7 @@ static const struct of_device_id rzn1_dmamux_match[] = { { .compatible = "renesas,rzn1-dmamux" }, {} }; +MODULE_DEVICE_TABLE(of, rzn1_dmamux_match); static struct platform_driver rzn1_dmamux_driver = { .driver = { From patchwork Thu Jun 9 14:14:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 12875618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDA4C433EF for ; Thu, 9 Jun 2022 14:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236881AbiFIOPC (ORCPT ); Thu, 9 Jun 2022 10:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232769AbiFIOPB (ORCPT ); Thu, 9 Jun 2022 10:15:01 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32D2970900 for ; Thu, 9 Jun 2022 07:14:59 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 02422C0006; Thu, 9 Jun 2022 14:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654784098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qU4oagj4tmBBbz/bXVPLwpPMYm3wl3oHGQ/HFAFCC5Y=; b=EGZd6e6Fs515CU8ZS4Sy+XqXDCeDiRqd4feWmuVhO6vQTXKnvZ4zdBtFJrXUJev61USXdN t1ai5aHYGNiVoIoatXn4MhFONyKrFSPShREyFUh38f5PTGO6pjutoX1Cl4qVZT5EqZOpBQ 4OxfjjHLShaMtcDVSlNNQEhpUki1ks2MTcocMua2Iha7iyN5RIfjdaorg4RegKdG/V41Ck 15gDQOAnVT47HBF/lnfI2n0rZxGIyufEN9iMGQOehh8kRQ8bahuyuY8g4PbmTeL5Vsibmu c+hzxj2/AUigwAC2wxn/eahMh9/EEkaRj1xZ0b1lZFH0LskoxWeuDqdx0cSJag== From: Miquel Raynal To: Vinod Koul , dmaengine@vger.kernel.org Cc: Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Andy Shevchenko , ilpo.jarvinen@linux.intel.com, Miquel Raynal , kernel test robot Subject: [PATCH v3 2/2] dmaengine: dw: dmamux: Fix build without CONFIG_OF Date: Thu, 9 Jun 2022 16:14:55 +0200 Message-Id: <20220609141455.300879-2-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220609141455.300879-1-miquel.raynal@bootlin.com> References: <20220609141455.300879-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org When built without OF support, of_match_node() expands to NULL, which produces the following output: >> drivers/dma/dw/rzn1-dmamux.c:105:34: warning: unused variable 'rzn1_dmac_match' [-Wunused-const-variable] static const struct of_device_id rzn1_dmac_match[] = { One way to silence the warning is to enclose the structure definition with an #ifdef CONFIG_OF/#endif block. Fixes: 134d9c52fca2 ("dmaengine: dw: dmamux: Introduce RZN1 DMA router support") Reported-by: kernel test robot Signed-off-by: Miquel Raynal Reviewed-by: Andy Shevchenko --- Changes in v3: * Did not extend the change to the second match table as requested by Andy. * Added a Fixes tag. Changes in v2: * Used the #ifdef solution rather than the __maybe_unused keyword. drivers/dma/dw/rzn1-dmamux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw/rzn1-dmamux.c b/drivers/dma/dw/rzn1-dmamux.c index 0ce4fb58185e..f9912c3dd4d7 100644 --- a/drivers/dma/dw/rzn1-dmamux.c +++ b/drivers/dma/dw/rzn1-dmamux.c @@ -102,10 +102,12 @@ static void *rzn1_dmamux_route_allocate(struct of_phandle_args *dma_spec, return ERR_PTR(ret); } +#ifdef CONFIG_OF static const struct of_device_id rzn1_dmac_match[] = { { .compatible = "renesas,rzn1-dma" }, {} }; +#endif static int rzn1_dmamux_probe(struct platform_device *pdev) {