From patchwork Thu Jun 9 22:16:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876028 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F03AC43334 for ; Thu, 9 Jun 2022 22:17:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F128D0051; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24238D0034; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC49C8D0051; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BD0B48D0034 for ; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8DDFF1076 for ; Thu, 9 Jun 2022 22:17:40 +0000 (UTC) X-FDA: 79560110280.26.CCBD23F Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf19.hostedemail.com (Postfix) with ESMTP id 2D23E1A0051 for ; Thu, 9 Jun 2022 22:17:40 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-30c1d90587dso212884347b3.14 for ; Thu, 09 Jun 2022 15:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=RBpkYSjEyD64s1FKNQbtXE7AfdgJKfYmd5PMKe66FHnMYYo7vB0Ncyw1KRR50CoJoo aoycDWjxbUREKPl/jCi5J+ZmN745Yr3i1ib/+VcJJf8M0JMLiwl79xnz8rJSR7GD/eD1 lW/QxkZdjk6n9mbnb49kc1QuGbm9WiR5bRhdOxYxvavs/N1vvPSKHy30utzBB/gyWoTU CgiL6ug+u8f1QpKo/0EMJTNBBIk/eilNKeOEcwDZBOTEwWg6fyCqMv4cdogePUE+xetI whOzeQ9ub81nWd36wnDnSka41WjIxLP4QO+2B8XH0LL13vJc0ad+W0zJV+BD/RIy1FOR 5kSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=6b+SdNqwANA4HcFcBCH0iSan+cNBYnfgikgjt23MzvG7obVqcJstPxRg15uoWEwrlb VL1wodqSsos/DomQc1WVumqXJ0q/uW7r8fXyqZLFdYgrLPY0JWlQHnIrH8XqJ8NT9X5y QtVb+ecv8abKTM6W4U5bh9eIhHKi3finm2zk5d6grWsMIuprWC1jHic+FaqIIrqaGZUp CPPkcj0EbGxsbenw9NKyRsRYuLfJcAvQ/aRtd44CFe3TGfwtxKimTTaPUFxAczA2ROlS OtLjSOEMbI93J4Mptx/C5IvBPuzkJP+y6mXC5/vf3OY3TjWASfv1LY/uSPWrSF6uGmyH X1qA== X-Gm-Message-State: AOAM532AwKJUrlj5aEq7+TvJ4GahOpJV8RbR7biSQ8LJRg+NymXGo/6P /r9l2fh+gOc/BHy4Ze4EyhfPHDLv X-Google-Smtp-Source: ABdhPJzTMnxRPuV6ZGJzvW5l0mMjxHOaj61kW/6XxvKjUl64lqYEHjJSEX/Dfo2Nrwl6bkVAjyNEv78Ldw== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a25:fe0d:0:b0:64d:915f:e73e with SMTP id k13-20020a25fe0d000000b0064d915fe73emr42473933ybe.447.1654813059372; Thu, 09 Jun 2022 15:17:39 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:20 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-2-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 01/12] x86/mce: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813060; a=rsa-sha256; cv=none; b=N82tXIHokgeXjUDrcYi3FFlrPRemoguyIsx3wEuGj9vuJOYFQkQt7qF39px4p0eiX2juzX 9iK+DZol9yfdmhwE7urHYHH3mjVEsPKALKynvw76Q4Np1HAu+B5MpRddVBoww8isbuYInY FVE3Jr0KOH2yUPkvnckyB7RzfmiNCJ8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBpkYSjE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=FXJ04DIOAlIuXzigXFXwLSvpiD2KKehplOQnAL+3uapDmwoLSQgufrFL2zCnHXjTLKvNFn X6Uyhim33f++f/mCEoYeLhcMed+TmWmjQebPSEJG8CrJlQLJTe8KTVLDY95YY+Dws0M7+e wDcOnebFHTwY41ekZ8jVdudGlYl0YnE= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2D23E1A0051 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBpkYSjE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com X-Stat-Signature: smhxtirawe4i887wab64ft8mfsmtif3o X-HE-Tag: 1654813060-797552 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] panic(msg); ^~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- arch/x86/kernel/cpu/mce/core.c | 2 +- scripts/Makefile.extrawarn | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 2c8ec5c71712..3d411b7c85ad 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) if (!fake_panic) { if (panic_timeout == 0) panic_timeout = mca_cfg.panic_timeout; - panic(msg); + panic("%s", msg); } else pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); From patchwork Thu Jun 9 22:16:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A92FC433EF for ; Thu, 9 Jun 2022 22:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12F458D0052; Thu, 9 Jun 2022 18:18:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B7298D0034; Thu, 9 Jun 2022 18:18:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4B968D0052; Thu, 9 Jun 2022 18:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CDEB08D0034 for ; Thu, 9 Jun 2022 18:18:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AE54A216FD for ; Thu, 9 Jun 2022 22:18:03 +0000 (UTC) X-FDA: 79560111246.05.4A367B6 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf18.hostedemail.com (Postfix) with ESMTP id 5920C1C005D for ; Thu, 9 Jun 2022 22:18:03 +0000 (UTC) Received: by mail-pl1-f201.google.com with SMTP id p2-20020a170902e74200b00164081f682cso13397982plf.16 for ; Thu, 09 Jun 2022 15:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=SFFjvyZvefpU9NrWWzQ0TAmvQ8SzfCLTau1AjR7El54=; b=Kr2RYZFWYOeNjzG0DXVZ1PIX9XZMzBF03Z569egSujYX+SETM8BM22isVSs7ZYg0je vtmIi51QjRTMj1fwLrkgjqNVlwKBP1pP5HLG5JFnMd4QeQYx2K01nU1Ejrc/H0elX0dB xVMAEAznym96CzfG/aOkwGNw3H9g+blFPI7HqqKYy6VdsppoXnWpV0WmljI7FHufbK83 ON+xFi3394AkXlTQEdIEaihpVBJQ8PGsd812EFScZ5x0FGwt1QmokUw/eccZEX97Itvg V6YGaLMc68zBNDG7tvYESM8uNaTijhm4Fewwwm5H2YtyjsN07CoVm9f4qHoqAerZAXZJ XTVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=SFFjvyZvefpU9NrWWzQ0TAmvQ8SzfCLTau1AjR7El54=; b=q8dz0CVm2IrN4YBnRVoqU1jJ9Ij1rimvwmJIjEM7ZFKTedRROIU2ffczON/iySqSOz aiwTI+QYQ40txqOShC7PG93rELNQGnB9UkILFmSJvt8IfJ05QZUT1Ktqg+DNUM8TisZl ftH4ARafM4acW07LORbFrM0a1E+XDcqVUw7sPJ5ExB3AZYG5R5nZuF6nz6kO43m/6ViJ 8uekqGF1PMduHykjrXC5/+qFA/frfG4BSR3ZxyJtAnPARvsgJbo/7ZV5jHpHqNk1SPW5 R/HwbW/bHAzFHCqCyYJoQskP1C0Qnbj3rqrzljjJGZGtH2TTeQIfp0hCokXcT9iqjkJa mzQA== X-Gm-Message-State: AOAM532WLlyvjUct3rM+DGPM8MkJNuElAOLhW8OerBK2rbHW7BSzNAEw jUb/34qDAh03yjfB1ZRXOGkaE1ED X-Google-Smtp-Source: ABdhPJweUcyR1bJf/XiwDrAaJ+hZ/VGm1qzwS+oRhWzjXi1BAcLnFDZIdAsYxk3A8uUCFP+evw6wWgyl2Q== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:35ce:0:b0:3fd:fb5a:a1c3 with SMTP id c197-20020a6335ce000000b003fdfb5aa1c3mr15000208pga.85.1654813082090; Thu, 09 Jun 2022 15:18:02 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:21 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-3-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 02/12] x86/CPU/AMD: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SFFjvyZvefpU9NrWWzQ0TAmvQ8SzfCLTau1AjR7El54=; b=riPp7RBTzArn5WO2gWXoRCmYEuBZkOR5PSINdMc976F4H+N6fwFnr9SvoE1yWvUR/jwnMa TmknoYyd2mhtgiedrcBsARX4OAwY11nH8wSJjV9OgfkltDSd1cXpzDh2reXxcOPr2JdIq4 Ay8zhS3DQTAh4eJR6tQWb2e7OtKSVBQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Kr2RYZFW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3mnGiYgUKCCMLNQANFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--morbo.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3mnGiYgUKCCMLNQANFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--morbo.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813083; a=rsa-sha256; cv=none; b=Q5nPcd+IscWmPo8JbkenqoFE/8N1BxsqrCsEtWaffPCa05nhZG5p9UPU9T6x09Gl2X9Fuc ch7uw1Z6I5+R4gwbZhHyIx2HUmdbsURmEU0yDmZGdCgTuyF8dRzfqGtDCcPyqwZ5MHMWoc SNzc2WMLjOtBsfFo33YnlgqIr+vZid8= X-Stat-Signature: u8tcjzhsqqi69kwpgehx5zjiaaxa87b4 X-Rspamd-Queue-Id: 5920C1C005D Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Kr2RYZFW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3mnGiYgUKCCMLNQANFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--morbo.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3mnGiYgUKCCMLNQANFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--morbo.bounces.google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1654813083-694186 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: arch/x86/kernel/cpu/mce/amd.c:1119:67: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] err = kobject_init_and_add(&b->kobj, &threshold_ktype, tb->kobj, get_name(cpu, bank, b)); ^~~~~~~~~~~~~~~~~~~~~~ arch/x86/kernel/cpu/mce/amd.c:1151:47: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] err = kobject_add(&b->blocks->kobj, b->kobj, b->blocks->kobj.name); ^~~~~~~~~~~~~~~~~~~~ arch/x86/kernel/cpu/mce/amd.c:1157:42: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] err = kobject_add(&pos->kobj, b->kobj, pos->kobj.name); ^~~~~~~~~~~~~~ arch/x86/kernel/cpu/mce/amd.c:1187:43: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] err = kobject_add(b->kobj, &dev->kobj, name); ^~~~ "%s", Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- arch/x86/kernel/cpu/mce/amd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 1c87501e0fa3..d19bf0eb0abe 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -1116,7 +1116,8 @@ static int allocate_threshold_blocks(unsigned int cpu, struct threshold_bank *tb else tb->blocks = b; - err = kobject_init_and_add(&b->kobj, &threshold_ktype, tb->kobj, get_name(cpu, bank, b)); + err = kobject_init_and_add(&b->kobj, &threshold_ktype, tb->kobj, "%s", + get_name(cpu, bank, b)); if (err) goto out_free; recurse: @@ -1148,13 +1149,13 @@ static int __threshold_add_blocks(struct threshold_bank *b) struct threshold_block *tmp = NULL; int err = 0; - err = kobject_add(&b->blocks->kobj, b->kobj, b->blocks->kobj.name); + err = kobject_add(&b->blocks->kobj, b->kobj, "%s", b->blocks->kobj.name); if (err) return err; list_for_each_entry_safe(pos, tmp, head, miscj) { - err = kobject_add(&pos->kobj, b->kobj, pos->kobj.name); + err = kobject_add(&pos->kobj, b->kobj, "%s", pos->kobj.name); if (err) { list_for_each_entry_safe_reverse(pos, tmp, head, miscj) kobject_del(&pos->kobj); @@ -1184,7 +1185,7 @@ static int threshold_create_bank(struct threshold_bank **bp, unsigned int cpu, if (nb && nb->bank4) { /* yes, use it */ b = nb->bank4; - err = kobject_add(b->kobj, &dev->kobj, name); + err = kobject_add(b->kobj, &dev->kobj, "%s", name); if (err) goto out; From patchwork Thu Jun 9 22:16:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876054 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16109C433EF for ; Thu, 9 Jun 2022 22:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E0FC8D0053; Thu, 9 Jun 2022 18:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 968CF8D0034; Thu, 9 Jun 2022 18:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80B638D0053; Thu, 9 Jun 2022 18:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C2268D0034 for ; Thu, 9 Jun 2022 18:18:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C05B16A7 for ; Thu, 9 Jun 2022 22:18:27 +0000 (UTC) X-FDA: 79560112254.26.1948E3D Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf05.hostedemail.com (Postfix) with ESMTP id D5E08100068 for ; Thu, 9 Jun 2022 22:18:26 +0000 (UTC) Received: by mail-pf1-f202.google.com with SMTP id 18-20020a621512000000b0051b90b3a793so12972266pfv.8 for ; Thu, 09 Jun 2022 15:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=zQ6igRU/lPsPPjITd4pdT0XeOfhGOx4hu6xL7AAJoM8=; b=QJYSL92EGHv0Glqefsz+fZAyuHXsVDJ+MxqtY38p/rJWyzN9tqq38im0/nAHSSrAcw XMQ6nAGoVVakkYRIOxtqwHJW03YmZH40gkW7E/YkdAEWc9hWN2V7ngXOGdkLxNXXFPVz MM6SoDd9zGDwN7h4y2Zv5sUmYXsKm79QEart8XywqgYgGMlR5uKSmr2M8zPPYELNG0fC sjbVW5cOWu2CabVPyhNOvTWLIe4OkL9eosbWQbgqXLmWmjLl4VHTPCfxGjF9R4eBYA8S SWfDBEXFQ0GXfeXiQjFQ4xktd6Mieq2x7asfEjehSXBFdpIoHP2WaOku4Aej/pIaybf5 FCNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=zQ6igRU/lPsPPjITd4pdT0XeOfhGOx4hu6xL7AAJoM8=; b=z7X1CcUXj69usnOC5UkPmjPr2dIIPEi4kSlDiL+5OBlglQXiYJbtkl4Lgu7fG/viaP RsZ6Xs26Qav/xM+yC02mW0YNfJEwJm4adsPez/aEPSOua39XkE4r6V3YKP2TmCjs8a9N vDVZee7ZGwrdfpeWfdRIoZ0IX9cYjxwCO1zuC2T6geunN8Y+W1aYS0be9qMYn/SQtd9U auDJNsxJwXQGTfbZAPtQ1x4vIsghTIpPUZtZlHEevAz4Gih6/rmWX5qRPGAbSAWShZ/j f4P9aiyZc+FquBIpju2znirovSEdYRdWGFjV2KzaibYyA3hxrX1d0ywdno25sXHoI7l6 A7XQ== X-Gm-Message-State: AOAM5324kkZFlAQFY8WsECAKZkym/iRnKKT2UAmEK6RopJ3dFXZnbxOG M6vyM4gNN5RhFbsAz+yWNL3a20vs X-Google-Smtp-Source: ABdhPJwaaQIFrsaGRD2eHE0bL/iy5r4Z+mF9XLusw0L85/0I2ggYu7uuJziQ3x377wlgzuNlbfNxKB4Iyw== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a17:90a:249:b0:1e0:a8a3:3c6c with SMTP id t9-20020a17090a024900b001e0a8a33c6cmr114285pje.0.1654813104885; Thu, 09 Jun 2022 15:18:24 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:22 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-4-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 03/12] x86/e820: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813106; a=rsa-sha256; cv=none; b=n6BGhLlcyvd1tyKzW9uMHiyNAYoVo0xVokiN+LsUXQeGAzm2rDSQMc9kWOJ2xHVi4HdbZv hPTrbozfGA4rmG7XF9UGycHixZV4YR9YUAm27TPKV+NErZc2iCKBqojl4Yaxbb4m7u7vyq Ubhad5T1q5hTxQhfRlvzeU5mLF1B8zs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QJYSL92E; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3sHGiYgUKCDkhjmWjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--morbo.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3sHGiYgUKCDkhjmWjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--morbo.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zQ6igRU/lPsPPjITd4pdT0XeOfhGOx4hu6xL7AAJoM8=; b=cHfZSZ0W1ptb4tihffAOAF+H5GwVi1TfA1Cxj1PBwtkA7A2/qW3OmU8lGndYxOquEIxOP5 ZWIv5FN5lRntj8gfEW11eKDX2CsZQSR26hR933faPCmshkD6g7ZvAvIbH72QWzPZvQHbax gKdxqJ1MEz8jEXYYcyDfzk25hyinpAE= X-Stat-Signature: gjcyg4kskwn7wn7t3fzptzcp1weyqah1 X-Rspamd-Queue-Id: D5E08100068 X-Rspam-User: X-Rspamd-Server: rspam10 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QJYSL92E; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3sHGiYgUKCDkhjmWjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--morbo.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3sHGiYgUKCDkhjmWjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--morbo.bounces.google.com X-HE-Tag: 1654813106-83760 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: arch/x86/kernel/e820.c:877:15: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] early_printk(msg); ^~~ arch/x86/kernel/e820.c:878:8: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] panic(msg); ^~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- arch/x86/kernel/e820.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index f267205f2d5a..ca4634a0bdb5 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -874,8 +874,8 @@ unsigned long __init e820__end_of_low_ram_pfn(void) static void __init early_panic(char *msg) { - early_printk(msg); - panic(msg); + early_printk("%s", msg); + panic("%s", msg); } static int userdef __initdata; From patchwork Thu Jun 9 22:16:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C21C43334 for ; Thu, 9 Jun 2022 22:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDA098D0054; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D890A8D0034; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C028C8D0054; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A9A7B8D0034 for ; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 857C661728 for ; Thu, 9 Jun 2022 22:18:49 +0000 (UTC) X-FDA: 79560113178.26.A413A8C Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf16.hostedemail.com (Postfix) with ESMTP id 232F2180057 for ; Thu, 9 Jun 2022 22:18:48 +0000 (UTC) Received: by mail-pj1-f74.google.com with SMTP id t11-20020a17090a2f8b00b001ea6a226d21so262713pjd.8 for ; Thu, 09 Jun 2022 15:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=qNUPK/S5iHdXgPK57Bkixsq++QOQQMHfyV6r2MtPs7v9I3SUg8azHVdlWi+Vmpdk0V e9swXJWEpf/dXShWMQkD9tdieecIjQpQiuIyNIyGp6c4DhP+OHtn6lVN3Jb0aUWnt0zX 6WRDoSX5skQyQJy1DXGgbB1frbSREBbKFeP8ovCXNP1nwpzQihNeuZDVsxzVVQEW/FTO oasKzV38q06qXK4hlfrcDIvuu6az9YMh+LOMOYwAEM/GaKPtPsyF6cfogObTYmCvxbsF HDhlFK8BOzg5MG7pql3z3B69jG4uxkigcwMhH0FMhZG9+AiHWiMvxTL/b/XFzI/yrt60 XE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=5i0Z0Y/sE9MZtkxnbsAWaMIyXjzdnj+Wjjoo1T/unz4E+21Z4752xPNpMQLzA35m+W TYoM3JVY4utNQNLi3sFPH6S0IhSPTZCmK5Nj5CgOgGWIHYgEkv4SmVrbjOxA6qtQ1jnZ AXLJHAGmTs+ucZvygtI5mGrT6CIldR6GyyPzINeDrJsW4jcGiN7C0kYtl6YML16xHc5e VHQEWRf/EaEV07Q4sqPlebR8EUorfjHLPh0JlWCuaVxqdvE90sTNIzaQpQgF5Teu+Zcj JvK22+SgCZLZFP39AsE1z6CJZDa7IlKuRejB9KebU3XW5bbt1U0gmeA/JkjQnKJv7KZF BDAg== X-Gm-Message-State: AOAM531z0fNiP2Z/MsTXnPOkMbbkQVfXVgrod+WTHTUmddecxa/jr10a ZTTZiPOAnNOo7+dbM/r/e0NBtD/e X-Google-Smtp-Source: ABdhPJxktSZZjGsZMg+ncs7oCo7UsGcqz2MItXnZVpN7aAWxKCb/sSBN71lrVJLJ6nxui+334t4TDARu1w== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:5924:0:b0:3fb:a75e:9e8a with SMTP id n36-20020a635924000000b003fba75e9e8amr36694755pgb.394.1654813127925; Thu, 09 Jun 2022 15:18:47 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:23 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-5-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 04/12] blk-cgroup: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813129; a=rsa-sha256; cv=none; b=NE4yy7t2mysw/NrEHtQ9mtIfL0CO+JeLKUk20NRKgJnzjnVrvKOGkmxiLzC/7FQhg0cQOX 7o9Okh4OayQjbqe8gu7LIRHIEA7MBPLMI5dpdliFC+BNgvQ49mAAlzdPUNYhBk6doTdil8 E4tXtgcnaorCZRG+hbCOgYC6FqcS7yc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qNUPK/S5"; spf=pass (imf16.hostedemail.com: domain of 3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=5Hn0jzUQ6AsWzyhperDYRVZdgZDoIv7iZ12azt8+YdRhwMedFoXUyuwxAPBk7viEZApnWh 39DppUPL9BGlUdF9E8uzrC3EB/kg5uj6W0TDZdQTaUx59G6Eco6GEyXEPR5rAWZs4vEoPp pspTJGab9/nmRz2mfbjwO6m0YW5nkd8= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 232F2180057 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qNUPK/S5"; spf=pass (imf16.hostedemail.com: domain of 3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: u6e1uo3asekypfp738t3re8tp7fpfjns X-HE-Tag: 1654813128-609726 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: mm/backing-dev.c:880:57: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); ^~~~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- mm/backing-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index ff60bd7d74e0..7b7786dceff3 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -877,7 +877,7 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args) return 0; vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name); if (IS_ERR(dev)) return PTR_ERR(dev); From patchwork Thu Jun 9 22:16:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70A8C433EF for ; Thu, 9 Jun 2022 22:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C2568D0055; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AEE8D0034; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DB08D0055; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 238E18D0034 for ; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id F3BC412101B for ; Thu, 9 Jun 2022 22:19:11 +0000 (UTC) X-FDA: 79560114144.08.772A96D Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf08.hostedemail.com (Postfix) with ESMTP id 9A1B3160067 for ; Thu, 9 Jun 2022 22:19:11 +0000 (UTC) Received: by mail-pf1-f201.google.com with SMTP id d2-20020aa78142000000b0051c394e5226so4833291pfn.19 for ; Thu, 09 Jun 2022 15:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=ezNDouTkewW/awvW/cRvKC6jHhcMBl4eQkJi6sdP+X2J6iJMkd00jA2jaRJhpFY7aw yxivdcEq++4iV1GgB2ziv1ayV3oP8FWg/GB0Zo4bN9LSRrIbKMWW4pYYedFNqaZbtBdq LI7orAiKEXNDUMTMRTz+eYmtPr0ihFSVRZhCMEgns7LQjXXffU9ysRs8Jm7/xp/mkHV8 hqJ/WTn4IigfYhYdyyonY3s//N3eKAKkW8RZYgrVC9YsY682gIJn1c0bZa76vTplgKaA 3OGnJiqbOGhiGk4PrcLnGinCbRAB3xGsfKwPwyZscTB2mgetoP8/LmB/5HB6hMrHCgU0 s7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=6J5jvBdYMQxnHqhw4+AWjqcoXvemy5gO7hckZRz5gVTvA0ItQcYeEHlIR5fwKydDNa ffnIgJf5Mmh3cPn/W0lVmAMRz9ul9GHslyONkdeWayscWK/AqLBOMdZ7Fh859Fm/JaJI DuCJ22Rv30f66EodrisWR0qGgGo9L2KHz0Y92FKRHWzlesDIxF5pqNZZHy9GfhPRqeSX bVGIgBoVGgKrNN1iSmSqcVTai8T4/dfoaRIzFYaK7bl82T94VsA4oekRFXBeWhkfd1Rx 9Ug7tTAPxnzq0mUjD/qXLtDeNpYkU8dkCypk+7I+nu4o6afywuaFUAlhYmFjRcXaBa2M slag== X-Gm-Message-State: AOAM530rx/oZXweMGf0S4dN6U91AMw32CnOAn8V6fQcDdOlPJtOJqoZK pBa26SszDkoKcW9GTC9x1sj/QhFz X-Google-Smtp-Source: ABdhPJymRh8XdI6qUr+0U3jn9BPA1WS3MroiwqAq54XxkobNI9HSYvmGC6qhWN+ZtdS8zin/gyNAdfGHUw== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:c5:0:b0:3fe:26a0:7abe with SMTP id 188-20020a6300c5000000b003fe26a07abemr10973746pga.152.1654813150612; Thu, 09 Jun 2022 15:19:10 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:24 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-6-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 05/12] fs: quota: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=Dbypp6TZHbduxwIg8qxU+Ga92/3Al+zWSoW8DMWiBl9AfUlmpMRUC1w57vKUhGCUIsnqOv sKL8t70f7uV9DVt6bYV+49XhJ7aY6p4+5rb+1y0rMoG6VGn9FAGHQwHGsNlPMLrR9skdrI omp7cNSwOFBRAo4H3UfnpHEfWJrfQ+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813151; a=rsa-sha256; cv=none; b=Vhs7iSBW5JC5Aq0zmubA3/dX6OX/GzYZu2OpAlMcsTEE2m55KGNZ6NvBN9agcRJXxxx5+I j6oKhgKrjd0RyGTUZWGUwkXuH6JZvTYdWGBzngqaMt1e0LowGoDt80Fa948i5cYDHRuig/ uzQ+xwuRXkbhnI8/py+IYtAFuUEMdu8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ezNDouTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ezNDouTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com X-Stat-Signature: ih8yms6pz96koos6wbufiu81h9srbmny X-Rspamd-Queue-Id: 9A1B3160067 X-HE-Tag: 1654813151-497896 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: fs/quota/dquot.c:206:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(module_names[qm].qm_mod_name)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- fs/quota/dquot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index a74aef99bd3d..3b613de3b371 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -203,7 +203,7 @@ static struct quota_format_type *find_quota_format(int id) module_names[qm].qm_fmt_id != id; qm++) ; if (!module_names[qm].qm_fmt_id || - request_module(module_names[qm].qm_mod_name)) + request_module("%s", module_names[qm].qm_mod_name)) return NULL; spin_lock(&dq_list_lock); From patchwork Thu Jun 9 22:16:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FFDC433EF for ; Thu, 9 Jun 2022 22:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FAE68D0056; Thu, 9 Jun 2022 18:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 683C28D0034; Thu, 9 Jun 2022 18:19:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5250B8D0056; Thu, 9 Jun 2022 18:19:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3CCE38D0034 for ; Thu, 9 Jun 2022 18:19:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0C4E4216FD for ; Thu, 9 Jun 2022 22:19:35 +0000 (UTC) X-FDA: 79560115110.08.7557680 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf26.hostedemail.com (Postfix) with ESMTP id 7A7DF140073 for ; Thu, 9 Jun 2022 22:19:34 +0000 (UTC) Received: by mail-pg1-f201.google.com with SMTP id t14-20020a65608e000000b003fa321e8ea3so12330550pgu.18 for ; Thu, 09 Jun 2022 15:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=VtmBCpNp1KP0Wih0wNtSn6S6eDN4r8qEfTH0S3sfDvI=; b=k5UJiPwakkG5FRIZZ5lAwSHv1cl5CV0HckKotKPvFRLB2rm04skCRUAH92Ocj74nI8 VRgM32h5RM5BUgSugbEFBV15QskHdJF/UARg45aXgMXIqpE44JaqgZSOgpAQZ1jpikDb GULMqiClDzX4kfuE9w7o93QGAbqsh6kUT85oC3PEd1vaEzeRnphtmpPAmbhnAhgk6lx0 LnkSW18ZNlDn2dA0I8HZDUuV5QwUSYnjU7SGR9fWBj1oQGC+opt0AKeg9qvISijvMYMC exN/sa9O/SGU7ijyDd9mK0GdtUUcbGfySNVXrOfDrxnggsEQ+nfu/2kYPptx+0sLFFrT DcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=VtmBCpNp1KP0Wih0wNtSn6S6eDN4r8qEfTH0S3sfDvI=; b=4Hdz7FEb40+MRcTA8xe2PqBgxvInOfwwzKmLj+FVNpSq+Btxyj4H9akQG9z1QuIrN2 HFeKEKzAQiciZyR5mHvIUw9OlLZQYtOznc2VS4oNlsCzIRrykU0aWDPSCiYVUs2qZHnK iy2BNHMjPVoISwD30+TZW+DTWNlQrThAM6MDyQ1gen9U3/AgeCyxWtTC21NSo47IXeNI rMDHVfeuBUAsvDbU5sDiSIJoSamp4eAr2H1SQHNjsE0ZBoLPcLa7mw0Snbk65f7wtqo1 L4w6lNurb0gvuOTziSeuBoNOyg+ETgoGjugKS/jHEiCk7jOpsjEolQIf3n12r83slUFo xvgg== X-Gm-Message-State: AOAM530fFBBBsH14m2pqFuScpqTvsoasrrAXaeUwaD0zk8BEt1DSoDzk ugkaGOqkwSHIRdWbQ0dCs4mbiAgZ X-Google-Smtp-Source: ABdhPJyLvkWkgsl5N6fEs4uPVrRWt8N7EGGq7Ji9SRjDngCAZu0NMTQ8venaNAjb270E/IyAc5Cnz/CcgQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:4722:0:b0:3fb:94a7:9986 with SMTP id u34-20020a634722000000b003fb94a79986mr36618043pga.531.1654813173379; Thu, 09 Jun 2022 15:19:33 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:25 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-7-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 06/12] PNP: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813174; a=rsa-sha256; cv=none; b=JreMLaJ3ZqmBntnzdOcy4FaKAbySDQ8EDQgp72dRKkz7cqH3uZTc3RlebVQXprYqVNXwIM 0RCc+bqxwAD86h2d680KchSCCDwR1u0syhfEXkPsF7yEX9qg0RHBUo2YA5n6iBGjNHG92b vf6MYuZjXZ9mWpTlY85TSdIzrCRPyII= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k5UJiPwa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of 39XGiYgUKCH4oqtdqiqqing.eqonkpwz-oomxcem.qti@flex--morbo.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=39XGiYgUKCH4oqtdqiqqing.eqonkpwz-oomxcem.qti@flex--morbo.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VtmBCpNp1KP0Wih0wNtSn6S6eDN4r8qEfTH0S3sfDvI=; b=Nn82XO2NEtdBKpPejf7rqn6dB1WpInwBvkILXC9uB42/jp0M9yywtt8mfb4sFH5HZL4Y5Q 2kvYRWXRrmC/OzYnjCfRZ6snyzD2JUOZJ+JZ/MpJkwCtQfOD4WcTwxQl4jxEbVLaMcWBnG kH6HIXr/eL/UTP2DftXX7ogGic19HsY= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7A7DF140073 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k5UJiPwa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of 39XGiYgUKCH4oqtdqiqqing.eqonkpwz-oomxcem.qti@flex--morbo.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=39XGiYgUKCH4oqtdqiqqing.eqonkpwz-oomxcem.qti@flex--morbo.bounces.google.com X-Stat-Signature: dijqz7fsxsyx5xrat7am48qhzu67g9ko X-HE-Tag: 1654813174-528075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: drivers/pnp/interface.c:273:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] pnp_printf(buffer, pnp_resource_type_name(res)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- drivers/pnp/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c index 44efcdb87e6f..553221a0c89a 100644 --- a/drivers/pnp/interface.c +++ b/drivers/pnp/interface.c @@ -270,7 +270,7 @@ static ssize_t resources_show(struct device *dmdev, list_for_each_entry(pnp_res, &dev->resources, list) { res = &pnp_res->res; - pnp_printf(buffer, pnp_resource_type_name(res)); + pnp_printf(buffer, "%s", pnp_resource_type_name(res)); if (res->flags & IORESOURCE_DISABLED) { pnp_printf(buffer, " disabled\n"); From patchwork Thu Jun 9 22:16:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D4EFC433EF for ; Thu, 9 Jun 2022 22:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96B918D0058; Thu, 9 Jun 2022 18:19:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4528D0057; Thu, 9 Jun 2022 18:19:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 747538D0058; Thu, 9 Jun 2022 18:19:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6179E8D0057 for ; Thu, 9 Jun 2022 18:19:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41DB121700 for ; Thu, 9 Jun 2022 22:19:57 +0000 (UTC) X-FDA: 79560116034.19.07F484E Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf23.hostedemail.com (Postfix) with ESMTP id CDEEC140063 for ; Thu, 9 Jun 2022 22:19:56 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id n6-20020a654886000000b003fda8768883so7235593pgs.14 for ; Thu, 09 Jun 2022 15:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=qfaKip6DwFGW+guGsE2/HUgOUCf7B/ryBL2HyFI8yyY=; b=rmDrQmu6i0rMhVWryy+1sSregBQbx8EzAhxguI/zyywENeaveJeync1WHxdDli/I7V XVFwNwX1LL/Eb2t1qJzoo+LZL4V651eslhmMESIosQ4CzFZqJ/XMZIcgfWh+ijuJ9S4U DE9dfzo5xGMJQHKyVBlVHIJPFhw5ayon8gNdeY1wYxrm/5naZOHI7yvxx4lN8IU/5Vsd Jrf74AJMKR+h5WOopQkEY05HkO30nH18xX4D85TjTMQIbL0iAHDhYHUPur2amaBP1CL6 RS8eMppIKQevbuQilaLP804yNxwZ9Wuv+YrNiMwDfjRjNIKBMBVfcgDhrLJV95/xQEbr 74gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=qfaKip6DwFGW+guGsE2/HUgOUCf7B/ryBL2HyFI8yyY=; b=TuxkSsMBDVwSzBUM8C/cr7UY7yM6NAb5wN3cqMIDs8wgwcBBmiNSCgP72QiZ8WIXgb Smy1XTQBy9B9MJHhmKmMwpNLDmfv3lUVkjXt19LCArKh9s73bdD2T69tfPOKEsWxJvBd LgJesD8pQ+CpiidOoYWIj/yOI4nyco48eOqM6ZXoyC8ynHAV3u0MIzSfJvTN0TZ18h5e 3gGfmAw8m3Oa2/Xw92Erv4rwLdV+XzvCRGVM1zSFY64c69O5Q0sFT0ZnnF43w4xH/4T2 R/Ijl7hyOwyq33FMXi4iVTqQQdgc72IxlASF1wApN5PuSuwvWvkJ89JqAndDRqEGlnFS jA3w== X-Gm-Message-State: AOAM531ZqY48RsG/w135ZBDCAirNnp0qiYUeV/9F73/uLSBGM/hZ55ae Bv6PPs2cbgwE3U344PxQIXoqcZ/c X-Google-Smtp-Source: ABdhPJzfxk5qZb5y/5tpnB1EFv7CAi9wKZuC1KM7/pyahvYM5X1dHlQAhdkQ2HW7pda2hCN2ocO+yxStMQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a62:1687:0:b0:50d:3364:46d4 with SMTP id 129-20020a621687000000b0050d336446d4mr42409947pfw.74.1654813195848; Thu, 09 Jun 2022 15:19:55 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:26 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-8-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 07/12] driver/char: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813196; a=rsa-sha256; cv=none; b=nw48Y9fonA6SNp3vFsoHx9rNqLg/aOn8Fn7/Kru1dLhL6EbNcH9hdDK3TssacxStoh0EOq vme98PVh6xiN6nXtnpOxhUpcF2UeSngaLVDepPOV7ly4lscgM6RcS2sXOlVffzDJYNYCwE DTBpZss6M3XUTkLXrsWcunlk7UQjvEM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rmDrQmu6; spf=pass (imf23.hostedemail.com: domain of 3C3KiYgUKCJQACFzC4CC492.0CA96BIL-AA8Jy08.CF4@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3C3KiYgUKCJQACFzC4CC492.0CA96BIL-AA8Jy08.CF4@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qfaKip6DwFGW+guGsE2/HUgOUCf7B/ryBL2HyFI8yyY=; b=SO1zZ8ZsDL2lpCOWRP74lfu0HEVamJiJHenFHJvjv7f4wQprPfLzPjwRNgT95DHyg1/Lra QuA7NDuzo8Z+d2hsywjcnFvl1Cx3YKdO611vcKnrZuXb52sTFnlrhN9ctbuNA1wupxR8ig UuHws0XDH9s1lua6VYdb1RAjFqz9wUU= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CDEEC140063 X-Stat-Signature: dwmjrdi145x7fs8w6kyh8gse69zm9i56 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rmDrQmu6; spf=pass (imf23.hostedemail.com: domain of 3C3KiYgUKCJQACFzC4CC492.0CA96BIL-AA8Jy08.CF4@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3C3KiYgUKCJQACFzC4CC492.0CA96BIL-AA8Jy08.CF4@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1654813196-59302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: drivers/char/mem.c:775:16: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] NULL, devlist[minor].name); ^~~~~~~~~~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- drivers/char/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 84ca98ed1dad..32d821ba9e4d 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -772,7 +772,7 @@ static int __init chr_dev_init(void) continue; device_create(mem_class, NULL, MKDEV(MEM_MAJOR, minor), - NULL, devlist[minor].name); + NULL, "%s", devlist[minor].name); } return tty_init(); From patchwork Thu Jun 9 22:16:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853C5CCA473 for ; Thu, 9 Jun 2022 22:20:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEBA98D0059; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72F08D0057; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CED298D0059; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BBFAD8D0057 for ; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 931D135C55 for ; Thu, 9 Jun 2022 22:20:19 +0000 (UTC) X-FDA: 79560116958.23.144731D Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf16.hostedemail.com (Postfix) with ESMTP id 42FBD180057 for ; Thu, 9 Jun 2022 22:20:19 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id f9-20020a636a09000000b00401b6bc63beso542760pgc.23 for ; Thu, 09 Jun 2022 15:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=NA8rGIzS2Lo/FSyJFJSopJzo3vj2qG+W/JBu2Td+wh8lNm3aGHNFbCPALJTDiKY3VZ BXYoT+Ww8rgiNjDcWDo8JWEIvIa789ch4uJ/akkx61GHrCbS4UYTLU+WBzXi0U6zqFg6 WETSd0zF9UD0yrUhECgMgO4+3B7vaNDE5q4OxsAILit4vZz26MEF5lP7eGpObNUfQYZP qWyriCnElNMS5dBnlp4ECfJw4cwUWsda0JPVGIsCkMRh996FjTM9tl6X5Bjcl49Ex3bX 056kN/4A+KMGFsvjat6Zhxnibo6NVJe0KQfbbqHffKzcdpAaOGAQ/5H1gcLRSIgsdnQd eZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=Z0322xQbZHmQem05WHdgrJ0pqZDd7f8wjmxmBe4bmU9wzd5SFxvBFWOZH3AthqlQiY uXhFjThHXd5kOPWC0JR4DjR82hWN35NNPcLJ1jKC2yeM9toRMUfuBJxQwwLxdDbRFjBC ajySds9d5GVOyP0o1Vz7dZiUrB+ZinRcEFwhmaqApima+dd5CyDxZgW4E8eQNFLWuF0S g6210Lbh0TQTnoTbxbE6KoKxVDSLlgi9C/WpjsJ16QXcNZ2cagohkFNddtf4gz8hxNFf evdu3l0TgjPsO0/uu/E1FvzoUw+tNLp7ddOwAcRpQy60W7aRnD+2H6pI7WUge9Zi1NyV XPuw== X-Gm-Message-State: AOAM5312dLTX7VR9xSa8eZYXL3zYcLB6xfU5TuUVE2GT/zbMLDUr//CI JZXV/d8GzIJ2NYV+DGcZR9e7KE4q X-Google-Smtp-Source: ABdhPJye2mFQrzIepKAqLUDnC7IYTgWuIi+7I2qa8DRzQUgLX+2gR0oj+bp3uxnl8nOmUO9s5APs/msqoQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a62:e919:0:b0:51e:7b6e:5a3b with SMTP id j25-20020a62e919000000b0051e7b6e5a3bmr1529888pfh.78.1654813218119; Thu, 09 Jun 2022 15:20:18 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:27 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-9-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 08/12] cdrom: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813219; a=rsa-sha256; cv=none; b=SMOqP+oZSuQvBUPA+WaGqctEt4WYJ/qu10rWA9SPVntQdG+nkbFUiGJNlHcGCQalLKtEYK gXlpNsQAyGX3uKyedoGhy3bIA1ymJ6+dnHr+EApniCh9ZE8AwCfQM97D1FNQlAt30dJOaO yvAQVqdHXDDkbH9EkupYJIJLC47PAZI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NA8rGIzS; spf=pass (imf16.hostedemail.com: domain of 3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=1YXcz1WTuvwkf3Crl4Zkpqao/a6q6PZ/5ldbZOVP+Iqwyi51ex/jl2J2BYBVl9CAd4cr/9 quIdkvBxJ2ldDSImCcYXbYOYJNIgeaprSkV2s3eLeyLuOPFKQEu7/F97sbl4796tOvlXNh rg5l9cuUqyYFeIZ7JqTEFqkDGb5Za1c= X-Rspamd-Queue-Id: 42FBD180057 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NA8rGIzS; spf=pass (imf16.hostedemail.com: domain of 3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: y1fukfg6mg9bk76r5538krfehwbu7oue X-HE-Tag: 1654813219-156941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: drivers/cdrom/cdrom.c:3454:48: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] ret = scnprintf(info + *pos, max_size - *pos, header); ^~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- drivers/cdrom/cdrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 416f723a2dbb..52b40120c76e 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3451,7 +3451,7 @@ static int cdrom_print_info(const char *header, int val, char *info, struct cdrom_device_info *cdi; int ret; - ret = scnprintf(info + *pos, max_size - *pos, header); + ret = scnprintf(info + *pos, max_size - *pos, "%s", header); if (!ret) return 1; From patchwork Thu Jun 9 22:16:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876060 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF4EC433EF for ; Thu, 9 Jun 2022 22:20:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF3E96B0074; Thu, 9 Jun 2022 18:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C348D0057; Thu, 9 Jun 2022 18:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CEE18D0034; Thu, 9 Jun 2022 18:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7CC346B0074 for ; Thu, 9 Jun 2022 18:20:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54F9520E1F for ; Thu, 9 Jun 2022 22:20:42 +0000 (UTC) X-FDA: 79560117924.03.815BF35 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf03.hostedemail.com (Postfix) with ESMTP id 06CAF20077 for ; Thu, 9 Jun 2022 22:20:41 +0000 (UTC) Received: by mail-pj1-f73.google.com with SMTP id g14-20020a17090a128e00b001e882d66615so262802pja.9 for ; Thu, 09 Jun 2022 15:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=25alQ5NbvDA/tAT/crdGxszOxkEet+uV+RiKp6teCtQ=; b=oZfJo/SXd3Qwc4Nv44GXKhWDAFTO95PgXKfM9e9BiPA93gnZilAa51s/ZcMgeZyQDX bdQWpsU2Iq0YRK8nhoojrl6Ovztg/h1fX8YAfPzB2dwLHljaWKbdC8Mk4yXY/4KToKYJ ovK2hyHWLN7o69TaNinVFAZmPIf4qo8PHxZBtzNCHZvyhMz5aDyGPm8IzfmTRY3xhkY5 HV52VK6dmyAZeje85nLNYwU1K6dOCF/suK14Mfn4D1Y16vY/jjL7/9lAyFEiDPQ1QSGP J6zMvdrdFc5DFPuif5nPyA2QWjOTwZ7NUnTVPFwq/IivldY6hoaIhzn4fUtrg8kNe7N/ zK6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=25alQ5NbvDA/tAT/crdGxszOxkEet+uV+RiKp6teCtQ=; b=FqRVqBp+h9s3bw7ERTLCApkqrz+/0kf4oweEh0qS5EyPdZvX+VczOtBr6FakrZN034 pLWb3vzZ3qBTun8omIbz1nwbc97ajdzNYwFcdACiJIpNpYUwO+C7PM3ZYIes7waHb4nN k3bJp9Zs4mz0kRw5Y8NYH7cSn82b/og4Xrzyq5/jUN5/y0C6TBLu94VQ2c7L+0XgbsDj 8sJo60epMEgyKAHemU+8zfsjGyeCiMC69zuasCe42TnxlV2iWuQlNymA8Qk/RvUOUwJp frvqiXUPL3TJaXnADM5HCzywoWIm/3jgUgDQPsh6jT7Jn9vGRJw5ozsiA/ffBSz7kyRW JC/g== X-Gm-Message-State: AOAM532xuBrC1/6F7V22jaYoZP29tADNnmiyNm20CqFIB79H0Fwg0FZj ojtwmGXOb02svP3ygXEC/iwho0F5 X-Google-Smtp-Source: ABdhPJw9W1H1jWw/58e5xPpEUFA37qKciU2RFZ0YGfr9UAt18WH9PywE6TBxCqfkRuUXpq4m2jNc2xi7ug== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a17:902:cf06:b0:161:53b6:474d with SMTP id i6-20020a170902cf0600b0016153b6474dmr41957402plg.63.1654813240658; Thu, 09 Jun 2022 15:20:40 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:28 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-10-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 09/12] ALSA: seq: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=25alQ5NbvDA/tAT/crdGxszOxkEet+uV+RiKp6teCtQ=; b=hb71ecjlzBu+opHN9h+XN812eiIrkB5BaIlpD1oSQmu5Hsrx8yQKqH00aCqckXl0cr6gkA xAW74KWPalxybLljph4hzpW+hN7K910B4UMKjDTKi9PvzL2wLf6TWvLwsQIc0QLHdPJOn3 fxhAvU1pUYEo1FCp3VeCtZ79y7lvCBc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813242; a=rsa-sha256; cv=none; b=7hhnIk3/l+Ia354YzNafpoS/8EYZSr0Vktip+y891iLVDfEqnSn9rGba3jJuGIe2Yussk0 yhIp2aRkh0gPFC0nHx6l4EGmkuyjhbGbnDtlmtUkpKMOhbtzthOgt2pTKCTapYbT9MemIb mfJiOZodHWPonsXoHBy3C4QkPUujZFI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="oZfJo/SX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of 3OHKiYgUKCMEtvyivnvvnsl.jvtspu14-ttr2hjr.vyn@flex--morbo.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3OHKiYgUKCMEtvyivnvvnsl.jvtspu14-ttr2hjr.vyn@flex--morbo.bounces.google.com X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="oZfJo/SX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of 3OHKiYgUKCMEtvyivnvvnsl.jvtspu14-ttr2hjr.vyn@flex--morbo.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3OHKiYgUKCMEtvyivnvvnsl.jvtspu14-ttr2hjr.vyn@flex--morbo.bounces.google.com X-Rspamd-Server: rspam03 X-Stat-Signature: y3x9k4ggs9axnecoyuzmkwtaz1c3e5ki X-Rspamd-Queue-Id: 06CAF20077 X-HE-Tag: 1654813241-502269 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: sound/core/seq/seq_clientmgr.c:2414:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] snd_iprintf(buffer, msg); ^~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- sound/core/seq/seq_clientmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 2e9d695d336c..2340f3e14eeb 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -2411,7 +2411,7 @@ static void snd_seq_info_dump_subscribers(struct snd_info_buffer *buffer, up_read(&group->list_mutex); return; } - snd_iprintf(buffer, msg); + snd_iprintf(buffer, "%s", msg); list_for_each(p, &group->list_head) { if (is_src) s = list_entry(p, struct snd_seq_subscribers, src_list); From patchwork Thu Jun 9 22:16:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154C4C43334 for ; Thu, 9 Jun 2022 22:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 994E28D0057; Thu, 9 Jun 2022 18:21:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91C3F8D0034; Thu, 9 Jun 2022 18:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 797478D0057; Thu, 9 Jun 2022 18:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 50F9C8D0034 for ; Thu, 9 Jun 2022 18:21:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 207D435A5D for ; Thu, 9 Jun 2022 22:21:04 +0000 (UTC) X-FDA: 79560118848.04.F879985 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf04.hostedemail.com (Postfix) with ESMTP id BA83140068 for ; Thu, 9 Jun 2022 22:21:03 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id m64-20020a255843000000b00663d6d41f5aso8393133ybb.12 for ; Thu, 09 Jun 2022 15:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=v4Xn62a8gwv09PX197f2KX5K6c68JUg+Unaoh5Rs3zU=; b=rIM31hja6TacLFy83ekGaYY6NocbE3+qp06k1AYSWqT3YCOM3vKnexoLoVRg3/QFrC NK6lDPMraatUaGV4ysDVq7Ma73A8ej30mShvcnMynXPj4q1s4HwLXHsyE5NReacxVqEF SN/r5DNjRMP1h9Yx1PS5+t5PqoRBJ1DmF1KeRqex3FpyMoNRbYlXt2tQwLA6Cftv+3aS xU6s22QmO1Pl1Kwrbe6vsMz+d3Z4FRfHNfEK9twj222QTX3BVZNBOKgun1MV8xBDAQQA +IscNJZzBGaDfdE3Gg++zvAyvxAsnUQ0EJis1knVDwKv7m2aWEOPArINp5NiPyNi+Z2n h4Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=v4Xn62a8gwv09PX197f2KX5K6c68JUg+Unaoh5Rs3zU=; b=X3Qlm1ocaih6KFAA4rydiaWAYg1amaYs98fFLHISHwpIOepI1iis++KG6Z/lZTXelf IBrwX03bSHDfPXEhaMPZziEZtl+D9xZG8lS9SMUSHQWhW0uIzZZLzfUtJFwpg4Xhstah yBSsrDGkoeuaBFj4a68d38IeMg4zD6dtjrp3/ddHc3SOdwOz8CfTYO5XwjB4xau5AAqU TD0gSLqulIXvuYfFeE9UFf4Yt2MMyWSLTR3K7UrZntYuLVOVz71kofVrnVqC4w/gWitR pSQ6WEXPFnxY48oA1fB+k6KHr9vcfHxFS0GT6dOUllMwKDf/PeMz0imZMIEKX9jcm4Ky ElNw== X-Gm-Message-State: AOAM532cHY1JQTWtavTsKHvE3at8anwNajIQN5l1+vRO4JMfRmy2d+0Y l05flfUy36gLBoApAiV+SOvRtqDu X-Google-Smtp-Source: ABdhPJwSDxouzP8D6734EA8fpYrXSwixl1FJKKaGzKk8Ee6TEpQt79esVExDoO3PJGM+WWqOyJq6+ArWEg== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a25:76d5:0:b0:663:ad77:8d48 with SMTP id r204-20020a2576d5000000b00663ad778d48mr18678005ybc.633.1654813262959; Thu, 09 Jun 2022 15:21:02 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:29 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-11-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 10/12] ALSA: seq: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v4Xn62a8gwv09PX197f2KX5K6c68JUg+Unaoh5Rs3zU=; b=kSgoQTmbgob/uyViZ4850f9SaUu7HFzokaQjdrnB+nYOwvDRQbbJJ51JzpGkOGiSYkOZ33 iACfRj6DbLZL7JipiRglT18pYhhQJR3ET1/AwRK8HucCxRIjbxYlBi4gYac8eyviBCgckm UzGtQFNZlfzGFOOtKnAhVQtZ8MJvILw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813263; a=rsa-sha256; cv=none; b=eBQSJXejnLvLs/C3dPQzNw3dP2KJ4y4Ba6B62gEa9rNeBLH+TZ+Sv/NfgB4lYOi+r7oLh4 GaGVguIPP5RkkQZOsuKAZCLyQ3ut773xsSvBX1NfdEyqPIw7LAOtF4EjJCJRf+x1jlJEwh vfXpy/dryIGQt/ydNe9ar6E7oSO4PsE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rIM31hja; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3TnKiYgUKCNcFHK4H9HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--morbo.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3TnKiYgUKCNcFHK4H9HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--morbo.bounces.google.com X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rIM31hja; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3TnKiYgUKCNcFHK4H9HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--morbo.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3TnKiYgUKCNcFHK4H9HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--morbo.bounces.google.com X-Rspamd-Server: rspam03 X-Stat-Signature: 83eu9hp3ba4da7t7pob4tuwwxyau83o3 X-Rspamd-Queue-Id: BA83140068 X-HE-Tag: 1654813263-648052 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: sound/core/sound.c:79:17: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(str); ^~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- sound/core/sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/sound.c b/sound/core/sound.c index df5571d98629..7866f29621bf 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -76,7 +76,7 @@ static void snd_request_other(int minor) case SNDRV_MINOR_TIMER: str = "snd-timer"; break; default: return; } - request_module(str); + request_module("%s", str); } #endif /* modular kernel */ From patchwork Thu Jun 9 22:16:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E91C433EF for ; Thu, 9 Jun 2022 22:21:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12ECA8D005A; Thu, 9 Jun 2022 18:21:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DECD8D0034; Thu, 9 Jun 2022 18:21:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B2D8D005A; Thu, 9 Jun 2022 18:21:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9A558D0034 for ; Thu, 9 Jun 2022 18:21:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id AC4B3615AF for ; Thu, 9 Jun 2022 22:21:28 +0000 (UTC) X-FDA: 79560119856.13.48770E4 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf24.hostedemail.com (Postfix) with ESMTP id 4DE2D180064 for ; Thu, 9 Jun 2022 22:21:28 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id t14-20020a65608e000000b003fa321e8ea3so12332405pgu.18 for ; Thu, 09 Jun 2022 15:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=+JW2n6LLjgkLeZpu0VrK7uVIniA8Omo9w9YQRrZ1ImQ=; b=i42901GYNhaxsHQ0DOGoOky9iCPlDaMMKrye+1S6wrdYfiDoHAZcC7HTQX/ufq8JDc FtLJH8ibG+4hcwJncrABH5MINqNlaiBQcg6AiUjnTwqlf664IuYPp0tvgNpDNS6s/GjQ Wjh2TOa/isNuXc04yhOdZrj9wIAtXkGMKkDBH370v2doh3glFP/6lvE9gZpbXECpN/zv UStKebGupQmmTtj2yMjnHwJiwJi/peKu25pYf9NTE11Ch6upWSa6FAa3CkIKEN5+Emo5 3UDTgqdqaohZKI3Gp3XYmJjjv1YwnDPf8AUi3y1kFAWlFzS3PLERdXTH2sKpk0ltR6ij /vAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=+JW2n6LLjgkLeZpu0VrK7uVIniA8Omo9w9YQRrZ1ImQ=; b=3cweJPFfE/RBJBmsNLemNqbV1VIsySkr/6JjHAAJtVntwuT47PgTmxTAtE34zPTYqf Po1aiqUM0Q0ko5U9YrSYquX9N2fmP+XCBERC7vpeKTTdncaLVwgOX5pOBH+XKWQmgEW3 0sXKeWLaOgvRJxeQyAi09NNj6Ri62KxG9Sqx8nWozDUGF7HfeoKIKtUNbdlKkgKye9T+ giTVEobXnq/iz/OD9Tn0yT1xE4xVwpgrxi2OXqLdFCM00LMFgBL9uGky8hy6eXoZckU6 8n6RvEbhuBQr1PHdGtugHlRS6PoPNoZnCcKYTHlihstdg2rbaqEWORGLQXiEWbBgQejh EOug== X-Gm-Message-State: AOAM5327teUMCorfngnI23pzjr38c7PTCo7OT9zXA2KautbxCz4PVQoO vGkWMyNHNbgi0YOWg9rR/wzGW9pZ X-Google-Smtp-Source: ABdhPJxwIiVK0GwVN12g3ZMNH56OyPQzBgCjPEweYrbMYHqEsJdgXTONzisCGHUJLebHzTiLq5Vb6Q5FXg== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:409:0:b0:3fd:77f0:9a75 with SMTP id 9-20020a630409000000b003fd77f09a75mr25262295pge.149.1654813287223; Thu, 09 Jun 2022 15:21:27 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:30 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-12-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 11/12] ALSA: control: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813288; a=rsa-sha256; cv=none; b=W39AkOAmMG7jLz8dTEwPWi4iHQ5pLZVC5mRSxJwTGHsQ5XTK2UvyvTWuqALgYs6KLAZMA7 4TVr7KfvgjlsN4vDRNpAbJCu+XN3DDpB/jC1iESfTkimNNn5/q5jTb1ffB277mzoJAVrxr Y5vwjo8AUOvPFaJvlBrcRD6nVZdC7mg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=i42901GY; spf=pass (imf24.hostedemail.com: domain of 3Z3KiYgUKCPAegjTgYggYdW.Ugedafmp-eecnSUc.gjY@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3Z3KiYgUKCPAegjTgYggYdW.Ugedafmp-eecnSUc.gjY@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+JW2n6LLjgkLeZpu0VrK7uVIniA8Omo9w9YQRrZ1ImQ=; b=pjUxSC3OM0LWHRXI4oxvygI37IHItErTAah/67Rm7/BRjRWK6VXMnz9SdOnjAX0xFbOBaq nlUl1TUJLyTkhB91pxIiPXDOp8dpRIK2Abivojs877/DFZIZqzc8lHXiemBhkFajJezlhN VY+cylaapZ0iUO0XpOuBO+f1nJ+Zph8= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4DE2D180064 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=i42901GY; spf=pass (imf24.hostedemail.com: domain of 3Z3KiYgUKCPAegjTgYggYdW.Ugedafmp-eecnSUc.gjY@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3Z3KiYgUKCPAegjTgYggYdW.Ugedafmp-eecnSUc.gjY@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: ppajuwcoh8onn45nr913rdmqdgrq3ixa X-HE-Tag: 1654813288-236688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: sound/core/control.c:2062:24: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] return request_module(module_name); ^~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- sound/core/control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/control.c b/sound/core/control.c index a25c0d64d104..a1778137147d 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -2059,7 +2059,7 @@ int snd_ctl_request_layer(const char *module_name) up_read(&snd_ctl_layer_rwsem); if (lops) return 0; - return request_module(module_name); + return request_module("%s", module_name); } EXPORT_SYMBOL_GPL(snd_ctl_request_layer); From patchwork Thu Jun 9 22:16:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 12876063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 492C2C433EF for ; Thu, 9 Jun 2022 22:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC83C8D005C; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C784E8D0034; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B193E8D005C; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9BB198D0034 for ; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6D6DB210E4 for ; Thu, 9 Jun 2022 22:21:50 +0000 (UTC) X-FDA: 79560120780.25.51C505A Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf23.hostedemail.com (Postfix) with ESMTP id 18F93140063 for ; Thu, 9 Jun 2022 22:21:49 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-2eb7d137101so213929827b3.12 for ; Thu, 09 Jun 2022 15:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=E9tSuZ6hKkd5R9UrAClvzMvLuSapw21MRvFh9K5m/Q4W/Ne6NP2WMWfSPzasz8wKZX Mng11d6Obxtbq83lWoSaFsdBiVCu3gb6X9dNoHMi3E7qOKWwZUm9cJAU6WOY5s+S4WcD k0KWGk2jmTkZOAqD94Ix96O/6kgOmQ/r+QpHomefwKvJ5cV0MNofmxceF2lXxoFWF6gg j5Cs7IkuMhKv2Pf+5++JwO5hcoMx6SP3if8FmA4NjIla9U/uK2//v1BfU0Tfe7AV8KrT Ey/sE8DleSJieRPHEDBL1hPn4naIWW02H/aWpnYArbukY4zZLmv4GV2t/e5g12dM+Qzj ZcQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=iavjKPtMtIHz/FPAsXIkMjiyMfip7JO9LSnsDasQClck50xddQsYDK1xFVRqWNqoPt zbnpvSFWQeT2b9PQnhDp1Gx/EO7qKUeLJ5mFA5FpOQ9encio7AHCA0BRtcOOK4IpliwT KstBOvQM3Jhsbcla3pHCYtXjFuBmcMf4J1lt1xRNzN8H4Wbb+OB2DoM012sfAYbkP83H nOMNgEXLxVzZEXVrYnP5SQwlgC9hD6JciUX/FbQn3uSt7f/fj/nYGCE6tOWduiiWdkgx HrSVcBWVmRiuSrVejmVmxm6MyVDDuHmSjFn4+p5xzKV3Enst5JzTV0GAtuxkh4oF32Mp RIPA== X-Gm-Message-State: AOAM533KLNJqzeDeqeWzt6Bz++37d2zDrtHFXt7oc05efPM8aM7vmgSl aMGVi9e92MpfpQ31Fsk2XSr099qX X-Google-Smtp-Source: ABdhPJzx/fiV7355Fpicwsezz0b2tB8XbCEkcbb8KPwyuPviI/0AOw7BwG+AXnNZJgmFqRPAiS2WX3p4fQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a81:c248:0:b0:313:3c2c:89cd with SMTP id t8-20020a81c248000000b003133c2c89cdmr17003210ywg.175.1654813309307; Thu, 09 Jun 2022 15:21:49 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:31 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-13-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 12/12] netfilter: conntrack: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813310; a=rsa-sha256; cv=none; b=dMbTMFJBXXby8u6HtzhF42zCbiDCdIIx0KVrFW6co6p+m9/WzAN0ZS6QzTQozmcTEL2Ufi xQQYcKhhaU2W3JEGoUVWWOO8m5+rJFlgMJfBnkQy+ANONlPW30NntmlUq+ovD7uSTfSD0n cFs+IbVWlG6TUURopQ/Key5hiYZdBOk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E9tSuZ6h; spf=pass (imf23.hostedemail.com: domain of 3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=wwNnRFRhqiqwL1W0pUKDggxIYT4WG2LS6vORVG58sIwlgXZGkJdRaOXog0m7gX348EYues VVrBZ8qhTByYeoqeV32vHgGQrD4qGDChC6h4bxxdBPZdTjG5gx/KkolPPuMQ6O5L4nIENh zEnwzbPm3QQyQI4NFOENtJOxgXdBfpw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 18F93140063 X-Stat-Signature: 454t73cxqjq1c6jddcsie1o68ybp3p8s X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E9tSuZ6h; spf=pass (imf23.hostedemail.com: domain of 3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1654813309-113253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(mod_name); ^~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- net/netfilter/nf_conntrack_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index c12a87ebc3ee..1e0424d37abc 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -165,7 +165,7 @@ nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonum) if (!nat) { snprintf(mod_name, sizeof(mod_name), "%s", h->nat_mod_name); rcu_read_unlock(); - request_module(mod_name); + request_module("%s", mod_name); rcu_read_lock(); nat = nf_conntrack_nat_helper_find(mod_name);