From patchwork Fri Jun 10 08:01:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12876650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 360C0C433EF for ; Fri, 10 Jun 2022 08:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id F038BC3411C; Fri, 10 Jun 2022 08:01:09 +0000 (UTC) Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by smtp.kernel.org (Postfix) with ESMTP id 9A600C3411B for ; Fri, 10 Jun 2022 08:01:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 9A600C3411B Authentication-Results: smtp.kernel.org; dmarc=pass (p=reject dis=none) header.from=baikalelectronics.ru Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=baikalelectronics.ru Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id 1DBA316A0; Fri, 10 Jun 2022 11:01:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com 1DBA316A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1654848117; bh=13289GlwRgaXrT3Rf0U7XzRXw9Hx/0u4Wt88ljluT6U=; h=From:To:CC:Subject:Date:From; b=UEN3gEJhqxNB6u9M7AiThaZURbYXH7FOQwJgR/CgXKmhgIPGY1J71t+8bkmfWj3ys KwCIgUhUwidwG69bX+PRgNUhlTWLqeqw3lcWlF7CoE4ugKw/S22qECG+O1NdKSEDqP 6tj9HO28FeexUr4uu2jmSUmfeqFmvnMVRtNUfEa0= Received: from localhost (192.168.53.207) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 10 Jun 2022 11:01:04 +0300 From: Serge Semin To: Arnd Bergmann , Philipp Zabel List-Id: CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , Subject: [PATCH 1/2] bus: bt1-apb: Don't print error on -EPROBE_DEFER Date: Fri, 10 Jun 2022 11:01:02 +0300 Message-ID: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) The Baikal-T1 APB bus driver correctly handles the deferred probe situation, but still pollutes the system log with a misleading error message. Let's fix that by using the dev_err_probe() method to print the log message in case of the clocks/resets request errors. Signed-off-by: Serge Semin --- drivers/bus/bt1-apb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c index b25ff941e7c7..ac13b5b97107 100644 --- a/drivers/bus/bt1-apb.c +++ b/drivers/bus/bt1-apb.c @@ -176,7 +176,8 @@ static int bt1_apb_request_rst(struct bt1_apb *apb) apb->prst = devm_reset_control_get_optional_exclusive(apb->dev, "prst"); if (IS_ERR(apb->prst)) { - dev_warn(apb->dev, "Couldn't get reset control line\n"); + dev_err_probe(apb->dev, PTR_ERR(apb->prst), + "Couldn't get reset control line\n"); return PTR_ERR(apb->prst); } @@ -200,7 +201,8 @@ static int bt1_apb_request_clk(struct bt1_apb *apb) apb->pclk = devm_clk_get(apb->dev, "pclk"); if (IS_ERR(apb->pclk)) { - dev_err(apb->dev, "Couldn't get APB clock descriptor\n"); + dev_err_probe(apb->dev, PTR_ERR(apb->pclk), + "Couldn't get APB clock descriptor\n"); return PTR_ERR(apb->pclk); } From patchwork Fri Jun 10 08:01:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12876649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36D68C43334 for ; Fri, 10 Jun 2022 08:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id F0353C34114; Fri, 10 Jun 2022 08:01:09 +0000 (UTC) Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by smtp.kernel.org (Postfix) with ESMTP id 9A649C3411D for ; Fri, 10 Jun 2022 08:01:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 9A649C3411D Authentication-Results: smtp.kernel.org; dmarc=pass (p=reject dis=none) header.from=baikalelectronics.ru Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=baikalelectronics.ru Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id ABF0F16A1; Fri, 10 Jun 2022 11:01:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com ABF0F16A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1654848117; bh=e4ZfABF2H4VfWmciwS705FYjJaibel8PX+2+puveoMc=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=Ef/Yb2/S4rJIkO98RxL4IzCCjWdDXftjL3WTbxxElZw1TnpVnaY1Ains4k8fVRlaU pyD8wWclaVDv5ANfDr2370uOhPnk4NJPwo8MyLdhbDqHnT3izIBbzTT5z9AbBy59mr MjlYQssDM7eHgkaCgeOM2worvMESx7pgZNMUHUCE= Received: from localhost (192.168.53.207) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 10 Jun 2022 11:01:05 +0300 From: Serge Semin To: Arnd Bergmann , Philipp Zabel List-Id: CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , Subject: [PATCH 2/2] bus: bt1-axi: Don't print error on -EPROBE_DEFER Date: Fri, 10 Jun 2022 11:01:03 +0300 Message-ID: <20220610080103.10689-2-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru> References: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) The Baikal-T1 AXI bus driver correctly handles the deferred probe situation, but still pollutes the system log with a misleading error message. Let's fix that by using the dev_err_probe() method to print the log message in case of the clocks/resets request errors. Signed-off-by: Serge Semin --- drivers/bus/bt1-axi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/bus/bt1-axi.c b/drivers/bus/bt1-axi.c index e7a6744acc7b..47bcf18f3115 100644 --- a/drivers/bus/bt1-axi.c +++ b/drivers/bus/bt1-axi.c @@ -136,7 +136,8 @@ static int bt1_axi_request_rst(struct bt1_axi *axi) axi->arst = devm_reset_control_get_optional_exclusive(axi->dev, "arst"); if (IS_ERR(axi->arst)) { - dev_warn(axi->dev, "Couldn't get reset control line\n"); + dev_err_probe(axi->dev, PTR_ERR(axi->arst), + "Couldn't get reset control line\n"); return PTR_ERR(axi->arst); } @@ -160,7 +161,8 @@ static int bt1_axi_request_clk(struct bt1_axi *axi) axi->aclk = devm_clk_get(axi->dev, "aclk"); if (IS_ERR(axi->aclk)) { - dev_err(axi->dev, "Couldn't get AXI Interconnect clock\n"); + dev_err_probe(axi->dev, PTR_ERR(axi->aclk), + "Couldn't get AXI Interconnect clock\n"); return PTR_ERR(axi->aclk); }