From patchwork Sun Jun 12 11:02:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 12878698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C6FC43334 for ; Sun, 12 Jun 2022 11:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9D38D0128; Sun, 12 Jun 2022 07:02:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 289B98D011D; Sun, 12 Jun 2022 07:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 150EA8D0128; Sun, 12 Jun 2022 07:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 073838D011D for ; Sun, 12 Jun 2022 07:02:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CA14C60A9B for ; Sun, 12 Jun 2022 11:02:34 +0000 (UTC) X-FDA: 79569295428.13.6BFAACE Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by imf29.hostedemail.com (Postfix) with ESMTP id 09928120083 for ; Sun, 12 Jun 2022 11:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=JUYU3aqCoEdG9jehlyG1aKnpn6Chafc4XXOZBNqZ6PY=; b=rXJHR/72ezrn2anPILZY3SDPdlDExwLi4v3xr8XkrFNo0+Q1t4vB8Kjy X0fXYiC45xQpp1cBtInVsyTbSTeUaAEMcfQbo8BMFIl42CRBORtm+c5yc fyToCdU6bRPcEQ4NR5XBDCylh/KDdFKUiHM9QdgG48CsnlSv3PrmFNosj k=; X-IronPort-AV: E=Sophos;i="5.91,294,1647298800"; d="scan'208";a="40585989" Received: from 245.122.68.85.rev.sfr.net (HELO hadrien) ([85.68.122.245]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 13:02:32 +0200 Date: Sun, 12 Jun 2022 13:02:31 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Paul Kocialkowski cc: kbuild-all@lists.01.org, lkp@intel.com, Linux Memory Management List , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: fix device_node_continue.cocci warnings (fwd) Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655031754; a=rsa-sha256; cv=none; b=NHH4Z0VveLxe+gyTW4mSqlHk5ZkpgJri6pjcZM44ys2HbWjXS5QGPgxYsr+pJDPJVutl2W i5VS+U0Ey6/u7CLepsymduqnvl5yy9mZGRxh7Qo0MWD8Lnh0KYKuDLsK3wysyD+g4QTzrh bBsuZ06/36at/Xy0v2Ggo+24GlOHjV8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b="rXJHR/72"; spf=pass (imf29.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.83 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655031754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=JUYU3aqCoEdG9jehlyG1aKnpn6Chafc4XXOZBNqZ6PY=; b=hQa2mA63JbUF9JYZUtnKUrvs7gQdp1GEETfJ8K8bNzOT7e+DW4bhxo4Ke2+26w5ieRx+QC WML0N36HBzxhcp6whF4YtSx2kUxSRanCNV4qslj7TXOyGDdFf8I1WXn/YBIFXoWjW+/UJU p86AVQkgzXpiMimlDDqcjm6zSPbUcWs= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 09928120083 X-Stat-Signature: jmbgxa6eumuwkwwc3b91fwrgh9iwqdze X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b="rXJHR/72"; spf=pass (imf29.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.83 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr X-HE-Tag: 1655031753-117828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The of_node_put does not seem to be needed. Note that there is none at the preceeding continues. julia ---------- Forwarded message ---------- Date: Sat, 11 Jun 2022 06:02:45 +0800 From: kernel test robot To: kbuild@lists.01.org Cc: lkp@intel.com, Julia Lawall Subject: [PATCH] drm: fix device_node_continue.cocci warnings CC: kbuild-all@lists.01.org BCC: lkp@intel.com CC: Linux Memory Management List TO: Paul Kocialkowski CC: Maxime Ripard CC: David Airlie CC: Daniel Vetter CC: dri-devel@lists.freedesktop.org CC: linux-kernel@vger.kernel.org From: kernel test robot drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put. Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6d0c806803170f120f8cb97b321de7bd89d3a791 commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller :::::: branch date: 17 hours ago :::::: commit date: 31 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/gpu/drm/logicvc/logicvc_layer.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d ret = logicvc_layer_init(logicvc, layer_node, index); if (ret) goto error; - - of_node_put(layer_node); } of_node_put(layers_node);