From patchwork Thu Jun 16 13:54:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixu Xia X-Patchwork-Id: 12883910 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76CBC433EF for ; Thu, 16 Jun 2022 13:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377303AbiFPNzD (ORCPT ); Thu, 16 Jun 2022 09:55:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233436AbiFPNzC (ORCPT ); Thu, 16 Jun 2022 09:55:02 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757A4344DD; Thu, 16 Jun 2022 06:55:01 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id g186so1323467pgc.1; Thu, 16 Jun 2022 06:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SuEwtiDlLgx2R0fhACrXqafzxg/xLHleHmagqvpWBd4=; b=W2a2f+bgmGf5MSxLbCrDAvw4WD6l/ix9/M30wYUL1PL+e0RDKK3Yf7JGdTTup2SmC6 K3BHey51uiYaPCKBB0fQAy4w6HE/bAragushXyXZEyAWqanyb/HR0r6QhAKZaNS5KwzB aZattOxmD0IzTNx+h5wdyeYrxl5SVp41M8+It9hqxTYH8/4mZ5v9jfDIWH9dG/X0UzTU Exjg8jmpcRRCTu1vuzPZixycRBRQ5exMQSxNxXMyLs1jVH2L7k2vrxiiYLXnx1t91Z7l 7yokOtKBpqfxLqYhCE58ajzYinQJimiSVAmOrGm0+gNMmzAKC4m7hZ4mHdLFjUn5UVg0 dN0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SuEwtiDlLgx2R0fhACrXqafzxg/xLHleHmagqvpWBd4=; b=FNq7S+tO93+RR0F/aC5/OxIHQLDUd1lqKys9TrQ6tLfu0Dms4tT/mmbYExejMRpALD 7zHat3QepDMV0tyB7JZmrAfqcEOM9m3DVuEje2upEbXqKwvB1Sn+wxPXB8KbTz0Z4PHF BhB3GZCJqrmkvdYHRxevxo1Jjp+RzSqw6oNWAw0jJCAxt7KlgGXRCVkgCsM37GjIJQlt ptYMrbQjlMvx2LOCU6e/1EB8eUdbPUOlztdCuzQQIolLhn0SXxaE7AIJqnN52nfzhIs7 qG8ii2r0ngae5EBQzO0wRHlmyCssxL43/+OXba0Ao7DD2IvS28nWHzB/ZJMX+fKw49l4 4d4A== X-Gm-Message-State: AJIora9t1KfxhXK+E0xI9VBoVWc74+ebkQtPSv1aT617tmeQb7fuVZ1d cTCkHtTDbx2SuwDGmUpSOZ4AplfxtA== X-Google-Smtp-Source: AGRyM1vfD0Uhf+JvOHog/Vh6ERS6IAC7Cuo/d7cY4Bz53t5s0ubo2uSkz1n/jjnHovASvoAa9yWxLA== X-Received: by 2002:a05:6a00:1a91:b0:51c:2ef4:fa1c with SMTP id e17-20020a056a001a9100b0051c2ef4fa1cmr4852801pfv.75.1655387700839; Thu, 16 Jun 2022 06:55:00 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id z21-20020a17090a8b9500b001e8520b211bsm1565149pjn.53.2022.06.16.06.54.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2022 06:55:00 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: hch@infradead.org, djwong@kernel.org, dan.j.williams@intel.com, Kaixu Xia Subject: [PATCH v2 1/2] iomap: set did_zero to true when zeroing successfully Date: Thu, 16 Jun 2022 21:54:39 +0800 Message-Id: <1655387680-28058-2-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1655387680-28058-1-git-send-email-kaixuxia@tencent.com> References: <1655387680-28058-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Kaixu Xia It is unnecessary to check and set did_zero value in while() loop in iomap_zero_iter(), we can set did_zero to true only when zeroing successfully at last. Signed-off-by: Kaixu Xia Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index d2a9f699e17e..1cadb24a1498 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -917,10 +917,10 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter, bool *did_zero) pos += bytes; length -= bytes; written += bytes; - if (did_zero) - *did_zero = true; } while (length > 0); + if (did_zero) + *did_zero = true; return written; } From patchwork Thu Jun 16 13:54:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixu Xia X-Patchwork-Id: 12883911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC6DC43334 for ; Thu, 16 Jun 2022 13:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233436AbiFPNzI (ORCPT ); Thu, 16 Jun 2022 09:55:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377310AbiFPNzE (ORCPT ); Thu, 16 Jun 2022 09:55:04 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D12F3A5D5; Thu, 16 Jun 2022 06:55:03 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id 129so1316023pgc.2; Thu, 16 Jun 2022 06:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WKPmpB+aAJiU6QhTcanmbujSg9PjTV7h3OUq8aN20ls=; b=BNDYUPT0KVPat6mgtpfD/fKON/fzzUKSm2Uh/Zsd7BB2Op/cc3mkqlfRc7Enf1K/gh vSgbPYEg68dP+o/wLLxp5kykPyBWfRKF9aTxunTS9njC9OoHYsmhxPKHcZ9P/xfckkKP mbsUwNGdaDXoWWVj+PJkidkc5sIElrDULyAHssgeXsE4nChJKMEuXRKlPCH7654edB1j UlwrOqmYB1mh4ypeQf6RuB3KZu0HWkS/liAIGqk8UDODz4uUeHxEC7eObTWJDJIs0T4c f4ad/kEI9dYaAdG9fy3JrIcrrD0GDvcbMs83x5bIs4Wv9hToq3HRqQcDUE5vci3A9H5f BKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WKPmpB+aAJiU6QhTcanmbujSg9PjTV7h3OUq8aN20ls=; b=CixpsL6vO557LGt9VP9EUZE4CCZNqFvICIckW7QDsx0GOVnDkPOp06eo4xsutEcsSy InHtna2rL98Fe4U34kIko1gXRTlktCOHnMKjIDZYd9VzyNFAnSLitUmT7nx/R7mke7OE 5299HloDCko5hE01mSRrtxLitrm9k6PD/2NJsXThPF3jwX+bTbMUHvf5AMaC4eoEFhWi lmpG5Khl1xGYONWjjbjIFK+MlzO4n1znXsU+ymumlpCzB/78cL3KsgZpEHffApT+AgVb 36Qa8qTZjYuNEn+oz3vLs3b5JYSCtGblMNMxb7TSgpSzfBXr/fTSsYNDQVn3O10E7uie K4Zg== X-Gm-Message-State: AJIora9jq22pOrmACG7lyE8/B4skOpOfyrgIjKKd7z7Fq6WlPRoHnmvn c7Meo1RjWgNMTk05owJkblbapKsXhg== X-Google-Smtp-Source: AGRyM1sQemj2DEtO+kYCnm4bQbxyl59usGhttndogk7CAk4twYyMjCv1rXYiaH5yLbiRhvbaIcRMYQ== X-Received: by 2002:a05:6a00:194d:b0:51b:eb84:49b1 with SMTP id s13-20020a056a00194d00b0051beb8449b1mr4855140pfk.77.1655387702912; Thu, 16 Jun 2022 06:55:02 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id z21-20020a17090a8b9500b001e8520b211bsm1565149pjn.53.2022.06.16.06.55.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2022 06:55:02 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: hch@infradead.org, djwong@kernel.org, dan.j.williams@intel.com, Kaixu Xia Subject: [PATCH v2 2/2] dax: set did_zero to true when zeroing successfully Date: Thu, 16 Jun 2022 21:54:40 +0800 Message-Id: <1655387680-28058-3-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1655387680-28058-1-git-send-email-kaixuxia@tencent.com> References: <1655387680-28058-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Kaixu Xia It is unnecessary to check and set did_zero value in while() loop in dax_zero_iter(), we can set did_zero to true only when zeroing successfully at last. Signed-off-by: Kaixu Xia Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig --- fs/dax.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 4155a6107fa1..649ff51c9a26 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1088,10 +1088,10 @@ static s64 dax_zero_iter(struct iomap_iter *iter, bool *did_zero) pos += size; length -= size; written += size; - if (did_zero) - *did_zero = true; } while (length > 0); + if (did_zero) + *did_zero = true; return written; }