From patchwork Thu Jun 16 16:17:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xianting Tian X-Patchwork-Id: 12884426 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AA8C43334 for ; Thu, 16 Jun 2022 16:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 556246B0088; Thu, 16 Jun 2022 12:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF456B0089; Thu, 16 Jun 2022 12:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CDBB6B008A; Thu, 16 Jun 2022 12:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 290916B0088 for ; Thu, 16 Jun 2022 12:18:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F09E2359E5 for ; Thu, 16 Jun 2022 16:17:59 +0000 (UTC) X-FDA: 79584605478.03.CD4F69A Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 170F380011 for ; Thu, 16 Jun 2022 16:17:58 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VGamLOw_1655396275; Received: from localhost(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VGamLOw_1655396275) by smtp.aliyun-inc.com; Fri, 17 Jun 2022 00:17:55 +0800 From: Xianting Tian To: akpm@linux-foundation.org, ziy@nvidia.com, gregkh@linuxfoundation.org, stable@vger.kernel.org, guoren@kernel.org Cc: huanyi.xj@alibaba-inc.com, guohanjun@huawei.com, zjb194813@alibaba-inc.com, tianhu.hh@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xianting Tian Subject: [PATCH 5.17] mm: validate buddy page before using Date: Fri, 17 Jun 2022 00:17:46 +0800 Message-Id: <20220616161746.3565225-7-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220616161746.3565225-1-xianting.tian@linux.alibaba.com> References: <20220616161746.3565225-1-xianting.tian@linux.alibaba.com> ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf30.hostedemail.com: domain of xianting.tian@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xianting.tian@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655396279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=GwRBrLHefCGpfLnbVrFywP3JMN6Fl2tUHXtYajlqdgY=; b=GVfm9r5uwHPNqXg1G+9Ls1v0GpT46vKzOVsc8bvQIqqhzQ69g0UTsJ6e1KJOAVovNzSyL6 /k1f/eSsT7P88GNMF9yrXkCuFouwd6cJ5wV7aWvWuichHCy8rGeHkevBPB4TCqRFhY6Inz 7nXR2X8X+K+6w9oosn4lU+p2lYtE2D4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655396279; a=rsa-sha256; cv=none; b=E51OOL5KebhHNa6xwedy3dRiQ8MVk+bBCNnbf5H06yaLa136wlm7LvoLesiqOdrRTxyLkT lRBHCFHuYmw1jQTZh+hS6T2Ys9OpG0veJ1bCMy5saIQkEde/DpyIZdMjlZmfqVMx+SbaPP y1+blBLmj7Zg31Kxb9nwas7od0N10iE= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 170F380011 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf30.hostedemail.com: domain of xianting.tian@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xianting.tian@linux.alibaba.com X-Stat-Signature: 8us4dbd6hf4xdi9diuadeqppboybo1k1 X-HE-Tag: 1655396278-350017 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 787af64d05cd ("mm: page_alloc: validate buddy before check its migratetype.") fixes a bug in 1dd214b8f21c and there is a similar bug in d9dddbf55667 that can be fixed in a similar way too. In unset_migratetype_isolate(), we also need the fix, so move page_is_buddy() from mm/page_alloc.c to mm/internal.h In addition, for RISC-V arch the first 2MB RAM could be reserved for opensbi, so it would have pfn_base=512 and mem_map began with 512th PFN when CONFIG_FLATMEM=y. But __find_buddy_pfn algorithm thinks the start pfn 0, it could get 0 pfn or less than the pfn_base value. We need page_is_buddy() to verify the buddy to prevent accessing an invalid buddy. Fixes: d9dddbf55667 ("mm/page_alloc: prevent merging between isolated and other pageblocks") Cc: stable@vger.kernel.org Reported-by: zjb194813@alibaba-inc.com Reported-by: tianhu.hh@alibaba-inc.com Signed-off-by: Xianting Tian --- mm/internal.h | 34 ++++++++++++++++++++++++++++++++++ mm/page_alloc.c | 37 +++---------------------------------- mm/page_isolation.c | 3 ++- 3 files changed, 39 insertions(+), 35 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index d80300392a19..dfa80bdfe5c6 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -386,6 +386,40 @@ static inline bool is_data_mapping(vm_flags_t flags) return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE; } +/* + * This function checks whether a page is free && is the buddy + * we can coalesce a page and its buddy if + * (a) the buddy is not in a hole (check before calling!) && + * (b) the buddy is in the buddy system && + * (c) a page and its buddy have the same order && + * (d) a page and its buddy are in the same zone. + * + * For recording whether a page is in the buddy system, we set PageBuddy. + * Setting, clearing, and testing PageBuddy is serialized by zone->lock. + * + * For recording page's order, we use page_private(page). + */ +static inline bool page_is_buddy(struct page *page, struct page *buddy, + unsigned int order) +{ + if (!page_is_guard(buddy) && !PageBuddy(buddy)) + return false; + + if (buddy_order(buddy) != order) + return false; + + /* + * zone check is done late to avoid uselessly calculating + * zone/node ids for pages that could never merge. + */ + if (page_zone_id(page) != page_zone_id(buddy)) + return false; + + VM_BUG_ON_PAGE(page_count(buddy) != 0, buddy); + + return true; +} + /* mm/util.c */ void __vma_link_list(struct mm_struct *mm, struct vm_area_struct *vma, struct vm_area_struct *prev); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b1caa1c6c887..78ada8dedefb 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -886,40 +886,6 @@ static inline void set_buddy_order(struct page *page, unsigned int order) __SetPageBuddy(page); } -/* - * This function checks whether a page is free && is the buddy - * we can coalesce a page and its buddy if - * (a) the buddy is not in a hole (check before calling!) && - * (b) the buddy is in the buddy system && - * (c) a page and its buddy have the same order && - * (d) a page and its buddy are in the same zone. - * - * For recording whether a page is in the buddy system, we set PageBuddy. - * Setting, clearing, and testing PageBuddy is serialized by zone->lock. - * - * For recording page's order, we use page_private(page). - */ -static inline bool page_is_buddy(struct page *page, struct page *buddy, - unsigned int order) -{ - if (!page_is_guard(buddy) && !PageBuddy(buddy)) - return false; - - if (buddy_order(buddy) != order) - return false; - - /* - * zone check is done late to avoid uselessly calculating - * zone/node ids for pages that could never merge. - */ - if (page_zone_id(page) != page_zone_id(buddy)) - return false; - - VM_BUG_ON_PAGE(page_count(buddy) != 0, buddy); - - return true; -} - #ifdef CONFIG_COMPACTION static inline struct capture_control *task_capc(struct zone *zone) { @@ -1129,6 +1095,9 @@ static inline void __free_one_page(struct page *page, buddy_pfn = __find_buddy_pfn(pfn, order); buddy = page + (buddy_pfn - pfn); + + if (!page_is_buddy(page, buddy, order)) + goto done_merging; buddy_mt = get_pageblock_migratetype(buddy); if (migratetype != buddy_mt diff --git a/mm/page_isolation.c b/mm/page_isolation.c index f67c4c70f17f..5d14cef812ee 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -93,7 +93,8 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) buddy_pfn = __find_buddy_pfn(pfn, order); buddy = page + (buddy_pfn - pfn); - if (!is_migrate_isolate_page(buddy)) { + if (page_is_buddy(page, buddy, order) && + !is_migrate_isolate_page(buddy)) { isolated_page = !!__isolate_free_page(page, order); /* * Isolating a free page in an isolated pageblock