From patchwork Tue Jul 5 02:26:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Jiaming X-Patchwork-Id: 12905912 X-Patchwork-Delegate: song@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D614C43334 for ; Tue, 5 Jul 2022 02:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234337AbiGEC01 (ORCPT ); Mon, 4 Jul 2022 22:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234470AbiGEC00 (ORCPT ); Mon, 4 Jul 2022 22:26:26 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1291A1274C; Mon, 4 Jul 2022 19:26:24 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 2DAE51E80D71; Tue, 5 Jul 2022 10:24:22 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SBn1PamTXi59; Tue, 5 Jul 2022 10:24:19 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: jiaming@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id BB7911E80D19; Tue, 5 Jul 2022 10:24:18 +0800 (CST) From: Zhang Jiaming To: song@kernel.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, d@ja.vu, liqiong@nfschina.com, renyu@nfschina.com, Zhang Jiaming , Paul Menzel Subject: [PATCH v2] block: Fix spelling mistakes in comments Date: Tue, 5 Jul 2022 10:26:17 +0800 Message-Id: <20220705022617.12555-1-jiaming@nfschina.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220704012328.6507-1-jiaming@nfschina.com> References: <20220704012328.6507-1-jiaming@nfschina.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org Fix spelling of dones't and waitting in comments. Fix tense mistakes of hold and finsh in comments. Use underline to connecting reconfig and mutex. Signed-off-by: Zhang Jiaming Reviewed-by: Paul Menzel --- drivers/md/raid5-cache.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c index 83c184eddbda..8d5154d94f86 100644 --- a/drivers/md/raid5-cache.c +++ b/drivers/md/raid5-cache.c @@ -125,7 +125,7 @@ struct r5l_log { * reclaimed. if it's 0, reclaim spaces * used by io_units which are in * IO_UNIT_STRIPE_END state (eg, reclaim - * dones't wait for specific io_unit + * doesn't wait for specific io_unit * switching to IO_UNIT_STRIPE_END * state) */ wait_queue_head_t iounit_wait; @@ -1326,12 +1326,12 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log, * Discard could zero data, so before discard we must make sure * superblock is updated to new log tail. Updating superblock (either * directly call md_update_sb() or depend on md thread) must hold - * reconfig mutex. On the other hand, raid5_quiesce is called with - * reconfig_mutex hold. The first step of raid5_quiesce() is waitting - * for all IO finish, hence waitting for reclaim thread, while reclaim - * thread is calling this function and waitting for reconfig mutex. So + * reconfig_mutex. On the other hand, raid5_quiesce is called with + * reconfig_mutex held. The first step of raid5_quiesce() is waiting + * for all IO to finish, hence waiting for reclaim thread, while reclaim + * thread is calling this function and waiting for reconfig_mutex. So * there is a deadlock. We workaround this issue with a trylock. - * FIXME: we could miss discard if we can't take reconfig mutex + * FIXME: we could miss discard if we can't take reconfig_mutex */ set_mask_bits(&mddev->sb_flags, 0, BIT(MD_SB_CHANGE_DEVS) | BIT(MD_SB_CHANGE_PENDING));