From patchwork Tue Jul 5 19:03:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12906957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF21C3F2D4 for ; Tue, 5 Jul 2022 19:04:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233176AbiGETEI (ORCPT ); Tue, 5 Jul 2022 15:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbiGETEH (ORCPT ); Tue, 5 Jul 2022 15:04:07 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95EE81FCD9; Tue, 5 Jul 2022 12:04:03 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id m13so12081985ioj.0; Tue, 05 Jul 2022 12:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOU+KnItVhf/B0aHx7CqIES1feV9qodTdW7HnBjAhyA=; b=Ikn1jwPxdb71CgjahsFcC/VLGtmxh7JDywjYFz9Kg1yWn8Fe7Z6ysZV2p4YwwacPLR Oy+gWA7wHVsyr9Cfi/+FZJ4PAbytY4aRFg+6/hlk7fCiV1A85B8ewQnj0yyx0u+SQWtq kOaJkjLBmoUx0BKE4dYngogxDlxjir+nui0zl+fu39gzweXOG8uRqWadwz3fl36CZP3U RTd8uJCPtoJvoGTdqczgq6w4vAqn0okWnlzBaGYDrYQIqVH6BmqPDuSoUwdN3tUSLOZk Xx3z9VXSY2jBPcYTdbxo39U4xty3PhdmhoEVEtrIfjyhmObnzZT+cL2JgFd/bIzRmzT4 +/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VOU+KnItVhf/B0aHx7CqIES1feV9qodTdW7HnBjAhyA=; b=lWakXYaApgDO7U38uFVYi52d7grmJfkWLpo4e5THYMibwBcdoLBTmEpJGPTcZLYJoM I63sQ2zQOm87wHh8rKWVfaVXqkn7K+mwvXzizCGukNO7l63kwZ+fVCkxCkE31x399r3V cQl4Di3NyHVir6p96eOr3WaQEBxGPfw5TH94o/lC9OAxj1poFOHgLk9BKWE0T0rm8kBM WedqTMpen/Ik8HwRdtfD59yTQwDQ5/SshSAgI4Q/M2H4mWi2ovjXzwVJRNQVlcnQBMCU HppBzufIW28nlgnrkK/nN+MC4jkusIgOKrjnKw5iSuGA7r/8UnD65QpBNdv6q4C0Ec3k kL9Q== X-Gm-Message-State: AJIora+ewz7NohIZZC8bX2tTrdm35IGgaqN4VGrc/sxdvrto5p7VaqvG XKOLV1NWonlOubHy9A1f6+avA6wwK64= X-Google-Smtp-Source: AGRyM1tUwNRE+1mxsYpsdSPIaTqNtqn7yE/Xp0n83SaMmuxIEfS+YhEaVW/SuytU5IAt15NQs35Gsg== X-Received: by 2002:a05:6638:260a:b0:339:e6de:2116 with SMTP id m10-20020a056638260a00b00339e6de2116mr22376259jat.302.1657047842691; Tue, 05 Jul 2022 12:04:02 -0700 (PDT) Received: from Dixie.. ([2604:2d80:a188:fd00:a8dc:16da:96d1:2d19]) by smtp.gmail.com with ESMTPSA id d93-20020a0285e6000000b0033efe01c20esm397762jai.42.2022.07.05.12.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 12:04:02 -0700 (PDT) From: Chris Morgan X-Google-Original-From: Chris Morgan To: linux-input@vger.kernel.org Cc: devicetree@vger.kernel.org, contact@artur-rojek.eu, maccraft123mc@gmail.com, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, paul@crapouillou.net, jic23@kernel.org, linux-iio@vger.kernel.org, Chris Morgan , Chris Morgan Subject: [PATCH v7 1/3] dt-bindings: adc-joystick: add poll-interval Date: Tue, 5 Jul 2022 14:03:52 -0500 Message-Id: <20220705190354.69263-2-macromorgan@hotmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705190354.69263-1-macromorgan@hotmail.com> References: <20220705190354.69263-1-macromorgan@hotmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Add poll-interval support for the adc-joystick documentation. This is an optional value and if not provided the adc-joystick works as it does today (with buffers). If this value is provided, the adc-joystick driver is polled at the specified interval. The existing attribute of "poll-interval" was used instead of complying with property-units.yaml after discussion of the issue on the mailing list. Signed-off-by: Maya Matuszczyk Signed-off-by: Chris Morgan Reviewed-by: Rob Herring Acked-by: Artur Rojek --- Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml index 2ee04e03bc22..ab5caad055ea 100644 --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml @@ -14,6 +14,9 @@ description: > Bindings for joystick devices connected to ADC controllers supporting the Industrial I/O subsystem. +allOf: + - $ref: input.yaml# + properties: compatible: const: adc-joystick @@ -28,6 +31,8 @@ properties: https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml for details. + poll-interval: true + '#address-cells': const: 1 From patchwork Tue Jul 5 19:03:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12906958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599FFCCA47F for ; Tue, 5 Jul 2022 19:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233161AbiGETEJ (ORCPT ); Tue, 5 Jul 2022 15:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233187AbiGETEH (ORCPT ); Tue, 5 Jul 2022 15:04:07 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD42201B1; Tue, 5 Jul 2022 12:04:04 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id l24so12001449ion.13; Tue, 05 Jul 2022 12:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lBoAduiOY3dTG1kjtzuuO2xA8vXJSUeY7/uBXp/jxVc=; b=peuQZQF4D+5LgZxEzu9M9xhXv9pEUthYyEY5UwjphfRdsw/ghYG7P4qTOLQFrb7GL8 2TGq/YL55wGe1zH1giVdtJ34VlTMoSPM3DSDPYYSuZNqNJEl1EPvr4NuSawWUJWnGEeR 8ODM22c853V6/War/ReZ1GGklutM1BITIHP0uKxqiP8smRud+8I3CpQxzFnUuiGdBhXc VL3iKJ42V0S+qDkzqPF066ZCJFHHJepBQw5hxZUHbK5yQI/OZ3ooCf9EVPAPKdbvRjMr yKsT9cvhf+A4oO3BT6zOVMOTMNHMFm/Weu2ud45WZPCKLp6lfYkAxFZgdVJ3V7e7sy0p /QFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lBoAduiOY3dTG1kjtzuuO2xA8vXJSUeY7/uBXp/jxVc=; b=5t1s+c4lPGUH3O8+/9X9HYT/xFU4ajljtLJhpvs0f0CGJqTZ6MhZTy1YFMxl76B6Lt JtId/dbAAT3nz6kQFxbkrZj2WioOx1rxYlv9YMds1Oveb6Bbcqr/SVcsPe5aqk7D61My 95nD+qn7tzvpt+jyZUh1G/3855qsetkGEbxTd9on328frkz7ujj/4xhx6jYn14pCNTUF mvtWfOYTtp1WR4JEP93p42nNVtPPT3NPNn0PE/w/D3L/XVtoqJsaWj4/fcjRFRTrn7Ro I0KLM9QyqyfSmFp1DzNgrgmPx7aiwmxfhTnTyc6PE5Nn79UBDmx1FHdLgmUtEKGIF10d CIHA== X-Gm-Message-State: AJIora+NiIwdhDkO4sfR1kZ6mgQQnQK4sTmODVb+ZL8xjQkwz0w17JJn fMajp1XJx9456mJMH49JZKjKntAiOlQ= X-Google-Smtp-Source: AGRyM1uVaTNH6OA/7IqEsGDU2r4z3CJ879Ru/r55x9DwqxBa8O8i9zkHF/kctqNKKdgdePdN3cwmYg== X-Received: by 2002:a05:6638:2596:b0:33e:e4e3:ce9 with SMTP id s22-20020a056638259600b0033ee4e30ce9mr4650798jat.16.1657047843973; Tue, 05 Jul 2022 12:04:03 -0700 (PDT) Received: from Dixie.. ([2604:2d80:a188:fd00:a8dc:16da:96d1:2d19]) by smtp.gmail.com with ESMTPSA id d93-20020a0285e6000000b0033efe01c20esm397762jai.42.2022.07.05.12.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 12:04:03 -0700 (PDT) From: Chris Morgan X-Google-Original-From: Chris Morgan To: linux-input@vger.kernel.org Cc: devicetree@vger.kernel.org, contact@artur-rojek.eu, maccraft123mc@gmail.com, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, paul@crapouillou.net, jic23@kernel.org, linux-iio@vger.kernel.org, Chris Morgan , Chris Morgan Subject: [PATCH v7 2/3] Input: adc-joystick - Add polled input device support Date: Tue, 5 Jul 2022 14:03:53 -0500 Message-Id: <20220705190354.69263-3-macromorgan@hotmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705190354.69263-1-macromorgan@hotmail.com> References: <20220705190354.69263-1-macromorgan@hotmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk. Signed-off-by: Maya Matuszczyk Signed-off-by: Chris Morgan Acked-by: Artur Rojek --- drivers/input/joystick/adc-joystick.c | 51 +++++++++++++++++++++------ 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c index 78ebca7d400a..2f4bd12d6344 100644 --- a/drivers/input/joystick/adc-joystick.c +++ b/drivers/input/joystick/adc-joystick.c @@ -26,8 +26,23 @@ struct adc_joystick { struct adc_joystick_axis *axes; struct iio_channel *chans; int num_chans; + bool polled; }; +static void adc_joystick_poll(struct input_dev *input) +{ + struct adc_joystick *joy = input_get_drvdata(input); + int i, val, ret; + + for (i = 0; i < joy->num_chans; i++) { + ret = iio_read_channel_raw(&joy->chans[i], &val); + if (ret < 0) + return; + input_report_abs(input, joy->axes[i].code, val); + } + input_sync(input); +} + static int adc_joystick_handle(const void *data, void *private) { struct adc_joystick *joy = private; @@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev) int error; int bits; int i; + unsigned int poll_interval; joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL); if (!joy) @@ -215,8 +231,17 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype = BUS_HOST; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + + joy->polled = !device_property_read_u32(dev, "poll-interval", + &poll_interval); + + if (joy->polled) { + input_setup_polling(input, adc_joystick_poll); + input_set_poll_interval(input, poll_interval); + } else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error = adc_joystick_set_axes(dev, joy); if (error) @@ -229,16 +254,20 @@ static int adc_joystick_probe(struct platform_device *pdev) return error; } - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy); - if (IS_ERR(joy->buffer)) { - dev_err(dev, "Unable to allocate callback buffer\n"); - return PTR_ERR(joy->buffer); - } + if (!joy->polled) { + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, + joy); + if (IS_ERR(joy->buffer)) { + dev_err(dev, "Unable to allocate callback buffer\n"); + return PTR_ERR(joy->buffer); + } - error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer); - if (error) { - dev_err(dev, "Unable to add action\n"); - return error; + error = devm_add_action_or_reset(dev, adc_joystick_cleanup, + joy->buffer); + if (error) { + dev_err(dev, "Unable to add action\n"); + return error; + } } return 0; From patchwork Tue Jul 5 19:03:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12906959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513A3CCA488 for ; Tue, 5 Jul 2022 19:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233166AbiGETEK (ORCPT ); Tue, 5 Jul 2022 15:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbiGETEJ (ORCPT ); Tue, 5 Jul 2022 15:04:09 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3525E1F2FA; Tue, 5 Jul 2022 12:04:06 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id k15so12033052iok.5; Tue, 05 Jul 2022 12:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5mR8xFqGjjP4W/nW8ZmW82KHWo8ArnxMdtQdz/0Xv58=; b=Akho+oNYYzMJsQJYNCLDZUNWuBvocCA1oS7XupTuS1pc35+87NcySHqmXO9+XNxTX6 oz/RWdwuOY38bAeOjJvDMrPLA6ipJzoSzd4ol0fZCY6uOhhuDCOwuVaUIwmTD+/Nnej2 x73aq3HFAY0SnHG5s5FIQ44uBBy5o1v/1ipf/+Z6wuLTsRUMjLGSi3WvyRhB4Nu+1nBt xItD7w/rlj/2+uV5Zql99j6ENcL7FjswUujGHHW5hNLsRS9wccwY/FzUZan7wRYZJn3I e8lBFosav1lDhynlwfnRsjqgcKd78H+m2WRrDqUhPgg78W6pnbHi5tctDaD+wV1/ZVep inVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5mR8xFqGjjP4W/nW8ZmW82KHWo8ArnxMdtQdz/0Xv58=; b=VcOzQFRSoJXJO2Yj+F5ooSZAUefdkxjHdmU3BHHhHWZO9n+HreMIJ+9G/WfvsA7foJ ygfQBgQx4sOt15Pu3seepN2A88kePJWRTjo7Y2BUCsvREdUlpV+8kZO2BtdrIvrjRtAm Fj7wv0l8sjBbsTkIcWHtFPWdevt+iWhZRLFUXt4E/UlrnyJQkf4sx8MGGcd79vg2wcXc nz5b4v8XDzn7pq3R/ziEoYs6iR2ribtY7AzpdupUbEzZBbjsVALokXbmFIf49Xh7eaxo xAo+1Co9caSDgPGK+VzZpe/q6ePGVi6I47QnMDbEj+AJI92oovzd0oIJHYsRj6fiVBav wvXA== X-Gm-Message-State: AJIora/ODfyFHpcKG2i7QzjJpkBLitFP0G9D6SZeXV3oyhKeaPrAHNfx mcdnTPMuuDhPaJWTXxs7LB0BGR7Ki64= X-Google-Smtp-Source: AGRyM1tdnWKKjsE+zYzNvWtHrhePWJ7yVdxYfibU12etrCbr8d/XSsRDrfFr3f0GBMQITni6Dx9B2Q== X-Received: by 2002:a02:caa9:0:b0:339:e1a6:387e with SMTP id e9-20020a02caa9000000b00339e1a6387emr23086464jap.97.1657047845295; Tue, 05 Jul 2022 12:04:05 -0700 (PDT) Received: from Dixie.. ([2604:2d80:a188:fd00:a8dc:16da:96d1:2d19]) by smtp.gmail.com with ESMTPSA id d93-20020a0285e6000000b0033efe01c20esm397762jai.42.2022.07.05.12.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 12:04:04 -0700 (PDT) From: Chris Morgan X-Google-Original-From: Chris Morgan To: linux-input@vger.kernel.org Cc: devicetree@vger.kernel.org, contact@artur-rojek.eu, maccraft123mc@gmail.com, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, paul@crapouillou.net, jic23@kernel.org, linux-iio@vger.kernel.org, Chris Morgan , Chris Morgan Subject: [PATCH v7 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Date: Tue, 5 Jul 2022 14:03:54 -0500 Message-Id: <20220705190354.69263-4-macromorgan@hotmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705190354.69263-1-macromorgan@hotmail.com> References: <20220705190354.69263-1-macromorgan@hotmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Update the Odroid Go Advance to use "poll-interval" from the adc-joystick driver. Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk --- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts index ea0695b51ecd..61583c3f24e6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts @@ -26,6 +26,7 @@ adc-joystick { compatible = "adc-joystick"; io-channels = <&saradc 1>, <&saradc 2>; + poll-interval = <60>; #address-cells = <1>; #size-cells = <0>;