From patchwork Sat Jul 9 01:17:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12912027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB353C43334 for ; Sat, 9 Jul 2022 01:18:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CBC0910E362; Sat, 9 Jul 2022 01:18:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id 290AC10E2D8 for ; Sat, 9 Jul 2022 01:18:00 +0000 (UTC) Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6AF97845C7; Sat, 9 Jul 2022 03:17:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1657329477; bh=AZhhgqlf2XXi7jYNLvbCad9Q7wvL8DTfBNlR3chlTFI=; h=From:To:Cc:Subject:Date:From; b=Vh2jnxKDz2/++7Ad/q/gf9bD1AGm+QdRElyB6IkxEliSXphkRUYuSXNGLMQxafRTV 7KYRshapQO7JQ2/KZq8GN6IQE3j/z1ozvi5gedfJjx8g1pOECpLqzoKJBTPDh0oqr8 0NYoKQOdWQ26xaPN0sXaG8u+R9V/OUV99scprZTMpKmEeU/995OxOlPMB2d7mj6tqw ZJl6n6XFM/psllGEPh/5lJioh1yWEcbatOd/b9BnSAv2JFbwY2J8rZFURNOTf+wKIk mo4xrt8Kn7mEH7hvkRslZGgIhNAOrWuPO+sx8EGSjbtNcIqo9EDCSXicszLGFhwi+l CrHuGHauzWwLA== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 1/4] drm/lcdif: Clean up headers Date: Sat, 9 Jul 2022 03:17:43 +0200 Message-Id: <20220709011746.142296-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peng Fan , Martyn Welch , Liu Ying , robert.foss@linaro.org, Liu Ying , Alexander Stein , Laurent Pinchart , Robby Cai , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Drop unneeded headers, sort rest alphabetically, no functional change. Reviewed-by: Liu Ying Reported-by: Liu Ying Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Marek Vasut Cc: Martyn Welch Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner Acked-by: Sam Ravnborg --- V2: Add RB from Liu --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 3 --- drivers/gpu/drm/mxsfb/lcdif_drv.h | 1 + drivers/gpu/drm/mxsfb/lcdif_kms.c | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index befad33dcb959..1370889c6d687 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include @@ -16,10 +15,8 @@ #include #include -#include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.h b/drivers/gpu/drm/mxsfb/lcdif_drv.h index cb916341e8454..6cdba6e20c02b 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.h +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.h @@ -8,6 +8,7 @@ #ifndef __LCDIF_DRV_H__ #define __LCDIF_DRV_H__ +#include #include #include #include diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index 1bec1279c8b56..d7363e2b2fad0 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -17,9 +17,9 @@ #include #include #include -#include #include #include +#include #include #include #include From patchwork Sat Jul 9 01:17:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12912025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE20DC43334 for ; Sat, 9 Jul 2022 01:18:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C06310E2D8; Sat, 9 Jul 2022 01:18:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2889010E095 for ; Sat, 9 Jul 2022 01:17:59 +0000 (UTC) Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E9AD0845CD; Sat, 9 Jul 2022 03:17:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1657329478; bh=o/SlySWlq8tseqR2SUaTx+paKp609YCOZ62YI26cdLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMOQVN4lXdfJrlWms8ZzgyTEwICxG+J16aCZvQYfrtzhqCasUbGtXDCZ8jymVQyNp Gu/kUiZ59+GJK5jH54bTVItcOOkzBJUIvEJjYjxVMNYlac1czBR/Lnk4jLlOyFWf2m +Uhalc6Icvj5NDVGgidFsvmKCjBS0YBS1q76Rjd4UyS6UxCeCuqLZXsILq0ZV5LpRD QlH5Pu5YNwPg+gyM+dyi5Gr72LLV6Ct8cL5ps2NX5j3CKWOjIk/pzzvQh4+uLb0wGG MuKh59w6E2ik75WJyAMoOYDL+/wYF6hKtHZ7jYHrxesEqgV4HBWn9Nuy0SI9O/iOgf MeQ3qQNg6g46Q== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/4] drm/lcdif: Consistently use plane timings Date: Sat, 9 Jul 2022 03:17:44 +0200 Message-Id: <20220709011746.142296-2-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220709011746.142296-1-marex@denx.de> References: <20220709011746.142296-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peng Fan , Martyn Welch , Liu Ying , robert.foss@linaro.org, Liu Ying , Alexander Stein , Laurent Pinchart , Robby Cai , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Drop the crtc_ prefix from mode, consistently use the plain one. Reviewed-by: Liu Ying Reported-by: Liu Ying Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Marek Vasut Cc: Martyn Welch Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V2: Add RB from Liu Replace plane with plain --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index d7363e2b2fad0..829b0a6bb0d3f 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -123,8 +123,8 @@ static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags) writel(ctrl, lcdif->base + LCDC_V8_CTRL); - writel(DISP_SIZE_DELTA_Y(m->crtc_vdisplay) | - DISP_SIZE_DELTA_X(m->crtc_hdisplay), + writel(DISP_SIZE_DELTA_Y(m->vdisplay) | + DISP_SIZE_DELTA_X(m->hdisplay), lcdif->base + LCDC_V8_DISP_SIZE); writel(HSYN_PARA_BP_H(m->htotal - m->hsync_end) | @@ -139,8 +139,8 @@ static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags) VSYN_HSYN_WIDTH_PW_H(m->hsync_end - m->hsync_start), lcdif->base + LCDC_V8_VSYN_HSYN_WIDTH); - writel(CTRLDESCL0_1_HEIGHT(m->crtc_vdisplay) | - CTRLDESCL0_1_WIDTH(m->crtc_hdisplay), + writel(CTRLDESCL0_1_HEIGHT(m->vdisplay) | + CTRLDESCL0_1_WIDTH(m->hdisplay), lcdif->base + LCDC_V8_CTRLDESCL0_1); writel(CTRLDESCL0_3_PITCH(lcdif->crtc.primary->state->fb->pitches[0]), From patchwork Sat Jul 9 01:17:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12912026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0239C433EF for ; Sat, 9 Jul 2022 01:18:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DA9710E354; Sat, 9 Jul 2022 01:18:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54B8910E32D for ; Sat, 9 Jul 2022 01:18:00 +0000 (UTC) Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 61BBA845D2; Sat, 9 Jul 2022 03:17:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1657329478; bh=DfDdetUodg8hstkoLleaU3t7OmZt3rrkZUJkbZ9o2ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K3hxtgIk41/DB0rO5zYB8zZgDGdr7XCup7kReLgb31/IujEKA2sOf3+YhtrN9FwRq 10tCIZUj0/VZYwds7XzBR5xOrk2H0U5ZoBoW+Mk/H2nkMpD5gjRlN1exRxOFDcMEDZ 3B5EjsZKntPBK6Ge5tB71a1vSmAdj+0TT6a4nnsEd5jVOizK4nj8GzcCd6PPin0XEz CLfj9er7d/Jgb7sL54qjOvbkJyT9TkTPoAk2utneHrK/DVq5mG3z+WOpmxGE1EIIEB GLf/UXyoIWLS7q60X0xX/N58qkjmA9JTq3gU73/2YmbxvlSeSlZLnvW/9K4CuJF7W5 rn7C2Yu6SddEw== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 3/4] drm/lcdif: Clean up debug prints and comments Date: Sat, 9 Jul 2022 03:17:45 +0200 Message-Id: <20220709011746.142296-3-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220709011746.142296-1-marex@denx.de> References: <20220709011746.142296-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peng Fan , Martyn Welch , Liu Ying , robert.foss@linaro.org, Liu Ying , Alexander Stein , Laurent Pinchart , Robby Cai , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Update debug print to report bridge timings over connector ones. Drop missed comment commit from mxsfb. Reviewed-by: Liu Ying Reported-by: Liu Ying Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Marek Vasut Cc: Martyn Welch Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V2: Add RB from Liu --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index 829b0a6bb0d3f..9a77c631300a4 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -204,7 +204,7 @@ static void lcdif_crtc_mode_set_nofb(struct lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m->crtc_clock, (int)(clk_get_rate(lcdif->clk) / 1000)); - DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n", + DRM_DEV_DEBUG_DRIVER(drm->dev, "Bridge bus_flags: 0x%08X\n", bus_flags); DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags); @@ -296,7 +296,6 @@ static void lcdif_crtc_atomic_enable(struct drm_crtc *crtc, lcdif_crtc_mode_set_nofb(lcdif, bridge_state, bus_format); - /* Write cur_buf as well to avoid an initial corrupt frame */ paddr = drm_fb_cma_get_gem_addr(new_pstate->fb, new_pstate, 0); if (paddr) { writel(lower_32_bits(paddr), From patchwork Sat Jul 9 01:17:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12912024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20A3FC433EF for ; Sat, 9 Jul 2022 01:18:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2783C10E095; Sat, 9 Jul 2022 01:18:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8511610E095 for ; Sat, 9 Jul 2022 01:18:00 +0000 (UTC) Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D3D6F845D3; Sat, 9 Jul 2022 03:17:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1657329479; bh=lmk82Oah7mQgcXIkRHLrWaugFWqFc+rIp+z1TvPhcS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ws1/l4ST8AnIju1QRGX/xB5JM6bUf3cZGNTQwi+czcR2YJfmFQfZ25kVKGeldsCKF s1wHoTKQLo2RZunmFkbhmWGQoak8Nzn85ezX59d5tyExtmyJbc5D684h6vup02rl7B Zx1qFcNpEc8J4si20FWeJJ5fDdpmlvl27edm5wY7tiitEVPhQP9SwnWB/s9zluNVfQ cZNtN++r8kJABvGXhgq+XeOfqoH3GOHC8aHM3dbPltNRkaSs+EUmgULQ5PrJCs0iRF uuOfMvf4Fsj8Hs6u7zfZOmgYNSBQz/P7h/InO2m+ifCqGT+gRe3LlXBmwdtA7qajnf RbGimADmJcUyg== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 4/4] drm/lcdif: switch to devm_drm_of_get_bridge Date: Sat, 9 Jul 2022 03:17:46 +0200 Message-Id: <20220709011746.142296-4-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220709011746.142296-1-marex@denx.de> References: <20220709011746.142296-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peng Fan , Martyn Welch , Liu Ying , robert.foss@linaro.org, Liu Ying , Alexander Stein , Laurent Pinchart , Robby Cai , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Reviewed-by: Liu Ying Reported-by: Liu Ying Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Marek Vasut Cc: Martyn Welch Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V2: Add RB from Liu --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index 1370889c6d687..746a4261f3da2 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -42,23 +42,11 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) { struct drm_device *drm = lcdif->drm; struct drm_bridge *bridge; - struct drm_panel *panel; int ret; - ret = drm_of_find_panel_or_bridge(drm->dev->of_node, 0, 0, &panel, - &bridge); - if (ret) - return ret; - - if (panel) { - bridge = devm_drm_panel_bridge_add_typed(drm->dev, panel, - DRM_MODE_CONNECTOR_DPI); - if (IS_ERR(bridge)) - return PTR_ERR(bridge); - } - - if (!bridge) - return -ENODEV; + bridge = devm_drm_of_get_bridge(drm->dev, drm->dev->of_node, 0, 0); + if (IS_ERR(bridge)) + return PTR_ERR(bridge); ret = drm_bridge_attach(&lcdif->encoder, bridge, NULL, 0); if (ret)