From patchwork Sat Jul 9 10:07:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 12912140 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCCBCCA481 for ; Sat, 9 Jul 2022 10:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbiGIKHl (ORCPT ); Sat, 9 Jul 2022 06:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiGIKHk (ORCPT ); Sat, 9 Jul 2022 06:07:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCDD4B0FA; Sat, 9 Jul 2022 03:07:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DE7D60DE9; Sat, 9 Jul 2022 10:07:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F58FC341CE; Sat, 9 Jul 2022 10:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657361258; bh=dqYqnXuzEPE0mXihhCJPYUpFXM9zwpfA8rk6kSTuBCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GKfzx3SqXsJGBAjpsgDp6mypn1L5oUbOzKatAFWraRL49e9nq1dnhRUIYWNjmdkCm ImzGorGOPul0XG+ZwWHru7Y4g2RqB/EBU18NdDa+7xUaTcju3MlMnoYnvDLhginzxn +WZ8YDUZtfzmJzYXBCzAsz+YsHbZZssFwR99l9Drs3XtOqSwxuJH5RhyHck9B+h5L4 Zk6yJRNPQKKap1ztitDAo47wA3Fi9ANOjwFY0nDxrNlj/pPyePAF34n8/tO07SOD4u 38DnHUEk76GYExc6lDMX/ymd43tkqJFmbaF5bPJPclBSU1yYX7mdS8a6hM8SpK9X4U H8lxc9/OPfztA== Received: from mchehab by mail.kernel.org with local (Exim 4.95) (envelope-from ) id 1oA7N9-004EGo-HT; Sat, 09 Jul 2022 11:07:35 +0100 From: Mauro Carvalho Chehab To: Linux Doc Mailing List Cc: Mauro Carvalho Chehab , "Jonathan Corbet" , "Mauro Carvalho Chehab" , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/21] fs: namei: address some kernel-doc issues Date: Sat, 9 Jul 2022 11:07:21 +0100 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org There are couple of symbols missing documentation: fs/namei.c:649: warning: Function parameter or member 'mnt' not described in 'path_connected' fs/namei.c:649: warning: Function parameter or member 'dentry' not described in 'path_connected' fs/namei.c:1089: warning: Function parameter or member 'inode' not described in 'may_follow_link' Document them. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/cover.1657360984.git.mchehab@kernel.org/ fs/namei.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 1f28d3f463c3..a8079d6250bc 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -640,6 +640,8 @@ static bool nd_alloc_stack(struct nameidata *nd) /** * path_connected - Verify that a dentry is below mnt.mnt_root + * @mnt: pointer to vfs mount + * @dentry: pointer to dentry to verify * * Rename can sometimes move a file or directory outside of a bind * mount, path_connected allows those cases to be detected. @@ -1072,6 +1074,7 @@ fs_initcall(init_fs_namei_sysctls); /** * may_follow_link - Check symlink following for unsafe situations * @nd: nameidata pathwalk data + * @inode: inode to check * * In the case of the sysctl_protected_symlinks sysctl being enabled, * CAP_DAC_OVERRIDE needs to be specifically ignored if the symlink is