From patchwork Mon Jul 11 09:52:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12913220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF817C433EF for ; Mon, 11 Jul 2022 09:53:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0D0523E7; Mon, 11 Jul 2022 11:52:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0D0523E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657533205; bh=SGu3Iez0MNumhaZ/Y5N82y7aeHKR+TFgV9GmQXULqtk=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=bZnFrEA06uyvkUVq5Gz1OscLB84FXVLjUZ30puTdux8tGIfBFGpKeKjwIiEYZPWyf zs796GLOn4y8S6lT6X0qwQfPQRf0DBlhvjb6fcbReHsgSlgacBnRZJM+j63gHetVOZ RcZ4PlTqBFO6XIj44Lfv4NfI3GNXiaCr8sG4qH7c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9240FF80152; Mon, 11 Jul 2022 11:52:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24F9FF804D6; Mon, 11 Jul 2022 11:52:33 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45CB4F800E8 for ; Mon, 11 Jul 2022 11:52:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45CB4F800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OgzJyXa5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657533147; x=1689069147; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SGu3Iez0MNumhaZ/Y5N82y7aeHKR+TFgV9GmQXULqtk=; b=OgzJyXa5zVH5/gsKXxYIgJVQ4q2C/2QyiVmBka4UzoN0z64NKRnF/lU2 cGG5uFauR8mE7rUvqN6YtQjjn3MDKtw+OrUg57DgaKhmpoJ+eQaMh/GJo SromcaoYXZKLEqU/ILZW7iG43UE8kd6SlFWcpUfOw3zf/dhjTX8HEK7r6 LOblCtNKrzQ0cDR96CQ9yUhZ/sdyRgY9CdzojmtWd3106J4rNRoU8fwn5 bPJAlt8sQ096QEiPDEIId1XSmr2mm63EG5inGL1NnyIcs4bdkMOBBAo4Z E7Cm77jAauow05XmJILSrHeRB5tNLlj61zKYkFkFu/T9Nc8RDGMhTzASo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="264398003" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="264398003" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 02:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="662485655" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2022 02:52:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6AEBE1A0; Mon, 11 Jul 2022 12:52:26 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v1 1/4] ALSA: hda: cs35l41: Improve dev_err_probe() messaging Date: Mon, 11 Jul 2022 12:52:16 +0300 Message-Id: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Drop duplicate print of returned value in the messages and use pattern return dev_err_probe(...) where it's possible. Signed-off-by: Andy Shevchenko --- sound/pci/hda/cs35l41_hda.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index cce27a86267f..23a97ada7272 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -460,10 +460,8 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i dev_set_drvdata(dev, cs35l41); ret = cs35l41_hda_read_acpi(cs35l41, device_name, id); - if (ret) { - dev_err_probe(cs35l41->dev, ret, "Platform not supported %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(cs35l41->dev, ret, "Platform not supported\n"); if (IS_ERR(cs35l41->reset_gpio)) { ret = PTR_ERR(cs35l41->reset_gpio); @@ -471,7 +469,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i if (ret == -EBUSY) { dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n"); } else { - dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret); + dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO\n"); goto err; } } From patchwork Mon Jul 11 09:52:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12913221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17EF7C433EF for ; Mon, 11 Jul 2022 09:53:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2AA39828; Mon, 11 Jul 2022 11:53:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2AA39828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657533235; bh=IFixV8KBTV+chD2hbw0USw+m4VI10depIHGAYgCIDEc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j0S7ZeuOZpUdtjxFeJH9h/KHQgW/CVNtdtf2hjVYxQhKQC8inry2EID+oThvSxAw3 jGtCAM3aDH2OSPkYSE0ZAwtBt0joEbc53ER0VeLvVrkzUoIIYJ/YqK16Z3/wOg1PAs iurE/fJ1D34JjZHSqHdXtbz6p0b6/cxZKsBLVjIg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5956AF80155; Mon, 11 Jul 2022 11:52:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C11D4F8047C; Mon, 11 Jul 2022 11:52:33 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2FAFF80152 for ; Mon, 11 Jul 2022 11:52:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2FAFF80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EzDOFAAL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657533148; x=1689069148; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IFixV8KBTV+chD2hbw0USw+m4VI10depIHGAYgCIDEc=; b=EzDOFAALLZ9Md5zznK/U8Wz9MRDGZYYL+QsdvdyUIz06Xd2R6UT81kCz RuV5Im5QyvX2TQhp6OOrAt/29vJPXSDSrSXVNUYaFfVsE9M1G4C0nesnB G03lEw6Z3knu4cRxeQZOjozYY2apQmKdUFbuHRIuIWqejRnkARaEaxMoX CEZeyrDsSCZgie0XjXSOI7IxOFyn/wo6CF8X6C4QyBHcMqHJUjrPhR6oZ cIX2J2cTWKZyBI5+DV6FmyZwWmbJkF8rfnqGi7Pe9hM3Y3MboZ6ZAkMbZ bUyuS6bt/35uc1ctV0venlrr/g9hmY7VWeYP3T1xz1wSv0nY2tMJRqy7T Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="370930113" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="370930113" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 02:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="840953939" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2022 02:52:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 73BD5AD; Mon, 11 Jul 2022 12:52:26 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v1 2/4] ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations Date: Mon, 11 Jul 2022 12:52:17 +0300 Message-Id: <20220711095219.36915-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> References: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ACPI is needed only for functioning of this codec on some platforms, there is no compilation dependency, so make it optional Signed-off-by: Andy Shevchenko Reported-by: kernel test robot --- sound/pci/hda/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index 79ade4787d95..e86cf80bdf96 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -97,7 +97,7 @@ config SND_HDA_SCODEC_CS35L41 config SND_HDA_SCODEC_CS35L41_I2C tristate "Build CS35L41 HD-audio side codec support for I2C Bus" depends on I2C - depends on ACPI + depends on ACPI || COMPILE_TEST depends on SND_SOC select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB @@ -113,7 +113,7 @@ comment "Set to Y if you want auto-loading the side codec driver" config SND_HDA_SCODEC_CS35L41_SPI tristate "Build CS35L41 HD-audio codec support for SPI Bus" depends on SPI_MASTER - depends on ACPI + depends on ACPI || COMPILE_TEST depends on SND_SOC select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB From patchwork Mon Jul 11 09:52:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12913222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69841C43334 for ; Mon, 11 Jul 2022 09:54:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B1D5082C; Mon, 11 Jul 2022 11:53:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B1D5082C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657533255; bh=mioNk0tvPDP7UvyjGTwFiy0EVcTJtI65Soj89fFF8yE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=navxZXYNGWcqomR5VmLhYQX5l5JbRxVGrH61Y1Gbecm3jTYSlxD5HKoEY1MHbbKKe 09ETdPnoY1vzMvj6J6aHPKoQlJ0ibejsK3cTEXumO3zT9UDDvZx5XvEoMGne6pl2/z 1pCB7Jl3xFixCwP51/FALn6s+H6kcNpWtITxsaIU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2F9A4F804FC; Mon, 11 Jul 2022 11:52:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5EEEAF804FC; Mon, 11 Jul 2022 11:52:36 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B8136F80256 for ; Mon, 11 Jul 2022 11:52:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B8136F80256 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Io9n1Nm1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657533150; x=1689069150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mioNk0tvPDP7UvyjGTwFiy0EVcTJtI65Soj89fFF8yE=; b=Io9n1Nm1mHWvcF1qN6HBh+EeOjJJIr5YcoLjUblyHrT2Y3jiIRjppDWO uCkvn6Bx5HaSAv3rAc+CTCIU4UY405w1TCg5NJtF4BtIJ3oax7j9O9wVt NS8KYHxkTv/X1Mqgliw6uV5PDcWfsjkq6esvUeOjX9cKYPmWxA8xn6zjM akKvqYs+K+k5nx4WRXKUZnqN0EONcgvuqE3dGlQB1S7LqL7mJW6Ib+9Aa 6hLX4oBu04O840kEDxGiPAUJnG5fP29CbrvyyYx9dHfKd5S94xfokQ1Ss XS0dOMyThovsMb3i9qFw3zEdi1w6yyCIiPw3aOPVa2fPkp0zCvoPIOCaE g==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="283374562" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="283374562" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 02:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="737035121" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 11 Jul 2022 02:52:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7C029481; Mon, 11 Jul 2022 12:52:26 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v1 3/4] ALSA: hda: cs35l41: Drop wrong use of ACPI_PTR() Date: Mon, 11 Jul 2022 12:52:18 +0300 Message-Id: <20220711095219.36915-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> References: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused which is not what we want. Instead of adding ifdeffery or attribute here and there, drop ACPI_PTR(). Signed-off-by: Andy Shevchenko --- sound/pci/hda/cs35l41_hda_i2c.c | 8 +++----- sound/pci/hda/cs35l41_hda_spi.c | 8 +++----- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda_i2c.c b/sound/pci/hda/cs35l41_hda_i2c.c index e810b278fb91..5cfb5aac37ac 100644 --- a/sound/pci/hda/cs35l41_hda_i2c.c +++ b/sound/pci/hda/cs35l41_hda_i2c.c @@ -6,9 +6,9 @@ // // Author: Lucas Tanure +#include #include #include -#include #include "cs35l41_hda.h" @@ -42,19 +42,17 @@ static const struct i2c_device_id cs35l41_hda_i2c_id[] = { {} }; -#ifdef CONFIG_ACPI static const struct acpi_device_id cs35l41_acpi_hda_match[] = { {"CLSA0100", 0 }, {"CSC3551", 0 }, - { }, + {} }; MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_hda_match); -#endif static struct i2c_driver cs35l41_i2c_driver = { .driver = { .name = "cs35l41-hda", - .acpi_match_table = ACPI_PTR(cs35l41_acpi_hda_match), + .acpi_match_table = cs35l41_acpi_hda_match, }, .id_table = cs35l41_hda_i2c_id, .probe = cs35l41_hda_i2c_probe, diff --git a/sound/pci/hda/cs35l41_hda_spi.c b/sound/pci/hda/cs35l41_hda_spi.c index 22e088f28438..c9a61675c4fd 100644 --- a/sound/pci/hda/cs35l41_hda_spi.c +++ b/sound/pci/hda/cs35l41_hda_spi.c @@ -6,7 +6,7 @@ // // Author: Lucas Tanure -#include +#include #include #include @@ -38,18 +38,16 @@ static const struct spi_device_id cs35l41_hda_spi_id[] = { {} }; -#ifdef CONFIG_ACPI static const struct acpi_device_id cs35l41_acpi_hda_match[] = { { "CSC3551", 0 }, - {}, + {} }; MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_hda_match); -#endif static struct spi_driver cs35l41_spi_driver = { .driver = { .name = "cs35l41-hda", - .acpi_match_table = ACPI_PTR(cs35l41_acpi_hda_match), + .acpi_match_table = cs35l41_acpi_hda_match, }, .id_table = cs35l41_hda_spi_id, .probe = cs35l41_hda_spi_probe, From patchwork Mon Jul 11 09:52:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12913223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F23F1CCA47B for ; Mon, 11 Jul 2022 09:54:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 123D6822; Mon, 11 Jul 2022 11:53:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 123D6822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657533266; bh=3N262QoHq7zgv+1D1IpRmJMMCOTGj2506vH+/IAwPgk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gMpo/f1aAO8zfiOTXzAvDq4TSJ9WScARskOWQoQKcpkztpP3qR+6znqmKb7QICh5P jeQaBz1QDapUe9vxhHeoap1r/irZU7c+iQIyEwKCGY7MHGzpw69IHaIygtqKnBNA82 THa0s3V/OlUlmKaDyTEB6kbyH8J4evZ+xDrpatZ0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B122CF80548; Mon, 11 Jul 2022 11:52:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 44ACAF80163; Mon, 11 Jul 2022 11:52:38 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3237AF80163 for ; Mon, 11 Jul 2022 11:52:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3237AF80163 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S5P3e3lr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657533150; x=1689069150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3N262QoHq7zgv+1D1IpRmJMMCOTGj2506vH+/IAwPgk=; b=S5P3e3lrWAjMRCoZTpzU0bAkDTgmU4wZDZIE47X9+Xy6DEtSQ47ZNtV7 9C5nCbKuaC195swjG/2NmYpVKlwCf6xluOne4zHePUVmos/kBkNK4sH1H EaYh6xV+d+YoXhA8Dnj+Fznho89kf4KzDkzmyw0iiWrIG3JLtD0zoP28T hrxlSVSaZC7AnluSTZK04sliP9dBgZdNCAzo14Qvkgg/6sjrmD6Q4EdqJ AJDQmXY4gWWuSMYz/QBKp8d5FkjqEiHD/yKtJAu+eZMGqlRXB+CBiGob8 gZ78h83e3axf6pIcX0BN4lOjTEVarKswaR2Ca/wDQlGoN78JT/jFwPH0j Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="370930114" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="370930114" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 02:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="840953940" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2022 02:52:19 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 85029400; Mon, 11 Jul 2022 12:52:26 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v1 4/4] ALSA: hda: cs35l41: Consolidate selections under SND_HDA_SCODEC_CS35L41 Date: Mon, 11 Jul 2022 12:52:19 +0300 Message-Id: <20220711095219.36915-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> References: <20220711095219.36915-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Selections can be propagated via selections, while dependencies are not. Hence, consolidate selections under the SND_HDA_SCODEC_CS35L41 option. Signed-off-by: Andy Shevchenko --- sound/pci/hda/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index e86cf80bdf96..8b73a12d356f 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -93,16 +93,16 @@ config SND_HDA_PATCH_LOADER config SND_HDA_SCODEC_CS35L41 tristate + select SND_HDA_GENERIC + select REGMAP_IRQ config SND_HDA_SCODEC_CS35L41_I2C tristate "Build CS35L41 HD-audio side codec support for I2C Bus" depends on I2C depends on ACPI || COMPILE_TEST depends on SND_SOC - select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 - select REGMAP_IRQ help Say Y or M here to include CS35L41 I2C HD-audio side codec support in snd-hda-intel driver, such as ALC287. @@ -115,10 +115,8 @@ config SND_HDA_SCODEC_CS35L41_SPI depends on SPI_MASTER depends on ACPI || COMPILE_TEST depends on SND_SOC - select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 - select REGMAP_IRQ help Say Y or M here to include CS35L41 SPI HD-audio side codec support in snd-hda-intel driver, such as ALC287.