From patchwork Mon Jul 11 11:01:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Kamboju X-Patchwork-Id: 12913332 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58B68C433EF for ; Mon, 11 Jul 2022 11:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZMC+he77dM4Vr0sK5Es0RSGP3eK6jdG6Zs+pjgCkd/c=; b=x/VPwhmvVF9Dtx s60gPrm3hPnOy+ZIDKzLVjc4qzNie1fVfqqEnQ3DrwQVVKPdmGpmgUl8Zri5oSl9C8Y+MDbBcv8v+ yl0PS9ihNry+vpIjabV7+4LQsnP/73EWcsepG+Ldo+KCzswEIoicXT7MAgIsjLNuKUP78JFH/KHuC Fsum+4wr5osjFcZ6i2dO2VTk4mMg5r18nHA8T+lBreZIIQG24Gt+wdbew12Bz33DRaIkwk0bSgZVe yLIY9Jnaoh1eRew81g3bl7/QE/CsusgQmwl354gPpSet8ZYxQ9tmYOiHc1Em33+rynvb1grlxxzD4 CxbVw/263Ap5iVjdJ1+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oArAz-000uLr-1V; Mon, 11 Jul 2022 11:02:05 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oArAw-000uJO-FV for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 11:02:03 +0000 Received: by mail-io1-xd2c.google.com with SMTP id n68so4556095iod.3 for ; Mon, 11 Jul 2022 04:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=zZThk4si2Df2oCcklrdiFPTJcwReEc+65EKNL0Y3jcA=; b=hEAtnyVmAaVw4hGQPfDNKMFHfWf4jgRpP6t4mIOeQ1ii1bvWwarph3IkjYrIp0OHcM qqzhukxCRTsCy2RVueuQQQ471HbVEMfojJarVVyC+rLT8dl3eICYvnz7xoC/mrSDKGV0 DRCf/BUiKfzxT3KKEiQGdL9tCVlRRL1ZEXVkdvmKXlbLCYPvw2TsXYP+Mi5YSQlDhyZh 6IbCzUrXnPovc6SlPMeeaDkvS1/MhIuOdTlUe+Mfz1qx1AE6kwOIMVhF1IYf5/Sey43z My6U9MNYp4hNZW2paUpegGjCM3lsWb4BMbzKL5nyqTSA8a/2whpRXJBDNTWMURGttMGB uCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=zZThk4si2Df2oCcklrdiFPTJcwReEc+65EKNL0Y3jcA=; b=pNUIU2XBEdEm7G3d6rITB3VPeUYAMs9hJkUMUYlMFT/rWwlqIeaYSCP5cl5Y4TSxmJ p0kbE3BE1SkQJlZuOxMKN5vitISHdxzyBS0AtOJL+gdsiiKXCOoKl3ox/pqHtIcqZAd9 8hNBh8RomwYXARr0OwU56rAd3OdD4mfQG331iG87ee+nxxv5Yb6HarabMtn500SF/rXg A9Al+AcuPkiwAVQoFTgVJb+ZFNHvesFpRfL9BeuiJmj7Fd22feo3pjMvGR79Niy5xZp+ Cp+8WeZmrkUmcjtXl6EhN4eHnb4fRlqGU7ED6SNA8DLEkGHFNyES+6HuxF60KcJISuFM WDaQ== X-Gm-Message-State: AJIora/6hBERLIiZQ2ySpOsReqAdiyAMweBCwObPLiSMwOhjBKuFvYlu hv8/748LFnkYedCBtNzcl7oGbZ9UlUHIAKXOTFsREg== X-Google-Smtp-Source: AGRyM1u0MaIJ0uypZPWBkAr2NPKGat9OktcIuoHO3nP77sJq2pHTDV3AU8nizI+RjOYBzF88RInvbapcqca0SsR3g6c= X-Received: by 2002:a05:6602:2ace:b0:678:d781:2984 with SMTP id m14-20020a0566022ace00b00678d7812984mr8968851iov.186.1657537319833; Mon, 11 Jul 2022 04:01:59 -0700 (PDT) MIME-Version: 1.0 From: Naresh Kamboju Date: Mon, 11 Jul 2022 16:31:48 +0530 Message-ID: Subject: [next] arn: PM: domains: Delete usage of driver_deferred_probe_check_state() To: open list , Linux-Next Mailing List , Linux ARM , regressions@lists.linux.dev, lkft-triage@lists.linaro.org Cc: Geert Uytterhoeven , Ulf Hansson , Saravana Kannan , Anders Roxell X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_040202_542376_DF9A87D6 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Linux next arm BeagleBoard x15 device boot failed due to the following commit. The x15 did not event showed any crash log on the serial console. Anders bisect this and found the first bad commit is Reported-by: Linux Kernel Functional Testing commit 5a46079a96451cfb15e4f5f01f73f7ba24ef851a Author: Saravana Kannan Date: Wed Jun 1 00:06:57 2022 -0700 PM: domains: Delete usage of driver_deferred_probe_check_state() Now that fw_devlink=on by default and fw_devlink supports "power-domains" property, the execution will never get to the point where driver_deferred_probe_check_state() is called before the supplier has probed successfully or before deferred probe timeout has expired. So, delete the call and replace it with -ENODEV. Tested-by: Geert Uytterhoeven Reviewed-by: Ulf Hansson Signed-off-by: Saravana Kannan Link: https://lore.kernel.org/r/20220601070707.3946847-2-saravanak@google.com Signed-off-by: Greg Kroah-Hartman dev_dbg(dev, "adding to PM domain %s\n", pd->name); --- Linaro LKFT https://lkft.linaro.org diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 739e52cd4aba..3e86772d5fac 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2730,7 +2730,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, mutex_unlock(&gpd_list_lock); dev_dbg(dev, "%s() failed to find PM domain: %ld\n", __func__, PTR_ERR(pd)); - return driver_deferred_probe_check_state(base_dev); + return -ENODEV; }