From patchwork Fri Jul 15 07:38:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 12918886 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF3FAC433EF for ; Fri, 15 Jul 2022 07:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=iB/55kCcdqu6X/plN7y1c3EAxvIAp1fyOm90FaaEnyc=; b=meeaa2l25x98gz XDvXcHPv81ozXbtPJFNEu8UvzmzXMMjrxgPYEhvPVrUWR1fmr3AmtlZkja3i6w25JqAEGT2W9LRot g8WVp9XA64A2DSTMoWnXoZIA3vZ4u4gymYpIvl7YM8BeJPkITgB24HbcokrXBd4FcujSBs9VJZ2nZ VHrlrTOsO1Bes3fd20SLJiNGcHUjzzlksCSNszXpZ9uDM73yxtaWKHLxdliY14or9yfyHvH1l+0aM jq3Y8wARL0D3Hb4xFzH6/q2SpQrCOfeRiRLRtTHs1CBxUSSkCR7fwieA+r5QA7bA2C5xGKq07wUil iWbadubBy8Bm6PG0wMdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCFuA-004xSq-LM; Fri, 15 Jul 2022 07:38:30 +0000 Received: from mail-eopbgr80083.outbound.protection.outlook.com ([40.107.8.83] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCFu7-004xOI-6O for linux-arm-kernel@lists.infradead.org; Fri, 15 Jul 2022 07:38:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qvcq1f45d8YmFyKZNr6zi4u+XRqmaUjv3erYkJ5kly34C8l7bP7nhF9H+ibutG/VAlu3XVWg4rENolq15mDcvoGJhJVBeYiB6D8MO8aYmlrg7r0FpfvNIvZx1t99y9GONvcEXVkgyRvWWpaauoZyImIxIjejcQRbylAVOAvOTNOkKsyNIkgxLNOzqZ7gjUEwW999XYKiqUjCa8+0bJ0iMYnZphP0qp4a4TX1vPKHb7ZzksNRmaHzBbvNgd8y3/g3HXomZY7qg1DQNP4ryjAjPq0yjhlW5Xb6MCt+pgc3lE6DXGDIMlMy1YScjIZ+0DwqEuz1d6XqD2vZEHqM4USzQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mk1HscuILBLIFPDz1yyxhRcAiq5JCH84m49FGkbG2SM=; b=cwH5rZnDhksaQY08Vd9t5AwqJrT7siKgRvAjgSk1NyzKPt0sVe/Mlet9dI1gH5QckZxElXA80p+HxNVSOEe9TOmWaLwtzKYuGIO/zc+ZRBsmZGGbAZ8jL/oAyqtjSQGf+Nelkv3a6jH9pEB1WVZQhgMT7XeVHQTC9gYkgZ9Ky4wIHeCY6PU/tOVy0uUBZf2y7+WhRiL36DYx9eBYjRtq4oaqtjBA+tveQi+ExkhlHSrgISG686mANEBVdvxyf9aVVJBlc6nzI1Cefd17OkhxbheAXFlYNmcsdHjY6S15C0ugDlVQ+4JfYpYWkUphi/fOiwpaO9Au6Nd5nv0H3k/WkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mk1HscuILBLIFPDz1yyxhRcAiq5JCH84m49FGkbG2SM=; b=sVH+m9HRjpethjre6jxsuxbtycjJUw+GhfsT2/5zWcbHbnSJtjkdwzRdY/a0RqejoEbPYGQvBKJ+lPROuxEqKWGnZpf0tsqdXaE2YHQ3C3wRmTGxbDapIlCFQAuqf9goJoa+3k+gAUGY2ztc5DSrJTaoZQQ8+VaYEUuNs5Fp6eo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by AM6PR04MB6615.eurprd04.prod.outlook.com (2603:10a6:20b:fd::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.16; Fri, 15 Jul 2022 07:38:22 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::5ed:ec65:3631:aca8]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::5ed:ec65:3631:aca8%4]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 07:38:22 +0000 From: Ming Qian To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl Cc: shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] media: amphion: adjust the encoder's value range of gop size Date: Fri, 15 Jul 2022 15:38:00 +0800 Message-Id: <20220715073800.11321-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.36.1 X-ClientProxiedBy: SG2P153CA0013.APCP153.PROD.OUTLOOK.COM (2603:1096::23) To AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9507227-a1d2-4f9e-e8a7-08da6634fe0f X-MS-TrafficTypeDiagnostic: AM6PR04MB6615:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3PgQHL+0pihVJU+K5Xia2HcMBcN2+82D+qCoCa6DpOhPX4mpdktjxOtCX/oQMoZB96YfmDxjPG2aYi05o6EpX1jnRpcDHSCYrzIMn4GWrwlZgIdg3mzrnyF/GvEJ5X8Lht3TvTMgj8joYNXPh0xdI9uuN/Ry2wYa0xICMyBOzzqVjoxHxEkkjeeyaWVlrbjSny0ddGtVB7Aa6W3my80IyBjWY/an5TK99nhg8qvvjJsDZD9a9MtPbEMu2DKhgMGTKfqS57UauwFJ3NOLUbNEjdNcR5MRjN4cJ3aE0+VYj9Bq+wO0HELKFliJNjncJEeMfBtOtjJ3lqbU/95omaA7KZDrslOxDbHG8GQdTdP2hBUi6q32G3Z6kDBxIz/7nHM/Qdrxkj+UMi4JM6Qg/2psdKo6/aKaatdtGROcEhY9v6X7A749xw69wTpYQG2/EJPJHcZtEwm4SOtwQCqPk1sXMwIkz1gIn9VjFmsyW4FVQmTeoDWG1Kq8RjAToSs5hIW2ZHy7hLfSoxPgdwRAOCi/Hp91mglM5MfqTUle94WJHOHgxtpyNJYTZfdtd7u1aompqI5ZjYwemOIrcEHJ6aD3sX9bXV1mhKKPYCunGJ+SSEGxkhAffS8FPdg9w+FT41cmuk0G+Z7NXDEKubnJoEDn3sd7+u+JHBP+BotH51uczHR4NtMwWU6DxRbM/oBStHqyJPysw6/upbd192Tktf0RZgmcftAeLyfI4hjioVKpaODjznKJZql5w5tIR9ckWht0Ff3atFVYuLlEtzFXbgyjiGJyyjX0bLY1dpDP2pQO3kMkonJdKAHNKY5ovU4WafGy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6341.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(44832011)(4744005)(2906002)(7416002)(5660300002)(316002)(66476007)(8676002)(66556008)(66946007)(6512007)(52116002)(26005)(6486002)(6506007)(478600001)(6666004)(41300700001)(8936002)(186003)(2616005)(38350700002)(38100700002)(86362001)(83380400001)(4326008)(36756003)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iJMb8+y+VZBHVe995BPS2z958LThxN3qfd3VgmxYh3K/BaXCg2EvvWPs+w5VjsmdyHALiTLvE4lCSHFiQgFSqSTd/ZXbLBq4wDgSKuUq1H0Wr8C27dK2B3lTcKPdm3W573OyctRltjsNr6DHfVH8TWYp9E/f+IgnbClJKr40BwswlX3PYR9rF07Icnk/Y/NnHBwCrxlz7fkE8V2S85Y9N/sGUgY+XKSRC8r7BEyjVpVrUDRMMGLnHs0CfCh+vJVvVcZoQXzCaKVVIcw6R3Xo9jKYZ2uaDR4lsct/WtAVXBMiAxf8XnYlJNuOKNO0p7tx2aDI1wAGYg1FlEgBocMcnKZmq9He6P+UyIpWYZbdS+Jw1KDVvfuCbHQJY8oki6bu3lGQHsPpqcml5btsgLwBcEZmn11KoKNy5eUmAM/IceKLSYa9TLlhR7XnOpBmXG/n/JHiqoTcL8alWMKtLWa1THu5KY3xC44XXNdNNyYfeNZw1MuBNHvFF9p03dUmful5weMif/pFUWJ8GXDsdvWJLpVpX3mBmHTo8nsVjqfDKKn1XdzMUUOBANY84qPMGShjiQcUAvj4v4SF7qJIBA1gtwjbzKY536UwDtdznPsy/KzWLHJe3aY8yWd3otsdPb6XtLzu8NYjmftI/afXujxuGtw4njPfqweI3XYKwYEAhphS4y0BMoAAb50QjlGFX0JT/Rt3pjIEFtGWFXoLB8a5HlRql3pOwka57jhNTbtxz9i8zJtP0gpuVNqk3EnUZPZaHjHOnUdi5dXPR7EcmtP5QbjkwnYO7hkmMNxAAX2mwqkKshFD9kO6Ri4BFb7BTKCEIvHOBYqvaEfM6dCu6bzLlZdC2r6jrIkCKvzXA3XLpRRXmiaMPxMhSGo/RcO4xc6lFYnfRrVERZa2mWP9GWMsORd/Z2cHZk9VsmsBK+GRHujJaQ/nDG50gjAAvcQfgBlvI4vTTsW/7PKqgBEhKnauq17wO9XTulRwOZ2BUU3aeK0FVkMVF7Aav32/8bm3VSdG0FJbmPZcdyZVNXv5EEe5K7WDQPli82zq/YYMLaBquyWQqTbPnIYHgChClEAbni/38Obqi4vWFbGmUZZkru6bmAJ1n7CPfw4teriJ5vKm/QsJO2mUHA+b+KSxG7yS06Km+Ulsp8tI5iVhNgWumJJFKfiwqrSC3tgq6xAvWVaMtZGYPVMR/72GIf/Y5nKBDiCoYWUfpXiyEcQ3RxyThzVuwsBxe+5WqriuphxAk30fbBJu83vE5B2NLi34C+rH0P1VuoXlkwENekrfnNxypnvX0O4Oe7Kfv5WcVr0mU5ieKdu2wzVXWJ7Nw8aYTA0PKViQEZA8hTjMLHSzpmtatepv3Fh+e/tPjvwRLDILGkX9MfgVQc/dCWdGBCmUIzTXMozLu2Djggu9iUlCrSOXpkZ1MLOLwK+yLFvOvEbWJltIzzZ8DJs1tLPiqfSkEyRH6FI/jMYqhHhBqfyua3s040dsx4CF/hSZcWLcjobeNHzN9mXClUMgPjSdKqZDU7Ocufu+G8x+8truDGmTknuImGz8y+Ni/dLoXwJq8Z5zICXjuGj2RXA2nmaQOBehQiQX7J0I X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9507227-a1d2-4f9e-e8a7-08da6634fe0f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 07:38:22.6102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FnMzM53jHt4r0QRv5fyykIu0Py/KJ1urbY9bYMMMFWI1gagqoANEawoy54vYYf48NAxXqbnsUdKJ0rcxrd5ohA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6615 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_003827_259625_F830E41C X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org adjust the value range of gop size from [0, 65535] to [1, 8000]. when the gop size is set to a too large value, it may affect the encoded picture quality. so constrain it to a reasonable range. Fixes: 0401e659c1f92 ("media: amphion: add v4l2 m2m vpu encoder stateful driver") Signed-off-by: Ming Qian --- drivers/media/platform/amphion/venc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c index 461524dd1e44..37212f087fdd 100644 --- a/drivers/media/platform/amphion/venc.c +++ b/drivers/media/platform/amphion/venc.c @@ -644,7 +644,7 @@ static int venc_ctrl_init(struct vpu_inst *inst) BITRATE_DEFAULT_PEAK); v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops, - V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30); + V4L2_CID_MPEG_VIDEO_GOP_SIZE, 1, 8000, 1, 30); v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops, V4L2_CID_MPEG_VIDEO_B_FRAMES, 0, 4, 1, 0);