From patchwork Mon Jul 18 19:42:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12921693 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC94C433EF for ; Mon, 18 Jul 2022 19:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236102AbiGRTnJ (ORCPT ); Mon, 18 Jul 2022 15:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234128AbiGRTnI (ORCPT ); Mon, 18 Jul 2022 15:43:08 -0400 Received: from master.debian.org (master.debian.org [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D97E3139D for ; Mon, 18 Jul 2022 12:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=xHvbIb7mzME8SgtOJbJqCoWGE1ItiA59/O2Ethkswsg=; b=PF qOJwLtqr9LXC2kuF2c+08I6akljtHBvy2ON4OmeZ2aypqhlP/SeJvglrPih4tqi+HhXxqWRvWC0tz NAI0JUv7Ou0KQh9BWaUKd0DeXylj4v3J0pkbHca6+pHz5+7i/IxsKGuq3wN+nxVKiUbSwlhGXNEZL rqU8mDivfFkgdgzBB20Kq0Qta77mjfeAgqjyFK+0+fqzmKr1CqIPSY9T9ld7SjgvFttj7qFRPZBAW 7ah1jNm1LmBH9oOcMAZDQt+DAjS8T/60z0Fgd+pAudhNPuntSrBs0A1Yw8R//CSDZHl4IgeKiuAop 6RYAg5m2le0cFy6AAGZ4nfyuoAsiLi2w==; Received: from ukleinek by master.debian.org with local (Exim 4.92) (envelope-from ) id 1oDWdy-0000os-PC; Mon, 18 Jul 2022 19:43:02 +0000 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jonathan Cameron Cc: Lars-Peter Clausen , Andy Shevchenko , linux-iio@vger.kernel.org, Yves-Alexis Perez Subject: [PATCH v2 1/3] iio: humidity: dht11: Don't warn on memory allocation failure Date: Mon, 18 Jul 2022 21:42:56 +0200 Message-Id: <20220718194258.181738-1-ukleinek@debian.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=933; h=from:subject; bh=8TVjomHREqqyvKRzyE40hre1M7hrdAwuPFvVp8l3SEU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBi1be2GgHBgw/Wd5r5qlaswSabD9fgJavgRlee0Efg YLK40sqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYtW3tgAKCRDB/BR4rcrsCXLUB/ 0fGlg2dL8OgJqdUFcpI4vsmfJOTDFPQZ2fF2y2i1jT/JEZfFfDhdmAPB7VOYdpYlTt1/OKL2CzXf3O Yzru45t0d65P/MKgdTGKAQU9fm7NGYyTjgtsxo0DSOVvO8vN6OQfglATxn11CzScKGiuOE+oqYaH05 HokTGjOPfbRYNl6XNq6DsowHrxB1VGf0+obkbzzL1VvoSilBtusLHRH0GjPeSBtlAltdCLb6yY70JZ KaMQASzF4zBEFDa7clZbyRWeLvwTjUoslAYeGD99QwiwppSd3oaY6pJ+yOiN2gZAJqBHXuj9MssbSx sCj3M74mowMRWKaSHPtzuTUBP4BKiW X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The kernel is already quite noisy if a memory allocation fails. So it's the usual policy to not add another message on the driver level. Drop the error message accordingly. Signed-off-by: Uwe Kleine-König Reviewed-by: Andy Shevchenko --- Unchanged since (implicit) v1 drivers/iio/humidity/dht11.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c index c97e25448772..891b6bf0b4ca 100644 --- a/drivers/iio/humidity/dht11.c +++ b/drivers/iio/humidity/dht11.c @@ -295,10 +295,8 @@ static int dht11_probe(struct platform_device *pdev) struct iio_dev *iio; iio = devm_iio_device_alloc(dev, sizeof(*dht11)); - if (!iio) { - dev_err(dev, "Failed to allocate IIO device\n"); + if (!iio) return -ENOMEM; - } dht11 = iio_priv(iio); dht11->dev = dev; From patchwork Mon Jul 18 19:42:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12921694 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5839EC43334 for ; Mon, 18 Jul 2022 19:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236145AbiGRTnK (ORCPT ); Mon, 18 Jul 2022 15:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234128AbiGRTnK (ORCPT ); Mon, 18 Jul 2022 15:43:10 -0400 Received: from master.debian.org (master.debian.org [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A44E9313B8 for ; Mon, 18 Jul 2022 12:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=IuS0+muwBjCKA4YU8k0P+du/8OKLFdqbKcdx4holZlI=; b=TqHX iuD1qgbmz2xCVlO3kCsr7M6x4JAGtrj//yC8SdO7UT2qwPOO51UXwuwI8NZhx99DCm80PE+ZrJDHr VY3g0xGNyNszIrcSaCsamvsGFDQ2FTKHFR8Nccn8qOCFic76vUNJMoCE6xMvb9sMJ5sViJJ6ufTYp SLS3OZTo5VhsS2n7dFmccU8V/UbQ6aZwME56sB44bbzJm2Oe6W75pIRiCibVxf8zc9KXkNcwim10Q KHZyPzJmC2dwr/qgkSjfOLcnZQjjRmCBIEguPOi40Q7B+LbWXgpqQFsvKJVSzHJMquzAtZF2eT/M3 J8SaMs97sbq6v0kUb4nzMgRIApb5Eg==; Received: from ukleinek by master.debian.org with local (Exim 4.92) (envelope-from ) id 1oDWe0-0000p5-Dh; Mon, 18 Jul 2022 19:43:04 +0000 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jonathan Cameron Cc: Lars-Peter Clausen , Andy Shevchenko , linux-iio@vger.kernel.org, Yves-Alexis Perez Subject: [PATCH v2 2/3] iio: humidity: dht11: Emit error messages for probe failures Date: Mon, 18 Jul 2022 21:42:57 +0200 Message-Id: <20220718194258.181738-2-ukleinek@debian.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220718194258.181738-1-ukleinek@debian.org> References: <20220718194258.181738-1-ukleinek@debian.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2053; h=from:subject; bh=qC4JFxOH3CD2NVD6lCY30RK7h3MvO/hDqMWI6pVSsc8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBi1be6XuyY1UxDyQchCGVz1xYITu4kY3pyT4CzR4je fEq70jWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYtW3ugAKCRDB/BR4rcrsCbNzCA CSu+VGChtclfRgofUbk74UlA8xMOoizZbQSHAnDW1DZi+RBYh9abb/fhMD5QbAiwz+j9uzbPUxAM0g wQgZDTB0eJAAv2vorxlB8JPLk04m1JahgLAwKZCWtlRA7+F+HsKDUk5FfyNw0hP+syObnEGr1TyfmX zp8Pjw2FChRoXOJViDge7mFffBtCTdrQMLJcRCnFv3O0ZepIGnD2ZUCo7b8P6srMvSqEUEITWKxhPZ cAiTmjTqpmjgl9ruqtp3z/1fj4VYDYKgzKe7mtQ6okZ0uo7HteDkyxOeZ+0l2NGoAzuGGIDnL4RokN NDRMyvlMgv1H/R4guZgqsLi4QKErY3 X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org There are two exit points in the driver's probe function that fail silently. From a user perspective this is unsatisfactory because the device is unusable but there is no hint in the kernel log about the actual problem which makes it unnecessarily hard to fix the problem. Make use of dev_err_probe() to emit a problem indication which also does the right thing if requesting the gpio return -EPROBE_DEFER. Signed-off-by: Uwe Kleine-König Reviewed-by: Andy Shevchenko --- Changes since (implicit) v1: - Make it actually compile. (It helps quite a lot to have the driver to be tested enabled in the config when doing compile tests *sigh*) - Fix a typo I added when manually splitting the original patch drivers/iio/humidity/dht11.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c index 891b6bf0b4ca..0db4f7471319 100644 --- a/drivers/iio/humidity/dht11.c +++ b/drivers/iio/humidity/dht11.c @@ -293,6 +293,7 @@ static int dht11_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct dht11 *dht11; struct iio_dev *iio; + int ret; iio = devm_iio_device_alloc(dev, sizeof(*dht11)); if (!iio) @@ -302,7 +303,8 @@ static int dht11_probe(struct platform_device *pdev) dht11->dev = dev; dht11->gpiod = devm_gpiod_get(dev, NULL, GPIOD_IN); if (IS_ERR(dht11->gpiod)) - return PTR_ERR(dht11->gpiod); + return dev_err_probe(dev, PTR_ERR(dht11->gpiod), + "Failed to acquire GPIO\n"); dht11->irq = gpiod_to_irq(dht11->gpiod); if (dht11->irq < 0) { @@ -323,7 +325,11 @@ static int dht11_probe(struct platform_device *pdev) iio->channels = dht11_chan_spec; iio->num_channels = ARRAY_SIZE(dht11_chan_spec); - return devm_iio_device_register(dev, iio); + ret = devm_iio_device_register(dev, iio); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to register iio device\n"); + + return 0; } static struct platform_driver dht11_driver = { From patchwork Mon Jul 18 19:42:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12921695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FDDC43334 for ; Mon, 18 Jul 2022 19:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236197AbiGRTnN (ORCPT ); Mon, 18 Jul 2022 15:43:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234128AbiGRTnN (ORCPT ); Mon, 18 Jul 2022 15:43:13 -0400 Received: from master.debian.org (master.debian.org [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7859B313A5 for ; Mon, 18 Jul 2022 12:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=87WYTvokChWA0TkWM01Hlms4BQL3Uf8tiOA7mq4jtb0=; b=CbKU /PpXI4034l2V6vDkukqg7b6kF3O8qTIuQ3rjcgmpfc+SEB166yQQRe157rhUHia3pSy0jfDbnkH2q WOhgY0apMONCT0S6+ySMetZVBeCGPAU92Y6Hghpi1KB04MNPeN6jqZT4N9CLP8RkYJyxJtu4gi4y8 FI3RIhqM5nRQQj2VtZlwd6eS5nMKe/jbcc9I+2QItol6wv7IcW1r3j5mrtTXqxbS7m168P3/D4d/B zJVCpj68N4j9mqQy/83O81O9/CoP1qQ7eBxA6G1k/G9ouDKKVujwhi1KbxV7wgQUo7hGZ6YSNSAeo Nm1S/2FG4LowNbWCtbbOoqRiBiceJQ==; Received: from ukleinek by master.debian.org with local (Exim 4.92) (envelope-from ) id 1oDWe2-0000pK-HW; Mon, 18 Jul 2022 19:43:06 +0000 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jonathan Cameron Cc: Lars-Peter Clausen , Andy Shevchenko , linux-iio@vger.kernel.org, Yves-Alexis Perez Subject: [PATCH v2 3/3] iio: humidity: dht11: Use dev_err_probe consistently Date: Mon, 18 Jul 2022 21:42:58 +0200 Message-Id: <20220718194258.181738-3-ukleinek@debian.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220718194258.181738-1-ukleinek@debian.org> References: <20220718194258.181738-1-ukleinek@debian.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1051; h=from:subject; bh=DTHe2HsNrArGM3o70Z/ShAF/gaKKYa9hT6OQgAqPNLI=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBi1be9F6LnDlALp9whUe14WHuh4ylWfLZC0ZAbY9wF tGZvct+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYtW3vQAKCRDB/BR4rcrsCX+KB/ wLZIZkcrD8woXUs2q/UAhYyLSXoeFF8pzN+L0IDeAkTjGWv3YiybTGKWM44sNJabED2+yMR9Pz0cMj T5aCnnHRUdlo5zbM58iAoA7kxqdynmssnAUtgfZu70EwiHyl6GGH6koWo0qIPMbuJB+HCc8cS0NtoR 6NF8l7ECkEFWxgTvul/CqnlwmIZaNsPDqbYxodCfhriOBUDZFkE8BqWyt2i3jzxNoDu1HZYvt/zF2c Pz2VLoKXTxwrxJoQD6ht021kyLB05b7qXluDiMaDQ8z2h9D+OL0tOf83gR42rSt3lMNL4jz9AVd596 q/BHPdEVdH70xJvYT8eQM6bbF+6IEx X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org All but one error path use dev_err_probe() to emit a message. Use the same incarnation for the remaining exit point for consistency. Signed-off-by: Uwe Kleine-König --- No changes since (implicit) v1 drivers/iio/humidity/dht11.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c index 0db4f7471319..d8b2cb3ef81e 100644 --- a/drivers/iio/humidity/dht11.c +++ b/drivers/iio/humidity/dht11.c @@ -307,10 +307,9 @@ static int dht11_probe(struct platform_device *pdev) "Failed to acquire GPIO\n"); dht11->irq = gpiod_to_irq(dht11->gpiod); - if (dht11->irq < 0) { - dev_err(dev, "GPIO %d has no interrupt\n", desc_to_gpio(dht11->gpiod)); - return -EINVAL; - } + if (dht11->irq < 0) + return dev_err_probe(dev, -EINVAL, "GPIO %d has no interrupt\n", + desc_to_gpio(dht11->gpiod)); dht11->timestamp = ktime_get_boottime_ns() - DHT11_DATA_VALID_TIME - 1; dht11->num_edges = -1;