From patchwork Tue Jul 19 11:52:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12922406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EE4C43334 for ; Tue, 19 Jul 2022 11:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 596DE6B0074; Tue, 19 Jul 2022 07:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 546D16B0075; Tue, 19 Jul 2022 07:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436646B0078; Tue, 19 Jul 2022 07:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 33E686B0074 for ; Tue, 19 Jul 2022 07:52:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F353D115D for ; Tue, 19 Jul 2022 11:52:49 +0000 (UTC) X-FDA: 79703687658.29.AC50FFC Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf03.hostedemail.com (Postfix) with ESMTP id 048032005B for ; Tue, 19 Jul 2022 11:52:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LnHHM0Tk0zFq9R; Tue, 19 Jul 2022 19:51:43 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 19:52:44 +0800 From: Miaohe Lin To: CC: , , Subject: [PATCH] mm/mempolicy: remove unneeded out label Date: Tue, 19 Jul 2022 19:52:33 +0800 Message-ID: <20220719115233.6706-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658231569; a=rsa-sha256; cv=none; b=XaQch0gsHExep4Bqk2kK0yYUGGuJDv77F+28pec3kBHNKutkn2aeCzdqgKUfmERYgmmRjm tPblOBu3Qb4xhhjovozqccPABN43OqRwPXZ7HmmAPDgHx/M7SZ50am0OGSA46qvcF/5Gsj dFl7s6dxbb0/sZsacfOY1ZnMyyl8BL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658231569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=TZNZjkbQAMppehS0KOunXAsFW+FyIPcrmWEmiFQ/EBI=; b=oQeWuaTsvR3C+Bf8krUlkzn5S/DhwWvNj8bw1hQ7RWGv73OadXeuxRhJyeEvtIxJsTrYqZ d9NxyitR/UovSYG9dIOGasc2Ftd0fD82PRESwcs3T5HP98b1Wz7sAZ+64lkxPyQbLPgmmT G3/UOH4gg3ISoK7UuQF2F6qRXtcNax8= Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: 5emzr64y6iweecthhixthkfeoxo7dous X-Rspamd-Queue-Id: 048032005B X-HE-Tag: 1658231568-193440 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can use unlock label to unlock ptl and return ret directly to remove the unneeded out label and reduce the size of mempolicy.o. No functional change intended. [Before] text data bss dec hex filename 26702 3972 6168 36842 8fea mm/mempolicy.o [After] text data bss dec hex filename 26662 3972 6168 36802 8fc2 mm/mempolicy.o Signed-off-by: Miaohe Lin --- mm/mempolicy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index dc74239d1ac7..6c27acb6cd63 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -466,9 +466,8 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, } page = pmd_page(*pmd); if (is_huge_zero_page(page)) { - spin_unlock(ptl); walk->action = ACTION_CONTINUE; - goto out; + goto unlock; } if (!queue_pages_required(page, qp)) goto unlock; @@ -485,7 +484,6 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, ret = -EIO; unlock: spin_unlock(ptl); -out: return ret; }