From patchwork Mon Jan 14 13:44:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3EB5713BF for ; Mon, 14 Jan 2019 13:46:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EF352896A for ; Mon, 14 Jan 2019 13:46:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 22E91289AD; Mon, 14 Jan 2019 13:46:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF8942896A for ; Mon, 14 Jan 2019 13:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfANNqS (ORCPT ); Mon, 14 Jan 2019 08:46:18 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37363 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbfANNp5 (ORCPT ); Mon, 14 Jan 2019 08:45:57 -0500 Received: by mail-wm1-f66.google.com with SMTP id g67so8882284wmd.2 for ; Mon, 14 Jan 2019 05:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=CsrEo/uJUfiY/yhKewL8SJyrD+mSyI9vQ5hR4ip+l8fH7imZ/n5u1l2mFgIgOJmIaT CLGzB1DFsfQ+LD0TWgG5KI9P+ixgpWiWaW8IldcliZ6LFPgAZayBd4QJpkewWd1XkU6B bCsrn+1AIUHxewPaSCiHqX+THm/66A3vjUQyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=FUD2UMq//IPKoZRBj8Rfi0oDoWioo4pYyse/II5zuFIJSsyslhniyr9BDSK6q3yFfm 6fmwbdVDos36oCl1tRYoY3hpLY/ro8Tp3VPToXE88gZ5qattuj8EjaKE7pbx7VmJVyIK Zf8fQm4hZEF/k4zBPx470c0jgk5ndTQ7ciOS6dGiOFW6rOnNoC+7LEMVVY2ipXExaHRj PNrDIP7ZuR8Mr+3ZEpWF+rZjnD+PptdyFBbY1vrzJul25ko4IfXCmn5Ql1YEgAQeDrQy oOkGmmhRaU5EVl9hmAoikukr7iagpF7plYaxCRFz/pHw/WyJA+iTQe+Ib63WjAK1ZOGa MUbQ== X-Gm-Message-State: AJcUukcwraRET67ha7NRLtmON+gAfwM+jwZYA41OMZHQ6GT9fulbaAou 9hCOk88+eaMMrW/97+fD40ErrA== X-Google-Smtp-Source: ALg8bN5Tu3CDY+htwXDCWVyW0b0gInxawViDsIS5SCsemKld1G35f3Y3cWCl0Wyrec0ZWCEf1dmfRA== X-Received: by 2002:a1c:4108:: with SMTP id o8mr11573993wma.91.1547473555389; Mon, 14 Jan 2019 05:45:55 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:54 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 1/4] slimbus: core: match full device id Date: Mon, 14 Jan 2019 13:44:46 +0000 Message-Id: <20190114134449.15367-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP match full slim device id instead of just product and manufacture code, this will allow drivers to be much more specific to that device. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 55eda5863a6b..9e4f3b21ba8c 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -21,7 +21,9 @@ static const struct slim_device_id *slim_match(const struct slim_device_id *id, { while (id->manf_id != 0 || id->prod_code != 0) { if (id->manf_id == sbdev->e_addr.manf_id && - id->prod_code == sbdev->e_addr.prod_code) + id->prod_code == sbdev->e_addr.prod_code && + id->dev_index == sbdev->e_addr.dev_index && + id->instance == sbdev->e_addr.instance) return id; id++; } From patchwork Mon Jan 14 13:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762581 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0C3714E5 for ; Mon, 14 Jan 2019 13:46:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A12B92896A for ; Mon, 14 Jan 2019 13:46:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 95725289AD; Mon, 14 Jan 2019 13:46:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F50E2896A for ; Mon, 14 Jan 2019 13:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbfANNqA (ORCPT ); Mon, 14 Jan 2019 08:46:00 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36375 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbfANNp6 (ORCPT ); Mon, 14 Jan 2019 08:45:58 -0500 Received: by mail-wm1-f65.google.com with SMTP id p6so8889909wmc.1 for ; Mon, 14 Jan 2019 05:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wcq/BZjA1FXBmfYxzVF9/4lLVBugXEKEif9lDq84KTU=; b=WYgKve76AQapL96P//w9NBFMjzVpCPuV8TxBk81O+FXe5c9IK/zBEFrQmR4S2O09UR 6OqbSicCV3seQTILK21YiaU4XHBsbTV82pUDQjCB5AObNHnfxuBde8YbBvoZBhRgVhnw xberplgt88Z4je80I8tlQZ7v7o2XE7iOFxMTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wcq/BZjA1FXBmfYxzVF9/4lLVBugXEKEif9lDq84KTU=; b=ZoGflbn0B8DWIuEfPpgqp7kJiNcJwwllhxRZ0fS5qLSgvNZSTxFyh/iPRSO4GbrYRY /dKC9MPuN4rSo+12cv62OkF/baZIEEuzVsC729+rJxeepF3SnnigH4Jo0kGNwvNJbJhH 5FM8RpeNjDKAid02CStMRllBq3qqIP0jUWTlphda4HdVXlw+9pMnYL7zYOY7fO3jp2O8 Pt+aHOBqg9Mcf8hMjV6akYXrXTTDNk63CqR/DSq4RlCVoHm3/XtI9+fLm+s1ShWksi9w q8U5Hw4jmcQsTIwfdMX4d2Woes4TmPVJN98lR5ZqHroteQ8iLuw6rQHtIqOJ7moK5o6b 4j6Q== X-Gm-Message-State: AJcUukc/KV4Ibcgbya+H85+bgWrAEOdibmJpMcoYDNcKRSPJOYEfpGSJ GdKlezlLAFrtCNej2nvFWbE21A== X-Google-Smtp-Source: ALg8bN64kMU4Zn8sj96BtI9KdISTw1k7FD7k6jTQSUEXSzZQv0Ihl1I4aNOOo+S0/qTxrawQKPLjhA== X-Received: by 2002:a1c:bdc5:: with SMTP id n188mr12588988wmf.69.1547473556520; Mon, 14 Jan 2019 05:45:56 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:55 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 2/4] slimbus: core: do not call device_status under a lock Date: Mon, 14 Jan 2019 13:44:47 +0000 Message-Id: <20190114134449.15367-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Calling device_status callback under a lock would prevent drivers to do any slimbus trasactions which would invoke this lock like get_laddr(). Remove this unnecessary lock! Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 9e4f3b21ba8c..1ba08b5f2e78 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -466,6 +466,7 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, sbdev->laddr = laddr; sbdev->is_laddr_valid = true; + mutex_unlock(&ctrl->lock); slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); @@ -473,6 +474,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code, sbdev->e_addr.dev_index, sbdev->e_addr.instance); + return 0; + err: mutex_unlock(&ctrl->lock); return ret; From patchwork Mon Jan 14 13:44:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3ACB14E5 for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B504428970 for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A87452896A; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D91028970 for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfANNqA (ORCPT ); Mon, 14 Jan 2019 08:46:00 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40968 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726643AbfANNp7 (ORCPT ); Mon, 14 Jan 2019 08:45:59 -0500 Received: by mail-wr1-f65.google.com with SMTP id x10so22875569wrs.8 for ; Mon, 14 Jan 2019 05:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=Z3/wDbhzhopFmyHNBAS1GSnVi/sNKVPlp0oNbYpPLEEL4VqHsy+5ZLBt6oDYjcSO4T fSSE2zHTTQQ5i0sIelPEi9Kt/qThgXItG1JoSdo3gDZqGmDhbfP4J2MMFDebFOUdkHFt 0PH6bLo8xpAZlp4JFNkG55gMcPu3FtXIGRer0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=WNwoeg+I7gSZIQHy+8LVz4Y0H1w0Bannpz3K88zAk0RV9vDKJJ+QRKhZR/cj0x3xyY kSje6osyUumaFNlqN3hwjkXrzhYg4RIkh4mMswEVoiK4PfMPh1AB7Kdg2fpRJnj1muPP KHjjItjY1qpcT7Sw1XGB6jjhI1Jc49lsW8MlI2GfhYbZg9EkizAjw079euDWXTg4jUbQ h1MWSlqPikVg+AjgA9jbjIkZ35Fd6n/0uVEoU8ukNfeZjQb+EZYaARaI1bGdfmli7gSd JuF0l+HUo1rQzaiTV/+Dfxt//U6oRkNWttmI8cfMLAYJTJZELAAJ22fIYz4I1GtHTMcM mnww== X-Gm-Message-State: AJcUukeMKnemVWyMoFnbsg4qBNF17UCnodKWQCA7u2pgU+4sQtS0eBrz v3tCyIqMoIZ7DqXWVn9wNT75LA== X-Google-Smtp-Source: ALg8bN5IB0p3NXMh0MZIhvE5oOFk11LD0A8yEBKLDOoJcNBn079uF1rverXDFyN7EkSnLe1MzonW8A== X-Received: by 2002:adf:b201:: with SMTP id u1mr24126617wra.165.1547473558066; Mon, 14 Jan 2019 05:45:58 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:57 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 3/4] slimbus: core: use slim_device_update_status() to update status Date: Mon, 14 Jan 2019 13:44:48 +0000 Message-Id: <20190114134449.15367-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before probe to avoid forward declaration too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 1ba08b5f2e78..8ffdc9876223 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -42,6 +42,23 @@ static int slim_device_match(struct device *dev, struct device_driver *drv) return !!slim_match(sbdrv->id_table, sbdev); } +static void slim_device_update_status(struct slim_device *sbdev, + enum slim_device_status status) +{ + struct slim_driver *sbdrv; + + if (sbdev->status == status) + return; + + sbdev->status = status; + if (!sbdev->dev.driver) + return; + + sbdrv = to_slim_driver(sbdev->dev.driver); + if (sbdrv->device_status) + sbdrv->device_status(sbdev, sbdev->status); +} + static int slim_device_probe(struct device *dev) { struct slim_device *sbdev = to_slim_device(dev); @@ -55,8 +72,7 @@ static int slim_device_probe(struct device *dev) /* try getting the logical address after probe */ ret = slim_get_logical_addr(sbdev); if (!ret) { - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); + slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); } else { dev_err(&sbdev->dev, "Failed to get logical address\n"); ret = -EPROBE_DEFER; @@ -297,23 +313,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) } EXPORT_SYMBOL_GPL(slim_unregister_controller); -static void slim_device_update_status(struct slim_device *sbdev, - enum slim_device_status status) -{ - struct slim_driver *sbdrv; - - if (sbdev->status == status) - return; - - sbdev->status = status; - if (!sbdev->dev.driver) - return; - - sbdrv = to_slim_driver(sbdev->dev.driver); - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); -} - /** * slim_report_absent() - Controller calls this function when a device * reports absent, OR when the device cannot be communicated with From patchwork Mon Jan 14 13:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A48D413BF for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96374289BC for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A6EC2896A; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CF5C2896A for ; Mon, 14 Jan 2019 13:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbfANNqP (ORCPT ); Mon, 14 Jan 2019 08:46:15 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45792 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726649AbfANNqA (ORCPT ); Mon, 14 Jan 2019 08:46:00 -0500 Received: by mail-wr1-f65.google.com with SMTP id t6so22853940wrr.12 for ; Mon, 14 Jan 2019 05:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=Xv+mo420RQ7SowyXQw5AOCTKRj/czTkjlgmqK2fPHy5sIyzgCxajeFCQkYBrAPj+95 +Fju2rw+nA/0cRLQlXuiFPULIZJGWcF/j3Qyi5ZPa66gsosd/FfNWpVg0zplq66CTSxK GbBvRVkhYOhLZXsP85cjaruzTkBMzLR5qQUkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=t/Ktf/a21zqqCGbbw2q/BYfobJTT7jvy0mCUwdP0DWMwael9/Nb+q9qBHUKt5G6Qz2 oP82/AL+5AVXD4bNGBlQppLm7Ju21IoYi2IHTWU7O1oCboBk/kF9qiOtAJCztKZIx6zj U3XKYc7IZCTSRZImWnsalbuEfcXk7xmMEFIZR9tStOcpYHzGwwnAqCFvvKCna0p2jgiH bRHpvbkSqybjmEQ4HbF9Ji0wJF8sjdb+0IyYmPeOCBOETktTTlZ5WXs1ldXVN+lwGYOw ADqJLnJdj72rOFl54x3TjY7yzWrXI5frYb+WsVxj8mfjYdfpw8/ANHyYUY1R3O972kbw PwPQ== X-Gm-Message-State: AJcUukfXX1B7ZQU8F5MiQLdRkfhnia6hjSWks7QK1Q46o5JTt4lXcguX 2nF3vw5TNAJxcBL5dCgmEN7/WL14jGk= X-Google-Smtp-Source: ALg8bN4MnerjFJwS814W3kl5XW6Mk6zbxqo8XNvKLGKMxT8Im17NTWIRM5DDeHIDp88gfaCzPytGIg== X-Received: by 2002:adf:b6a1:: with SMTP id j33mr24357526wre.55.1547473559036; Mon, 14 Jan 2019 05:45:59 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:58 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 4/4] slimbus: core: add missing spin_lock_init on txn_lock Date: Mon, 14 Jan 2019 13:44:49 +0000 Message-Id: <20190114134449.15367-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add missing spin lock intialization this also fixes the spinlock bad magic warning. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 8ffdc9876223..b2f07d2043eb 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -274,6 +274,7 @@ int slim_register_controller(struct slim_controller *ctrl) mutex_init(&ctrl->lock); mutex_init(&ctrl->sched.m_reconf); init_completion(&ctrl->sched.pause_comp); + spin_lock_init(&ctrl->txn_lock); dev_dbg(ctrl->dev, "Bus [%s] registered:dev:%p\n", ctrl->name, ctrl->dev);